[GitHub] metron issue #715: METRON-1131: The Stellar REPL rejects valid hostnames for...

Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/715 I give it a ++1 now that I've validated in full dev. Succeeds and fails as expected. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] metron issue #715: METRON-1131: The Stellar REPL rejects valid hostnames for...

Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/715 +1 on inspections, and +1 apology :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] metron pull request #716: METRON-1132 Enhance Profiler Debug Functions

GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/716 METRON-1132 Enhance Profiler Debug Functions Enhanced the `PROFILER_APPLY` function so that multiple messages can be applied at once. This makes it much simpler to test with larger, likely more

[GitHub] metron pull request #677: METRON-1073: Add option to limit fields returned f...

Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/677 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron issue #677: METRON-1073: Add option to limit fields returned from sea...

Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/677 +1 Tested in full dev. Looks good @merrimanr, thanks for the contribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] metron issue #694: METRON-1085: Add REST endpoint to save a user profile for...

Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/694 The latest commit addresses the formatting comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] metron issue #715: METRON-1131: The Stellar REPL rejects valid hostnames for...

Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/715 +1 Solid! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] metron issue #702: METRON-1114: Add group by capabilities to search REST end...

Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/702 The latest commit moves this group by function to it's own REST endpoint. Combining groups and search results became too awkward once I started looking into adding sorting and size constraints to

[GitHub] metron pull request #715: METRON-1131: The Stellar REPL rejects valid hostna...

GitHub user cestella opened a pull request: https://github.com/apache/metron/pull/715 METRON-1131: The Stellar REPL rejects valid hostnames for zookeeper in its CLI options ## Contributor Comments Currently, the REPL defines a valid zookeeper hostname is one which matches

[GitHub] metron pull request #706: METRON-1119 Bad Out-of-Order Logic for SaltyRowKey...

Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/706 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron pull request #708: METRON-1120 Profile's 'groupBy' Expression Has No ...

Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/708 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron issue #708: METRON-1120 Profile's 'groupBy' Expression Has No Referen...

Github user cestella commented on the issue: https://github.com/apache/metron/pull/708 +1 by inspection. This is good stuff --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] metron pull request #694: METRON-1085: Add REST endpoint to save a user prof...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/694#discussion_r135085139 --- Diff: metron-interface/metron-rest-client/src/main/java/org/apache/metron/rest/model/AlertsProfile.java --- @@ -0,0 +1,89 @@ +/** + *

[GitHub] metron pull request #694: METRON-1085: Add REST endpoint to save a user prof...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/694#discussion_r135084490 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/search/SearchRequest.java --- @@ -106,4 +107,33 @@ public void

[GitHub] metron pull request #694: METRON-1085: Add REST endpoint to save a user prof...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/694#discussion_r135084360 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/AlertsProfileControllerIntegrationTest.java --- @@ -0,0 +1,226 @@

[GitHub] metron pull request #694: METRON-1085: Add REST endpoint to save a user prof...

Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/694#discussion_r135084396 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/AlertsProfileControllerIntegrationTest.java --- @@ -0,0 +1,226 @@

[GitHub] metron pull request #694: METRON-1085: Add REST endpoint to save a user prof...

Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/694#discussion_r135074463 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/AlertsProfileControllerIntegrationTest.java --- @@ -0,0 +1,226 @@

[GitHub] metron issue #706: METRON-1119 Bad Out-of-Order Logic for SaltyRowKeyBuilder

Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/706 @cestella Any other thoughts on this one? Otherwise I will get it merged. Thanks for the reviews, @mattf-horton and @cestella --- If your project is set up for it, you can reply to

Re: [ANNOUNCE] Metron community meeting

I should be more clear, for discussions like this, I treat them open forever. For things that are asking for consensus, it generally goes like a PR. People discuss until the voices sort of die down and some loose consensus is built. I normally go by the following conditions: - 1 full

Re: [ANNOUNCE] Metron community meeting

forever as far as I'm concerned. They don't really close so much as they are forgotten. :) On Thu, Aug 24, 2017 at 11:08 AM, Otto Fowler wrote: > Casey, what is the time frame for the discuss thread to ‘close’? > > > On August 24, 2017 at 10:06:12, Casey Stella

Re: [ANNOUNCE] Metron community meeting

Casey, what is the time frame for the discuss thread to ‘close’? On August 24, 2017 at 10:06:12, Casey Stella (ceste...@gmail.com) wrote: Yeah, sorry about that; technology (and webex in particular) is such a fragile thing sometimes. I think the synopsis is pretty complete. That being said, if

[GitHub] metron issue #699: METRON-1068: Use Elastic end point in alerts ui

Github user iraghumitra commented on the issue: https://github.com/apache/metron/pull/699 @merrimanr Updated readme with login instructions. Thanks for taking time for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] metron pull request #707: METRON-1121 Ignore Profile with Bad 'init', 'updat...

Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/707 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [ANNOUNCE] Metron community meeting

Yeah, sorry about that; technology (and webex in particular) is such a fragile thing sometimes. I think the synopsis is pretty complete. That being said, if there's anything that you want clarity on, we can hammer it out on the discuss thread too. On Wed, Aug 23, 2017 at 4:28 PM, James Sirota

[GitHub] metron pull request #705: METRON-1118 Ignore Profile with Bad 'onlyif' or 'f...

Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/705 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] metron pull request #694: METRON-1085: Add REST endpoint to save a user prof...

Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/metron/pull/694#discussion_r135023071 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/AlertsProfileControllerIntegrationTest.java --- @@ -0,0 +1,226

[GitHub] metron issue #707: METRON-1121 Ignore Profile with Bad 'init', 'update' or '...

Github user cestella commented on the issue: https://github.com/apache/metron/pull/707 Yep, +1 by inspection, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] metron pull request #694: METRON-1085: Add REST endpoint to save a user prof...

Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/694#discussion_r134927600 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/AlertsProfileControllerIntegrationTest.java --- @@ -0,0 +1,226 @@

[GitHub] metron pull request #694: METRON-1085: Add REST endpoint to save a user prof...

Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/694#discussion_r134930540 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/service/impl/AlertsProfileServiceImplTest.java --- @@ -0,0 +1,127 @@ +/*

[GitHub] metron pull request #694: METRON-1085: Add REST endpoint to save a user prof...

Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/694#discussion_r134931179 --- Diff: metron-interface/metron-rest-client/src/main/java/org/apache/metron/rest/model/AlertsProfile.java --- @@ -0,0 +1,89 @@ +/** + * Licensed

[GitHub] metron pull request #694: METRON-1085: Add REST endpoint to save a user prof...

Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/694#discussion_r134927788 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/AlertsProfileControllerIntegrationTest.java --- @@ -0,0 +1,226 @@

[GitHub] metron pull request #694: METRON-1085: Add REST endpoint to save a user prof...

Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/694#discussion_r134924613 --- Diff: metron-interface/metron-rest-client/src/main/java/org/apache/metron/rest/converter/JsonConverter.java --- @@ -0,0 +1,53 @@ +/** + *

[GitHub] metron pull request #694: METRON-1085: Add REST endpoint to save a user prof...

Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/694#discussion_r134926541 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/AlertsProfileControllerIntegrationTest.java --- @@ -0,0 +1,226 @@

[GitHub] metron pull request #694: METRON-1085: Add REST endpoint to save a user prof...

Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/694#discussion_r134924778 --- Diff: metron-interface/metron-rest-client/src/main/java/org/apache/metron/rest/model/AlertsProfile.java --- @@ -0,0 +1,89 @@ +/** + * Licensed

[GitHub] metron pull request #694: METRON-1085: Add REST endpoint to save a user prof...

Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/694#discussion_r134930645 --- Diff: metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/search/SearchRequest.java --- @@ -106,4 +107,33 @@ public void

[GitHub] metron pull request #694: METRON-1085: Add REST endpoint to save a user prof...

Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/694#discussion_r134926549 --- Diff: metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/AlertsProfileControllerIntegrationTest.java --- @@ -0,0 +1,226 @@