Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141991874
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private HttpStatus
Hi Justin,
I am adding the nested “alert" field requirement to the product documentation,
and I had a question:
* If the user opts to use the default configuration, will they still need to
add the nested “alert” field?
When I’m finished with the documentation, I’ll send you a link to make sure
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/781
Altho I suppose the "Locality-Sensitive" part of TLSH means it operates at
word level instead of byte or character level?
---
Github user mattf-horton commented on the issue:
https://github.com/apache/metron/pull/781
FUZZY_SCORE and BLOOM_*. Is it worth trying to unify these
similarity-recognizers with similarity hash, or are they too far apart in terms
of expected use patterns?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/768
Let me be more clear, sorry.
Vagrant up doesn't work.
If I do
```bash
% metron-deployment> mvn package -DskipTests -P build-rpms
```
I get these errors in the RPM's.
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/768
I cannot get this to vagrant up:
> MANY OF THESE ->
metron-config.noarch: E: script-without-shebang
/usr/metron/0.4.1/web/expressjs/node_modules/repeat-string/package.json
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141975467
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private HttpSt
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/781
Ok, I have not worked through the doc, but it looks good to me. I can stop
thinking about how this relates to FUZZY_SCORE.
---
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141974727
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private HttpStatus
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141971685
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private HttpStatus
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141971177
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private HttpStatus
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141968868
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private HttpStatus
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/681
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/681
me too, +1
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/681
I'm +1, thanks again for the contribution!
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/681
Yeah, I'm ok with that.
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/781
Let me write up a step-by-step use-case doc and I'll call this one done.
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/781#discussion_r141944809
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/hashing/TLSHHasher.java
---
@@ -0,0 +1,203 @@
+/*
+ *
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/768
@ottobackwards can u check it now I merged master again looks like mpack is
in now.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/781
+1 by inspection, really nice.
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/781#discussion_r141933534
--- Diff: metron-stellar/stellar-common/pom.xml ---
@@ -51,6 +52,11 @@
--- End diff --
Yep, added
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/781#discussion_r141931953
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/hashing/TLSHHasher.java
---
@@ -0,0 +1,203 @@
+/*
+ *
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/781#discussion_r141919312
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/utils/hashing/TLSHHasher.java
---
@@ -0,0 +1,203 @@
+/*
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/781#discussion_r141920133
--- Diff: metron-stellar/stellar-common/pom.xml ---
@@ -51,6 +52,11 @@
--- End diff --
Does t
GitHub user cestella opened a pull request:
https://github.com/apache/metron/pull/781
METRON-1052:
## Contributor Comments
This is a follow-on to METRON-539. Currently we have Stellar functions to
perform cryptographic hashing operations. It would be useful to expand this to
s
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/768
I don't understand how this is not picking up the management pack
integration for alerts? I don't see it in ambari
---
I put up a preliminary PR at https://github.com/apache/metron/pull/780. As
noted there, this should almost certainly be under a different heading, and
possibly a different README, so feel free to chime in on that. Primary
goal is to make sure the content makes sense and get adjustments as needed.
GitHub user justinleet opened a pull request:
https://github.com/apache/metron/pull/780
METRON-1220: Create documentation around alert nested field
## Contributor Comments
Adding some docs around the requirement of an "alert" field on new sensors.
There's an open discuss
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/771
[METRON-1221 Shared Metron Angular
Components](https://issues.apache.org/jira/browse/METRON-1221)
---
We can also consider this when thinking about creating parsers with
archetypes that contain ‘default’
elasticsearch templates.
On September 29, 2017 at 10:00:03, Justin Leet (justinjl...@gmail.com)
wrote:
As part of building a backend for meta-alerts (
https://github.com/apache/metron/pull/734)
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/771
+1 works as described ...
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/771
definitely
---
As part of building a backend for meta-alerts (
https://github.com/apache/metron/pull/734), there's an additional
requirement for the Elasticsearch templates for new sensors. Although
seemingly minor, this should be called out explicitly because of the wider
implications of leaving it out of ANY s
Github user iraghumitra commented on the issue:
https://github.com/apache/metron/pull/768
@ottobackwards Done please have a look ...
---
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141869253
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private Ht
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/771
@ottobackwards should we push that as a follow up issue for now rather than
expanding the scope of this PR?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/771
Our common components should be identified and moved to angular libraries
as much as possible
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/771
This brings up the issue with having 'split' these uis. They have common
things that we shouldn't have to duplicate in each application.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/775
How would you reproduce this? I have not been seeing failures.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/768
I would like to review this, can you resolve conflicts?
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141862571
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private HttpSt
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141861097
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private HttpStatus
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141860594
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private HttpStatus
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141844398
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private Ht
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/779#discussion_r141840699
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/controller/RestExceptionHandler.java
---
@@ -45,4 +45,14 @@ private HttpSt
45 matches
Mail list logo