Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/774#discussion_r151196532
--- Diff: bundles-maven-plugin/README.md ---
@@ -0,0 +1,230 @@
+
+# Apache Metron Bundle Maven Plugin
+
+Apache Metron Bundles Maven
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/841
METRON-1316 Fastcapa Fails to Compile in Test Environment
DPDK 16.11.1 will no longer compile against newer Linux kernels due to an
interface change in the kernel.
This can be
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/841
> During the deployment, I noticed the following message. I was not sure if
this can be ignored or needs to be looked at.
Hi Anand - Thanks for testing! I saw that a few times a
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/825
Even if the functionality is addressed, are there tests that cover this
condition that we can pull in from this PR? I don't think we ever got a proper
integration test to cover this issue
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/832
I merged with the latest changed from #824
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/825
Sounds good. I will take a look at #842.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/842
+1 LGTM
Tests pass as-is. Then I commented out [the core fix for this
issue](https://github.com/apache/metron/blob/fd896fbebe9d5e77eb11d1ce953ab2b55cc84387/metron-platform/metron
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/827
How does `getCommonColumnMetadata` behave when we have a mismatched field
(aka a field named the same in two different indices, but with different
types)? Do we need similar mismatch handling?
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/827
Even better then. Can we just get rid of it?
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/827
@justinleet I think that's a good find. I'd suggest we fix this issue on a
subsequent PR after we get this and #832 merged. On #832, the refactoring will
make it much easier to unit
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/832
I just merged in the last bits from master. This is ready for review.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/832
Thanks for all the reviews, guys. Going to commit now.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
Hi @iraghumitra - I'd like to see your work get in ASAP. Can you merge
with master when you get a chance?
Also, I think you need to make some updates based on recent PRs that
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r151791732
--- Diff: scripts/Bro/Kafka/logs-to-kafka.bro ---
@@ -14,32 +14,37 @@
# See the License for the specific language governing
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r151794206
--- Diff: scripts/init.bro ---
@@ -18,11 +18,20 @@
module Kafka;
export {
- const topic_name: string = "bro&qu
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r151793309
--- Diff: scripts/Bro/Kafka/logs-to-kafka.bro ---
@@ -14,32 +14,37 @@
# See the License for the specific language governing
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/843#discussion_r151798907
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/SearchServiceImpl.java
---
@@ -96,6 +96,11 @@ public
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/843#discussion_r151799957
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/SearchControllerIntegrationTest.java
---
@@ -132,6 +132,30
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/843#discussion_r151799462
--- Diff:
metron-interface/metron-rest/src/main/java/org/apache/metron/rest/service/impl/SearchServiceImpl.java
---
@@ -96,6 +96,11 @@ public
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/843#discussion_r151801296
--- Diff:
metron-interface/metron-rest/src/test/java/org/apache/metron/rest/controller/SearchControllerIntegrationTest.java
---
@@ -132,6 +132,30
Github user nickwallen commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/3
+1 This works great @JonZeolla . This is a really nice enhancement. I
tested by manually installing Bro and using bro-pkg to install our plugin.
Everything works exactly as I
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
@iraghumitra I see that you merged some changes. Is this ready to test?
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
That's weird @justinleet . The create request is working for me. I'll
mess with it some more and try to replicate what you are seeing.
I am seeing a separate issue on the RE
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/845
METRON-1321 Metaalert Threat Score Type Does Not Match Sensor Indices
After creating Metaalerts in the Alerts UI, I am unable to sort by threat
triage score. The exception that is logged is
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/845
I am still testing this in Full Dev. Will respond once I verify this
completely.
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/845#discussion_r152077236
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java
---
@@ -614,8 +625,15
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/845#discussion_r152083195
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchMetaAlertDao.java
---
@@ -614,8 +625,15
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/845
I ran this up according to my testing instructions and it addresses the
problem. Please take a look-see.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
Hi @iraghumitra - The UI does not refresh itself after a metaalert is
deleted. If this is something easy to fix, let's tackle it. Otherwise, I can
create a JIRA to track this and we can f
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
> I am not refreshing on purpose. If I refresh the UI after any operation
users would lose the current context and see new alerts (If available).
Ok @iraghumitra. Since you have a va
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/841
That's weird @anandsubbu . What version of Vagrant and VirtualBox are you
running?
Here are the versions that I am running...
* Virtualbox Version 5.1.22 r115126
* Va
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
Something seems to be wrong with saved searches. When I run through a
manual test script of creating metaalerts, deleting and navigating, most (if
not all) of my saved searches are these giant
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
@justinleet @iraghumitra I am glad that no one else can reproduce. I will
work on trying to get a set of steps to reproduce this. Let's not worry about
this on the current PR.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
IMHO I think the functionality is good on this PR. There are 3 functional
tests that failed, but they are minor and can be addressed after we get this PR
in.
My only hold-up right now
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/843
> Still need to spin up full dev and validate there. Will report back once
I have successfully done that but this can be reviewed in the meantime.
@merrimanr Did you run this up in F
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/843
Unless I missed it, I just don't see confirmation that you ran this change
up in Full Dev. If you already did, I am just looking for confirmation. I am
not asking you to run it up again,
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/843
Stated differently... Your PR description says "I need to run this up in
Full Dev." I am just looking for confirmation that you did that. That's all.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/843
+1 LGTM. No need to run it up again.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/841
@anandsubbu Yes, I think that is a good point. I can add that to a README
in the centos-7.4/ directory. I'm sure someone will run across this problem.
Can you share what
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/846
+1 Thanks, Anand. I tested with Docker daemon running, not running and not
installed. Worked as advertised.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
@iraghumitra Are all these e2e tests passing for you? I am still getting
failures. I manually truncated the `metron_updates` table before running them
also
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
Just a quick update... I was working with @iraghumitra yesterday on getting
the e2e tests to pass for me. It seems that with older versions of NPM the
tests do pass, but then only various shades
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/2#discussion_r152848070
--- Diff: scripts/Bro/Kafka/logs-to-kafka.bro ---
@@ -14,32 +14,37 @@
# See the License for the specific language governing
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
@iraghumitra Can you describe how you install Node/NPM on your development
box? I want to install using the same mechanism (and versions) and see if I
can get the e2e tests all working like you
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
+1
I'd like to see sign-off from at least one other committer (if not more)
before this gets merged.
I previously outlined the manual functional testing that I performed.
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/849
METRON-1320 Add C++11 Compliance Check to platform-info
Some of the module dependencies for the Management and Alerts UI must be
built natively on the host. This requires a C/C++ compiler. In
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/849#discussion_r153324714
--- Diff: metron-deployment/scripts/platform-info.sh ---
@@ -73,6 +73,30 @@ echo "--"
echo "npm"
npm --version
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/849#discussion_r153325047
--- Diff: metron-deployment/scripts/platform-info.sh ---
@@ -73,6 +73,30 @@ echo "--"
echo "npm"
npm --version
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/849#discussion_r153336117
--- Diff: metron-deployment/scripts/platform-info.sh ---
@@ -73,6 +73,30 @@ echo "--"
echo "npm"
npm --version
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/803
Great. I will get this PR merged. I am glad to see that this one is ready
to go.
---
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/851
METRON-1336 Patching Can Result in Bad Configuration
The following problems are addressed in this PR.
* A patch can be constructed that when applied creates an invalid
configuration
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/849
> Is this the expected output?
I agree with @ottobackwards . That looks like what I would expect to see.
@JonZeolla I assume since you asked, it is not what you would exp
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/836
+1 I like this @JonZeolla. This reads more clearly IMHO.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/830
Hi @iraghumitra - Is this PR still valid? Can you deconflict when you get
some cycles?
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/812
Bump. @JonZeolla You are good to go here. Let me know if you need help
merging/deploying the changes.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/847
Looks good, Jon. I agree with what you said. Let's get the release
process sorted before we commit this one.
---
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/852
METRON-1239 Drop extra dev environments
Per the previous discussion referenced in JIRA, this PR drops support for
the Quick Dev and Code Lab environments. These have been effectively dead for
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/852
Thanks @ottobackwards . I just pushed that fix, plus some other little
things I found.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/852
> @anandsubbu: I found one more reference to quick dev - here.
I was confused about that README.vm file. Any idea what that is for?
> @anandsubbu: Also, I could see th
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/852
> The issue is that we should use this type of operation, but do it as part
of maven no?
It doesn't seem that the utility is useful enough to maintain anymore. It
had value o
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/852
We can tackle the issue of documenting in a discuss thread. I'm not going
to tackle that issue on this PR.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/852
No problem @ottobackwards . I just deleted the ReadMeUtils and README.vm
files in the latest commit. I assume that whatever approach we take for
documenting, we want to get rid of these files
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/854
Experimental Improvements - Feedback Only - Do Not Merge
This is a PR to get feedback on some minor improvements that I was
experimenting with. If the community finds any of this useful, I will
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/855
METRON-1338 Excluding retry files from RAT check
When Vagrant fails, it generates a *.retry file. These files are ignored by
Git, but will unnecessarily fail a build because of the Rat check
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/854
Yes, I would just get in the habit of running `./mvn clean install
-DskipTests` rather than what we normally do.
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154105765
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154102327
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154110355
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154116726
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154118407
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154133309
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154133974
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154143988
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154171511
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154171805
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/856#discussion_r154189837
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/StellarStatementReporter.java
---
@@ -0,0 +1,166
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/851#discussion_r154207266
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -156,7 +156,7 @@ public
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/851#discussion_r154208493
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -343,25 +343,57 @@ public
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/851#discussion_r154209165
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -343,25 +343,57 @@ public
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/851#discussion_r154508202
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -343,25 +343,57 @@ public
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/851
@mmiklavc @cestella The kick is complete. All PRs merged. Ready for review.
---
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/851#discussion_r154798328
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -343,25 +343,42 @@ public
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/851#discussion_r154799152
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -572,15 +590,22 @@ public
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/851#discussion_r154821946
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/configuration/ConfigurationsUtils.java
---
@@ -343,25 +343,42 @@ public
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/851
Bump. Anything else we need on this one?
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/851
Thanks guys. Nice work on the meta-PRs. I like how that turned out.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/859
+1 Thanks!
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/859
Good catch @mmiklavc. Would be nice to get that added to the blueprint so
it just happens.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/859
Nice. I'm glad you uncovered the issue with the REST API. Reaffirming +1
---
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/864
METRON-1348 Metron Service Checks Use Wrong Hostname
The Metron service check can often use the incorrect hostname when checking
the Alerts UI, Management UI, and REST services. This results in
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/864#discussion_r156526514
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/params/status_params.py
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/866
METRON-1349 Full Dev Builds Metron Twice
Removing the "Quick Dev" environment in #852 had an unintended side effect.
It caused Metron to be built twice during the Full Dev deployme
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/866#discussion_r156724938
--- Diff: metron-deployment/roles/epel/tasks/main.yml ---
@@ -16,6 +16,4 @@
#
---
- name: Install EPEL repository
- yum: name=epel
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/866#discussion_r156725657
--- Diff: metron-deployment/roles/ambari_config/tasks/main.yml ---
@@ -26,16 +26,15 @@
retries: 5
delay: 10
-- name : check if
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/866#discussion_r156726426
--- Diff: metron-deployment/playbooks/metron_install.yml ---
@@ -15,13 +15,6 @@
# limitations under the License.
#
---
-- hosts
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/866#discussion_r156746647
--- Diff: metron-deployment/playbooks/metron_install.yml ---
@@ -15,13 +15,6 @@
# limitations under the License.
#
---
-- hosts
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/866
Sorry, I do not understand what you are asking, @ottobackwards
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/866
With this PR, you should see "Build Metron" and "Build Metron RPMs" only
once each. Here is the log output of what it should look-like.
[ansible.example.log](https://gith
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/866
Also, keep in mind that each time you run a 'vagrant up' it will append to
that ansible.log file. So that file will contain multiple deployments.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/866
Ha. Very nice @ottobackwards . I added more detailed testing steps should
they be needed by anyone else. Sadly, no cows.
---
1 - 100 of 832 matches
Mail list logo
