[GitHub] metron issue #846: METRON-1328: Enhance platform-info.sh script to check if ...

2017-11-22 Thread JonZeolla
Github user JonZeolla commented on the issue: https://github.com/apache/metron/pull/846 +1 tested on my mac with and without the daemon running. ---

[GitHub] metron issue #846: METRON-1328: Enhance platform-info.sh script to check if ...

2017-11-22 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/846 I would prefer it always say docker is running or not, but this will work. +1 ---

[GitHub] metron issue #846: METRON-1328: Enhance platform-info.sh script to check if ...

2017-11-22 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/846 +1 Thanks, Anand. I tested with Docker daemon running, not running and not installed. Worked as advertised. ---

[GitHub] metron issue #846: METRON-1328: Enhance platform-info.sh script to check if ...

2017-11-22 Thread anandsubbu
Github user anandsubbu commented on the issue: https://github.com/apache/metron/pull/846 Hi @ottobackwards , thanks for your review. I prefixed a 'WARNING' to the message text so it would catch the eye of the user. Also, I removed the else bit for docker running scenario,

[GitHub] metron issue #846: METRON-1328: Enhance platform-info.sh script to check if ...

2017-11-22 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/846 Thanks for the contribution! This is a great idea. If I may, I think this may be more clear: ```bash if docker info 2>&1 | grep -q 'Cannot connect to the Docker daemon' then