Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/37#issuecomment-193815074
Looks like deployment/roles/snort/files/snortrules-snapshot-2962.tar.gz is
giving an apache-rat license violation. Can you fix and update?
---
If your
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/34#issuecomment-193823068
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user cestella opened a pull request:
https://github.com/apache/incubator-metron/pull/39
METRON-62 Add writing to enriched data back to the enrichment topology
When we rearchitected the topologies to use flux, we never added back in
the HDFS writing. This needs to be done
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/38#issuecomment-193971678
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/41#issuecomment-194475475
Ok +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user cestella opened a pull request:
https://github.com/apache/incubator-metron/pull/44
METRON-66 Fix Grok parser to load patterns via HDFS
This contains the grok parser fix as well as the various issues that were
found collectively in integration testing:
* Grok
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/42#issuecomment-196293674
+1, looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/43#issuecomment-196327514
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/48#issuecomment-198380921
+1 this looks good, merging now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/47#issuecomment-197539298
This looks good to me, but I'm going to defer to @merrimanr to give it a
second glance since he's in that code right now.
---
If your project is
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/52#issuecomment-199264783
+1, this is great. Thank you very much for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/53#issuecomment-199292568
This looks good. I especially like the single-node deployment only running
bro, snort, yaf and enrichment. I think we could even trim it down to just bro
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/53#issuecomment-199339197
+1 from me now. I believe the travis error is due to travis not being set
up yet, which will happen external to this PR.
---
If your project is set up for
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/54#issuecomment-199471482
+1 from me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/55#issuecomment-199554897
+1. This should avoid pulling over local copies node modules, which we're
seeing periodically.
---
If your project is set up for it, you can reply to
GitHub user cestella opened a pull request:
https://github.com/apache/incubator-metron/pull/57
METRON-84 Update license/notices with appropriate 3rd party bundled notices
As part of the apache release, we have to provide pointers at the end of
the license file for bundled
GitHub user cestella opened a pull request:
https://github.com/apache/incubator-metron/pull/64
Updating missing licenses from metron-ui.
This is required for the apache release
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/64#issuecomment-203428699
* Removed extraneous LICENSE files and COPYING files
* Fixed the verbiage for the cisco contribution in the LICENSE file
* Added link to the license
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/65#issuecomment-204392919
+1 from me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user cestella opened a pull request:
https://github.com/apache/incubator-metron/pull/66
METRON-93: Generalize the HBase threat intel infrastructure to support
enrichments
As it stands, the threat intel infrastructure is awkward. Namely, different
threat intelligence sources
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/67#discussion_r58221412
--- Diff:
metron-streaming/Metron-Solr/src/main/java/org/apache/metron/writer/solr/MetronSolrClient.java
---
@@ -0,0 +1,83
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/67#discussion_r58221656
--- Diff:
metron-streaming/Metron-Solr/src/main/java/org/apache/metron/writer/solr/MetronSolrClient.java
---
@@ -0,0 +1,83
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/67#discussion_r58221773
--- Diff:
metron-streaming/Metron-Solr/src/main/java/org/apache/metron/writer/solr/MetronSolrClient.java
---
@@ -0,0 +1,83
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/67#discussion_r58222887
--- Diff: deployment/inventory/singlenode-vagrant/group_vars/all ---
@@ -62,7 +62,7 @@ threat_intel_bulk_load: False
#Sensors
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/67#discussion_r58223047
--- Diff: deployment/inventory/multinode-vagrant/group_vars/all ---
@@ -49,17 +49,23 @@ snort_version: "2.9.8.0-1"
snort_alert_csv_p
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/67#discussion_r58223216
--- Diff:
metron-streaming/Metron-Common/src/main/java/org/apache/metron/bolt/ConfiguredBolt.java
---
@@ -77,15 +82,37 @@ public void childEvent
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/67#discussion_r58223640
--- Diff: metron-streaming/Metron-Elasticsearch/pom.xml ---
@@ -0,0 +1,202 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
xmln
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/67#discussion_r58224354
--- Diff:
metron-streaming/Metron-Solr/src/main/java/org/apache/metron/writer/solr/MetronSolrClient.java
---
@@ -0,0 +1,83
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/66#discussion_r58237558
--- Diff:
metron-streaming/Metron-DataLoads/src/main/java/org/apache/metron/dataloads/hbase/mr/PrunerMapper.java
---
@@ -48,7 +48,7 @@ public void
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/66#discussion_r58373817
--- Diff:
metron-streaming/Metron-Common/src/main/java/org/apache/metron/enrichment/EnrichmentConfig.java
---
@@ -0,0 +1,203
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/66#discussion_r58375098
--- Diff:
metron-streaming/Metron-Common/src/test/java/org/apache/metron/enrichment/EnrichmentConfigTest.java
---
@@ -0,0 +1,253 @@
+package
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/66#discussion_r58468314
--- Diff:
metron-streaming/Metron-Common/src/test/java/org/apache/metron/enrichment/EnrichmentConfigTest.java
---
@@ -0,0 +1,253 @@
+package
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/68#discussion_r58468994
--- Diff: deployment/roles/metron_streaming/defaults/main.yml ---
@@ -34,3 +39,6 @@ storm_topologies:
- "{{ metron_directory }}/c
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/68#discussion_r58469110
--- Diff: metron-streaming/Metron-DataLoads/pom.xml ---
@@ -149,7 +149,12 @@
${project.parent.version}
test
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/68#discussion_r58472032
--- Diff: deployment/roles/metron_streaming/defaults/main.yml ---
@@ -34,3 +39,6 @@ storm_topologies:
- "{{ metron_directory }}/c
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/68#discussion_r58473310
--- Diff: deployment/roles/metron_streaming/defaults/main.yml ---
@@ -34,3 +39,6 @@ storm_topologies:
- "{{ metron_directory }}/c
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/68#discussion_r58473935
--- Diff: deployment/roles/metron_streaming/defaults/main.yml ---
@@ -34,3 +39,6 @@ storm_topologies:
- "{{ metron_directory }}/c
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/68#discussion_r58474064
--- Diff: deployment/roles/metron_streaming/defaults/main.yml ---
@@ -34,3 +39,6 @@ storm_topologies:
- "{{ metron_directory }}/c
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/63#issuecomment-205832068
+1 for sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/66#discussion_r58729524
--- Diff:
metron-streaming/Metron-Common/src/main/java/org/apache/metron/bolt/BulkMessageWriterBolt.java
---
@@ -81,8 +81,7 @@ public void execute
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/66#discussion_r58729427
--- Diff: metron-streaming/Metron-Common/pom.xml ---
@@ -34,8 +34,11 @@
Metron Kraken Repository
https
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/66#discussion_r58862697
--- Diff: deployment/roles/metron_streaming/tasks/main.yml ---
@@ -109,8 +111,10 @@
- { regexp: "bolt.hbase.table.name=&q
Github user cestella closed the pull request at:
https://github.com/apache/incubator-metron/pull/66
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/69#issuecomment-206891621
+1 and I'm itching to get travis back and in working order. Just for
posterity, the integration tests were failing and not reporting the failure
back
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/70#issuecomment-207453329
I looked at it. Looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/73#issuecomment-208532061
It's unfortunate that we are unable to get this to work with singlenode
vagrant. In lieu of that, can we have at least a utility and some sample dat
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/73#issuecomment-208532922
Got it, makes sense. This looks great, btw.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/73#issuecomment-208544467
So, since this touches the ansible stuff, could we please get someone else
to verify that singlenode vagrant isn't broken in a too-subtle-for-me-to-detect
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/76#issuecomment-210534256
I don't think the license for argparse is kosher. Please investigate and
remove if inappropriate or adjust the license file if that's required.
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/76#issuecomment-210547443
Ahh I see I thought there was some weirdness with GPL, but as I look it's
Python licensed now. It only became part of the standard package as of 2.7
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/76#issuecomment-210557717
Yeah the license is fine. We are going to have it installed in the vagrant
box as part of ansible, right?
On Fri, Apr 15, 2016 at 18:16 Nick Allen
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/76#issuecomment-210560794
Sounds good!
On Fri, Apr 15, 2016 at 18:37 Nick Allen wrote:
> Right. Next step is to update deployment/roles/pycapa to use this instead
&
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/76#issuecomment-210562709
Yes
On Fri, Apr 15, 2016 at 18:46 Nick Allen wrote:
> Ok good - Leaving argparse in the requirements.txt.
>
> Does "Sou
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/82#issuecomment-211970028
+1, looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/79#discussion_r60250470
--- Diff: metron-streaming/Metron-DataLoads/pom.xml ---
@@ -167,56 +225,14
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/79#issuecomment-211974974
+1, looks great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/81#discussion_r60249308
--- Diff:
metron-streaming/Metron-Common/src/test/java/org/apache/metron/bolt/BulkMessageWriterTest.java
---
@@ -0,0 +1,147
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/81#discussion_r60251394
--- Diff:
metron-streaming/Metron-EnrichmentAdapters/src/test/java/org/apache/metron/enrichment/bolt/EnrichmentJoinBoltTest.java
---
@@ -0,0 +1,86
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/81#discussion_r60251529
--- Diff:
metron-streaming/Metron-EnrichmentAdapters/src/test/java/org/apache/metron/enrichment/bolt/EnrichmentJoinBoltTest.java
---
@@ -0,0 +1,86
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/81#issuecomment-211975900
+1, looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/83#discussion_r60275671
--- Diff:
metron-streaming/Metron-DataLoads/src/test/java/org/apache/metron/dataloads/nonbulk/taxii/flatfile/SimplEnrichmentFlatFileLoaderTest.java
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/83#discussion_r60413561
--- Diff:
metron-streaming/Metron-DataLoads/src/test/java/org/apache/metron/dataloads/nonbulk/flatfile/SimplEnrichmentFlatFileLoaderTest.java
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/88#issuecomment-214301254
It appears Metron-Topologies still exists. Is that intended? If so, can
we rename to match the naming style of the other projects, please.
---
If your
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/88#issuecomment-214301466
Docs in the various Readme.md's still refer to old naming, can we adjust
those to prevent confusion?
---
If your project is set up for it, you can rep
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/88#issuecomment-214487973
+1, this looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user cestella opened a pull request:
https://github.com/apache/incubator-metron/pull/89
METRON-119 Move PCAP infrastructure from HBase
As it stands, the existing approach to handling PCAP data has some issues
handling high volume packet capture data. With the advent of a
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/89#issuecomment-214755233
Oh, please see the new updated docs for
* [Metron PCAP
Service](https://github.com/cestella/incubator-metron/tree/pcap_extraction_topology/metron-streaming
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/87#discussion_r61094126
--- Diff: metron-sensors/fastcapa/README.md ---
@@ -0,0 +1,76 @@
+Fastcapa
+
+
+Fastcapa is an Apache Metron sensor that
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/86#discussion_r61096549
--- Diff: deployment/roles/pycapa/tasks/dependencies.yml ---
@@ -15,20 +15,22 @@
# limitations under the License.
#
---
-- name
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/86#discussion_r61097845
--- Diff: deployment/roles/pycapa/tasks/dependencies.yml ---
@@ -15,20 +15,22 @@
# limitations under the License.
#
---
-- name
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/89#issuecomment-215057231
I'm not done merging 113 into this PR branch yet. Took me all day yesterday
and I'm still testing. I'll let you know when I'm do
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/89#issuecomment-215065111
In retrospect, this PR is a hot mess. Let me close and reopen once merging
and validation has been completed with a cleaner commit log.
---
If your project
Github user cestella closed the pull request at:
https://github.com/apache/incubator-metron/pull/89
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/90#issuecomment-215129100
+1, this looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/86#issuecomment-215129474
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/85#issuecomment-215133778
+1 this looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user cestella opened a pull request:
https://github.com/apache/incubator-metron/pull/93
METRON-119 Move PCAP infrastructure from HBase
As it stands, the existing approach to handling PCAP data has some issues
handling high volume packet capture data. With the advent of a
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/92#issuecomment-215559766
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/94#issuecomment-215568818
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/93#issuecomment-215694256
@dlyle65535 Definitely agreed, I'll submit a change this morning to remove
the warnings.
---
If your project is set up for it, you can reply to this
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/93#discussion_r61566951
--- Diff:
metron-deployment/roles/metron_streaming/tasks/metron_topology.yml ---
@@ -16,18 +16,14 @@
#
---
- name: Submit Metron
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/93#discussion_r61567528
--- Diff:
metron-deployment/roles/metron_streaming/tasks/metron_topology.yml ---
@@ -16,18 +16,14 @@
#
---
- name: Submit Metron
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/96#issuecomment-215979113
@merrimanr Hmm, I liked that feature (being able to run individual roles
against either a vagrant image or a prebuilt image). That will be useful, I
think
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/96#issuecomment-215985677
I'm not sure that `ansible-playbook -i
metron-deployment/inventory/singlenode-vagrant/hosts
metron-deployment/playbooks/metron_install.yml --tags enric
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/97#issuecomment-216260955
+1 this looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/98#issuecomment-216294305
+1 this is great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/96#issuecomment-216301128
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/106#issuecomment-217462306
Big +1, applied this change last night and it worked like a charm on SNV
---
If your project is set up for it, you can reply to this email and have your
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/95#issuecomment-217462512
+1, this is great. Thanks for contributing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user cestella opened a pull request:
https://github.com/apache/incubator-metron/pull/108
METRON-141: The ability to do threat triage
We have the ability to mark messages as part of the enrichment topology as
threat alerts, but we have no ability to prioritize those alerts
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/111#issuecomment-217664922
Looks like we got 2 for the same JIRA, this PR and PR 109. Cool! It's
great when people contribute. :)
---
If your project is set up for it, you can
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/109#discussion_r62421908
--- Diff:
metron-platform/metron-data-management/src/main/java/org/apache/metron/dataloads/extractor/csv/CSVExtractor.java
---
@@ -82,6 +83,14
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/109#discussion_r62421915
--- Diff:
metron-platform/metron-data-management/src/test/java/org/apache/metron/dataloads/extractor/csv/CSVExtractorTest.java
---
@@ -91,5 +85,9
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/109#issuecomment-217665302
This looks great outside of the couple of things I mentioned. Definitely
like the null check. +1 imminent if you get those changes.
---
If your project is
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/110#issuecomment-217665485
Cool, got my vote +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/107#issuecomment-217665540
"Having successfully created your Amazon Web Services account, hopefully
you will find that the most difficult tasks are behind us." I LOL
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/108#discussion_r62583229
--- Diff:
metron-platform/metron-common/src/test/java/org/apache/metron/common/cli/ConfigurationsUtilsTest.java
---
@@ -74,7 +74,7 @@ public void
Github user cestella commented on a diff in the pull request:
https://github.com/apache/incubator-metron/pull/108#discussion_r62583706
--- Diff:
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/bolt/EnrichmentJoinBolt.java
---
@@ -84,7 +88,7 @@ public
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/109#issuecomment-218142099
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user cestella commented on the pull request:
https://github.com/apache/incubator-metron/pull/113#issuecomment-218212537
This looks good to me, but I'd very much like @dlyle65535 to chime in.
---
If your project is set up for it, you can reply to this email and have your
401 - 500 of 1218 matches
Mail list logo
