Re: Move Vysper from sandbox

2009-06-21 Thread Niklas Gustavsson
On Sun, Jun 21, 2009 at 12:19 AM, Emmanuel Lecharnyelecha...@apache.org wrote: Well, sorry for being a bit a PITA, but I would like to see more javadoc in the project. We already have been burnt (and still are !!!) with MINA suffering from such a problem that I would like to avoid it again.

[jira] Commented: (VYSPER-12) Implement XEP-0199: XMPP Ping

2009-06-21 Thread Niklas Gustavsson (JIRA)
[ https://issues.apache.org/jira/browse/VYSPER-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12722317#action_12722317 ] Niklas Gustavsson commented on VYSPER-12: - I'm looking at implementing this to get

Vysper unit tests on running server

2009-06-21 Thread Niklas Gustavsson
Hey Over at FtpServer, we run a lot of unit tests but starting the server and then letting a client (in our case commons-net) interact with it, testing for correct outcomes. I'm thinking something similar would be a good idea for Vysper but fail to find any such tests (besides

[jira] Commented: (VYSPER-12) Implement XEP-0199: XMPP Ping

2009-06-21 Thread Bernd Fondermann (JIRA)
[ https://issues.apache.org/jira/browse/VYSPER-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12722320#action_12722320 ] Bernd Fondermann commented on VYSPER-12: Great idea, since this XEP recently has

Re: Vysper unit tests on running server

2009-06-21 Thread Bernd Fondermann
Niklas Gustavsson wrote: Hey Over at FtpServer, we run a lot of unit tests but starting the server and then letting a client (in our case commons-net) interact with it, testing for correct outcomes. I'm thinking something similar would be a good idea for Vysper but fail to find any such

Re: Move Vysper from sandbox

2009-06-21 Thread Bernd Fondermann
Emmanuel Lecharny wrote: Niklas Gustavsson wrote: Hi For Vysper, the export page has been updated (https://issues.apache.org/jira/browse/VYSPER-47), Bernd has assembled a list of all contributors (https://issues.apache.org/jira/browse/VYSPER-45) and I think we've done the due diligence

Re: Move Vysper from sandbox

2009-06-21 Thread Emmanuel Lecharny
Niklas Gustavsson wrote: On Sun, Jun 21, 2009 at 12:19 AM, Emmanuel Lecharnyelecha...@apache.org wrote: Well, sorry for being a bit a PITA, but I would like to see more javadoc in the project. We already have been burnt (and still are !!!) with MINA suffering from such a problem that I would

[jira] Resolved: (DIRMINA-616) New release.xml file

2009-06-21 Thread Edouard De Oliveira (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edouard De Oliveira resolved DIRMINA-616. - Resolution: Fixed New release.xml file

[jira] Updated: (DIRMINA-616) New release.xml file

2009-06-21 Thread Edouard De Oliveira (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edouard De Oliveira updated DIRMINA-616: Assignee: Edouard De Oliveira (was: Julien Vermillard) Seems that there's

[jira] Commented: (DIRMINA-679) NullPointerException in ProtocolCodecFilter.filterWrite

2009-06-21 Thread Edouard De Oliveira (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12722357#action_12722357 ] Edouard De Oliveira commented on DIRMINA-679: - John were you using an

Re: Move Vysper from sandbox

2009-06-21 Thread Emmanuel Lecharny
Bernd Fondermann wrote: To turn this into an actually task, could you point out areas/classes that especially lack javadoc? I have conducted a quick review of around one third of the java files (test excluded). I have tagged all the files I reviewed with : * J : files without javadoc * j

[jira] Commented: (DIRMINA-679) NullPointerException in ProtocolCodecFilter.filterWrite

2009-06-21 Thread John J. Franey (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12722362#action_12722362 ] John J. Franey commented on DIRMINA-679: No. I was not using ExecutorFilter.

Re: Move Vysper from sandbox

2009-06-21 Thread Alex Karasulu
Hi gang, I think we're all a bit sensitive after having dealt with a situation where a code base was left almost totally undocumented by a developer here at MINA. I think Emmanuel makes good points and so do the Bernard and others. Let's all work together to ameliorate our fears from the past

Re: Vysper unit tests on running server

2009-06-21 Thread Niklas Gustavsson
On Sun, Jun 21, 2009 at 11:14 AM, Bernd Fondermannbf_...@brainlounge.de wrote: For testing new functionality (mostly handlers), starting the server is not neccessary (and that's a big plus). Just testing the handler in isolation is usually sufficient. I should have pointed out that I did not

Re: Move Vysper from sandbox

2009-06-21 Thread Niklas Gustavsson
On Sun, Jun 21, 2009 at 12:01 PM, Emmanuel Lecharnyelecha...@apache.org wrote: I didn't said that Vysper should not exit the sandbox, sorry of it was interpreted this way. Oh, that was just me reading to much into your reply. And I should probably have mentioned that I do not think Vysper is

[jira] Commented: (DIRMINA-714) Packet sequence is unordered in multi thread.

2009-06-21 Thread Edouard De Oliveira (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12722377#action_12722377 ] Edouard De Oliveira commented on DIRMINA-714: - I committed a fix which should

[jira] Resolved: (DIRMINA-714) Packet sequence is unordered in multi thread.

2009-06-21 Thread Edouard De Oliveira (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edouard De Oliveira resolved DIRMINA-714. - Resolution: Fixed Packet sequence is unordered in multi thread.

Re: Move Vysper from sandbox

2009-06-21 Thread Emmanuel Lecharny
Alex just expressed what I had in mind much better than I did ! Sometime, it helps to be a native english speaker :) ( I don't know how many time some frustration arose from the incapacity we have to express with the correct wording what we really think ...) Thanks guys ! On Sun, Jun 21, 2009

[jira] Assigned: (DIRMINA-632) WriteFuture.awaitUninterruptibly() or .join() hangs if write() throws Exceptions

2009-06-21 Thread Edouard De Oliveira (JIRA)
[ https://issues.apache.org/jira/browse/DIRMINA-632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edouard De Oliveira reassigned DIRMINA-632: --- Assignee: Edouard De Oliveira WriteFuture.awaitUninterruptibly() or

Re: Vysper unit tests on running server

2009-06-21 Thread Bernd Fondermann
Niklas Gustavsson wrote: On Sun, Jun 21, 2009 at 11:14 AM, Bernd Fondermannbf_...@brainlounge.de wrote: For testing new functionality (mostly handlers), starting the server is not neccessary (and that's a big plus). Just testing the handler in isolation is usually sufficient. I should

Re: Move Vysper from sandbox

2009-06-21 Thread Bernd Fondermann
Emmanuel Lecharny wrote: Bernd Fondermann wrote: To turn this into an actually task, could you point out areas/classes that especially lack javadoc? I have conducted a quick review of around one third of the java files (test excluded). I have tagged all the files I reviewed with : * J :

Re: Vysper unit tests on running server

2009-06-21 Thread Niklas Gustavsson
On Sun, Jun 21, 2009 at 10:21 PM, Bernd Fondermannbf_...@brainlounge.de wrote: [snipped some good arguments] XMPP is not only specified for socket transport. It's defined BOSH (over HTTP) as well. I'm sure you wouldn't want to double every e2e test for both transports? Yeah, I've worked a

Website and Documentation

2009-06-21 Thread Bernd Fondermann
Hi, MINA websites are powered by Confluence exports, AFAIUI. There is Apache MINA Vysper in Confluence. How do I start moving Vysper's lab pages over without screwing up? Is there a documentation documentation somewhere? Bernd

Re: Website and Documentation

2009-06-21 Thread Niklas Gustavsson
On Sun, Jun 21, 2009 at 10:52 PM, Bernd Fondermannbf_...@brainlounge.de wrote: MINA websites are powered by Confluence exports, AFAIUI. Right. There is Apache MINA Vysper in Confluence. How do I start moving Vysper's lab pages over without screwing up? Probably easiest to edit them and

Re: Move Vysper from sandbox

2009-06-21 Thread Emmanuel Lecharny
Bernd Fondermann wrote: Emmanuel Lecharny wrote: Bernd Fondermann wrote: To turn this into an actually task, could you point out areas/classes that especially lack javadoc? I have conducted a quick review of around one third of the java files (test excluded). I have tagged

[Vote] Separating the spec compliance stuff

2009-06-21 Thread Niklas Gustavsson
Great to see all the Vysper discussions going on. This is going to be a great project! On Fri, Jun 12, 2009 at 10:37 PM, Niklas Gustavssonnik...@protocol7.com wrote: What do you think? I'm leaning towards keeping the code here at MINA, but doing it as a separate module from Vysper. Since no

Re: [Vote] Separating the spec compliance stuff

2009-06-21 Thread Emmanuel Lecharny
Niklas Gustavsson wrote: [X] +1, Do it -- -- cordialement, regards, Emmanuel Lécharny www.iktek.com directory.apache.org

Re: Move Vysper from sandbox

2009-06-21 Thread Michael Jakl
Hi! On Sun, Jun 21, 2009 at 23:04, Emmanuel Lecharnyelecha...@apache.org wrote: I have to admit that this kind of quantitive analysis doesn't tell me much. I'd rather improve the javadoc for a central class than write a new one for a simple interface setter method where the name and

[jira] Created: (VYSPER-78) Javadoc for PubSub-related classes

2009-06-21 Thread Michael Jakl (JIRA)
Javadoc for PubSub-related classes -- Key: VYSPER-78 URL: https://issues.apache.org/jira/browse/VYSPER-78 Project: VYSPER Issue Type: Improvement Components: XEP0060 PubSub Reporter:

Re: [Vote] Separating the spec compliance stuff

2009-06-21 Thread Michael Jakl
On Sun, Jun 21, 2009 at 23:20, Niklas Gustavssonnik...@protocol7.com wrote: To get a final decision on this, let's vote and be done: [x] +1, Do it

Re: Move Vysper from sandbox

2009-06-21 Thread Emmanuel Lecharny
Michael Jakl wrote: Hi! The documentation I found in Vysper proved very helpful and - of course - more of it would do good. Anyway I'd second the view that good documentation shouldn't repeat what the code says best. The HTML argument is a good one, but IMHO more relevant in closed source

Re: Move Vysper from sandbox

2009-06-21 Thread Alex Karasulu
On Sun, Jun 21, 2009 at 6:57 PM, Michael Jakl jakl.mich...@gmail.comwrote: Hi! On Sun, Jun 21, 2009 at 23:04, Emmanuel Lecharnyelecha...@apache.org wrote: I have to admit that this kind of quantitive analysis doesn't tell me much. I'd rather improve the javadoc for a central class than

Re: [Vote] Separating the spec compliance stuff

2009-06-21 Thread Ashish
[X] +1, Do it thanks ashish Blog: http://www.ashishpaliwal.com/blog My Photo Galleries: http://www.pbase.com/ashishpaliwal