zhoutt96oci commented on PR #248:
URL: https://github.com/apache/mina-sshd/pull/248#issuecomment-1255158765
mmm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
zhoutt96oci commented on PR #248:
URL: https://github.com/apache/mina-sshd/pull/248#issuecomment-1255153051
mmm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
zhoutt96better commented on PR #248:
URL: https://github.com/apache/mina-sshd/pull/248#issuecomment-1255152043
hhh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
zhoutt96oci commented on PR #248:
URL: https://github.com/apache/mina-sshd/pull/248#issuecomment-1255151425
test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
tomaswolf opened a new pull request, #247:
URL: https://github.com/apache/mina-sshd/pull/247
Window expansions can occur even when the channel is already closing. Abort
writing only if the stream is closed immediately, or is already closed.
--
This is an automated message from the Apache
tomaswolf merged PR #241:
URL: https://github.com/apache/mina-sshd/pull/241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tomaswolf commented on PR #241:
URL: https://github.com/apache/mina-sshd/pull/241#issuecomment-1252260941
> I've seen there are some changes in the forwarding topic in the meanwhile.
Is it worth to check if there are other leaking situations maybe there? Or at
least checking the tests
knalli commented on PR #241:
URL: https://github.com/apache/mina-sshd/pull/241#issuecomment-1252237200
Oh, alright
I've seen there are some changes in the forwarding topic in the meanwhile.
Is it worth to check if there are other leaking situations maybe there? Or at
least
tomaswolf commented on PR #241:
URL: https://github.com/apache/mina-sshd/pull/241#issuecomment-1252232948
> Oops.. I missed your comment. Squash & rebase done.
Guess you didn't notice that I had already done so. I just hadn't merged yet.
--
This is an automated message from the
knalli commented on PR #241:
URL: https://github.com/apache/mina-sshd/pull/241#issuecomment-1252124075
Oops.. I missed your comment. Squash & rebase done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
zhoutt96better closed pull request #246: test
URL: https://github.com/apache/mina-sshd/pull/246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zhoutt96better commented on PR #246:
URL: https://github.com/apache/mina-sshd/pull/246#issuecomment-1250569328
comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
zhoutt96better commented on PR #246:
URL: https://github.com/apache/mina-sshd/pull/246#issuecomment-1250569271
ss
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
zhoutt96better commented on PR #246:
URL: https://github.com/apache/mina-sshd/pull/246#issuecomment-1250560759
test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
tomaswolf merged PR #244:
URL: https://github.com/apache/mina-sshd/pull/244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tomaswolf closed pull request #245: Update README.md
URL: https://github.com/apache/mina-sshd/pull/245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tomaswolf commented on PR #244:
URL: https://github.com/apache/mina-sshd/pull/244#issuecomment-1246549726
This looks OK now.
- The problem with `ClientDeadlockTest` was
tomaswolf commented on PR #244:
URL: https://github.com/apache/mina-sshd/pull/244#issuecomment-1245521520
> Looks like the ClientDeadlockTest has a problem on Windows with Netty,
though.
Actually, it also fails here in GitHub CI on Ubuntu. Still cannot reproduce,
neither on Windows,
nicklester opened a new issue, #20:
URL: https://github.com/apache/mina-ftpserver/issues/20
It would be exceptionally useful to track the number of remaining passive
ports available in the pool as they are assigned/released. Before I work on PR,
I wanted to check if there was any was of
tomaswolf commented on PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#issuecomment-1245167266
"2.9.2-SNAPSHOT" is just the current development version. I don't think
we'll do another patch release for this. So most likely the change will come
whenever 2.10.0 is released, which
onyas commented on PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#issuecomment-1244795409
Hi, @tomaswolf Good day, another question, when is this version 2.9.2
planned to be released?
--
This is an automated message from the Apache Git Service.
To respond to the message,
tomaswolf commented on PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#issuecomment-1242956515
@lgoldstein and @gnodet: I'd appreciate your opinions on this. Please also
see my thoughts at
onyas commented on PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#issuecomment-1242826914
Sure, please go ahead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
tomaswolf commented on PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#issuecomment-1242774789
Looks good now. Is it OK for you if I squash this series and fix some of the
javadoc comments, and then force-push onto this branch?
--
This is an automated message from the Apache
tomaswolf commented on code in PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#discussion_r967672989
##
sshd-core/src/test/java/org/apache/sshd/client/ClientTest.java:
##
@@ -1530,6 +1532,29 @@ public void testConnectUsingIPv6Address() throws
IOException {
onyas commented on code in PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#discussion_r967655211
##
sshd-core/src/test/java/org/apache/sshd/client/ClientTest.java:
##
@@ -1530,6 +1532,29 @@ public void testConnectUsingIPv6Address() throws
IOException {
}
tomaswolf commented on code in PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#discussion_r967621455
##
sshd-core/src/test/java/org/apache/sshd/client/ClientTest.java:
##
@@ -1530,6 +1532,29 @@ public void testConnectUsingIPv6Address() throws
IOException {
tomaswolf commented on code in PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#discussion_r967621421
##
sshd-core/src/test/java/org/apache/sshd/client/ClientTest.java:
##
@@ -1530,6 +1532,29 @@ public void testConnectUsingIPv6Address() throws
IOException {
tomaswolf commented on code in PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#discussion_r967619429
##
sshd-core/src/test/java/org/apache/sshd/client/ClientTest.java:
##
@@ -1530,6 +1532,29 @@ public void testConnectUsingIPv6Address() throws
IOException {
tomaswolf commented on code in PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#discussion_r967617775
##
sshd-core/src/test/java/org/apache/sshd/client/ClientTest.java:
##
@@ -1530,6 +1532,29 @@ public void testConnectUsingIPv6Address() throws
IOException {
onyas commented on PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#issuecomment-1242651184
Hi @tomaswolf All the suggestions are implemented, please take a look.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
tomaswolf commented on PR #241:
URL: https://github.com/apache/mina-sshd/pull/241#issuecomment-1242360255
Looks good. Please rebase and squash the commits, then we can merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tomaswolf commented on PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#issuecomment-1242234993
> Can we write a test for this?
I've created issue
[SSHD-1295](https://issues.apache.org/jira/browse/SSHD-1295) in our bug tracker
for this, and have posted a test case there.
tomaswolf commented on code in PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#discussion_r967243244
##
sshd-core/src/main/java/org/apache/sshd/client/SshClient.java:
##
@@ -586,9 +587,14 @@ protected ConnectFuture doConnect(
lgoldstein commented on code in PR #244:
URL: https://github.com/apache/mina-sshd/pull/244#discussion_r967206452
##
sshd-sftp/pom.xml:
##
@@ -150,7 +150,6 @@
org.apache.maven.plugins
tomaswolf commented on code in PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#discussion_r967176879
##
sshd-common/src/main/java/org/apache/sshd/common/future/DefaultSshFuture.java:
##
@@ -227,6 +252,16 @@ public void cancel() {
setValue(CANCELED);
}
onyas commented on PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#issuecomment-1241799969
Hi, @tomaswolf Thank you for the suggestions, I updated the code, please
help review.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the
tomaswolf commented on code in PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#discussion_r966772266
##
sshd-core/src/main/java/org/apache/sshd/client/future/ConnectFuture.java:
##
@@ -78,4 +80,13 @@ default ClientSession getClientSession() {
* Cancels the
tomaswolf commented on PR #244:
URL: https://github.com/apache/mina-sshd/pull/244#issuecomment-1241652073
Looks like the ClientDeadlockTest has a problem on Windows, though. I'll
have to investigate that before we can merge this.
--
This is an automated message from the Apache Git
tomaswolf commented on code in PR #244:
URL: https://github.com/apache/mina-sshd/pull/244#discussion_r966757372
##
sshd-sftp/pom.xml:
##
@@ -150,7 +150,6 @@
org.apache.maven.plugins
tomaswolf commented on code in PR #244:
URL: https://github.com/apache/mina-sshd/pull/244#discussion_r966757372
##
sshd-sftp/pom.xml:
##
@@ -150,7 +150,6 @@
org.apache.maven.plugins
lgoldstein commented on code in PR #244:
URL: https://github.com/apache/mina-sshd/pull/244#discussion_r966711733
##
sshd-sftp/pom.xml:
##
@@ -150,7 +150,6 @@
org.apache.maven.plugins
tomaswolf opened a new pull request, #244:
URL: https://github.com/apache/mina-sshd/pull/244
This series of commits enables most tests for all I/O back-ends. For the
details, see the individual commit messages.
There are two new very minor features; see CHANGES.md.
--
This is an
tomaswolf merged PR #243:
URL: https://github.com/apache/mina-sshd/pull/243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
onyas commented on PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#issuecomment-1241396817
Hi, @tomaswolf Thank you for your insights, and I updated the code
according to your suggestions. Please help review.
Thanks.
--
This is an automated message from the Apache Git
tomaswolf opened a new pull request, #243:
URL: https://github.com/apache/mina-sshd/pull/243
Ensure that the IoProcessor pool is disposed, otherwise a selector may not
get closed, leading to a file handle leak.
--
This is an automated message from the Apache Git Service.
To respond to
tomaswolf commented on PR #242:
URL: https://github.com/apache/mina-sshd/pull/242#issuecomment-1240757939
As far as I see what happens is that the asynchronous connection attempt
succeeds after the timeout.
I'd move the timeout flag and the `isTimeout()` method to
hboutemy opened a new pull request, #34:
URL: https://github.com/apache/mina/pull/34
XBean Spring produces non reproducible output, as seen when rebuilding Mina
releases
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/mina/README.md
waiting
onyas opened a new pull request, #242:
URL: https://github.com/apache/mina-sshd/pull/242
Hi there,
We have encouraged an issue in which the SSHD doesn’t close the session when
connecting timeout.
The code we are using is attached here.
knalli commented on PR #241:
URL: https://github.com/apache/mina-sshd/pull/241#issuecomment-1233418548
Note: The existing test `testLocalForwardingNative` isn't covering this
(anymore) because the semaphore `tearDownSignal` is checked in the events (like
`tornDownExplicitTunnel`) only --
knalli opened a new pull request, #241:
URL: https://github.com/apache/mina-sshd/pull/241
This fixes de-allocating / unbinding a local port forwarding binding when
using a dynamic auto-allocated port.
The information "localAddress" is controlled by the user and may contain
still a
chrjohn opened a new pull request, #33:
URL: https://github.com/apache/mina/pull/33
nextFolter -> nextFilter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
lgoldstein closed pull request #237: [SSHD-1283] Added configuration property
to control whether ScpShell is enabled
URL: https://github.com/apache/mina-sshd/pull/237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
tomaswolf merged PR #240:
URL: https://github.com/apache/mina-sshd/pull/240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tomaswolf opened a new pull request, #240:
URL: https://github.com/apache/mina-sshd/pull/240
More precise logging in onWritten() to distinguish the cases better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
tomaswolf merged PR #239:
URL: https://github.com/apache/mina-sshd/pull/239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tomaswolf opened a new pull request, #239:
URL: https://github.com/apache/mina-sshd/pull/239
If data is appended while a file is read via SFTP, SftpInputStreamAsync
would enter an infinite loop if requestOffset >= fileSize + bufferSize.
Fix this and issue only sequential read requests
tomaswolf merged PR #238:
URL: https://github.com/apache/mina-sshd/pull/238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tomaswolf opened a new pull request, #238:
URL: https://github.com/apache/mina-sshd/pull/238
Make sure that a thread does not try to acquire the write lock if
it already holds the read lock. This could happen if a write is not
enqueued and there is an exception during writing, and we
lgoldstein commented on code in PR #237:
URL: https://github.com/apache/mina-sshd/pull/237#discussion_r939481418
##
sshd-common/src/main/java/org/apache/sshd/common/config/PreferredAuthConfigEntry.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation
tomaswolf commented on code in PR #237:
URL: https://github.com/apache/mina-sshd/pull/237#discussion_r938932950
##
sshd-common/src/main/java/org/apache/sshd/common/config/PreferredAuthConfigEntry.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
lgoldstein commented on PR #237:
URL: https://github.com/apache/mina-sshd/pull/237#issuecomment-1206442337
>> I don't see any connection between commit
https://github.com/apache/mina-sshd/commit/4e2f817c1eff380d083cf43df5d1aec6d8830564
and SSHD-1281. Please fix that typo in the commit
lgoldstein commented on PR #237:
URL: https://github.com/apache/mina-sshd/pull/237#issuecomment-1206442013
>> This doesn't appear to be a non-standard option. Normal OpenSSH allows
overriding any config setting via "-o" on the command-line, and
PreferredAuthentications is a standard SSH
lgoldstein commented on PR #237:
URL: https://github.com/apache/mina-sshd/pull/237#issuecomment-1206441258
>> Perhaps I'm missing something (can only review this in the Github Web UI
right now), but I don't see any use of this list.
No, you are not missing anything - I am still
lgoldstein commented on PR #237:
URL: https://github.com/apache/mina-sshd/pull/237#issuecomment-1206440348
>> BTW: I think we should have a new release 2.9.1 with only the fixes for
Java 8 (SSHD-1281/SSHD-1285), with anything else in a later release. In
particular new features should not
lgoldstein commented on code in PR #237:
URL: https://github.com/apache/mina-sshd/pull/237#discussion_r938794190
##
sshd-common/src/main/java/org/apache/sshd/common/config/PreferredAuthConfigEntry.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation
tomaswolf commented on PR #237:
URL: https://github.com/apache/mina-sshd/pull/237#issuecomment-1206375362
BTW: I think we should have a new release 2.9.1 with only the fixes for Java
8 (SSHD-1281/SSHD-1285), with anything else in a later release. In particular
new features should not be
tomaswolf commented on code in PR #237:
URL: https://github.com/apache/mina-sshd/pull/237#discussion_r938746368
##
sshd-common/src/main/java/org/apache/sshd/common/config/PreferredAuthConfigEntry.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
lgoldstein commented on PR #237:
URL: https://github.com/apache/mina-sshd/pull/237#issuecomment-1204259170
@tomaswolf Could you take a look ? Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lgoldstein closed pull request #234: [SSHD-1283] Added configuration property
to control whether ScpShell is enabled
URL: https://github.com/apache/mina-sshd/pull/234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
norrisjeremy commented on PR #235:
URL: https://github.com/apache/mina-sshd/pull/235#issuecomment-1203632844
The `pom.xml` for this project already has the following, so it seems more
consistent to do it the way I proposed:
```
org.apache.maven.plugins
elecharny commented on PR #235:
URL: https://github.com/apache/mina-sshd/pull/235#issuecomment-1203567816
Hi,
I think this can also be done with just a property, like what we have in
MINA:
```
java-8-compilation
[9,)
tomaswolf merged PR #236:
URL: https://github.com/apache/mina-sshd/pull/236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tomaswolf opened a new pull request, #236:
URL: https://github.com/apache/mina-sshd/pull/236
If there's an exception in Nio2Connector after the session was set on
the DefaultIoConnectFuture, a program might just hang on that session
until the next read or write attempt, or until a
tomaswolf merged PR #235:
URL: https://github.com/apache/mina-sshd/pull/235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
norrisjeremy opened a new pull request, #235:
URL: https://github.com/apache/mina-sshd/pull/235
… Java versions > 8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
lgoldstein opened a new pull request, #234:
URL: https://github.com/apache/mina-sshd/pull/234
@tomaswolf Do you mind giving this a quick look-over ? Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
gnodet merged PR #233:
URL: https://github.com/apache/mina-sshd/pull/233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tomaswolf commented on PR #233:
URL: https://github.com/apache/mina-sshd/pull/233#issuecomment-1184859197
@gnodet, @elecharny : this should fix the problem noticed in the 2.9.0
release candidate [on the dev mailing
list](https://www.mail-archive.com/dev@mina.apache.org/msg38601.html). At
tomaswolf opened a new pull request, #233:
URL: https://github.com/apache/mina-sshd/pull/233
Running a "mvn clean install" from the source tar archive failed for
some container tests because unpacking the tar might not preserve
executable bits. Testcontainers need an entrypoint that is
lgoldstein closed pull request #232: Upgraded some dependencies versions
URL: https://github.com/apache/mina-sshd/pull/232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
lgoldstein closed pull request #231: [SSHD-1276] Added capability to redirect
command/shell STDERR stream to STDOUT one
URL: https://github.com/apache/mina-sshd/pull/231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dependabot[bot] opened a new pull request, #19:
URL: https://github.com/apache/mina-ftpserver/pull/19
Bumps [spring-web](https://github.com/SpringSource/spring-framework) from
2.5.5 to 3.2.5.RELEASE.
Commits
See full diff in
lgoldstein commented on PR #231:
URL: https://github.com/apache/mina-sshd/pull/231#issuecomment-1177947787
You are correct - fixed it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tomaswolf commented on PR #231:
URL: https://github.com/apache/mina-sshd/pull/231#issuecomment-1177369294
What about ```Streaming.Async```?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lgoldstein opened a new pull request, #231:
URL: https://github.com/apache/mina-sshd/pull/231
@tomaswolf I would appreciate your feedback...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] opened a new pull request, #23:
URL: https://github.com/apache/mina-vysper/pull/23
Bumps jackrabbit-core from 1.5.3 to 2.1.0.
[ mentions shell
and/or command but not subsystem. However, I see no harm in allowing this for
dependabot[bot] opened a new pull request, #22:
URL: https://github.com/apache/mina-vysper/pull/22
Bumps tomcat-catalina from 7.0.27 to 7.0.81.
[