Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-02-05 Thread Julien Vermillard
On Mon, 04 Feb 2008 22:02:19 -0700 Jeff Genender [EMAIL PROTECTED] wrote: Mike Heath wrote: To clarify, my understanding of pipelining is that it is sending multiple requests and then waiting for the corresponding responses. This is more than HTTP keep alive which would also allow

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-02-05 Thread Alex Karasulu
Thanks Julien this is cool. Trustin why isn't any of this code documented? Would be nice if users can see what this is about ... might make people use it more. Alex On Feb 5, 2008 3:07 AM, Julien Vermillard [EMAIL PROTECTED] wrote: On Mon, 04 Feb 2008 22:02:19 -0700 Jeff Genender [EMAIL

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-02-05 Thread Rick McGuire
This sounds like an excellent approach to merging the efforts. Rick Mike Heath wrote: I've been looking into merging http://svn.apache.org/repos/asf/geronimo/sandbox/async-http-client-mina2/ into http://svn.apache.org/repos/asf/mina/asyncweb/trunk/client/ and I'm trying to figure out the best

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-02-05 Thread Jeff Genender
Wow...this is awesome...I could have used this because this is essentially the same mechanism I wrote in AHC ;-) Yeah...this should be documented in the FAQ somewhere as this would come in handy. Jeff Julien Vermillard wrote: Hi, Just by the way, if you want to monitor a request/response

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-02-05 Thread Maarten Bosteels
On Feb 5, 2008 10:07 AM, Alex Karasulu [EMAIL PROTECTED] wrote: Thanks Julien this is cool. Trustin why isn't any of this code documented? Would be nice if users can see what this is about ... might make people use it more. see

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-02-05 Thread Alex Karasulu
Excellent thanks. Alex On Feb 5, 2008 9:50 AM, Maarten Bosteels [EMAIL PROTECTED] wrote: On Feb 5, 2008 10:07 AM, Alex Karasulu [EMAIL PROTECTED] wrote: Thanks Julien this is cool. Trustin why isn't any of this code documented? Would be nice if users can see what this is about ...

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-02-04 Thread Mike Heath
Rick McGuire wrote: I had some time this morning, and decided to take a look at this. It was fairly straightforward merging the changes back in to the 2.0 sandbox branch. There's a bit of a problem going on here with the jsps used for the tests. In the 1.1.5-based version, there was no

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-02-04 Thread Sangjin Lee
Yeah I believe so (as far as I can tell). It was more or less a straightforward porting, so there might be interesting and subtle behavior changes we may need to look at. But it should be a good solid baseline. Thanks, Sangjin On Feb 4, 2008 2:50 PM, Mike Heath [EMAIL PROTECTED] wrote: Rick

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-02-04 Thread Mike Heath
I've been looking into merging http://svn.apache.org/repos/asf/geronimo/sandbox/async-http-client-mina2/ into http://svn.apache.org/repos/asf/mina/asyncweb/trunk/client/ and I'm trying to figure out the best way to proceed. Here are some of the pain points I see: - The only redeeming quality

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-02-04 Thread Sangjin Lee
Sounds good to me. The codec has evolved quite a bit, so yeah, we'd need to pay attention to the codec to make sure all the features are properly migrated... Please let me know how I can participate in this effort. We'll open new JIRA issues as we identify individual tasks, no? Thanks, Sangjin

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-02-04 Thread Jeff Genender
Mike Heath wrote: I've been looking into merging http://svn.apache.org/repos/asf/geronimo/sandbox/async-http-client-mina2/ into http://svn.apache.org/repos/asf/mina/asyncweb/trunk/client/ and I'm trying to figure out the best way to proceed. Here are some of the pain points I see: - The

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-02-04 Thread Mike Heath
Jeff Genender wrote: snip I think this timeout is a different timeout in implementation...that is unless this was added to 2.0, then duplication may be correct. Its a response timeout, not socket timeout...I think thats different. MINA has support for triggering events for read idle, write

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-02-04 Thread Mike Heath
Jeff Genender wrote: Mike Heath wrote: Jeff Genender wrote: snip I think this timeout is a different timeout in implementation...that is unless this was added to 2.0, then duplication may be correct. Its a response timeout, not socket timeout...I think thats different. MINA has

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-02-04 Thread Jeff Genender
Mike Heath wrote: What the FAQ is saying is that the idle event wont tell you which request message was issued when the timeout occured. So using an idle read to detect an unresponsive connection is perfectly legitimate. I don't see why using idle wouldn't work for pipelining. If the

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-02-04 Thread Jeff Genender
Mike Heath wrote: To clarify, my understanding of pipelining is that it is sending multiple requests and then waiting for the corresponding responses. This is more than HTTP keep alive which would also allow using a single connection for multiple requests but doesn't necessarily involve the

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-02-01 Thread Jeff Genender
Or you can use Linux or Mac ;-) j/k! Thanks for looking into that Rick. Jeff Rick McGuire wrote: I had some time this morning, and decided to take a look at this. It was fairly straightforward merging the changes back in to the 2.0 sandbox branch. There's a bit of a problem going on here

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-02-01 Thread Sangjin Lee
Thanks Rick! This was fast. I'll also take a quick look... Regards, Sangjin On Feb 1, 2008 11:17 AM, Jeff Genender [EMAIL PROTECTED] wrote: Or you can use Linux or Mac ;-) j/k! Thanks for looking into that Rick. Jeff Rick McGuire wrote: I had some time this morning, and decided to

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-01-31 Thread Sangjin Lee
Just so I understand... What is the direction we're taking? Just for the terminology sake, I'll call these versions - g-ahc-v1: Geronimo AHC based on Mina 1.1 (the one that Rick and I were working on) - g-ahc-v2: Geronimo AHC based on Mina trunk - mina-ahc: Mina AHC that was refactored into

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-01-31 Thread jvermillard
Hi, Just so I understand... What is the direction we're taking? Just for the terminology sake, I'll call these versions - g-ahc-v1: Geronimo AHC based on Mina 1.1 (the one that Rick and I were working on) - g-ahc-v2: Geronimo AHC based on Mina trunk - mina-ahc: Mina AHC that was

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-01-31 Thread Jeff Genender
Yes.. I think that is the best course of action. I think they are pretty similar since I created the mina 2 version in late December. I think the delta is rather small. Jeff On Jan 31, 2008, at 1:34 PM, Sangjin Lee [EMAIL PROTECTED] wrote: Just so I understand... What is the direction

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-01-31 Thread jvermillard
sorry for double post,I'm out of my office and using webmail which is really bugged :( Sorry for the inconvenience, Julien

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-01-31 Thread jvermillard
Hi Just so I understand... What is the direction we're taking? Just for the terminology sake, I'll call these versions - g-ahc-v1: Geronimo AHC based on Mina 1.1 (the one that Rick and I were working on). - g-ahc-v2: Geronimo AHC based on Mina trunk - mina-ahc: Mina AHC that was

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-01-30 Thread Rick McGuire
Alex Karasulu wrote: Kevan, Thanks for taking the time to respond. More inline ... On Jan 30, 2008 1:08 AM, Kevan Miller [EMAIL PROTECTED] wrote: ... So, as we discussed the last time, the community members that have been active in this area are Jeff Genender, Sangjin Lee, and Rick

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-01-30 Thread Jeff Genender
Rick, This was the port I did to Mina 2: http://svn.apache.org/repos/asf/geronimo/sandbox/async-http-client-mina2/ Jeff Rick McGuire wrote: Alex Karasulu wrote: Kevan, Thanks for taking the time to respond. More inline ... On Jan 30, 2008 1:08 AM, Kevan Miller [EMAIL PROTECTED] wrote:

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-01-30 Thread Rick McGuire
Jeff Genender wrote: Rick, This was the port I did to Mina 2: http://svn.apache.org/repos/asf/geronimo/sandbox/async-http-client-mina2/ Jeff, Is that the preferred version? Since that branch is in the geronimo SVN tree, do you have any objections to me directly porting and applying some

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-01-30 Thread Sangjin Lee
Yes, I am very interested in working with you guys on this. I'll work with Rick. For your information, the following is the list of JIRA issues that were submitted and resolved on the Geronimo AHC. I suspect pretty much all of them will be relevant.

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-01-30 Thread Alex Karasulu
On Jan 30, 2008 1:49 PM, Jeff Genender [EMAIL PROTECTED] wrote: Being that its in the sandbox...anything goes. ;-) However...with that said...lets see what pans out here at Mina. I would certainly consider the delta now before we get 3 diverse versions ;-) Yes the preferred version is Mina

[AsyncHttpClient] On bringing the code bases and communities together

2008-01-29 Thread Alex Karasulu
Hi, Please excuse the cross post but it's quite necessary. Furthermore people should not feel like they cannot cross post responses so please feel free. It looks like the two versions of the http client based on MINA are starting to diverge. I've noticed the other day that some of the fixes for

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-01-29 Thread Mike Heath
Alex Karasulu wrote: Hi, Please excuse the cross post but it's quite necessary. Furthermore people should not feel like they cannot cross post responses so please feel free. It looks like the two versions of the http client based on MINA are starting to diverge. I've noticed the other

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-01-29 Thread Kevan Miller
On Jan 29, 2008, at 7:28 PM, Mike Heath wrote: Alex Karasulu wrote: Hi, Please excuse the cross post but it's quite necessary. Furthermore people should not feel like they cannot cross post responses so please feel free. It looks like the two versions of the http client based on MINA

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-01-29 Thread Alex Karasulu
Kevan, Thanks for taking the time to respond. More inline ... On Jan 30, 2008 1:08 AM, Kevan Miller [EMAIL PROTECTED] wrote: ... So, as we discussed the last time, the community members that have been active in this area are Jeff Genender, Sangjin Lee, and Rick McGuire. You already know

Re: [AsyncHttpClient] On bringing the code bases and communities together

2008-01-29 Thread Trustin Lee
On Jan 30, 2008 3:44 PM, Alex Karasulu [EMAIL PROTECTED] wrote: Kevan, Thanks for taking the time to respond. More inline ... On Jan 30, 2008 1:08 AM, Kevan Miller [EMAIL PROTECTED] wrote: ... So, as we discussed the last time, the community members that have been active in this area