[GitHub] [mina-sshd] tomaswolf commented on pull request #194: [SSHD-1161] OpenSSH client certificate publickey authentication

tomaswolf commented on pull request #194: URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841716792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [mina-sshd] tomaswolf commented on pull request #194: [SSHD-1161] OpenSSH client certificate publickey authentication

tomaswolf commented on pull request #194: URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-842030945 The build failures are unrelated. There are unstable tests. Going to merge this as is. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [mina-sshd] tomaswolf commented on pull request #194: [SSHD-1161] OpenSSH client certificate publickey authentication

tomaswolf commented on pull request #194: URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841858902 Good points. I suggest we do both in follow-up changes. * Validation of the certificate type would also to happen in the server-side code (client certificate presented

[GitHub] [mina-sshd] tomaswolf commented on pull request #194: [SSHD-1161] OpenSSH client certificate publickey authentication

tomaswolf commented on pull request #194: URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841789777 Done. Take a look and if OK with you, I'd merge like that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [mina-sshd] tomaswolf commented on pull request #194: [SSHD-1161] OpenSSH client certificate publickey authentication

tomaswolf commented on pull request #194: URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841735774 > If possible could you make the commit w/ the main code changes by Alec and mention me instead? > > He did stay up pretty late to sort out the final implementation :)

[GitHub] [mina-sshd] tomaswolf commented on pull request #194: [SSHD-1161] OpenSSH client certificate publickey authentication

tomaswolf commented on pull request #194: URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841716792 This looks great. Thanks a lot! The PR now contains a lot of commits that leave intermediary stages in the repo and a lot of clean-up commits, and merging in master in the

[GitHub] [mina-sshd] tomaswolf commented on pull request #194: [SSHD-1161] OpenSSH client certificate publickey authentication

tomaswolf commented on pull request #194: URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841215391 No, not really. A profile was just the first thing that I thought of. An unsuspecting user who doesn't have docker on his machine should probably still be able to run a maven

[GitHub] [mina-sshd] tomaswolf commented on pull request #194: [SSHD-1161] OpenSSH client certificate publickey authentication

tomaswolf commented on pull request #194: URL: https://github.com/apache/mina-sshd/pull/194#issuecomment-841167902 Looks like the windows VMs used in the test builds don't have docker? We might have to make this test run conditionally on non-Windows only. Maybe with a profile that we'd