Hi,
I have opened a PR for adding new content to 1.2.1 release notes:
https://github.com/apache/incubator-mxnet/pull/11478
Please help review. Once this PR is approved I will be cutting the release.
Thanks,
Anirudh
On Tue, Jun 26, 2018 at 7:10 PM, Chris Olivier
wrote:
> +1
>
> On Tue, Jun
+1
On Tue, Jun 26, 2018 at 5:50 PM Anirudh wrote:
> Hi all,
>
> The current warning message for save_params: "save_params is deprecated,
> use save_parameters instead" is misleading
> for users who may use the API to load into SymbolBlock. To make it clearer
> for all users, a better warning
Hi all,
The current warning message for save_params: "save_params is deprecated,
use save_parameters instead" is misleading
for users who may use the API to load into SymbolBlock. To make it clearer
for all users, a better warning message is to include alternative to
save_params and reference to
Detailed documents should help, but the current warning message that
"save_params is deprecated, use save_parameters instead" is not sufficient
enough.
Some details about the API changes:
1. v1.2 changed the implementation of "save_params", which is explained in
the release note. The main
Wouldn’t this break users who are on 1.2.0 and used our API correctly? Why do
we have to revert load_params, given that it’s backward compatible?
-sz
> On Jun 25, 2018, at 6:30 PM, Anirudh wrote:
>
> Hi,
>
> 1.2.1 (load_params) is backward compatible with 1.1.0 not with 1.2.0.
> It does not
save_parameters didn't exist in 1.2.0 so its addition usually isn't
supposed to happen in a patch release if we stick to semantic versioning. I
couldn't find a discussion on this exception. Did it happen?
Would people who used 1.2.0 to save models be able to load parameters in
1.2.1 using the
Hi Mu,
The warining currently printed is "save_params is deprecated. Please use
save_parameters."
Isn't this similar to what you are suggesting ?
Anirudh
On Mon, Jun 25, 2018 at 3:47 PM, Mu Li wrote:
> v1.2.1 will print a deprecating warning message when calling
> save_params. We should tell
v1.2.1 will print a deprecating warning message when calling
save_params. We should tell users clearly to replace "save_params" with
"save_parameters" or something else.
On Mon, Jun 18, 2018 at 6:52 PM, Anirudh wrote:
> Hi,
>
> This is the vote to release Apache MXNet (incubating) version
Hi all,
Thanks a lot for checking the release. This vote has passed with:
6 +1s
Binding:
Sandeep
Haibin
Indhu
Non Binding:
Carin
Pedro
Lai
Anirudh
On Fri, Jun 22, 2018 at 8:00 AM, sandeep krishnamurthy <
sandeep.krishn...@gmail.com> wrote:
> +1
>
> Lai (https://github.com/roywei) and
Hi all,
Thanks for checking the release. We need one more binding +1. I would
request committers to help out here so that we can get the vote started on
general@.
Anirudh
On Thu, Jun 21, 2018 at 3:06 PM, Pedro Larroy
wrote:
> I already changed my vote to +1 I don't think this a big issue,
I already changed my vote to +1 I don't think this a big issue, just a
pixel difference of 1 when loading an image.
On Thu, Jun 21, 2018 at 2:20 PM Marco de Abreu
wrote:
> We had 868 successful runs and no failures for that test so far, Pedro.
>
> On Thu, Jun 21, 2018 at 11:17 PM Pedro
+1 I tested the Scala jars (through the clojure package) on staging on for
the various platforms and they look good.
On Thu, Jun 21, 2018 at 5:20 PM, Anirudh wrote:
> That looks like a flaky test because of atol being too small. please force
> rtol and atol values and see if you are still able
That looks like a flaky test because of atol being too small. please force
rtol and atol values and see if you are still able to reproduce.
On Thu, Jun 21, 2018 at 2:16 PM, Pedro Larroy
wrote:
> Observed just one failure in OSX in test_imdecode:
>
>
>
We had 868 successful runs and no failures for that test so far, Pedro.
On Thu, Jun 21, 2018 at 11:17 PM Pedro Larroy
wrote:
> Observed just one failure in OSX in test_imdecode:
>
>
> ==
> FAIL: test_imdecode
Observed just one failure in OSX in test_imdecode:
==
FAIL: test_imdecode (test_image.TestImage)
--
Traceback (most recent call last):
File
+1
Built from source with CUDA on Ubuntu.
Ran example/gluon/word_language_model/train.py
Best,
Haibin
On Thu, Jun 21, 2018 at 11:08 AM, Anirudh wrote:
> Hi Pedro,
>
> I think you raised this issue in 1.2.0 release here:
> https://lists.apache.org/thread.html/ddc088a21aac179144350ea97353a7
>
I guess that's why I disable openmp for development, so given that it's a
known issue an the unit tests passed on osx I change my vote accordingly
to +1 not to block the release.
On Thu, Jun 21, 2018 at 1:52 PM Anirudh wrote:
> Hi Pedro,
>
> I have seen this with the DEBUG flag on, not without
Hi Pedro,
I have seen this with the DEBUG flag on, not without it.
I opened an issue here some time back:
https://github.com/apache/incubator-mxnet/issues/10856
Anirudh
On Thu, Jun 21, 2018 at 12:16 PM, Pedro Larroy wrote:
> Got it. Sorry to bring this up, and the deja-vu :-) . Makes sense
Got it. Sorry to bring this up, and the deja-vu :-) . Makes sense not to
consider this issue again as you suggested, thanks.
I compiled in OSX and run unit tests. Also run SSD detector and is working
fine.
Compiled in ubuntu / cpu / debug with openmp. And run unit tests. I have
the following
Hi Pedro,
I think you raised this issue in 1.2.0 release here:
https://lists.apache.org/thread.html/ddc088a21aac179144350ea97353a7ea885b2765ccb98db08a03ba2d@%3Cdev.mxnet.apache.org%3E
.
I actually forgot about this issue during this release. Having said that, I
think since this works with make
I think I have fixed this before, I will check if the patch didn't make it
to the branch.
On Thu, Jun 21, 2018 at 10:24 AM Pedro Larroy
wrote:
> -1 I can't compile:
>
> 3rdparty/dmlc-core/libdmlc.a(io.cc.o): In function
> `std::thread::thread::Init(std::function
+1
On Mon, Jun 18, 2018, 6:52 PM Anirudh wrote:
> Hi,
>
> This is the vote to release Apache MXNet (incubating) version 1.2.1. Voting
> will start now and close Thursday June 21st 7:00 PM PDT.
>
> Link to release candidate 1.2.1.rc0:
>
>
22 matches
Mail list logo
