Hi Marco,
Currently all Scala examples I have changed contains test coverage on CI (in
the example/src/test/). It's been temporarily disabled because of the memory
leaks.
I would also like to raise a discussion on a general standard for testing
examples, this is what Scala side doing:
1. For
Hi Qing,
thanks a lot for your efforts around the Scala examples and to assist us
getting the Scala API to a broader user base! This is a great user-facing
approach!
The following might not be in the current course of how we handle examples
in Python, but let me elaborate: I have seen a lot of
Agree to make incremental improvements. As long as the changes do not
change the current states of memory leak, but improve the documents
and demonstrate the way to use type-safe apis, I think it is fair to
merge into v1.3.
On Wed, Jul 11, 2018 at 4:43 PM Naveen Swamy wrote:
>
> Qing, its great
Qing, its great that you are working on improving the Scala Examples with
documentation and tests.
Ideally, we shouldn't have any memory leaks..it erodes trust with our
users, however I understand it can take significant time and debugging
effort to resolve them. Given that these leaks already
