Re: ReducedHTMLParser broken

2005-10-31 Thread Martin Marinschek
Hi Simon, can I ask you again to open a jira-issue? Maybe you could also write up a unit test which shows that the ReducedHtmlParser is broken? Alternatively, just send in a very reduced HTML page where the problem occurs. Thanks a lot, regards, Martin On 10/31/05, Simon Kitching [EMAIL

RE: [jira] Commented: (MYFACES-739) Null Pointer Exception

2005-10-31 Thread Jensen, Darren W. \(Corporate\)
I do not call getDataModel directly. I am detaching the HtmlDataTable in a Component ProcessAction method. When the ProcessAction method call completes, an HTMLDataTableHack method higher up in the call stack will call the getDataModel as it is returning to process the next event in the

Resetting state before encoding of dataTable

2005-10-31 Thread Martin Marinschek
Hi *, and especially Mathias, I have changed the following code segment _initialDescendantComponentState = null; if (_isValidChilds !hasErrorMessages(context)) { //Refresh DataModel for rendering: _dataModelMap.clear();

[jira] Reopened: (MYFACES-701) Allow custom theme.js file without duplicating jscookmenu.js

2005-10-31 Thread Martin Marinschek (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-701?page=all ] Martin Marinschek reopened MYFACES-701: --- Assign To: (was: Martin Marinschek) You are right - this is not fully fixed. Allow custom theme.js file without duplicating

[jira] Updated: (MYFACES-768) ReducedHTMLParser issues

2005-10-31 Thread Simon Kitching (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-768?page=all ] Simon Kitching updated MYFACES-768: --- Attachment: ReducedHTMLParser.java New implementation of ReducedHTMLParser for consideration ReducedHTMLParser issues

[jira] Commented: (MYFACES-739) Null Pointer Exception

2005-10-31 Thread Martin Marinschek (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-739?page=comments#action_12356411 ] Martin Marinschek commented on MYFACES-739: --- mail by Darren Jensen: I do not call getDataModel directly. I am detaching the HtmlDataTable in a Component

[jira] Created: (MYFACES-768) ReducedHTMLParser issues

2005-10-31 Thread Simon Kitching (JIRA)
ReducedHTMLParser issues Key: MYFACES-768 URL: http://issues.apache.org/jira/browse/MYFACES-768 Project: MyFaces Type: Bug Reporter: Simon Kitching Attachments: ReducedHTMLParser.java ReducedHTMLParser (used by AddResource class)

[jira] Updated: (MYFACES-768) ReducedHTMLParser issues

2005-10-31 Thread Simon Kitching (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-768?page=all ] Simon Kitching updated MYFACES-768: --- Attachment: ReducedHTMLParserTest.java Unit tests for ReducedHTMLParser ReducedHTMLParser issues Key: MYFACES-768

[jira] Commented: (MYFACES-765) t:inputCalendar/ stops working

2005-10-31 Thread Bruno Aranda (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-765?page=comments#action_12356401 ] Bruno Aranda commented on MYFACES-765: -- I've just given it a quick look. It seems that there is a problem with the current day somewhere... The links for the month

[jira] Commented: (MYFACES-701) Allow custom theme.js file without duplicating jscookmenu.js

2005-10-31 Thread Neal Haggard (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-701?page=comments#action_12356417 ] Neal Haggard commented on MYFACES-701: -- As I stated in my fix, it would be nice if this was a possibility. While having three separate variables allows much

[jira] Updated: (MYFACES-766) documention for javascript listener

2005-10-31 Thread Sharath Reddy (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-766?page=all ] Sharath Reddy updated MYFACES-766: -- Attachment: jslistener documention for javascript listener --- Key: MYFACES-766 URL:

[jira] Created: (MYFACES-767) Programming error in HtmlTextareaRenderer

2005-10-31 Thread Ricardo Tercero Lozano (JIRA)
Programming error in HtmlTextareaRenderer - Key: MYFACES-767 URL: http://issues.apache.org/jira/browse/MYFACES-767 Project: MyFaces Type: Bug Components: Tomahawk Versions: 1.1.0 Reporter: Ricardo Tercero

[jira] Commented: (MYFACES-760) Tree2 setLeaf(false) error

2005-10-31 Thread Andrew Efremov (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-760?page=comments#action_12356405 ] Andrew Efremov commented on MYFACES-760: I checked my application. It return a correct Tree with correct isLiaf() method. Node [0:0] have isLeaf() == false But I'm

[jira] Created: (MYFACES-766) documention for javascript listener

2005-10-31 Thread Sharath Reddy (JIRA)
documention for javascript listener --- Key: MYFACES-766 URL: http://issues.apache.org/jira/browse/MYFACES-766 Project: MyFaces Type: Improvement Components: Tomahawk Versions: Nightly Environment: N.A. Reporter:

[jira] Commented: (MYFACES-765) t:inputCalendar/ stops working

2005-10-31 Thread Martin Marinschek (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-765?page=comments#action_12356391 ] Martin Marinschek commented on MYFACES-765: --- The simple example with calendar doesn't work anymore as well. t:inputCalendar/ stops working

[jira] Reopened: (MYFACES-627) valueChangeListener not called for elements in HtmlDataTable

2005-10-31 Thread Mathias Broekelmann (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-627?page=all ] Mathias Broekelmann reopened MYFACES-627: - We now have a client id with double _0_0, _1_1 and so on. To solve this we have to copy the implementation from

[jira] Closed: (MYFACES-627) valueChangeListener not called for elements in HtmlDataTable

2005-10-31 Thread Mathias Broekelmann (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-627?page=all ] Mathias Broekelmann closed MYFACES-627: --- Resolution: Won't Fix This can not be fixed by myfaces. file an issue for the sun ri. valueChangeListener not called for elements in

[jira] Commented: (MYFACES-760) Tree2 setLeaf(false) error

2005-10-31 Thread Andrew Efremov (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-760?page=comments#action_12356402 ] Andrew Efremov commented on MYFACES-760: This is my recursive function for creating tree public TreeNodeBase WayRoundTree(Classifier node){ TreeNodeBase

[jira] Closed: (MYFACES-765) t:inputCalendar/ stops working

2005-10-31 Thread Martin Marinschek (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-765?page=all ] Martin Marinschek closed MYFACES-765: - Fix Version: Nightly Resolution: Fixed Thanks Boris - should already be fixed. please test from svn head. regards, Martin

Re: Resetting state before encoding of dataTable

2005-10-31 Thread Mathias Brökelmann
Have talked about this in our googletalk? I thought it was about the rowstate between request. This solution might not work in every case. The spec says to discard any row state before rendering the table if no errors are on the page. IMO clearing the rowstate and the datamodel must be done

[jira] Commented: (MYFACES-765) t:inputCalendar/ stops working

2005-10-31 Thread Bruno Aranda (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-765?page=comments#action_12356439 ] Bruno Aranda commented on MYFACES-765: -- I added a fix for the shifMonth thing. On those dates that not all the months have (eg, 31th) when the button to shift month

[jira] Created: (MYFACES-769) configurable IDs used for rendering

2005-10-31 Thread Dave Brondsema (JIRA)
configurable IDs used for rendering --- Key: MYFACES-769 URL: http://issues.apache.org/jira/browse/MYFACES-769 Project: MyFaces Type: Improvement Reporter: Dave Brondsema If the same code is used ot generated a component tree

RE: [jira] Commented: (MYFACES-738) Exceptions thrown during processing of EL statements are not displayed with the underlying cause, and there is no log message.

2005-10-31 Thread Andrew Harris
Yes, I think they are, but the issue is that after a couple of catch throws, the cause becomes the previous catcher rather than the underlying reason for the failure. So there is originally a throwable catch, that is caught and an EvaluationException thrown, which is caught and another

Re: svn commit: r329877 - /myfaces/tomahawk/trunk/src/java/org/apache/myfaces/component/html/util/AddResource.java

2005-10-31 Thread Martin Marinschek
Mathias, I did that cause my brain stopped working for half an hour ;) regards, Martin On 10/31/05, Mathias Brökelmann [EMAIL PROTECTED] wrote: Martin can you tell me why did you change this? The ResourceLoader was intentionally introduced to enable custom components which are developed by

[jira] Updated: (MYFACES-768) ReducedHTMLParser issues

2005-10-31 Thread Simon Kitching (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-768?page=all ] Simon Kitching updated MYFACES-768: --- Attachment: ReducedHTMLParser.java ReducedHTMLParserTest.java Ok, these versions of the files are 100% complete and bug-free as far as I

[jira] Commented: (MYFACES-768) ReducedHTMLParser issues

2005-10-31 Thread Martin Marinschek (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-768?page=comments#action_12356450 ] Martin Marinschek commented on MYFACES-768: --- Very well done. Thanks for your efforts. regards, Martin ReducedHTMLParser issues

[jira] Closed: (MYFACES-768) ReducedHTMLParser issues

2005-10-31 Thread Martin Marinschek (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-768?page=all ] Martin Marinschek closed MYFACES-768: - Fix Version: Nightly Resolution: Fixed Assign To: Martin Marinschek ReducedHTMLParser issues

Re: ReducedHTMLParser issues

2005-10-31 Thread Simon Kitching
Hi Martin, Thanks for that! As always, an issue is found as soon as a commit is made:-). There is a problem parsing !DOCTYPE. I've got that fixed already (and of course an updated unit test so it can't happen again), but would like to test a little more. I will post a patch very soon.

Re: ReducedHTMLParser issues

2005-10-31 Thread Martin Marinschek
Don't stress yourself - it's just the nightly build, so not to big of a problem. regards, Martin On 10/31/05, Simon Kitching [EMAIL PROTECTED] wrote: Hi Martin, Thanks for that! As always, an issue is found as soon as a commit is made:-). There is a problem parsing !DOCTYPE. I've got

Re: ReducedHTMLParser issues

2005-10-31 Thread Simon Kitching
Martin Marinschek wrote: Don't stress yourself - it's just the nightly build, so not to big of a problem. Thanks, but it's hopefully done anyway. changes: * Handle DOCTYPE and Processing Instruction commands in input HTML * Track line# of input for error messages * Remove some debugging

HtmlCollapsiblePanel

2005-10-31 Thread Simon Kitching
Hi, I've started getting problems with HtmlCollapsiblePanel in the SVN TRUNK code. 13:15:11,509 ERROR [[jsp]] Servlet.service() for servlet jsp threw exception java.lang.NoSuchMethodError: org.apache.myfaces.custom.collapsiblepanel.HtmlCollapsiblePanelTag.doAfterBody()I at

[jira] Commented: (MYFACES-707) Define renderer method getChildren(UIComponent) instead of calling component.getChildren directly

2005-10-31 Thread Simon Kitching (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-707?page=comments#action_12356465 ] Simon Kitching commented on MYFACES-707: Is there any chance someone could check commit the attached patches soon? I've got a custom table renderer that outputs

[jira] Commented: (MYFACES-765) t:inputCalendar/ stops working

2005-10-31 Thread Boris Kovalenko (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-765?page=comments#action_12356466 ] Boris Kovalenko commented on MYFACES-765: - Thanks, Bruno! But what about duplicate ids for now? There was no problems with nightly of 18.10.2005 for example. Should

[jira] Commented: (MYFACES-765) t:inputCalendar/ stops working

2005-10-31 Thread Simon Kitching (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-765?page=comments#action_12356468 ] Simon Kitching commented on MYFACES-765: The exception is due to some stricter error-checking implemented recently in the _ComponentChildrenList class. No component

[jira] Commented: (MYFACES-760) Tree2 setLeaf(false) error

2005-10-31 Thread Andrew Efremov (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-760?page=comments#action_12356478 ] Andrew Efremov commented on MYFACES-760: Thanks Jon, but I set Leaf == true only to example. I don't need to set it. I want to create Tree and never change it in

[jira] Commented: (MYFACES-760) Tree2 setLeaf(false) error

2005-10-31 Thread Andrew Efremov (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-760?page=comments#action_12356479 ] Andrew Efremov commented on MYFACES-760: By the way node [0:0] in my previous post is considered as notLeaf according to my logs. But somehow later it became it is