[GitHub] JoeHut opened a new pull request #4: Readme.md: Link OS-specific documentation

[GitBox]

JoeHut opened a new pull request #4: Readme.md: Link OS-specific documentation
URL: https://github.com/apache/mynewt-mcumgr/pull/4
 
 
   Link the names of the OS-specific documentation for Mynewt and Zephyr in
   the Readme files.
   
   Signed-off-by: Johannes Hutter 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Olivier-ProGlove opened a new pull request #5: cmd: img_mgmt: Add an extra byte to the 'hash' buffer

[GitBox]

Olivier-ProGlove opened a new pull request #5: cmd: img_mgmt: Add an extra byte 
to the 'hash' buffer
URL: https://github.com/apache/mynewt-mcumgr/pull/5
 
 
   _cbor_value_copy_string() (invoked by cbor_read_object()) adds a
   null-character to the byte string.
   Not adding this additional byte to the buffer obviously corrupts the memory.
   
   Signed-off-by: Olivier Martin 
   
   cc: @carlescufi, @nvlsianpu 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi commented on issue #5: cmd: img_mgmt: Add an extra byte to the 'hash' buffer

[GitBox]

carlescufi commented on issue #5: cmd: img_mgmt: Add an extra byte to the 
'hash' buffer
URL: https://github.com/apache/mynewt-mcumgr/pull/5#issuecomment-401405021
 
 
   @ccollins476ad can you please review? thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] calumljohnston opened a new issue #1: Error: errno 0 when running cross-compiled executable on Yocto ARM system

[GitBox]

calumljohnston opened a new issue #1: Error: errno 0 when running 
cross-compiled executable on Yocto ARM system
URL: https://github.com/apache/mynewt-mcumgr-cli/issues/1
 
 
   When trying to run the command:
   `root@02c00081527f2ae6:~# ./mcumgr -c serial1 image list`
   
   The only output is the line:
   `Error: errno 0`
   
   The program itself runs fine when browsing help, setting up `serial1` etc.
   
   Running:
   `root@02c00081527f2ae6:~# ./mcumgr -c serial1 image list -l DEBUG`
   
   Outputs:
   ```DEBU[2018-06-25 14:31:26.072] Using connection profile: name=serial1 
type=serial connstring=dev=/dev/ttyS1 
   DEBU[2018-06-25 14:31:26.074] goroutine 1 [running]:
   
mynewt.apache.org/newtmgr/vendor/mynewt.apache.org/newt/util.NewNewtError(0x10d0e3c0,
 0x7, 0x7)

/home/calum/go/src/mynewt.apache.org/newtmgr/vendor/mynewt.apache.org/newt/util/util.go:77
 +0xc4
   
mynewt.apache.org/newtmgr/vendor/mynewt.apache.org/newt/util.ChildNewtError(0x66e678,
 0x93a448, 0x93a448)

/home/calum/go/src/mynewt.apache.org/newtmgr/vendor/mynewt.apache.org/newt/util/util.go:103
 +0x74
   mynewt.apache.org/newtmgr/newtmgr/cli.GetXport(0x0, 0x0, 0x0, 0x0)
/home/calum/go/src/mynewt.apache.org/newtmgr/newtmgr/cli/common.go:161 
+0x228
   mynewt.apache.org/newtmgr/newtmgr/cli.GetSesn(0x0, 0x0, 0x10c000e0, 
0x10c4e460)
/home/calum/go/src/mynewt.apache.org/newtmgr/newtmgr/cli/common.go:318 
+0x198
   mynewt.apache.org/newtmgr/newtmgr/cli.imageStateListCmd(0x10d50900, 
0x10d08420, 0x0, 0x4)
/home/calum/go/src/mynewt.apache.org/newtmgr/newtmgr/cli/image.go:90 
+0x18
   
mynewt.apache.org/newtmgr/vendor/github.com/spf13/cobra.(*Command).execute(0x10d50900,
 0x10d08340, 0x4, 0x4, 0x10d50900, 0x10d08340)

/home/calum/go/src/mynewt.apache.org/newtmgr/vendor/github.com/spf13/cobra/command.go:654
 +0x1f4
   
mynewt.apache.org/newtmgr/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x10d5,
 0x10c3df88, 0x4, 0x10d0c030)

/home/calum/go/src/mynewt.apache.org/newtmgr/vendor/github.com/spf13/cobra/command.go:729
 +0x1ec
   
mynewt.apache.org/newtmgr/vendor/github.com/spf13/cobra.(*Command).Execute(0x10d5,
 0x620f5c, 0x10c14a00)

/home/calum/go/src/mynewt.apache.org/newtmgr/vendor/github.com/spf13/cobra/command.go:688
 +0x1c
   main.main()

/home/calum/go/src/github.com/apache/mynewt-mcumgr-cli/mcumgr/mcumgr.go:94 +0xd4
   
   goroutine 5 [syscall]:
   os/signal.signal_recv(0x0)
/usr/lib/go-1.10/src/runtime/sigqueue.go:139 +0x130
   os/signal.loop()
/usr/lib/go-1.10/src/os/signal/signal_unix.go:22 +0x14
   created by os/signal.init.0
/usr/lib/go-1.10/src/os/signal/signal_unix.go:28 +0x30
   
   goroutine 7 [select, locked to thread]:
   runtime.gopark(0x6220ac, 0x0, 0x5f9174, 0x6, 0x18, 0x1)
/usr/lib/go-1.10/src/runtime/proc.go:291 +0xfc
   runtime.selectgo(0x10c2a7a0, 0x10c6c240)
/usr/lib/go-1.10/src/runtime/select.go:392 +0xe98
   runtime.ensureSigM.func1()
/usr/lib/go-1.10/src/runtime/signal_unix.go:549 +0x1c0
   runtime.goexit()
/usr/lib/go-1.10/src/runtime/asm_arm.s:1015 +0x4
   
   goroutine 17 [chan receive]:
   main.main.func1(0x10c14a00)

/home/calum/go/src/github.com/apache/mynewt-mcumgr-cli/mcumgr/mcumgr.go:82 +0x30
   created by main.main

/home/calum/go/src/github.com/apache/mynewt-mcumgr-cli/mcumgr/mcumgr.go:80 +0xcc

   Error: errno 0
   ```
   Not hugely knowledgable in go so may be doing something wrong here but help 
would be appreciated.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ccollins476ad commented on issue #5: cmd: img_mgmt: Add an extra byte to the 'hash' buffer

[GitBox]

ccollins476ad commented on issue #5: cmd: img_mgmt: Add an extra byte to the 
'hash' buffer
URL: https://github.com/apache/mynewt-mcumgr/pull/5#issuecomment-401909191
 
 
   Thanks, Olivier.  This looks like a good workaround for the buffer overrun.
   
   The real bug seems to be in the TinyCbor implementation.  From 
`_cbor_value_copy_string`'s heading:
   ```
* On success, this function sets the number of bytes copied to \c{*buflen}. 
If
* the buffer is large enough, this function will insert a null byte after 
the
* last copied byte, to facilitate manipulation of null-terminated strings.
* That byte is not included in the returned value of \c{*buflen}.
   ```
   
   However, this particular bug is not in the official TinyCbor source 
(https://github.com/intel/tinycbor), and it is also not in the Mynewt fork.  I 
guess this bug must be an artifact from the original merge to Zephyr.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ccollins476ad closed pull request #5: cmd: img_mgmt: Add an extra byte to the 'hash' buffer

[GitBox]

ccollins476ad closed pull request #5: cmd: img_mgmt: Add an extra byte to the 
'hash' buffer
URL: https://github.com/apache/mynewt-mcumgr/pull/5
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/cmd/img_mgmt/src/img_mgmt_state.c 
b/cmd/img_mgmt/src/img_mgmt_state.c
index bca3aed..299169b 100644
--- a/cmd/img_mgmt/src/img_mgmt_state.c
+++ b/cmd/img_mgmt/src/img_mgmt_state.c
@@ -251,7 +251,11 @@ img_mgmt_state_read(struct mgmt_ctxt *ctxt)
 int
 img_mgmt_state_write(struct mgmt_ctxt *ctxt)
 {
-uint8_t hash[IMAGE_HASH_LEN];
+/*
+ * We add 1 to the 32-byte hash buffer as _cbor_value_copy_string() adds
+ * a null character at the end of the buffer.
+ */
+uint8_t hash[IMAGE_HASH_LEN + 1];
 size_t hash_len;
 bool confirm;
 int slot;


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi commented on issue #5: cmd: img_mgmt: Add an extra byte to the 'hash' buffer

[GitBox]

carlescufi commented on issue #5: cmd: img_mgmt: Add an extra byte to the 
'hash' buffer
URL: https://github.com/apache/mynewt-mcumgr/pull/5#issuecomment-401910216
 
 
   @ccollins476ad I don’t have merge rights on this repo. Mind merging this 
yourself? Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi commented on issue #5: cmd: img_mgmt: Add an extra byte to the 'hash' buffer

[GitBox]

carlescufi commented on issue #5: cmd: img_mgmt: Add an extra byte to the 
'hash' buffer
URL: https://github.com/apache/mynewt-mcumgr/pull/5#issuecomment-401910386
 
 
   Cc @mariuszskamra @sjanc 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi commented on issue #4: Readme.md: Link OS-specific documentation

[GitBox]

carlescufi commented on issue #4: Readme.md: Link OS-specific documentation
URL: https://github.com/apache/mynewt-mcumgr/pull/4#issuecomment-402069439
 
 
   CC @ccollins476ad. This looks good, can you merge this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi commented on issue #3: Unable to compile sample on zephyr 1.11

[GitBox]

carlescufi commented on issue #3: Unable to compile sample on zephyr 1.11
URL: https://github.com/apache/mynewt-mcumgr/issues/3#issuecomment-402069628
 
 
   @ccollins476ad this seems to be obsolete, mind closing it?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi opened a new issue #6: BLE reassembly support

[GitBox]

carlescufi opened a new issue #6: BLE reassembly support
URL: https://github.com/apache/mynewt-mcumgr/issues/6
 
 
   The BLE transport supports segmentation (i.e. splitting SMP reponses into 
multiple ATT_MTU-sized notifications) but not reassembly (i.e. reassembling SMP 
requests that have been split across multiple ATT_MTU-sized Write Commands).
   
   CC @ccollins476ad @nvlsianpu @philips77 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi commented on issue #2: Image upload broken on Windows

[GitBox]

carlescufi commented on issue #2: Image upload broken on Windows
URL: https://github.com/apache/mynewt-mcumgr-cli/issues/2#issuecomment-402132372
 
 
   I wonder what `Error 3` means?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi commented on issue #2: Image upload broken on Windows

[GitBox]

carlescufi commented on issue #2: Image upload broken on Windows
URL: https://github.com/apache/mynewt-mcumgr-cli/issues/2#issuecomment-402132221
 
 
   CC @ccollins476ad @utzig @sjanc @lemrey


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi opened a new issue #2: Image upload broken on Windows

[GitBox]

carlescufi opened a new issue #2: Image upload broken on Windows
URL: https://github.com/apache/mynewt-mcumgr-cli/issues/2
 
 
   Running `mcumgr` on Windows with the following settings:
   
   ```
   C:\Users\Carles\go\bin>mcumgr conn show com3
   Connection profiles:
 com3: type=serial, connstring='dev=COM3,baud=115200'
   ```
   
   Every time I try to send an image to MCUboot in recovery mode:
   
   ```
   C:\Users\Carles\go\bin>mcumgr image upload 
c:\Users\Carles\shared\signed_smp_svr_12_06_2018_8h30m.bin -c com3 -e
0 / 110780 
[---]
   0.00%Error: 3
   ```
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi commented on issue #1: Error: errno 0 when running cross-compiled executable on Yocto ARM system

[GitBox]

carlescufi commented on issue #1: Error: errno 0 when running cross-compiled 
executable on Yocto ARM system
URL: https://github.com/apache/mynewt-mcumgr-cli/issues/1#issuecomment-402131783
 
 
   CC @ccollins476ad @utzig 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi commented on issue #2: Image upload broken on Windows

[GitBox]

carlescufi commented on issue #2: Image upload broken on Windows
URL: https://github.com/apache/mynewt-mcumgr-cli/issues/2#issuecomment-402137495
 
 
   @utzig thanks! I now realize I get this error on Linux as well after 
updating `mcumgr`, so this is not a Windows issue. Here's the log:
   
   [log.txt](https://github.com/apache/mynewt-mcumgr-cli/files/2159232/log.txt)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi commented on issue #2: Image upload broken on Windows

[GitBox]

carlescufi commented on issue #2: Image upload broken on Windows
URL: https://github.com/apache/mynewt-mcumgr-cli/issues/2#issuecomment-402133202
 
 
   @ccollins476ad I would report the exact mcumgr version, but it simply shows:
   
   ```
   C:\Users\Carles\go\bin>mcumgr version
   mcumgr 0.0.0-dev
   ```
   
   I ran ` go get -u github.com/apache/mynewt-mcumgr-cli/mcumgr` before testing


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi commented on issue #5: cmd: img_mgmt: Add an extra byte to the 'hash' buffer

[GitBox]

carlescufi commented on issue #5: cmd: img_mgmt: Add an extra byte to the 
'hash' buffer
URL: https://github.com/apache/mynewt-mcumgr/pull/5#issuecomment-402118844
 
 
   @Olivier-ProGlove @JoeHut will you send a PR to Zephyr to update with this 
version?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi commented on issue #6: BLE reassembly support

[GitBox]

carlescufi commented on issue #6: BLE reassembly support
URL: https://github.com/apache/mynewt-mcumgr/issues/6#issuecomment-402130885
 
 
   Note that this is required for interaction with Android phones version 5 and 
below, since they don't support big ATT_MTUs (I am told by @philips77)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] utzig closed pull request #4: Readme.md: Link OS-specific documentation

[GitBox]

utzig closed pull request #4: Readme.md: Link OS-specific documentation
URL: https://github.com/apache/mynewt-mcumgr/pull/4
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index 1f202b3..3aa6df9 100644
--- a/README.md
+++ b/README.md
@@ -16,8 +16,8 @@ both the Apache Mynewt and Zephyr operating systems.
 For tips on using mcumgr with your particular OS, see the appropriate file from
 the list below:
 
-* README-mynewt.md
-* README-zephyr.md
+* [Mynewt](README-mynewt.md)
+* [Zephyr](README-zephyr.md)
 
 ## Dependencies
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] JoeHut commented on issue #5: cmd: img_mgmt: Add an extra byte to the 'hash' buffer

[GitBox]

JoeHut commented on issue #5: cmd: img_mgmt: Add an extra byte to the 'hash' 
buffer
URL: https://github.com/apache/mynewt-mcumgr/pull/5#issuecomment-402156773
 
 
   @carlescufi Sure.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi opened a new pull request #7: Upstream of Zephyr downstream modifications

[GitBox]

carlescufi opened a new pull request #7: Upstream of Zephyr downstream 
modifications
URL: https://github.com/apache/mynewt-mcumgr/pull/7
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi commented on issue #7: Upstream of Zephyr downstream modifications

[GitBox]

carlescufi commented on issue #7: Upstream of Zephyr downstream modifications
URL: https://github.com/apache/mynewt-mcumgr/pull/7#issuecomment-402194450
 
 
   CC @utzig @ccollins476ad @JoeHut 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] turon opened a new pull request #4: [linux] initial port and osal additions.

[GitBox]

turon opened a new pull request #4: [linux] initial port and osal additions.
URL: https://github.com/apache/mynewt-nimble/pull/4
 
 
   - Created linux port of os_task, os_sem, os_mutex, os_callout, os_eventq, 
etc.
   - Added unit tests for osal.
   - Mods to support pointer alignment on 64-bit architectures.
   - Fixes to ble_hci_sock to support linux port
   - Fallback to BLE 4.2 or 4.0 controllers when 5.0 features not available.
   
   Tested advertising, scan response, connections and GATT database operations.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] turon closed pull request #2: Revert incomplete 64-bit mempool support.

[GitBox]

turon closed pull request #2: Revert incomplete 64-bit mempool support.
URL: https://github.com/apache/mynewt-nimble/pull/2
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/porting/common/src/os/os_mempool.c 
b/porting/common/src/os/os_mempool.c
index 55a8f123..65e4f615 100644
--- a/porting/common/src/os/os_mempool.c
+++ b/porting/common/src/os/os_mempool.c
@@ -102,7 +102,7 @@ os_mempool_init(struct os_mempool *mp, int blocks, int 
block_size,
 /* Blocks need to be sized properly and memory buffer should be
  * aligned
  */
-if (((uintptr_t)membuf & (OS_ALIGNMENT - 1)) != 0) {
+if (((uint32_t)membuf & (OS_ALIGNMENT - 1)) != 0) {
 return OS_MEM_NOT_ALIGNED;
 }
 }
@@ -113,7 +113,7 @@ os_mempool_init(struct os_mempool *mp, int blocks, int 
block_size,
 mp->mp_num_free = blocks;
 mp->mp_min_free = blocks;
 mp->mp_num_blocks = blocks;
-mp->mp_membuf_addr = (uintptr_t)membuf;
+mp->mp_membuf_addr = (uint32_t)membuf;
 mp->name = name;
 os_mempool_poison(membuf, true_block_size);
 SLIST_FIRST(mp) = membuf;
@@ -175,24 +175,24 @@ os_mempool_is_sane(const struct os_mempool *mp)
 int
 os_memblock_from(const struct os_mempool *mp, const void *block_addr)
 {
-uint32_t  true_block_size;
-uintptr_t baddr_ptr;
-uint32_t  end;
+uint32_t true_block_size;
+uint32_t baddr32;
+uint32_t end;
 
-_Static_assert(sizeof block_addr == sizeof baddr_ptr,
+_Static_assert(sizeof block_addr == sizeof baddr32,
"Pointer to void must be 32-bits.");
 
-baddr_ptr = (uintptr_t)block_addr;
+baddr32 = (uint32_t)block_addr;
 true_block_size = OS_MEMPOOL_TRUE_BLOCK_SIZE(mp);
 end = mp->mp_membuf_addr + (mp->mp_num_blocks * true_block_size);
 
 /* Check that the block is in the memory buffer range. */
-if ((baddr_ptr < mp->mp_membuf_addr) || (baddr_ptr >= end)) {
+if ((baddr32 < mp->mp_membuf_addr) || (baddr32 >= end)) {
 return 0;
 }
 
 /* All freed blocks should be on true block size boundaries! */
-if (((baddr_ptr - mp->mp_membuf_addr) % true_block_size) != 0) {
+if (((baddr32 - mp->mp_membuf_addr) % true_block_size) != 0) {
 return 0;
 }
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vrahane closed pull request #1: Readme.md: Fix bad links in file README.md

[GitBox]

vrahane closed pull request #1: Readme.md: Fix bad links in file README.md
URL: https://github.com/apache/mynewt-mcumgr/pull/1
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index 4726883..cad3514 100644
--- a/README.md
+++ b/README.md
@@ -124,12 +124,12 @@ Information and documentation for mcumgr is stored within 
the source.
 
 For more information in the source, here are some pointers:
 
-- [cborattr](https://github.com/apache/mcumgr/tree/master/cborattr): Used for 
parsing incoming mcumgr requests.  Destructures mcumgr packets and populates 
corresponding field variables.
-- [cmd](https://github.com/apache/mcumgr/tree/master/cmd): Built-in command 
handlers for the core mcumgr commands.
-- [ext](https://github.com/apache/mcumgr/tree/master/ext): Third-party 
libraries that mcumgr depends on.
-- [mgmt](https://github.com/apache/mcumgr/tree/master/mgmt): Code implementing 
the `mgmt` layer of mcumgr.
-- [samples](https://github.com/apache/mcumgr/tree/master/samples): Sample 
applications utilizing mcumgr.
-- [smp](https://github.com/apache/mcumgr/tree/master/smp): The built-in 
transfer encoding: Simple management protocol.
+- [cborattr](https://github.com/apache/mynewt-mcumgr/tree/master/cborattr): 
Used for parsing incoming mcumgr requests.  Destructures mcumgr packets and 
populates corresponding field variables.
+- [cmd](https://github.com/apache/mynewt-mcumgr/tree/master/cmd): Built-in 
command handlers for the core mcumgr commands.
+- [ext](https://github.com/apache/mynewt-mcumgr/tree/master/ext): Third-party 
libraries that mcumgr depends on.
+- [mgmt](https://github.com/apache/mynewt-mcumgr/tree/master/mgmt): Code 
implementing the `mgmt` layer of mcumgr.
+- [samples](https://github.com/apache/mynewt-mcumgr/tree/master/samples): 
Sample applications utilizing mcumgr.
+- [smp](https://github.com/apache/mynewt-mcumgr/tree/master/smp): The built-in 
transfer encoding: Simple management protocol.
 
 ## Joining
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi commented on issue #2: Image upload broken

[GitBox]

carlescufi commented on issue #2: Image upload broken
URL: https://github.com/apache/mynewt-mcumgr-cli/issues/2#issuecomment-402391252
 
 
   CC @andrzej-kaczmarek 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi commented on issue #2: Image upload broken

[GitBox]

carlescufi commented on issue #2: Image upload broken
URL: https://github.com/apache/mynewt-mcumgr-cli/issues/2#issuecomment-402391354
 
 
   Latest log with today's mcumgr: 
   [log.txt](https://github.com/apache/mynewt-mcumgr-cli/files/2162238/log.txt)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi edited a comment on issue #2: Image upload broken

[GitBox]

carlescufi edited a comment on issue #2: Image upload broken
URL: https://github.com/apache/mynewt-mcumgr-cli/issues/2#issuecomment-402391354
 
 
   The PR above ( apache/mynewt-newtmgr#92) does not fix this.
   
   Latest log with today's mcumgr: 
   [log.txt](https://github.com/apache/mynewt-mcumgr-cli/files/2162238/log.txt)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] andrzej-kaczmarek closed issue #2: Image upload broken

[GitBox]

andrzej-kaczmarek closed issue #2: Image upload broken
URL: https://github.com/apache/mynewt-mcumgr-cli/issues/2
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] utzig closed pull request #7: Upstreaming of Zephyr downstream modifications

[GitBox]

utzig closed pull request #7: Upstreaming of Zephyr downstream modifications
URL: https://github.com/apache/mynewt-mcumgr/pull/7
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/Kconfig b/Kconfig
index 83eaeaa..15b546e 100644
--- a/Kconfig
+++ b/Kconfig
@@ -19,12 +19,10 @@ config MCUMGR
 bool
 prompt "mcumgr Support"
 select TINYCBOR
-default n
 help
   This option enables the mcumgr management library.
 
 if MCUMGR
-source "ext/lib/mgmt/mcumgr/mgmt/port/zephyr/Kconfig"
 source "ext/lib/mgmt/mcumgr/cmd/Kconfig"
 
 config APP_LINK_WITH_MCUMGR
diff --git a/cmd/fs_mgmt/Kconfig b/cmd/fs_mgmt/Kconfig
index ccbcf17..dae3ad7 100644
--- a/cmd/fs_mgmt/Kconfig
+++ b/cmd/fs_mgmt/Kconfig
@@ -19,7 +19,6 @@ menuconfig MCUMGR_CMD_FS_MGMT
 bool
 prompt "Enable mcumgr handlers for file management"
 depends on FILE_SYSTEM
-default n
 help
   Enables mcumgr handlers for file management
 
diff --git a/cmd/fs_mgmt/port/zephyr/src/zephyr_fs_mgmt.c 
b/cmd/fs_mgmt/port/zephyr/src/zephyr_fs_mgmt.c
index 754d3c3..231a0f8 100644
--- a/cmd/fs_mgmt/port/zephyr/src/zephyr_fs_mgmt.c
+++ b/cmd/fs_mgmt/port/zephyr/src/zephyr_fs_mgmt.c
@@ -45,7 +45,7 @@ int
 fs_mgmt_impl_read(const char *path, size_t offset, size_t len,
   void *out_data, size_t *out_len)
 {
-fs_file_t file;
+struct fs_file_t file;
 ssize_t bytes_read;
 int rc;
 
@@ -109,7 +109,7 @@ int
 fs_mgmt_impl_write(const char *path, size_t offset, const void *data,
size_t len)
 {
-fs_file_t file;
+struct fs_file_t file;
 int rc;
  
 /* Truncate the file before writing the first chunk.  This is done to
diff --git a/cmd/img_mgmt/Kconfig b/cmd/img_mgmt/Kconfig
index 3a581c6..73f0df0 100644
--- a/cmd/img_mgmt/Kconfig
+++ b/cmd/img_mgmt/Kconfig
@@ -21,9 +21,6 @@ menuconfig MCUMGR_CMD_IMG_MGMT
 select FLASH
 select MPU_ALLOW_FLASH_WRITE if CPU_HAS_MPU
 select IMG_MANAGER
-select MCUBOOT_IMG_MANAGER
-
-default n
 help
   Enables mcumgr handlers for image management
 
diff --git a/cmd/log_mgmt/Kconfig b/cmd/log_mgmt/Kconfig
index 9373571..201c6e0 100644
--- a/cmd/log_mgmt/Kconfig
+++ b/cmd/log_mgmt/Kconfig
@@ -18,8 +18,6 @@
 menuconfig MCUMGR_CMD_LOG_MGMT
 bool
 prompt "Enable mcumgr handlers for log management"
-depends on MDLOG
-default n
 help
   Enables mcumgr handlers for log management
 
diff --git a/cmd/os_mgmt/Kconfig b/cmd/os_mgmt/Kconfig
index 10f0abc..4be58ba 100644
--- a/cmd/os_mgmt/Kconfig
+++ b/cmd/os_mgmt/Kconfig
@@ -19,7 +19,6 @@ menuconfig MCUMGR_CMD_OS_MGMT
 bool
 prompt "Enable mcumgr handlers for OS management"
 select REBOOT
-default n
 help
   Enables mcumgr handlers for OS management
 
diff --git a/cmd/stat_mgmt/Kconfig b/cmd/stat_mgmt/Kconfig
index 3688ed1..9c5ae18 100644
--- a/cmd/stat_mgmt/Kconfig
+++ b/cmd/stat_mgmt/Kconfig
@@ -19,7 +19,6 @@ menuconfig MCUMGR_CMD_STAT_MGMT
 bool
 prompt "Enable mcumgr handlers for statistics management"
 depends on STATS
-default n
 help
   Enables mcumgr handlers for statistics management.
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] JoeHut commented on issue #7: Upstreaming of Zephyr downstream modifications

[GitBox]

JoeHut commented on issue #7: Upstreaming of Zephyr downstream modifications
URL: https://github.com/apache/mynewt-mcumgr/pull/7#issuecomment-402200028
 
 
   Looks like that is everything :+1: 
   
   ```
   $ diff -r mynewt-mcumgr zephyr/ext/lib/mgmt/mcumgr 
   Only in mynewt-mcumgr/cborattr: pkg.yml
   Only in mynewt-mcumgr/cborattr: syscfg.yml
   Only in mynewt-mcumgr/cborattr: test
   Only in mynewt-mcumgr/cmd/fs_mgmt: pkg.yml
   Only in mynewt-mcumgr/cmd/fs_mgmt/port: mynewt
   Only in mynewt-mcumgr/cmd/fs_mgmt: syscfg.yml
   Only in mynewt-mcumgr/cmd/img_mgmt: pkg.yml
   Only in mynewt-mcumgr/cmd/img_mgmt/port: mynewt
   diff -r mynewt-mcumgr/cmd/img_mgmt/src/img_mgmt_state.c 
zephyr/ext/lib/mgmt/mcumgr/cmd/img_mgmt/src/img_mgmt_state.c
   254,258c254
   < /*
   <  * We add 1 to the 32-byte hash buffer as _cbor_value_copy_string() 
adds
   <  * a null character at the end of the buffer.
   <  */
   < uint8_t hash[IMAGE_HASH_LEN + 1];
   ---
   > uint8_t hash[IMAGE_HASH_LEN];
   Only in mynewt-mcumgr/cmd/img_mgmt: syscfg.yml
   Only in mynewt-mcumgr/cmd/log_mgmt/port: mynewt
   Only in mynewt-mcumgr/cmd/os_mgmt: pkg.yml
   Only in mynewt-mcumgr/cmd/os_mgmt/port: mynewt
   Only in mynewt-mcumgr/cmd/os_mgmt: syscfg.yml
   Only in mynewt-mcumgr: .git
   Only in mynewt-mcumgr: .gitignore
   Only in mynewt-mcumgr/mgmt: pkg.yml
   Only in mynewt-mcumgr/mgmt: syscfg.yml
   diff -r mynewt-mcumgr/README.md zephyr/ext/lib/mgmt/mcumgr/README.md
   19,20c19,20
   < * [Mynewt](README-mynewt.md)
   < * [Zephyr](README-zephyr.md)
   ---
   > * README-mynewt.md
   > * README-zephyr.md
   Only in mynewt-mcumgr: repository.yml
   Only in mynewt-mcumgr: samples
   Only in mynewt-mcumgr/smp: pkg.yml
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi commented on issue #2: Image upload broken on Windows

[GitBox]

carlescufi commented on issue #2: Image upload broken on Windows
URL: https://github.com/apache/mynewt-mcumgr-cli/issues/2#issuecomment-402196482
 
 
   Not sure if this is an MCUmgr or MCUboot issue actually. For now I will keep 
it here, but there is something definitely broken. @sjanc could you also test 
for me with MCUboot built with Zephyr and the latest MCUboot that you get with 
`go get`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ccollins476ad commented on issue #2: Image upload broken

[GitBox]

ccollins476ad commented on issue #2: Image upload broken
URL: https://github.com/apache/mynewt-mcumgr-cli/issues/2#issuecomment-402248195
 
 
   The fix to newtmgr will be automatically included in mcumgr.  By the way, 
the fix was just merged to the newtmgr repo.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ccollins476ad closed issue #3: Unable to compile sample on zephyr 1.11

[GitBox]

ccollins476ad closed issue #3: Unable to compile sample on zephyr 1.11
URL: https://github.com/apache/mynewt-mcumgr/issues/3
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi commented on issue #7: Upstreaming of Zephyr downstream modifications

[GitBox]

carlescufi commented on issue #7: Upstreaming of Zephyr downstream modifications
URL: https://github.com/apache/mynewt-mcumgr/pull/7#issuecomment-402234451
 
 
   @utzig thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ccollins476ad commented on issue #2: Image upload broken on Windows

[GitBox]

ccollins476ad commented on issue #2: Image upload broken on Windows
URL: https://github.com/apache/mynewt-mcumgr-cli/issues/2#issuecomment-402198760
 
 
   I believe this is an issue that was recently introduced into newtmgr (and 
therefore mcumgr-cli).  The problem is that the CLI tool recently starting 
including a 32-byte hash in the first upload chunk.  On systems with a limited 
maximum ATT MTU, this doesn't leave enough room for a "complete" set of image 
data in the request.  The first request of an upgrade is required to have at 
least 32 bytes of image data to be valid (it must contain the full image 
header).
   
   There is a PR that fixes this issue that is ready to be merged: 
https://github.com/apache/mynewt-newtmgr/pull/92


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] carlescufi commented on issue #2: Image upload broken

[GitBox]

carlescufi commented on issue #2: Image upload broken
URL: https://github.com/apache/mynewt-mcumgr-cli/issues/2#issuecomment-402202003
 
 
   @ccollins476ad thanks for the info. We'll wait until that PR is merged to 
close this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mkiiskila closed pull request #1: [osal] Minor fixes to the os abstraction porting layer.

[GitBox]

mkiiskila closed pull request #1: [osal] Minor fixes to the os abstraction 
porting layer.
URL: https://github.com/apache/mynewt-nimble/pull/1
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/porting/common/include/os/os_fault.h 
b/porting/common/include/os/os_fault.h
index 4ce34c26..60f5faa7 100644
--- a/porting/common/include/os/os_fault.h
+++ b/porting/common/include/os/os_fault.h
@@ -21,7 +21,7 @@
 #define _OS_FAULT_H
 
 #ifdef __cplusplus
-extern "c" {
+extern "C" {
 #endif
 
 void __assert_func(const char *, int, const char *, const char *)
diff --git a/porting/common/src/os/os_mempool.c 
b/porting/common/src/os/os_mempool.c
index 65e4f615..55a8f123 100644
--- a/porting/common/src/os/os_mempool.c
+++ b/porting/common/src/os/os_mempool.c
@@ -102,7 +102,7 @@ os_mempool_init(struct os_mempool *mp, int blocks, int 
block_size,
 /* Blocks need to be sized properly and memory buffer should be
  * aligned
  */
-if (((uint32_t)membuf & (OS_ALIGNMENT - 1)) != 0) {
+if (((uintptr_t)membuf & (OS_ALIGNMENT - 1)) != 0) {
 return OS_MEM_NOT_ALIGNED;
 }
 }
@@ -113,7 +113,7 @@ os_mempool_init(struct os_mempool *mp, int blocks, int 
block_size,
 mp->mp_num_free = blocks;
 mp->mp_min_free = blocks;
 mp->mp_num_blocks = blocks;
-mp->mp_membuf_addr = (uint32_t)membuf;
+mp->mp_membuf_addr = (uintptr_t)membuf;
 mp->name = name;
 os_mempool_poison(membuf, true_block_size);
 SLIST_FIRST(mp) = membuf;
@@ -175,24 +175,24 @@ os_mempool_is_sane(const struct os_mempool *mp)
 int
 os_memblock_from(const struct os_mempool *mp, const void *block_addr)
 {
-uint32_t true_block_size;
-uint32_t baddr32;
-uint32_t end;
+uint32_t  true_block_size;
+uintptr_t baddr_ptr;
+uint32_t  end;
 
-_Static_assert(sizeof block_addr == sizeof baddr32,
+_Static_assert(sizeof block_addr == sizeof baddr_ptr,
"Pointer to void must be 32-bits.");
 
-baddr32 = (uint32_t)block_addr;
+baddr_ptr = (uintptr_t)block_addr;
 true_block_size = OS_MEMPOOL_TRUE_BLOCK_SIZE(mp);
 end = mp->mp_membuf_addr + (mp->mp_num_blocks * true_block_size);
 
 /* Check that the block is in the memory buffer range. */
-if ((baddr32 < mp->mp_membuf_addr) || (baddr32 >= end)) {
+if ((baddr_ptr < mp->mp_membuf_addr) || (baddr_ptr >= end)) {
 return 0;
 }
 
 /* All freed blocks should be on true block size boundaries! */
-if (((baddr32 - mp->mp_membuf_addr) % true_block_size) != 0) {
+if (((baddr_ptr - mp->mp_membuf_addr) % true_block_size) != 0) {
 return 0;
 }
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sreenathreddykonda opened a new pull request #5: Freertos port

[GitBox]

sreenathreddykonda opened a new pull request #5: Freertos port
URL: https://github.com/apache/mynewt-nimble/pull/5
 
 
   Looking FreeRTOS ported NIMBLE


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sreenathreddykonda closed pull request #5: Freertos port

[GitBox]

sreenathreddykonda closed pull request #5: Freertos port
URL: https://github.com/apache/mynewt-nimble/pull/5
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvlsianpu commented on issue #2: Fix imgmgr to follow flash write alignment

[GitBox]

nvlsianpu commented on issue #2: Fix imgmgr to follow flash write alignment
URL: https://github.com/apache/mynewt-mcumgr/issues/2#issuecomment-378901986
 
 
   @utzig @ccollins476ad 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nvlsianpu opened a new issue #2: Fix imgmgr to follow flash write alignment

[GitBox]

nvlsianpu opened a new issue #2: Fix imgmgr to follow flash write alignment
URL: https://github.com/apache/mynewt-mcumgr/issues/2
 
 
   Replay bugfix https://github.com/apache/mynewt-core/pull/963 to 
cmd/img_mgmt/src/img_mgmt.c function  `static int img_mgmt_upload(struct 
mgmt_ctxt *ctxt)`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yatishmishra opened a new issue #3: Unable to compile sample on zephyr 1.11

[GitBox]

yatishmishra opened a new issue #3: Unable to compile sample on zephyr 1.11
URL: https://github.com/apache/mynewt-mcumgr/issues/3
 
 
   Hi I am using zephyr 1.11 and trying to compile the sample code. I am 
getting following errors
   FAILED: ccache 
/home/yatish/zephyr-sdk-0.9.2/sysroots/x86_64-pokysdk-linux/usr/bin/arm-zephyr-eabi/arm-zephyr-eabi-gcc
 -DKERNEL -DMBEDTLS_CONFIG_FILE=\"config-mini-tls1_2.h\" -DNRF52840_XXAA 
-D_FORTIFY_SOURCE=2 -D__ZEPHYR__=1 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/kernel/include 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/arch/arm/include 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/arch/arm/soc/nordic_nrf5/nrf52 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/arch/arm/soc/nordic_nrf5/nrf52/include
 -I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/arch/arm/soc/nordic_nrf5/include 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/boards/arm/nrf52840_pca10056 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/include 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/include/drivers 
-Izephyr/include/generated -isystem 
/home/yatish/zephyr-sdk-0.9.2/sysroots/x86_64-pokysdk-linux/usr/lib/arm-zephyr-eabi/gcc/arm-zephyr-eabi/6.2.0/include
 -isystem 
/home/yatish/zephyr-sdk-0.9.2/sysroots/x86_64-pokysdk-linux/usr/lib/arm-zephyr-eabi/gcc/arm-zephyr-eabi/6.2.0/include-fixed
 -I/home/yatish/zephyr-sdk-0.9.2/sysroots/armv5-zephyr-eabi/usr/include 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/lib/crypto/tinycrypt/include 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/hal/cmsis/Include 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/hal/nordic/nrfx 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/hal/nordic/nrfx/drivers/include
 -I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/hal/nordic/nrfx/hal 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/hal/nordic/nrfx/mdk 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/hal/nordic/. 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/subsys/bluetooth 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/fs/nffs/include 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/lib/crypto/mbedtls/include 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/lib/crypto/mbedtls/configs 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/lib/mgmt/mcumgr/cborattr/include
 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/lib/mgmt/mcumgr/cmd/fs_mgmt/include
 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/lib/mgmt/mcumgr/cmd/img_mgmt/include
 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/lib/mgmt/mcumgr/cmd/os_mgmt/include
 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/lib/mgmt/mcumgr/cmd/stat_mgmt/include
 -I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/lib/mgmt/mcumgr/mgmt/include 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/lib/mgmt/mcumgr/mgmt/port/zephyr/include
 -I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/lib/mgmt/mcumgr/smp/include 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/lib/mgmt/mcumgr/util/include 
-I/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/lib/encoding/tinycbor/src -Os 
-g -Wall -Wformat -Wformat-security -Wno-format-zero-length -imacros 
/home/yatish/Desktop/zephyr-zephyr-v1.11.0/samples/mynewt-mcumgr-master/samples/smp_svr/zephyr/build/zephyr/include/generated/autoconf.h
 -ffreestanding -Wno-main -std=c99 -fno-asynchronous-unwind-tables -fno-pie 
-fno-pic -fno-strict-overflow -Wno-pointer-sign -Wno-unused-but-set-variable 
-fno-reorder-functions -fno-defer-pop -Werror=implicit-int -ffunction-sections 
-fdata-sections -mabi=aapcs --sysroot 
/home/yatish/zephyr-sdk-0.9.2/sysroots/armv5-zephyr-eabi/usr -mthumb 
-mcpu=cortex-m4 -MD -MT CMakeFiles/app.dir/src/main.c.obj -MF 
CMakeFiles/app.dir/src/main.c.obj.d -o CMakeFiles/app.dir/src/main.c.obj   -c 
../src/main.c
   In file included from 
/home/yatish/Desktop/zephyr-zephyr-v1.11.0/include/fs/nffs_fs.h:11:0,
from 
/home/yatish/Desktop/zephyr-zephyr-v1.11.0/include/fs/fs_interface.h:47,
from 
/home/yatish/Desktop/zephyr-zephyr-v1.11.0/include/fs.h:11,
from ../src/main.c:20:
   
/home/yatish/Desktop/zephyr-zephyr-v1.11.0/ext/fs/nffs/include/nffs/nffs.h:530:0:
 warning: "STATS_INC" redefined
#define STATS_INC(sectvarname, var)

   In file included from ../src/main.c:14:0:
   /home/yatish/Desktop/zephyr-zephyr-v1.11.0/include/stats.h:155:0: note: this 
is the location of the previous definition
#define STATS_INC(group__, var__) \

   ../src/main.c:52:15: error: variable ‘nffs_mnt’ has initializer but 
incomplete type
static struct fs_mount_t nffs_mnt = {
  ^~
   ../src/main.c:53:2: error: unknown field ‘type’ specified in initializer
 .type = FS_NFFS,
 ^
   ../src/main.c:53:10: error: ‘FS_NFFS’ undeclared here (not in a function)
 .type = FS_NFFS,
 ^~~
   ../src/main.c:53:10: warning: excess elements in struct initializer
   ../src/main.c:53:10: note: (near initialization for ‘nffs_mnt’)
   ../src/main.c:54:2: error: unknown field ‘mnt_point’ 

[GitHub] rymanluk opened a new pull request #8: [RFC] nimble/mesh: Add possibility to use extended advertising

[GitBox]

rymanluk opened a new pull request #8: [RFC] nimble/mesh: Add possibility to 
use extended advertising
URL: https://github.com/apache/mynewt-nimble/pull/8
 
 
   With this patch Mesh can make use of multi instances which came with
   advertising extension. It creates one advertising instance for
   PB-ADV and one for PB-GATT and PROXY.
   
   That said, it is possible to create additional instances which are
   used for non mesh purpose. Note that this brings limitation on Mesh
   Friendship due to timings.
   
   To make use of it application needs to set BLE_EXT_ADV and
   BLE_MULTI_ADV_INSTANCES at least to 1. Mesh will use last available
   advertising instance for PB-ADV and second to last for PB-GATT and
   PROXY


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michal-narajowski opened a new pull request #11: mesh: Add example implementation of generic onoff and level models

[GitBox]

michal-narajowski opened a new pull request #11: mesh: Add example 
implementation of generic onoff and level models
URL: https://github.com/apache/mynewt-nimble/pull/11
 
 
   This patch adds simple implementation of these two models
   with support for both client and server. There is also an example
   light model that simulates a light bulb and controls 4 LEDs through
   4 PWMs.
   
   To use these features set BLE_MESH_SHELL_MODELS: 1 and you should
   enable pwm0, pwm1, pwm2 and pwm3 devices. On nrf52840 you should
   specify PWM_0: 1, PWM_1: 1, PWM_2: 1, PWM_3: 1, to achieve this.
   
   Here are the commands used to control the server from client (mesh-shell
   will communicate through local interface by default):
   
   `init` - to initialize mesh
   `provision 0 0x0001` - provision mesh with fixed keys, 0x0001 is a unicast 
address
   of a node
   `app-key-add 0 0 0` - add app key with netkey_idx=0 appkey_idx=0 and value=0
   `mod-app-bind 0x0001 0x 0x1000` - bind appkey with generic onoff server 
model
   `mod-app-bind 0x0001 0x 0x1001` - bind appkey with generic onoff client 
model
   `mod-app-bind 0x0001 0x 0x1002` - bind appkey with generic level server 
model
   `mod-app-bind 0x0001 0x 0x1003` - bind appkey with generic level client
   model
   `gen-level-set 50` - set diode lightness to 50%
   `gen-level-get` - get state of level model
   `gen-onoff-set 0` - set state of onoff model to off
   `gen-onoff-get` - get state of onoff model


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sterlinghughes commented on issue #4: [linux] initial port and osal additions.

[GitBox]

sterlinghughes commented on issue #4: [linux] initial port and osal additions.
URL: https://github.com/apache/mynewt-nimble/pull/4#issuecomment-375367695
 
 
   @andrzej-kaczmarek are we good to merge this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] simonratner commented on a change in pull request #9: nimble/ll: Do not use sec_txdone for legacy adv

[GitBox]

simonratner commented on a change in pull request #9: nimble/ll: Do not use 
sec_txdone for legacy adv
URL: https://github.com/apache/mynewt-nimble/pull/9#discussion_r175498964
 
 

 ##
 File path: nimble/controller/src/ble_ll_adv.c
 ##
 @@ -1323,7 +1323,9 @@ ble_ll_adv_halt(void)
 
 os_eventq_put(_ble_ll_data.ll_evq, >adv_txdone_ev);
 #if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_EXT_ADV)
-os_eventq_put(_ble_ll_data.ll_evq, >adv_sec_txdone_ev);
+if (!(advsm->props & BLE_HCI_LE_SET_EXT_ADV_PROP_LEGACY)) {
 
 Review comment:
   Wondering: why is the check explicitly for legacy adv rather than 
`ble_ll_adv_active_chanset_is_sec(advsm)` like in `ble_ll_adv_tx_done`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rymanluk commented on a change in pull request #11: mesh: Add example implementation of generic onoff and level models

[GitBox]

rymanluk commented on a change in pull request #11: mesh: Add example 
implementation of generic onoff and level models
URL: https://github.com/apache/mynewt-nimble/pull/11#discussion_r176059882
 
 

 ##
 File path: nimble/host/mesh/src/light_model.h
 ##
 @@ -0,0 +1,25 @@
+/*
+ * Copyright (c) 2017 Intel Corporation
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ */
+#ifndef __BT_MESH_LIGHT_MODEL_H
+#define __BT_MESH_LIGHT_MODEL_H
+
+#include "mesh/mesh.h"
 
 Review comment:
   don't we need #include "syscfg/syscfg.h" ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sdalu opened a new pull request #12: ble service: Device Information Service

[GitBox]

sdalu opened a new pull request #12: ble service: Device Information Service
URL: https://github.com/apache/mynewt-nimble/pull/12
 
 
   See: https://github.com/apache/mynewt-core/pull/901


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-imgmod] ccollins476ad opened a new pull request #2: Distinguish partial {en|de}crypt from full

[GitBox]

ccollins476ad opened a new pull request #2: Distinguish partial {en|de}crypt 
from full
URL: https://github.com/apache/mynewt-imgmod/pull/2
 
 
   When we calculate a build's SHA256, we provide two inputs to the hash 
function:
   1. Image header
   2. Unencrypted image body
   
   The image header contains an "encrypted" flag (`IMAGE_F_ENCRYPTED`).  This 
has an interesting implication: when we decrypt a build, its hash is no longer 
valid.
   
   There are two use cases for decrypting an image:
   
   1. Create an unencrypted version of the image.
   
   For this use case, the decrypted image should be well formed and usable as 
an unencrypted image.
   
   2. Re-sign an image with a new key.
   
   For this use case, the procedure typically looks like this:
   
   a. Start with a signed and encrypted image.
   b. Decrypt image (`imgmod image decrypt`).
   c. Remove signature TLVs (`imgmod image rmsigs`).
   d. Re-sign image (`imgmod image sign`).
   e. Re-encrypt image (`imgmod image encrypt`).
   
   In this use case, it is critical that step b (decrypt) does *not* clear the 
`IMAGE_F_ENCRYPTED` flag from the image header.  This flag must remain set so 
that the signature produced in step d is valid.
   
   So we need two sets of {en|de}crypt commands:
   * Full
   * Partial
   
   The "full" versions apply to use case 1.
   The "partial" versions apply to use case 2.
   
   The old commands (`image encrypt`, `image decrypt`) are the partial 
versions.  These remain unchanged.
   
   The new commands (`image encryptfull` `image decryptfull`) are the full 
versions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-imgmod] ccollins476ad merged pull request #2: Distinguish partial {en|de}crypt from full

[GitBox]

ccollins476ad merged pull request #2: Distinguish partial {en|de}crypt from full
URL: https://github.com/apache/mynewt-imgmod/pull/2
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-artifact] ccollins476ad opened a new pull request #1: [DO NOT MERGE] Verify

[GitBox]

ccollins476ad opened a new pull request #1: [DO NOT MERGE] Verify
URL: https://github.com/apache/mynewt-artifact/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-artifact] ccollins476ad merged pull request #1: Add "verify" functionality

[GitBox]

ccollins476ad merged pull request #1: Add "verify" functionality
URL: https://github.com/apache/mynewt-artifact/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-imgmod] ccollins476ad opened a new pull request #1: Set / clear "encrypt" flag in image header

[GitBox]

ccollins476ad opened a new pull request #1: Set / clear "encrypt" flag in image 
header
URL: https://github.com/apache/mynewt-imgmod/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-imgmod] ccollins476ad merged pull request #1: Set / clear "encrypt" flag in image header

[GitBox]

ccollins476ad merged pull request #1: Set / clear "encrypt" flag in image header
URL: https://github.com/apache/mynewt-imgmod/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-imgmod] utzig commented on issue #1: Set / clear "encrypt" flag in image header

[GitBox]

utzig commented on issue #1: Set / clear "encrypt" flag in image header
URL: https://github.com/apache/mynewt-imgmod/pull/1#issuecomment-491438909
 
 
   Yes, LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-artifact] ccollins476ad merged pull request #3: Add support for ed25519 encrypted signing keys

[GitBox]

ccollins476ad merged pull request #3:  Add support for ed25519 encrypted 
signing keys 
URL: https://github.com/apache/mynewt-artifact/pull/3
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-artifact] ccollins476ad commented on a change in pull request #2: Support verification of encrypted images

[GitBox]

ccollins476ad commented on a change in pull request #2: Support verification of 
encrypted images
URL: https://github.com/apache/mynewt-artifact/pull/2#discussion_r298257906
 
 

 ##
 File path: image/create.go
 ##
 @@ -38,7 +38,7 @@ import (
 type ImageCreator struct {
Body []byte
Version  ImageVersion
-   SigKeys  []sec.SignKey
+   SigKeys  []sec.PrivSignKey
 
 Review comment:
   I forgot to reply here in case others were following.  @utzig and I 
discussed this offline, and we concluded that while the current naming may not 
be the most intuitive, we couldn't think of any obviously-better candidates.  
So, for now we will keep the current names.  If they prove too confusing, we 
can always change them later!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-artifact] utzig commented on a change in pull request #2: Support verification of encrypted images

[GitBox]

utzig commented on a change in pull request #2: Support verification of 
encrypted images
URL: https://github.com/apache/mynewt-artifact/pull/2#discussion_r297642260
 
 

 ##
 File path: image/create.go
 ##
 @@ -38,7 +38,7 @@ import (
 type ImageCreator struct {
Body []byte
Version  ImageVersion
-   SigKeys  []sec.SignKey
+   SigKeys  []sec.PrivSignKey
 
 Review comment:
   There is no such thing as `PubSignKey`, a sign key is private by definition.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-imgmod] ccollins476ad opened a new pull request #3: Use external artifact package

[GitBox]

ccollins476ad opened a new pull request #3:  Use external artifact package 
URL: https://github.com/apache/mynewt-imgmod/pull/3
 
 
   The artifact package has been moved out of the newt repo and into its own 
repo (github.com/apache/mynewt-artifact).  Use this external package rather 
than the deprecated one in the newt repo.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-artifact] ccollins476ad commented on a change in pull request #2: Support verification of encrypted images

[GitBox]

ccollins476ad commented on a change in pull request #2: Support verification of 
encrypted images
URL: https://github.com/apache/mynewt-artifact/pull/2#discussion_r297778632
 
 

 ##
 File path: image/create.go
 ##
 @@ -38,7 +38,7 @@ import (
 type ImageCreator struct {
Body []byte
Version  ImageVersion
-   SigKeys  []sec.SignKey
+   SigKeys  []sec.PrivSignKey
 
 Review comment:
   By "Pub" I mean the public component of the key; the part that you use to 
verify a signature.  Do you think `PrivSignKey` / `PubSignKey` is not a good 
way to name these types?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-artifact] utzig commented on a change in pull request #2: Support verification of encrypted images

[GitBox]

utzig commented on a change in pull request #2: Support verification of 
encrypted images
URL: https://github.com/apache/mynewt-artifact/pull/2#discussion_r297782191
 
 

 ##
 File path: image/create.go
 ##
 @@ -38,7 +38,7 @@ import (
 type ImageCreator struct {
Body []byte
Version  ImageVersion
-   SigKeys  []sec.SignKey
+   SigKeys  []sec.PrivSignKey
 
 Review comment:
   `PubKey` would be ok for the verification, or `VerifyKey` (which sounds a 
bit weird!). I just mentioned it because saying that it is private is like 
saying: "look this number is prime, AND it also is only divisible by 1 and 
itself". All those name changes don't bring extra information. Although I would 
not mind if you prefer this way, since it's done already! ;-)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-artifact] ccollins476ad merged pull request #2: Support verification of encrypted images

[GitBox]

ccollins476ad merged pull request #2: Support verification of encrypted images
URL: https://github.com/apache/mynewt-artifact/pull/2
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-artifact] utzig commented on a change in pull request #2: Support verification of encrypted images

[GitBox]

utzig commented on a change in pull request #2: Support verification of 
encrypted images
URL: https://github.com/apache/mynewt-artifact/pull/2#discussion_r297795938
 
 

 ##
 File path: sec/sign.go
 ##
 @@ -0,0 +1,259 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package sec
+
+import (
+   "bytes"
+   "crypto"
+   "crypto/ecdsa"
+   "crypto/rsa"
+   "crypto/x509"
+   "encoding/asn1"
+   "encoding/pem"
+
+   "github.com/apache/mynewt-artifact/errors"
+)
+
+type PrivSignKey struct {
+   // Only one of these members is non-nil.
+   Rsa *rsa.PrivateKey
+   Ec  *ecdsa.PrivateKey
+}
+
+type PubSignKey struct {
+   Rsa *rsa.PublicKey
+   Ec  *ecdsa.PublicKey
+}
+
+type Sig struct {
+   KeyHash []byte
+   Data[]byte
+}
+
+// XXX: Rename this.
 
 Review comment:
   Will you leave this here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-artifact] ccollins476ad commented on a change in pull request #2: Support verification of encrypted images

[GitBox]

ccollins476ad commented on a change in pull request #2: Support verification of 
encrypted images
URL: https://github.com/apache/mynewt-artifact/pull/2#discussion_r297802197
 
 

 ##
 File path: sec/sign.go
 ##
 @@ -0,0 +1,259 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package sec
+
+import (
+   "bytes"
+   "crypto"
+   "crypto/ecdsa"
+   "crypto/rsa"
+   "crypto/x509"
+   "encoding/asn1"
+   "encoding/pem"
+
+   "github.com/apache/mynewt-artifact/errors"
+)
+
+type PrivSignKey struct {
+   // Only one of these members is non-nil.
+   Rsa *rsa.PrivateKey
+   Ec  *ecdsa.PrivateKey
+}
+
+type PubSignKey struct {
+   Rsa *rsa.PublicKey
+   Ec  *ecdsa.PublicKey
+}
+
+type Sig struct {
+   KeyHash []byte
+   Data[]byte
+}
+
+// XXX: Rename this.
 
 Review comment:
   Oops, thanks.  I renamed it, but didn't remove the comment :).  I have fixed 
it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-imgmod] ccollins476ad merged pull request #3: Use external artifact package

[GitBox]

ccollins476ad merged pull request #3:  Use external artifact package 
URL: https://github.com/apache/mynewt-imgmod/pull/3
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [mynewt-documentation] ccollins476ad opened a new pull request #96: ble bare bones tutorial: Add missing #include

[GitBox]

ccollins476ad opened a new pull request #96:
URL: https://github.com/apache/mynewt-documentation/pull/96


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] vrahane commented on pull request #96: ble bare bones tutorial: Add missing #include

[GitBox]

vrahane commented on pull request #96:
URL: 
https://github.com/apache/mynewt-documentation/pull/96#issuecomment-626272816


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] sjanc merged pull request #101: Update add_newtmgr.rst

[GitBox]

sjanc merged pull request #101:
URL: https://github.com/apache/mynewt-documentation/pull/101


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] rafacouto opened a new pull request #101: Update add_newtmgr.rst

[GitBox]

rafacouto opened a new pull request #101:
URL: https://github.com/apache/mynewt-documentation/pull/101


   Package dependencies updated to v1.8.0.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] caspermeijn opened a new pull request #97: Add rust blinky conversion tutorial

[GitBox]

caspermeijn opened a new pull request #97:
URL: https://github.com/apache/mynewt-documentation/pull/97


   This adds tutorial about converting the Blinky application to Rust. I see 
this as the beginning of a series of articles about Rust and Mynewt.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] caspermeijn commented on pull request #98: Add more rust target explanations

[GitBox]

caspermeijn commented on pull request #98:
URL: 
https://github.com/apache/mynewt-documentation/pull/98#issuecomment-647102915


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] caspermeijn commented on pull request #99: nRF tutorials: fix table formatting, and syntax errors in interim examples

[GitBox]

caspermeijn commented on pull request #99:
URL: 
https://github.com/apache/mynewt-documentation/pull/99#issuecomment-647102748


   LGTM
   Please note the you can simplify the the emphasize by using 
`:emphasize-lines: 1-17,24`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] micolous opened a new pull request #99: Fix table formatting and typos in interim examples for nRF

[GitBox]

micolous opened a new pull request #99:
URL: https://github.com/apache/mynewt-documentation/pull/99


   At present, there's broken spacing because of the excessive wrapping on this 
table:
   
   https://user-images.githubusercontent.com/246847/85215729-04922200-b3c0-11ea-9c58-fe4c0bcce399.png;>
   
   I've also fixed some small syntax errors in the earlier stages of the 
tutorial.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] utzig commented on pull request #98: Add more rust target explanations

[GitBox]

utzig commented on pull request #98:
URL: 
https://github.com/apache/mynewt-documentation/pull/98#issuecomment-638981202


   /cc @caspermeijn 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] utzig opened a new pull request #98: Add more rust target explanations

[GitBox]

utzig opened a new pull request #98:
URL: https://github.com/apache/mynewt-documentation/pull/98


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] caspermeijn commented on pull request #98: Add more rust target explanations

[GitBox]

caspermeijn commented on pull request #98:
URL: 
https://github.com/apache/mynewt-documentation/pull/98#issuecomment-640436453


   Why did you change the TARGET variable? Did you test that value? It doesn't 
seem to build for me, but I could do something wrong. 
   If you do want to change it, you should change the `rustup` command as well.
   
   I want to do some kind of mapping in the future, so that the mynewt compiler 
selection also triggers the rust compiler selection. But I don't know how to do 
that yet ;-)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] caspermeijn commented on pull request #98: Add more rust target explanations

[GitBox]

caspermeijn commented on pull request #98:
URL: 
https://github.com/apache/mynewt-documentation/pull/98#issuecomment-641036846


   Yes, that was what I was looking for! Now only the `emphasize-lines` needs 
an update.
   
   Well, my idea was to keep the tutorial as a simplified explanation of how it 
works and then build towards a package that takes care of all this kind of 
stuff. 
   
   For example a next tutorial I want to show how to convert the unsafe api to 
a rust api for GPIO and then point to a package with completed conversions. 
   
   Now that I think about it, a rust-blinky app does matches this description 
as well.
   
   The only problem is that I think the apps in core are not discoverable. I 
mostly used the tutorials for learning, because I didn't know the existence of 
the core apps.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] utzig commented on pull request #98: Add more rust target explanations

[GitBox]

utzig commented on pull request #98:
URL: 
https://github.com/apache/mynewt-documentation/pull/98#issuecomment-640906930


   > Why did you change the TARGET variable? Did you test that value? It 
doesn't seem to build for me, but I could do something wrong.
   
   I had tested it on another MCU which is also Cortex-M4, but now I did on 
nrf52840 as well and it works. I updated this PR so that the shell script 
auto-detects which Cortex type is being used and sets the proper TARGET.
   
   > If you do want to change it, you should change the `rustup` command as 
well.
   
   Done (in a way!).
   
   Why don't you submit a PR to https://github.com/apache/mynewt-core adding a 
new app, say `rust-blinky`? That would make it easier to colaborate then 
working on documentation! :-P
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] utzig commented on a change in pull request #97: Add rust blinky conversion tutorial

[GitBox]

utzig commented on a change in pull request #97:
URL: 
https://github.com/apache/mynewt-documentation/pull/97#discussion_r434937287



##
File path: docs/tutorials/other/rust.rst
##
@@ -0,0 +1,275 @@
+..
+  #
+  # Copyright 2020 Casper Meijn 
+  #
+  # Licensed under the Apache License, Version 2.0 (the "License");
+  # you may not use this file except in compliance with the License.
+  # You may obtain a copy of the License at
+  #
+  # http://www.apache.org/licenses/LICENSE-2.0
+  #
+  # Unless required by applicable law or agreed to in writing, software
+  # distributed under the License is distributed on an "AS IS" BASIS,
+  # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  # See the License for the specific language governing permissions and
+  # limitations under the License.
+  #
+
+Rust Blinky application
+===
+
+This tutorial shows you how to convert the Blinky application to Rust. This 
includes 
+integrating Cargo into newt builder.
+
+.. contents::
+  :local:
+  :depth: 2
+
+Prerequisites
+~
+
+Ensure that you meet the following prerequisites before continuing with
+this tutorial:
+
+- You have basic knowledge about `Rust 
`__.
+- You have basic knowledge about `Rust Embedded 
`__.
+- You have rust installed using `rustup 
`__.
+-  Follow :doc:`Blinky tutorial <../blinky/blinky>` to create a 
+   project with a basic application. You will extend that application in this 
+   tutorial.
+
+Initialize Rust
+~~~
+
+The first step is to initialize a crate for developing your application in. You
+can do this in the existing `blinky` directory. 
+
+.. code-block:: console
+
+$ cargo init --lib apps/blinky
+Created library package
+$ tree apps/blinky
+apps/blinky
+├── Cargo.toml
+├── pkg.yml
+└── src
+├── lib.rs
+└── main.c
+
+1 directory, 4 files
+
+This creates a Cargo.toml configuration file and src/lib.rs. We will use these 
+files to place our application in. You may notice that the Rust application is
+not configured as an app, but as an lib. This is needed later to allow linking
+to the rest of mynewt.
+
+Setup the basics
+
+
+Now we want to actually convert the application code to Rust. Let's open 
`src/lib.rs`
+and remove the contents. Then start with some basic setup:
+
+.. code-block:: rust
+
+#![no_std]
+
+extern crate panic_halt;
+
+#[no_mangle]
+pub extern "C" fn main() {
+
+loop {
+}
+}
+
+The first line states that this program doesn't use the standard library. This
+means that only the core library is linked to the program. See 
+`rust-embedded book 
`__ 
+for more information.
+
+The next line specifies the panic handler. Panicking is an important feature of
+Rust. To ease this tutorial we choose to halt the processor on panic. See 
+`rust-embedded book 
`__
+for alternatives.
+
+Then we have the ``main`` function. It contains a endless loop as it should 
never
+return, but doesn't do anything useful yet. It is marked ``no_mangle`` and 
``extern "C"``
+to make sure it can be called from the mynewt C code.
+
+Converting sysinit
+~~
+
+The next step is to do the sysinit. This is implemented as a C macro, which is
+incompatible with Rust. This could be solved by using a C library, but for this
+tutorial we will simply execute the macro manually.
+
+.. code-block:: rust
+:emphasize-lines: 3-7, 13-16
+
+#![no_std]
+
+extern "C" {
+fn sysinit_start();
+fn sysinit_app();
+fn sysinit_end();
+}
+
+extern crate panic_halt;
+
+#[no_mangle]
+pub extern "C" fn main() {
+/* Initialize all packages. */
+unsafe { sysinit_start(); }
+unsafe { sysinit_app(); }
+unsafe { sysinit_end(); }
+
+loop {
+}
+}
+
+First we manually define the three sysinit functions. This is similar to the
+C header file. Then we execute the sysinit as the macro would do. 
+
+We need the ``unsafe`` indication because the C code doesn't have the same 
memory
+guarantees as Rust. Normally we need to build a safe Rust wrapper, but that is 
+out of scope for this tutorial.
+
+Doing GPIO and delays
+~
+
+Now it is time to do some GPIO and add a delay. Again we define the functions 
+and then use them in and around the loop. We need some constants that are 
+normally defined by the BSP or MCU. These constants need to move to a better 
+place later.
+
+.. code-block:: rust
+:emphasize-lines: 7-9, 14, 16, 25, 28-29, 31-32
+
+#![no_std]
+
+extern "C" {
+fn sysinit_start();
+   

[GitHub] [mynewt-documentation] utzig merged pull request #97: Add rust blinky conversion tutorial

[GitBox]

utzig merged pull request #97:
URL: https://github.com/apache/mynewt-documentation/pull/97


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] utzig merged pull request #98: Add more rust target explanations

[GitBox]

utzig merged pull request #98:
URL: https://github.com/apache/mynewt-documentation/pull/98


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] mikevoyt opened a new pull request #100: Use the nordic_pca10040 BSP

[GitBox]

mikevoyt opened a new pull request #100:
URL: https://github.com/apache/mynewt-documentation/pull/100


   nrf52dk is no longer the correct BSP for the nRF52 board



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] utzig merged pull request #100: Use the nordic_pca10040 BSP

[GitBox]

utzig merged pull request #100:
URL: https://github.com/apache/mynewt-documentation/pull/100


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] utzig merged pull request #99: nRF tutorials: fix table formatting, and syntax errors in interim examples

[GitBox]

utzig merged pull request #99:
URL: https://github.com/apache/mynewt-documentation/pull/99


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] utzig opened a new pull request #103: Update banner release and add 1.8.0 to chooser

[GitBox]

utzig opened a new pull request #103:
URL: https://github.com/apache/mynewt-documentation/pull/103


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] caspermeijn commented on issue #102: What exatcly does the "latest" option refer to?

[GitBox]

caspermeijn commented on issue #102:
URL: 
https://github.com/apache/mynewt-documentation/issues/102#issuecomment-733204004


   I am not sure what you mean with version dropdown. At 
https://mynewt.apache.org/documentation/ I see a link to the v1.8.0 of the 
documentation.
   
   I believe that the "latest" documentation is generated from the master 
branch and that the  "v1.8.0" documenation is generated from the v1.8.0 tag of 
mynewt.
   
   Does that answer your question?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] EPNW commented on issue #102: What exatcly does the "latest" option refer to?

[GitBox]

EPNW commented on issue #102:
URL: 
https://github.com/apache/mynewt-documentation/issues/102#issuecomment-733532063


   I'm not sure about this: Once you select "1.8.0" on the page you mention and 
inspect the version dropdown on the page you land on, there is no entry for 
"1.8.0", only "latest" and from "1.7.0" downwards. So either "1.8.0" is not 
accessible from the dropdown, or "latest" actually refers to "1.8.0". But I 
don't think that the later is the case, since when you go to 
[https://mynewt.apache.org/v1_8_0/](https://mynewt.apache.org/v1_8_0/) (what is 
again, unavailable from the version dropdown), you get a warning that "Version 
1.8.0 is not the most recent version of the Apache Mynewt documentation."
   
   With version dropdown I mean this:
   
![latest](https://user-images.githubusercontent.com/30860236/100197769-18a3f780-2efb-11eb-828f-264f285da596.png)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] caspermeijn commented on issue #102: What exatcly does the "latest" option refer to?

[GitBox]

caspermeijn commented on issue #102:
URL: 
https://github.com/apache/mynewt-documentation/issues/102#issuecomment-742030060


   You are right, the dropdown was not updated. This will be fixed by 
https://github.com/apache/mynewt-documentation/pull/103
   
   So latest is the master branch of mynewt and the specific version are tagged 
releases of mynewt. v1.8.0 is the most recent release. I believe there are 
plans to release v1.9 in a few months.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] caspermeijn commented on pull request #103: Update banner release and add 1.8.0 to chooser

[GitBox]

caspermeijn commented on pull request #103:
URL: 
https://github.com/apache/mynewt-documentation/pull/103#issuecomment-742027355


   LGTM



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] utzig merged pull request #103: Update banner release and add 1.8.0 to chooser

[GitBox]

utzig merged pull request #103:
URL: https://github.com/apache/mynewt-documentation/pull/103


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] utzig commented on issue #102: What exatcly does the "latest" option refer to?

[GitBox]

utzig commented on issue #102:
URL: 
https://github.com/apache/mynewt-documentation/issues/102#issuecomment-742398657


   The reported issues were fixed for the moment being, now there is "1.8.0" 
and "latest". It happened due to Apache moving its build infrastructure to new 
servers, which disabled the auto publishing of site content when our repos are 
updated, so they ended up stale. I pushed a new site manually this time, but a 
new Jenkins site publishing must be set up soon. I am closing this, feel free 
to reopen if issues persist.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] utzig closed issue #102: What exatcly does the "latest" option refer to?

[GitBox]

utzig closed issue #102:
URL: https://github.com/apache/mynewt-documentation/issues/102


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] EPNW opened a new issue #102: What exatcly does the "latest" option refer to?

[GitBox]

EPNW opened a new issue #102:
URL: https://github.com/apache/mynewt-documentation/issues/102


   I was about to cite [HAL page of the 
manual](https://mynewt.apache.org/latest/os/modules/hal/hal.html) in an essay. 
For this, I need to be able to exactly describe the version I'm refereing to. 
The version drop down allows me to select different versions, either a specific 
one (e.g. 1.7.0, 1.6.0) or "latest". Obviously, I can not cite "latest", 
because the version "latest" is refering to will change in the future. I need 
to cite something like "1.8.0". Could we change the "latest" option in the 
version dropdown to "1.8.0 (latest)" (assuming 1.8.0 is currently latest, which 
I don't know, since the version drop down tells me nothing about the latest 
version)?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] KKopyscinski opened a new pull request #104: native_install: update macOS "Installing GCC/libc"

[GitBox]

KKopyscinski opened a new pull request #104:
URL: https://github.com/apache/mynewt-documentation/pull/104


   Mynewt Core accommodated clang as default compiler for macOS systems,
   as gcc-5 was old and not supported on newer macOS versions. Still, gcc
   might be installed and used, but it's no longer a default solution.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] KKopyscinski merged pull request #104: native_install: update macOS "Installing GCC/libc"

[GitBox]

KKopyscinski merged pull request #104:
URL: https://github.com/apache/mynewt-documentation/pull/104


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] KKopyscinski commented on issue #79: Unable to build BLE Eddystone project

[GitBox]

KKopyscinski commented on issue #79:
URL: 
https://github.com/apache/mynewt-documentation/issues/79#issuecomment-849377258


   fixed by 
https://github.com/apache/mynewt-documentation/commit/955f9d3d2f7b078d4cf2a654c3c3416e67f77f70


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] KKopyscinski closed issue #79: Unable to build BLE Eddystone project

[GitBox]

KKopyscinski closed issue #79:
URL: https://github.com/apache/mynewt-documentation/issues/79


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-documentation] mkasenberg opened a new pull request #106: native_install: Update link to toolchain for Windows

[GitBox]

mkasenberg opened a new pull request #106:
URL: https://github.com/apache/mynewt-documentation/pull/106


   This fixes error that occurred on Windows at newt create-image command:
   Error: arm-none-eabi-objcopy
   [..]pache-mynewt-nimble/apps/bttester/bttester.hex 64-bit address
   0x4b4fa3c000 out of range for Intel Hex file


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org