On Thu, 7 Nov 2019 at 22:28, Laszlo Kishalmi
wrote:
> When you create your PR for 7.2, please close this one in favor of that:
>
PR#1620 has been merged now, which is great news! Is everyone happy that no
changes are needed to the processjsannotations ant task - this was
discussed in the
I do not have privileges to close the PR
https://github.com/apache/netbeans/pull/1108
Jose Contreras
El jue., 7 nov. 2019 a las 17:20, Jose Ch () escribió:
> I will, thanks for bringing it to my attention.
>
> Jose Contreras
>
> El jue., 7 nov. 2019 a las 16:28, Laszlo Kishalmi (<
>
I will, thanks for bringing it to my attention.
Jose Contreras
El jue., 7 nov. 2019 a las 16:28, Laszlo Kishalmi (<
laszlo.kisha...@gmail.com>) escribió:
> When you create your PR for 7.2, please close this one in favor of that:
> https://github.com/apache/netbeans/pull/1108
>
>
> On 11/7/19
When you create your PR for 7.2, please close this one in favor of that:
https://github.com/apache/netbeans/pull/1108
On 11/7/19 1:41 PM, Jose Ch wrote:
Thanks for your help Peter.
I tested the PR and it works for both the asm5.2 and the asm7.2 branches. I
also compare the output from the
Thanks for your help Peter.
I tested the PR and it works for both the asm5.2 and the asm7.2 branches. I
also compare the output from the original asm5.0.1 with the new ones
(ams5.2-asm7.2) and it was the same.
I also tested using ASM API v6 & v7, the output was the same and I worked
without
On Wed, 6 Nov 2019 at 22:24, Jose Ch wrote:
>
> I will test the PR and do as you suggest Pete.
For what it's worth my implementation was a bit different:
private static class CtorDelVisitor extends AnnotationVisitor {
int[] indices;
/**
* Constructs a new {@link
I will test the PR and do as you suggest Pete.
El mié., 6 nov. 2019 a las 14:56, Peter Hull ()
escribió:
> On Wed, 6 Nov 2019 at 20:38, Svata Dedic
> wrote:
> > Yes, that was it. You probably didn't do "ant clean" (neither did I).
> Right.
> > The NPE should be fixed by
> >
On Wed, 6 Nov 2019 at 20:38, Svata Dedic wrote:
> Yes, that was it. You probably didn't do "ant clean" (neither did I).
Right.
> The NPE should be fixed by
> https://github.com/pepness/incubator-netbeans/pull/2
Right again!
I just opened up my mail to post my progress, great to see you'd
already
Dne 06. 11. 19 v 16:17 Peter Hull napsal(a):
On Wed, 6 Nov 2019 at 15:13, Jose Ch wrote:
For some reason I've got both 7.2 and 5.0.1 on the startup classpath -
Yes, that was it. You probably didn't do "ant clean" (neither did I).
The NPE should be fixed by
On Wed, 6 Nov 2019 at 15:13, Jose Ch wrote:
> Could you verify that in the line 300 (Startup Classpath) it is using the asm
> version 5.2 or above?
For some reason I've got both 7.2 and 5.0.1 on the startup classpath -
I will do a clean & rebuild then report back to you.
Pete
Startup Classpath
Hi Peter,
Could you verify that in the line 300 (Startup Classpath) it is using the
asm version 5.2 or above?
Besides adding logging to the Asm.java class it is needed to upgrade the
asm library:
For asm version 5.2:
On Wed, 6 Nov 2019 at 00:42, Jose Ch wrote:
> I tried to upgrade the asm-all-5.0.1 library to the latest version 7.2 and
> received a nullPointerException (line 774 of asm-52 & asm-72 files). I
> already successfully upgrade it to version 5.1
>
12 matches
Mail list logo
