[GitHub] incubator-netbeans pull request #84: [NETBEANS-54] Module Review core.kit

GitHub user geertjanw opened a pull request: https://github.com/apache/incubator-netbeans/pull/84 [NETBEANS-54] Module Review core.kit You can merge this pull request into a Git repository by running: $ git pull https://github.com/geertjanw/incubator-netbeans

[GitHub] incubator-netbeans pull request #83: [NETBEANS-54] Module Review libs.byteli...

GitHub user vieiro opened a pull request: https://github.com/apache/incubator-netbeans/pull/83 [NETBEANS-54] Module Review libs.bytelist - Updated Maven coordinates for jruby's bytelist 0.1 (LGPL 2.1) You can merge this pull request into a Git repository by running: $ git

add "-notice.txt" if needed with any required notices?

Hi all, From the list of modules to review I see: add "-notice.txt" if needed with any required notices a) What does "if needed" exactly mean? When is a notice file required? b) From [1], == DO NOT EDIT THIS FILE DIRECTLY. IT IS GENERATED == BY THE buildnotice TARGET

[GitHub] incubator-netbeans pull request #52: [NETBEANS-54] Module review xml modules

Github user junichi11 commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/52#discussion_r143345445 --- Diff: xml/src/org/netbeans/modules/xml/resources/templates/emptyXmlSchema.xsd.template --- @@ -1,4 +1,24 @@ +<#-- + +

[GitHub] incubator-netbeans pull request #52: [NETBEANS-54] Module review xml modules

Github user junichi11 commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/52#discussion_r143345452 --- Diff: xml/src/org/netbeans/modules/xml/resources/templates/xml_entity.ent.template --- @@ -1,4 +1,24 @@ +<#-- + +

[GitHub] incubator-netbeans pull request #52: [NETBEANS-54] Module review xml modules

Github user junichi11 commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/52#discussion_r143345425 --- Diff: xml/src/org/netbeans/modules/xml/resources/templates/emptyDTD.dtd.template --- @@ -1,4 +1,24 @@ +<#-- + +

[GitHub] incubator-netbeans pull request #52: [NETBEANS-54] Module review xml modules

Github user junichi11 commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/52#discussion_r143345436 --- Diff: xml/src/org/netbeans/modules/xml/resources/templates/emptyXML.xml.template --- @@ -1,4 +1,24 @@ +<#-- + +

[GitHub] incubator-netbeans pull request #52: [NETBEANS-54] Module review xml modules

Github user junichi11 commented on a diff in the pull request: https://github.com/apache/incubator-netbeans/pull/52#discussion_r143345448 --- Diff: xml/src/org/netbeans/modules/xml/resources/templates/xhtml.xml.template --- @@ -1,4 +1,24 @@ +<#-- + +Licensed

[GitHub] incubator-netbeans pull request #74: [NETBEANS-54] Module Review terminal

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/74 ---

[GitHub] incubator-netbeans pull request #68: [NETBEANS-54] Module Review project.lib...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/68 ---

[GitHub] incubator-netbeans pull request #67: [NETBEANS-54] Module Review team.common...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/67 ---

Re: [GitHub] incubator-netbeans issue #74: [NETBEANS-54] Module Review terminal

Hi, Thank you for your help! I'll do [1]. If other people prefer another choice, I'll fix it again. Junichi 2017-10-08 6:39 GMT+09:00 Craig Russell : > Hi, > > IMO, you could do any of these: > > 1. ship it with the # comment lines as it is now > 2. remove the # lines and

Re: [GitHub] incubator-netbeans issue #74: [NETBEANS-54] Module Review terminal

Hi, IMO, you could do any of these: 1. ship it with the # comment lines as it is now 2. remove the # lines and add the file to rat excludes (no significant ip here) 3. use the "short form" license header Whatever is easiest and most like treatment of other such files. Craig > On Oct 7, 2017,

[GitHub] incubator-netbeans pull request #63: [NETBEANS-54] Module Review csl.api

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/63 ---

[GitHub] incubator-netbeans issue #74: [NETBEANS-54] Module Review terminal

Github user junichi11 commented on the issue: https://github.com/apache/incubator-netbeans/pull/74 Yes, probably, "#" signs are not needed. I used them because I thought that the format should be unified. It is already used in o.n.swing.tabcontrol/readme.txt[1]. [1]

[GitHub] incubator-netbeans pull request #82: [NETBEANS-54] Module Review hibernate

GitHub user ikysil opened a pull request: https://github.com/apache/incubator-netbeans/pull/82 [NETBEANS-54] Module Review hibernate - external binary contains DTDs for Hibernate 3.0 configuration files - changed license headers for files reported by Rat - replacing the

[GitHub] incubator-netbeans pull request #81: [NETBEANS-54] Module Review libs.antlr4...

GitHub user vieiro opened a pull request: https://github.com/apache/incubator-netbeans/pull/81 [NETBEANS-54] Module Review libs.antlr4.runtime - Updated maven coordinates for antlr 4.5.3 (BSD) - No other problems found. You can merge this pull request into a Git repository

Questions on netbeans files

To all module reviewers: If you have questions/comments on a specific file, it will help me greatly if you include the git url to the file in question. That way, folks like me who are not immersed in the code can quickly see what you are talking about. With just the file name, it is just not

[GitHub] incubator-netbeans pull request #62: [NETBEANS-54] Module Review hibernate

Github user ikysil closed the pull request at: https://github.com/apache/incubator-netbeans/pull/62 ---

[GitHub] incubator-netbeans issue #62: [NETBEANS-54] Module Review hibernate

Github user ikysil commented on the issue: https://github.com/apache/incubator-netbeans/pull/62 It looks like this particular pull request is broken beyond reasonable repair due to mistakes which I did during synchronization with upstream. I will open a new PR. ---

[GitHub] incubator-netbeans issue #53: [NETBEANS-54] Module Review editor.codetemplat...

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/53 Could you please revisit the "some text xml files without header". If possible I'd add a license header, if not, I'd add an exclude to build.xml. ---

Re: Exclude .template files?

An user working for a corporation might not like to see an Apache copyright header after clicking on Open in Editor from Tools | Templates. Templates also seem to be pretty basic, so there's not much IP to expressly protect. --emi On Sat, Oct 7, 2017 at 8:54 PM, Matthias Bläsing

[GitHub] incubator-netbeans pull request #55: [NETBEANS-54] Module Review editor.comp...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/55 ---

[GitHub] incubator-netbeans pull request #56: [NETBEANS-54] Module Review editor.erro...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/56 ---

[GitHub] incubator-netbeans pull request #64: [NETBEANS-54] Module Review j2ee.core.u...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/64 ---

[GitHub] incubator-netbeans pull request #66: [NETBEANS-54] Module Review editor.sett...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/66 ---

[GitHub] incubator-netbeans pull request #80: [NETBEANS-54] Module Review libs.antlr3...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/80 ---

[GitHub] incubator-netbeans pull request #79: [NETBEANS-54] Module Review lexer.nbbri...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/79 ---

[GitHub] incubator-netbeans pull request #80: [NETBEANS-54] Module Review libs.antlr3...

GitHub user vieiro opened a pull request: https://github.com/apache/incubator-netbeans/pull/80 [NETBEANS-54] Module Review libs.antlr3.runtime * Updated external/binaries-list with Maven coordinates for antlr3 runtime (BSD) * No other problems found. You can merge this

Re: Exclude .template files?

Hey, Am Samstag, den 07.10.2017, 20:30 +0300 schrieb Emilian Bold: > Seems to me .template files are user-facing and code generators so > they should *not* have a license header, correct? > > See for yourself with Tools | Templates, then Open in Editor. depends - template files can be

Re: Non dual licensed file

Hey, Am Samstag, den 07.10.2017, 20:28 +0300 schrieb Emilian Bold: > How interesting > jshell.support/src/org/netbeans/modules/jshell/tool/Feedback.java is > GPL with Class Path Exception but not CDDL. the code was oracles to donate and they did. From my perspective it does not matter if the

Exclude .template files?

Seems to me .template files are user-facing and code generators so they should *not* have a license header, correct? See for yourself with Tools | Templates, then Open in Editor. --emi

[GitHub] incubator-netbeans pull request #79: [NETBEANS-54] Module Review lexer.nbbri...

GitHub user vieiro opened a pull request: https://github.com/apache/incubator-netbeans/pull/79 [NETBEANS-54] Module Review lexer.nbbridge - No external libraries. - One test failed: org.netbeans.modules.lexer.nbbridge.test.MimeLookupLanguageProv - Added license to a

Non dual licensed file

How interesting jshell.support/src/org/netbeans/modules/jshell/tool/Feedback.java is GPL with Class Path Exception but not CDDL. --emi

Re: Using #Hacktoberfest for the modules review

Yeah, it was bound to happen. --emi On Sat, Oct 7, 2017 at 8:06 PM, Geertjan Wielenga wrote: > Great, started doing that. Noticed that some of the license headers have > already been updated, i.e., by the recent update to the converter tool. > > Gj > > On Sat,

Re: Adding stuff to binaries-list

On 07/10/17 16:56, Antonio wrote: I don't know if any other NetBeans modules (Ruby?, HTML?, JavaScript?, etc.) use this ant task & xml to generate NetBeans lexers from their antlr grammars. I don't think any other modules use the "gen" subdirectory here to generate NetBeans lexer from

[GitHub] incubator-netbeans issue #42: [NETBEANS-54] Module Review editor

Github user vieiro commented on the issue: https://github.com/apache/incubator-netbeans/pull/42 Closing PR as requested. ---

[GitHub] incubator-netbeans pull request #42: [NETBEANS-54] Module Review editor

Github user vieiro closed the pull request at: https://github.com/apache/incubator-netbeans/pull/42 ---

[GitHub] incubator-netbeans issue #43: [NETBEANS-54] Module Review editor.bookmarks

Github user vieiro commented on the issue: https://github.com/apache/incubator-netbeans/pull/43 Closing PR as requested. ---

[GitHub] incubator-netbeans pull request #43: [NETBEANS-54] Module Review editor.book...

Github user vieiro closed the pull request at: https://github.com/apache/incubator-netbeans/pull/43 ---

Re: Using #Hacktoberfest for the modules review

Great, started doing that. Noticed that some of the license headers have already been updated, i.e., by the recent update to the converter tool. Gj On Sat, Oct 7, 2017 at 6:53 PM, Emilian Bold wrote: > You could also visit the PRs from >

Re: Using #Hacktoberfest for the modules review

You could also visit the PRs from https://github.com/emilianbold/incubator-netbeans/pulls and if you see one without any feedback comment on it. Some first-time committers make small errors so they need hints. --emi On Sat, Oct 7, 2017 at 7:48 PM, Geertjan Wielenga

Re: Using #Hacktoberfest for the modules review

Hope I can help, if there's a way to assign something to me, happy to get involved. Gj On Sat, Oct 7, 2017 at 6:36 PM, Emilian Bold wrote: > So, nobody wants to help with #Hacktoberfest? > > BTW, the reason I'm using my own repository is because there was not > clear

Re: Using #Hacktoberfest for the modules review

So, nobody wants to help with #Hacktoberfest? BTW, the reason I'm using my own repository is because there was not clear way how to make GitHub issues with labels for the Apache repository (which doesn't even have issues). But with my own repository, one short script and two hours later all the

[GitHub] incubator-netbeans issue #62: [NETBEANS-54] Module Review hibernate

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/62 Looks better, but you still introduce a change into HibernateRevengTemplate.xml. You add a XML prolog to the file, that was not there before. So could you please: -

[GitHub] incubator-netbeans issue #77: [NETBEANS-54] Module Review api.search

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/77 Done. ---

[GitHub] incubator-netbeans pull request #77: [NETBEANS-54] Module Review api.search

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/77 ---

[GitHub] incubator-netbeans pull request #75: [NETBEANS-54] Module Review api.templat...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/75 ---

[GitHub] incubator-netbeans pull request #76: [NETBEANS-54] Module Review api.visual

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/76 ---

[GitHub] incubator-netbeans pull request #78: [NETBEANS-54] Module Review autoupdate....

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/78 ---

[GitHub] incubator-netbeans issue #77: [NETBEANS-54] Module Review api.search

Github user geertjanw commented on the issue: https://github.com/apache/incubator-netbeans/pull/77 Hope someone can do the merges of my PRs, such as this one, haven't got that working yet. ---

Re: Adding stuff to binaries-list

On 07/10/17 15:32, Matthias Bläsing wrote: Hey, Am Samstag, den 07.10.2017, 14:16 +0200 schrieb Antonio Vieiro: I’m currently reviewing the lexer module. This depends either in “antlr" or "antlr-runtime” (I think it’s “antlr”), so I’ll need to add some stuff to the “external/binaries-list” and

[GitHub] incubator-netbeans pull request #45: [NETBEANS-54] Module Review masterfs.ui

Github user rtaneja1 closed the pull request at: https://github.com/apache/incubator-netbeans/pull/45 ---

[GitHub] incubator-netbeans issue #64: [NETBEANS-54] Module Review j2ee.core.utilitie...

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/64 Looks good. ---

[GitHub] incubator-netbeans pull request #78: [NETBEANS-54] Module Review autoupdate....

GitHub user geertjanw opened a pull request: https://github.com/apache/incubator-netbeans/pull/78 [NETBEANS-54] Module Review autoupdate.services You can merge this pull request into a Git repository by running: $ git pull https://github.com/geertjanw/incubator-netbeans

[GitHub] incubator-netbeans issue #77: [NETBEANS-54] Module Review api.search

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/77 The changes look to only touch files, that I would have seen under "central problems". The change itself looks good though. ---

Re: Adding stuff to binaries-list

Hey, Am Samstag, den 07.10.2017, 14:16 +0200 schrieb Antonio Vieiro: > I’m currently reviewing the lexer module. This depends either in > “antlr" or "antlr-runtime” (I think it’s “antlr”), so I’ll need to > add some stuff to the “external/binaries-list” and the proper antlr > license as well (as

[GitHub] incubator-netbeans pull request #77: [NETBEANS-54] Module Review api.search

GitHub user geertjanw opened a pull request: https://github.com/apache/incubator-netbeans/pull/77 [NETBEANS-54] Module Review api.search You can merge this pull request into a Git repository by running: $ git pull https://github.com/geertjanw/incubator-netbeans

Re: Two module reviews in one PR

OK, think I got it now. https://github.com/apache/incubator-netbeans/pull/75 https://github.com/apache/incubator-netbeans/pull/76 I now have a fork with a branch for the two modules I am reviewing, enabling me to do a PR per module that I have reviewed. Hope this is the right way to go. Any

[GitHub] incubator-netbeans issue #75: [NETBEANS-54] Module Review api.templates

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/75 Looks good. ---

[GitHub] incubator-netbeans issue #76: [NETBEANS-54] Module Review api.visual

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/76 Looks good. ---

[GitHub] incubator-netbeans pull request #76: [NETBEANS-54] Module Review api.visual

GitHub user geertjanw opened a pull request: https://github.com/apache/incubator-netbeans/pull/76 [NETBEANS-54] Module Review api.visual You can merge this pull request into a Git repository by running: $ git pull https://github.com/geertjanw/incubator-netbeans

[GitHub] incubator-netbeans issue #5: [NETBEANS-54] Module Review db.core

Github user matthiasblaesing commented on the issue: https://github.com/apache/incubator-netbeans/pull/5 This PR was created nearly two weeks ago - I'll merge this tomorrow, if no one issues a veto. ---

[GitHub] incubator-netbeans pull request #75: [NETBEANS-54] Module Review api.templat...

GitHub user geertjanw opened a pull request: https://github.com/apache/incubator-netbeans/pull/75 [NETBEANS-54] Module Review api.templates You can merge this pull request into a Git repository by running: $ git pull https://github.com/geertjanw/incubator-netbeans

[GitHub] incubator-netbeans pull request #74: [NETBEANS-54] Module Review terminal

GitHub user junichi11 opened a pull request: https://github.com/apache/incubator-netbeans/pull/74 [NETBEANS-54] Module Review terminal - no external library - checked Rat report: add the license header in README.*. ignore manifest.mf - skimmed through the module, did not

Adding stuff to binaries-list

Hi all, I’m currently reviewing the lexer module. This depends either in “antlr" or "antlr-runtime” (I think it’s “antlr”), so I’ll need to add some stuff to the “external/binaries-list” and the proper antlr license as well (as in [1]). But I have some questions: a) How do I know what the

[GitHub] incubator-netbeans issue #45: [NETBEANS-54] Module Review masterfs.ui

Github user junichi11 commented on the issue: https://github.com/apache/incubator-netbeans/pull/45 Merged in 215043377068868481619d203e0312131294206b. @rtaneja1 Do you mind closing this PR? Thanks! ---

[GitHub] incubator-netbeans pull request #36: [NETBEANS-54] Module Review api.xml

Github user asfgit closed the pull request at: https://github.com/apache/incubator-netbeans/pull/36 ---

[GitHub] incubator-netbeans issue #43: [NETBEANS-54] Module Review editor.bookmarks

Github user junichi11 commented on the issue: https://github.com/apache/incubator-netbeans/pull/43 Merged in 9117c00eabdabc179ccb4055044fcbb2ab40039a. @vieiro Do you mind closing this PR? Thanks! ---

Re: Problems to be solved centrally should be excluded temporarily from rat

Agreed. Gj On Sat, 7 Oct 2017 at 10:10, Emilian Bold wrote: > Hello, > > It makes no sense for everybody to skip the files from "Problems to be > solved centrally". > > We should add exclude rules for all the files and people should focus > on everything else. > > Then,

[GitHub] incubator-netbeans issue #42: [NETBEANS-54] Module Review editor

Github user junichi11 commented on the issue: https://github.com/apache/incubator-netbeans/pull/42 Merged in 215acff0f9714513987031fae8bf329b0514789c. @vieiro Do you mind closing this PR? ---

Re: Two module reviews in one PR

Do the names of those branches make sense? My plan is to push from my local git clone of my fork into those two branches for the license header changes for the api.visual and api.templates modules. Does that make sense? If so, will make a short screencast of this for others, if this is the

Re: Two module reviews in one PR

Thanks. Gj On Sat, Oct 7, 2017 at 11:45 AM, Cezariusz Marek wrote: > Use "git branch -r" (or -rv) to see remote branches. > > -- > Cezariusz Marek > > > -Original Message- > From: Geertjan Wielenga [mailto:geertjan.wiele...@googlemail.com] > Sent: Saturday,

RE: Two module reviews in one PR

Use "git branch -r" (or -rv) to see remote branches. -- Cezariusz Marek -Original Message- From: Geertjan Wielenga [mailto:geertjan.wiele...@googlemail.com] Sent: Saturday, October 7, 2017 11:22 AM To: dev@netbeans.incubator.apache.org Subject: Re: Two module reviews in one PR I've

Re: Two module reviews in one PR

I've created two branches via the UI on GitHub: https://github.com/geertjanw/incubator-netbeans/branches How do I see them when I do 'git branch -v' or am I doing something wrong? Gj On Fri, Oct 6, 2017 at 11:07 PM, Matthias Bläsing wrote: > Hey Geertjan, > > Am

Re: javahelp: DTDs copyright 2001 Sun Microsystems

Anything copyrighted to Oracle or Sun has been donated by Oracle to Apache. Gj On Sat, Oct 7, 2017 at 10:49 AM, Emilian Bold wrote: > Are these files donated: > > javahelp/src/org/netbeans/modules/javahelp/resources/favorites_2_0.dtd >

javahelp: DTDs copyright 2001 Sun Microsystems

Are these files donated: javahelp/src/org/netbeans/modules/javahelp/resources/favorites_2_0.dtd javahelp/src/org/netbeans/modules/javahelp/resources/helpset_1_0.dtd javahelp/src/org/netbeans/modules/javahelp/resources/helpset_2_0.dtd

Re: Portions Copyrighted 2007-2008 Stefan Riha, Roland Poppenreiter

Hi, Am Samstag, den 07.10.2017, 09:29 +0300 schrieb Emilian Bold: > spellchecker.bindings.properties/src/org/netbeans/modules/spellchecke > r/bindings/properties/PropertiesTokenListProvider.java I would override the copyright and replace it with the ALv2: * If Oracle and Sun both followed the

Problems to be solved centrally should be excluded temporarily from rat

Hello, It makes no sense for everybody to skip the files from "Problems to be solved centrally". We should add exclude rules for all the files and people should focus on everything else. Then, as we go through the 'Problems to be solved centrally' and make a global decision we remove the

[GitHub] incubator-netbeans issue #73: [NETBEANS-54] Module Review profiler.j2se

Github user varaghar commented on the issue: https://github.com/apache/incubator-netbeans/pull/73 Thank you for the response, I will update this. ---

Re: terminal/README.attributes and terminal/README.close_semantics

I appreciate your notification :) Junichi 2017-10-07 16:24 GMT+09:00 Emilian Bold : > I'm fine with either way. I was just wondering... > > --emi > > > On Sat, Oct 7, 2017 at 10:06 AM, Junichi Yamamoto > wrote: >> I see. I add the same one because

Re: terminal/README.attributes and terminal/README.close_semantics

I'm fine with either way. I was just wondering... --emi On Sat, Oct 7, 2017 at 10:06 AM, Junichi Yamamoto wrote: > I see. I add the same one because it is already used in > o.n.swing.tabcontrol.readme.txt. > > Thanks, > Junichi > > 2017-10-07 15:13 GMT+09:00 Emilian Bold

Re: terminal/README.attributes and terminal/README.close_semantics

I see. I add the same one because it is already used in o.n.swing.tabcontrol.readme.txt. Thanks, Junichi 2017-10-07 15:13 GMT+09:00 Emilian Bold : > That looks good enough. Not sure how the license header is supposed to > look in .txt files. I mean, we don't have to

Re: NetBeans Mentoring/Training Suggestion

This seems like something that could automated based on git blame and perhaps some bugzilla history. Of course, some people have left Oracle, are busy with their current jobs / life so there won't be much re-engaging. --emi On Fri, Oct 6, 2017 at 5:49 PM, Ryan Cuprak wrote:

Portions Copyrighted 2007-2008 Stefan Riha, Roland Poppenreiter

spellchecker.bindings.properties/src/org/netbeans/modules/spellchecker/bindings/properties/PropertiesTokenListProvider.java --emi

Re: terminal/README.attributes and terminal/README.close_semantics

That looks good enough. Not sure how the license header is supposed to look in .txt files. I mean, we don't have to comment them in any way. --emi On Sat, Oct 7, 2017 at 2:00 AM, Junichi Yamamoto wrote: > Hi Emilian, > > OK. I agree with you. > Can we add the same