[GitHub] JaroslavTulach commented on issue #248: adding crlf characters for the failing tests in api.templates

2017-11-07 Thread GitBox
JaroslavTulach commented on issue #248: adding crlf characters for the failing tests in api.templates URL: https://github.com/apache/incubator-netbeans/pull/248#issuecomment-342734078 There are two jobs running (some of) our tests:

[GitHub] JaroslavTulach commented on issue #248: adding crlf characters for the failing tests in api.templates

2017-11-07 Thread GitBox
JaroslavTulach commented on issue #248: adding crlf characters for the failing tests in api.templates URL: https://github.com/apache/incubator-netbeans/pull/248#issuecomment-342734078 There are two jobs running (some of) our tests:

[GitHub] jlahoda commented on issue #252: wip attempt to get ignore from .gitgnore

2017-11-07 Thread GitBox
jlahoda commented on issue #252: wip attempt to get ignore from .gitgnore URL: https://github.com/apache/incubator-netbeans/pull/252#issuecomment-342730748 Seems good to me. I was thinking of introducing a new fileset(/patternset) that would set-up itself from .gitignore, but this is good

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Jan Lahoda
Hi Ate, Thanks a lot for your review and comments. On Wed, Nov 8, 2017 at 12:04 AM, Ate Douma wrote: > I get a different build error: > > BUILD FAILED > /home/ate/tmp/netbeans/netbeans-platform-source-platform-9.0-alpha/nbbuild/build.xml:122: > Download of >

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Vadiraj Deshpande
+1 On 2017-11-07 05:17, Geertjan Wielenga wrote: > Hi all,> > > Please vote on releasing Apache NetBeans 9.0 Alpha (incubating)! If this> > voting passes, another similar voting will be started on> > gene...@incubator.apache.org, and if that passes too, then we can release> > this

[GitHub] sarveshkesharwani commented on issue #248: adding crlf characters for the failing tests in api.templates

2017-11-07 Thread GitBox
sarveshkesharwani commented on issue #248: adding crlf characters for the failing tests in api.templates URL: https://github.com/apache/incubator-netbeans/pull/248#issuecomment-342718911 @jlahoda Thank you. That's really a great idea. @junichi11 Fixed. Thanks a lot for the review.

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Ricardo Pacheco
+1 El nov. 7, 2017 6:28 PM, "Attila Kelemen" escribió: +1 (binding) 2017-11-07 11:17 GMT+01:00 Geertjan Wielenga < geertjan.wiele...@googlemail.com>: > Hi all, > > Please vote on releasing Apache NetBeans 9.0 Alpha (incubating)! If this > voting passes, another

Re: Introduction - Desmond from SA

2017-11-07 Thread Hermien Pellissier
Hi Desmond, It is always good to meet fellow South Africans in the NetBeans community! Welcome! This is the right mailing list if you want to stay in touch with the development of Apache NetBeans. :) ~ Hermien On Tue, Nov 7, 2017 at 5:48 PM, Desmond Nysschens wrote: > Hey

[GitHub] junichi11 commented on issue #248: adding crlf characters for the failing tests in api.templates

2017-11-07 Thread GitBox
junichi11 commented on issue #248: adding crlf characters for the failing tests in api.templates URL: https://github.com/apache/incubator-netbeans/pull/248#issuecomment-342699249 > Were the tests in SCFTHandlerTest.java passing before in linux? (without these crlf changes) Yes,

[GitHub] junichi11 opened a new pull request #255: [NETBEANS-54] Module Review api.templates

2017-11-07 Thread GitBox
junichi11 opened a new pull request #255: [NETBEANS-54] Module Review api.templates URL: https://github.com/apache/incubator-netbeans/pull/255 - Remove the license header from utf8.xml because unit tests fail. - Exclude utf8.xml from rat.

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Attila Kelemen
+1 (binding) 2017-11-07 11:17 GMT+01:00 Geertjan Wielenga < geertjan.wiele...@googlemail.com>: > Hi all, > > Please vote on releasing Apache NetBeans 9.0 Alpha (incubating)! If this > voting passes, another similar voting will be started on > gene...@incubator.apache.org, and if that passes too,

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Ate Douma
I get a different build error: BUILD FAILED /home/ate/tmp/netbeans/netbeans-platform-source-platform-9.0-alpha/nbbuild/build.xml:122: Download of 276009D3F0A27079A80D241C3183EC712305A42A-net.java.html.boot.script-1.5.jar produced content with hash 5DE9DD70EDCD9B30E0671ACC813F6F0C80E951AA when

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Geertjan Wielenga
Great. And, what were you doing wrong? Gj On Tue, Nov 7, 2017 at 10:18 PM, John McDonnell wrote: > Looked at the README from the git repo saw what I was doing wrong. > > > So happy to give this a: > +1 (non binding) > > > > On 7 November 2017 at 20:36, Jiří Kovalský

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Geertjan Wielenga
Ah, probably left out the -Dcluster.config=platform bit. Thanks, Gj On Tue, Nov 7, 2017 at 11:47 PM, Geertjan Wielenga < geertjan.wiele...@googlemail.com> wrote: > Great. And, what were you doing wrong? > > Gj > > On Tue, Nov 7, 2017 at 10:18 PM, John McDonnell >

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Junichi Yamamoto
+1 (binding) Regards, Junichi 2017-11-07 19:17 GMT+09:00 Geertjan Wielenga : > Hi all, > > Please vote on releasing Apache NetBeans 9.0 Alpha (incubating)! If this > voting passes, another similar voting will be started on > gene...@incubator.apache.org, and if

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread John McDonnell
Looked at the README from the git repo saw what I was doing wrong. So happy to give this a: +1 (non binding) On 7 November 2017 at 20:36, Jiří Kovalský wrote: > +1 (binding) > > Let's speed up the Alpha and Beta releases as much as possible. > > -Jirka > > Dne

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Joerg Michelberger
+1 Joerg

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread John McDonnell
I want to vote yes, but should the sources be buildable? If I execute ant the build fails? $ ant ... [insert-module-all-targets] This module is missing from checkout: maven.apisupport - at least can't find:

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Joerg Michelberger
+1 Joerg

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Jiří Kovalský
+1 (binding) Let's speed up the Alpha and Beta releases as much as possible. -Jirka Dne 7.11.2017 v 19:10 Emilian Bold napsal(a): +1 (binding) Minor remarks: DEPENDENCIES lists stuff from another NetBeans repository. I don't believe we should list our own code as dependency. LICENSE

[GitHub] matthiasblaesing commented on a change in pull request #161: [NETBEANS-96] New PAC Script evaluation environment

2017-11-07 Thread GitBox
matthiasblaesing commented on a change in pull request #161: [NETBEANS-96] New PAC Script evaluation environment URL: https://github.com/apache/incubator-netbeans/pull/161#discussion_r149484109 ## File path: core.network/src/org/netbeans/core/network/utils/HostnameUtils.java

[GitHub] matthiasblaesing commented on a change in pull request #161: [NETBEANS-96] New PAC Script evaluation environment

2017-11-07 Thread GitBox
matthiasblaesing commented on a change in pull request #161: [NETBEANS-96] New PAC Script evaluation environment URL: https://github.com/apache/incubator-netbeans/pull/161#discussion_r149480116 ## File path: core.network/src/org/netbeans/core/network/utils/IpAddressUtils.java

[GitHub] matthiasblaesing commented on a change in pull request #161: [NETBEANS-96] New PAC Script evaluation environment

2017-11-07 Thread GitBox
matthiasblaesing commented on a change in pull request #161: [NETBEANS-96] New PAC Script evaluation environment URL: https://github.com/apache/incubator-netbeans/pull/161#discussion_r149477926 ## File path:

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Benny Neugebauer
+1 But the link to the artifact is broken. It should be: https://builds.apache.org/view/Incubator%20Projects/job/incubator-netbeans-release/lastSuccessfulBuild/artifact/dist/netbeans-platform-source-platform-9.0-alpha.zip On 2017-11-07 11:17, Geertjan Wielenga wrote: > Hi

YouTube: Apache NetBeans (incubating) at Devoxx 2017

2017-11-07 Thread Geertjan Wielenga
https://www.youtube.com/watch?v=n9uKRYGfTd8 At the above location, from about -54 minutes to the end (i.e., at the end of the steam), you'll see a short presentation given this evening about Apache NetBeans at Devoxx in Belgium -- by several people -- me, Sven, Kirk, Johan, including Ate (one of

[GitHub] matthiasblaesing commented on issue #234: [NETBEANS-68] Remove SwingX dependency

2017-11-07 Thread GitBox
matthiasblaesing commented on issue #234: [NETBEANS-68] Remove SwingX dependency URL: https://github.com/apache/incubator-netbeans/pull/234#issuecomment-342584013 @bolsover Thank you for looking into this David. I created a fix and added that as PR #254. When this run through the

[GitHub] matthiasblaesing opened a new pull request #254: [NETBEANS-68] Fix NULL handling after fix in 1d362fa77521762a9af99792620414086b868f76

2017-11-07 Thread GitBox
matthiasblaesing opened a new pull request #254: [NETBEANS-68] Fix NULL handling after fix in 1d362fa77521762a9af99792620414086b868f76 URL: https://github.com/apache/incubator-netbeans/pull/254 There are two issues: - the BooleanCellRenderer used in the ResultSetJXTable should not

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Emilian Bold
+1 (binding) Minor remarks: DEPENDENCIES lists stuff from another NetBeans repository. I don't believe we should list our own code as dependency. LICENSE file. A bit odd how the Apache license is shown in a code block, but nothing wrong with it. Not sure why we ship jemmy (and the jemmy src

[GitHub] dtrebbien opened a new pull request #253: Extend the SizeEqualsZero Java hint to look for Yoda conditions

2017-11-07 Thread GitBox
dtrebbien opened a new pull request #253: Extend the SizeEqualsZero Java hint to look for Yoda conditions URL: https://github.com/apache/incubator-netbeans/pull/253 This is an automated message from the Apache Git Service.

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Anton Epple
+1 Am 07.11.17, 11:17 schrieb "Geertjan Wielenga" : Hi all, Please vote on releasing Apache NetBeans 9.0 Alpha (incubating)! If this voting passes, another similar voting will be started on gene...@incubator.apache.org, and if that passes

Re: [RESULT]: [VOTE] Release 1.5 of NetBeans HTML/Java API

2017-11-07 Thread Bertrand Delacretaz
On Mon, Nov 6, 2017 at 4:54 PM, Jaroslav Tulach wrote: > ...Does it still make sense to do official release of > version 1.5 or can we skip that?... IIUC the only thing left is to move that release under /dist/release/incubator/netbeans - I think you should do it to

RE: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Eric Barboni
Hi, +1 (non-binding) Eric -Message d'origine- De : Geertjan Wielenga [mailto:geertjan.wiele...@googlemail.com] Envoyé : mardi 7 novembre 2017 11:18 À : dev@netbeans.incubator.apache.org Objet : [VOTE] Release Apache NetBeans 9.0 Alpha (incubating) Hi all, Please vote on releasing

RE: Rat discrepancy

2017-11-07 Thread Eric Barboni
Hi Jan Opened this PR https://github.com/apache/incubator-netbeans/pull/252 . Instead of trying to map git ignore to incomplete ant patterset, I prefer to use the git tools itself. @Lars, nice but I was puzzled because result were different with PR161 not merged Regards Eric -Message

Introduction - Desmond from SA

2017-11-07 Thread Desmond Nysschens
Hey guys, Web site says to introduce me self. I am a PHP’er and been dev’ing with Netbeans for more than 15 years. Currently I am coding Laravel / Symfony stuff and thought I might keep abreast with the Netbeans hand-over to Apache , if I may. Please advise where / how to subscribe to your

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Leonardo Loch Zanivan
+1 (binding) -- Atenciosamente, Leonardo Loch Zanivan On Tue, Nov 7, 2017 at 8:17 AM, Geertjan Wielenga < geertjan.wiele...@googlemail.com> wrote: > Hi all, > > Please vote on releasing Apache NetBeans 9.0 Alpha (incubating)! If this > voting passes, another similar voting will be started on >

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Geertjan Wielenga
Understand and sympathize with that perspective. Note though that that solution also has the potential of someone getting the wrong impression. Each approach to this is potenially confusing. Gj On Tue, 7 Nov 2017 at 16:28, Neil C Smith wrote: > +1 (binding) > > Almost

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Neil C Smith
+1 (binding) Almost put 0. I'm only unsure on the subject line - surely we should be saying Apache NetBeans Platform 9.0 alpha? Just wary of anyone (away from here) getting the wrong impression that this is the first alpha for the IDE. Best wishes, Neil -- Neil C Smith Artist & Technologist

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Tushar Joshi
+1 Release this package as Apache NetBeans 9.0 Alpha (incubating) (binding) with regards Tushar

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Petr Pisl
+1 for Apache NetBeans 9.0 Alpha. Petr On 7.11.2017 11:17, Geertjan Wielenga wrote: Hi all, Please vote on releasing Apache NetBeans 9.0 Alpha (incubating)! If this voting passes, another similar voting will be started on gene...@incubator.apache.org, and if that passes too, then we can

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread ghader.ark...@gmail.com
+1 yes

[GitHub] ebarboni opened a new pull request #252: wip attempt to get ignore from .gitgnore

2017-11-07 Thread GitBox
ebarboni opened a new pull request #252: wip attempt to get ignore from .gitgnore URL: https://github.com/apache/incubator-netbeans/pull/252 ant task to build patternset from gitignore file. Try to reduce false positive.

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread David Heffelfinger
+1 -- http://ensode.net - A Guide to Java, Linux and Other Technology Topics My Books: http://www.packtpub.com/authors/profiles/david-heffelfinger My Video Training: http://www.packtpub.com/java-ee-development-with-netbeans-7/video Follow me on Twitter: https://twitter.com/ensode On Nov 7,

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Andreas Ernst
+1 (non-binding) Am 07.11.17 um 11:17 schrieb Geertjan Wielenga: Hi all, Please vote on releasing Apache NetBeans 9.0 Alpha (incubating)! If this voting passes, another similar voting will be started on gene...@incubator.apache.org, and if that passes too, then we can release this version.

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Lars Bruun-Hansen
+1 Remark: NOTICE file looks as if it could use some more line breaks. JUnit notice is duplicated. Perhaps NOTICE file was handcrafted for this release? Lars On Tue, Nov 7, 2017 at 1:36 PM, Sven Reimers wrote: > +1 > > Sven > > On Tue, Nov 7, 2017 at 1:28 PM, Josh

[GitHub] jlahoda commented on issue #248: adding crlf characters for the failing tests in api.templates

2017-11-07 Thread GitBox
jlahoda commented on issue #248: adding crlf characters for the failing tests in api.templates URL: https://github.com/apache/incubator-netbeans/pull/248#issuecomment-342469201 My personal opinion: ideally tests should pass/work on both Linux and Windows. Instead of playing with

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Josh Juneau
+1 on the release. Josh Juneau juneau...@gmail.com http://jj-blogger.blogspot.com https://www.apress.com/index.php/author/author/view/id/1866 On Tue, Nov 7, 2017 at 4:17 AM, Geertjan Wielenga < geertjan.wiele...@googlemail.com> wrote: > Hi all, > > Please vote on releasing Apache NetBeans 9.0

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Timon Veenstra
+1 On Tue, Nov 7, 2017 at 1:23 PM, Jan Lahoda wrote: > Hi Michael, > > I think that's right. I've re-run the job, specifying the version. The > updated artefacts are: > source: > https://builds.apache.org/view/Incubator%20Projects/job/ >

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Jan Lahoda
Hi Michael, I think that's right. I've re-run the job, specifying the version. The updated artefacts are: source: https://builds.apache.org/view/Incubator%20Projects/job/incubator-netbeans-release/lastSuccessfulBuild/artifact/dist/netbeans-platform-source-platform-9.0-alpha.zip MD5:

AW: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Christian Lenz
+1 do it. Gesendet von Mail für Windows 10 Von: Vikas Prabhakar Gesendet: Dienstag, 7. November 2017 13:17 An: dev@netbeans.incubator.apache.org Betreff: Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating) +1 Please release the package. On 11/7/2017 3:47 PM, Geertjan Wielenga wrote: >

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Michael Nascimento
I guess it won't affect the signature, so +1 (binding). Regards, Michael On Tue, Nov 7, 2017 at 8:38 AM, Geertjan Wielenga wrote: > Good point, I don't know, though it can certainly be done. > > Gj > > On Tue, Nov 7, 2017 at 11:36 AM, Michael Nascimento

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Sarvesh Kesharwani
+1 Sarvesh Kesharwani On 11/7/2017 5:41 PM, Martin Balin wrote: +1 Release this package as Apache NetBeans 9.0 Alpha (incubating) Martin Balin On 7.11.2017 11:17, Geertjan Wielenga wrote: Hi all, Please vote on releasing Apache NetBeans 9.0 Alpha (incubating)! If this voting passes,

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Martin Balin
+1 Release this package as Apache NetBeans 9.0 Alpha (incubating) Martin Balin On 7.11.2017 11:17, Geertjan Wielenga wrote: Hi all, Please vote on releasing Apache NetBeans 9.0 Alpha (incubating)! If this voting passes, another similar voting will be started on gene...@incubator.apache.org,

[GitHub] lbruun opened a new pull request #251: [NETBEANS-126] Re-instate browser icons

2017-11-07 Thread GitBox
lbruun opened a new pull request #251: [NETBEANS-126] Re-instate browser icons URL: https://github.com/apache/incubator-netbeans/pull/251 Reinstates those browser icons that were originally removed from Oracle's donation to Apache. See

[GitHub] lbruun commented on issue #161: [NETBEANS-96] New PAC Script evaluation environment

2017-11-07 Thread GitBox
lbruun commented on issue #161: [NETBEANS-96] New PAC Script evaluation environment URL: https://github.com/apache/incubator-netbeans/pull/161#issuecomment-341973053 Unit tests fixed. - The `timeRange()` test failed because it did `assertTrue(timeRange(0, 23))`, and since you did

Re: Rat discrepancy

2017-11-07 Thread Lars Bruun-Hansen
Wouldn't know why you see what you see, but FYI this file is removed by PR 161 https://github.com/apache/incubator-netbeans/pull/161 .. but as this PR is not yet merged I cannot explain what you see. I hope it won't be long before PR161 is merged and then this file is history. On Tue, Nov 7,

[GitHub] bolsover commented on issue #234: [NETBEANS-68] Remove SwingX dependency

2017-11-07 Thread GitBox
bolsover commented on issue #234: [NETBEANS-68] Remove SwingX dependency URL: https://github.com/apache/incubator-netbeans/pull/234#issuecomment-342447166 Excellent work but BooleanCellRenderer this a null pointer exception if database value is null rather than 0 or 1. Sorry for lack of

Re: [VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Michael Nascimento
Geertjan, Shouldn't the artifact names end with 9.0-alpha? Regards, Michael On Tue, Nov 7, 2017 at 8:17 AM, Geertjan Wielenga wrote: > Hi all, > > Please vote on releasing Apache NetBeans 9.0 Alpha (incubating)! If this > voting passes, another similar voting

[VOTE] Release Apache NetBeans 9.0 Alpha (incubating)

2017-11-07 Thread Geertjan Wielenga
Hi all, Please vote on releasing Apache NetBeans 9.0 Alpha (incubating)! If this voting passes, another similar voting will be started on gene...@incubator.apache.org, and if that passes too, then we can release this version. Apache NetBeans 9.0 Alpha (incubating) are the modules of Apache

[GitHub] lbruun commented on issue #1: Updated Java Doc with better description and examples of presenters, ?

2017-11-07 Thread GitBox
lbruun commented on issue #1: Updated Java Doc with better description and examples of presenters, ? URL: https://github.com/apache/incubator-netbeans-html4j/pull/1#issuecomment-342414646 Valid XHTML definitely not wrong. I guess it is a matter of religion. I tend to agree with

[GitHub] JaroslavTulach closed pull request #1: Updated Java Doc with better description and examples of presenters, ?

2017-11-07 Thread GitBox
JaroslavTulach closed pull request #1: Updated Java Doc with better description and examples of presenters, ? URL: https://github.com/apache/incubator-netbeans-html4j/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below