[GitHub] vieiro opened a new pull request #326: Verify libs and licenses - duplicated binaries

2017-12-13 Thread GitBox
vieiro opened a new pull request #326: Verify libs and licenses - duplicated binaries URL: https://github.com/apache/incubator-netbeans/pull/326 Added some entries to "ignored-overlaps" - javacc-3.2 (used at compile time in db.sql.visualeditor) - commons-lang-2.6 (used by

[GitHub] geertjanw closed pull request #326: Verify libs and licenses - duplicated binaries

2017-12-13 Thread GitBox
geertjanw closed pull request #326: Verify libs and licenses - duplicated binaries URL: https://github.com/apache/incubator-netbeans/pull/326 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] junichi11 commented on issue #296: #269262 - [Regression] The editor screen is not scrolled with a keyboard after Japanese strings are input using IME

2017-12-18 Thread GitBox
junichi11 commented on issue #296: #269262 - [Regression] The editor screen is not scrolled with a keyboard after Japanese strings are input using IME URL: https://github.com/apache/incubator-netbeans/pull/296#issuecomment-352642343 Hi @vieiro , Currently, I don't use this patch.

[GitHub] vieiro commented on issue #296: #269262 - [Regression] The editor screen is not scrolled with a keyboard after Japanese strings are input using IME

2017-12-18 Thread GitBox
vieiro commented on issue #296: #269262 - [Regression] The editor screen is not scrolled with a keyboard after Japanese strings are input using IME URL: https://github.com/apache/incubator-netbeans/pull/296#issuecomment-352645761 Hi @junichi11 @matthiasblaesing Users have been using

[GitHub] geertjanw closed pull request #296: #269262 - [Regression] The editor screen is not scrolled with a keyboard after Japanese strings are input using IME

2017-12-19 Thread GitBox
geertjanw closed pull request #296: #269262 - [Regression] The editor screen is not scrolled with a keyboard after Japanese strings are input using IME URL: https://github.com/apache/incubator-netbeans/pull/296 This is a PR merged from a forked repository. As GitHub hides the original

[GitHub] geertjanw commented on issue #296: #269262 - [Regression] The editor screen is not scrolled with a keyboard after Japanese strings are input using IME

2017-12-19 Thread GitBox
geertjanw commented on issue #296: #269262 - [Regression] The editor screen is not scrolled with a keyboard after Japanese strings are input using IME URL: https://github.com/apache/incubator-netbeans/pull/296#issuecomment-352689719 OK, merging.

[GitHub] JaroslavTulach commented on a change in pull request #332: Updated references to osgi.cmpn-4.2.jar in project files, followup to NETBEANS-105

2017-12-19 Thread GitBox
JaroslavTulach commented on a change in pull request #332: Updated references to osgi.cmpn-4.2.jar in project files, followup to NETBEANS-105 URL: https://github.com/apache/incubator-netbeans/pull/332#discussion_r157706655 ## File path: libs.osgi/nbproject/project.properties

[GitHub] geertjanw closed pull request #332: Updated references to osgi.cmpn-4.2.jar in project files, followup to NETBEANS-105

2017-12-19 Thread GitBox
geertjanw closed pull request #332: Updated references to osgi.cmpn-4.2.jar in project files, followup to NETBEANS-105 URL: https://github.com/apache/incubator-netbeans/pull/332 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[GitHub] geertjanw commented on issue #332: Updated references to osgi.cmpn-4.2.jar in project files, followup to NETBEANS-105

2017-12-19 Thread GitBox
geertjanw commented on issue #332: Updated references to osgi.cmpn-4.2.jar in project files, followup to NETBEANS-105 URL: https://github.com/apache/incubator-netbeans/pull/332#issuecomment-352712416 OK, so this is good to be merged, merging now.

[GitHub] vieiro opened a new pull request #327: NOTICE file

2017-12-17 Thread GitBox
vieiro opened a new pull request #327: NOTICE file URL: https://github.com/apache/incubator-netbeans/pull/327 - Added some missing notice files for some modules. - Updated nbbuild/notice-stub.txt "preamble" to acknowledge previous copyright notices in the codebase. - Updated

[GitHub] vieiro commented on a change in pull request #327: NOTICE file

2017-12-17 Thread GitBox
vieiro commented on a change in pull request #327: NOTICE file URL: https://github.com/apache/incubator-netbeans/pull/327#discussion_r157376927 ## File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/CreateNoticeFile.java ## @@ -0,0 +1,216 @@ +/* + * Licensed to the

[GitHub] vieiro commented on a change in pull request #327: NOTICE file

2017-12-17 Thread GitBox
vieiro commented on a change in pull request #327: NOTICE file URL: https://github.com/apache/incubator-netbeans/pull/327#discussion_r157377886 ## File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/CreateNoticeFile.java ## @@ -0,0 +1,216 @@ +/* + * Licensed to the

[GitHub] vieiro opened a new pull request #328: Missing dependency in libs.bytelist

2017-12-17 Thread GitBox
vieiro opened a new pull request #328: Missing dependency in libs.bytelist URL: https://github.com/apache/incubator-netbeans/pull/328 This solves issue #216 https://issues.apache.org/jira/browse/NETBEANS-216 We recently upgraded libs.bytelist to bytelist v1.0.15 due to unclear

[GitHub] vieiro commented on a change in pull request #327: NOTICE file

2017-12-17 Thread GitBox
vieiro commented on a change in pull request #327: NOTICE file URL: https://github.com/apache/incubator-netbeans/pull/327#discussion_r157383221 ## File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/CreateNoticeFile.java ## @@ -0,0 +1,216 @@ +/* + * Licensed to the

[GitHub] jlahoda commented on a change in pull request #327: NOTICE file

2017-12-17 Thread GitBox
jlahoda commented on a change in pull request #327: NOTICE file URL: https://github.com/apache/incubator-netbeans/pull/327#discussion_r157376403 ## File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/CreateNoticeFile.java ## @@ -0,0 +1,216 @@ +/* + * Licensed to the

[GitHub] jlahoda commented on a change in pull request #327: NOTICE file

2017-12-17 Thread GitBox
jlahoda commented on a change in pull request #327: NOTICE file URL: https://github.com/apache/incubator-netbeans/pull/327#discussion_r157376673 ## File path: nbbuild/antsrc/org/netbeans/nbbuild/extlibs/CreateNoticeFile.java ## @@ -0,0 +1,216 @@ +/* + * Licensed to the

[GitHub] vieiro closed pull request #324: verify-libs-and-licenses 5a / 5b

2017-12-12 Thread GitBox
vieiro closed pull request #324: verify-libs-and-licenses 5a / 5b URL: https://github.com/apache/incubator-netbeans/pull/324 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] lbruun opened a new pull request #275: [NETBEANS-144] Changes to About Dialog and Lic Accept wnd

2017-11-16 Thread GitBox
lbruun opened a new pull request #275: [NETBEANS-144] Changes to About Dialog and Lic Accept wnd URL: https://github.com/apache/incubator-netbeans/pull/275 - Changes the text below the image in the About Dialog (image itself is not changed, needs to be done!) - Changes the URL

[GitHub] jlahoda opened a new pull request #278: As per Bertrand's request, added comments to compile-time deps explai?

2017-11-17 Thread GitBox
jlahoda opened a new pull request #278: As per Bertrand's request, added comments to compile-time deps explai? URL: https://github.com/apache/incubator-netbeans/pull/278 ?ning their need; fixing a few closely related problems.

[GitHub] lbruun commented on issue #277: Permit CLI --open-group to accept a substring of a group name as a convenience

2017-11-18 Thread GitBox
lbruun commented on issue #277: Permit CLI --open-group to accept a substring of a group name as a convenience URL: https://github.com/apache/incubator-netbeans/pull/277#issuecomment-345426087 Good explanations. Thx. This

[GitHub] jlahoda closed pull request #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs?

2017-11-11 Thread GitBox
jlahoda closed pull request #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs? URL: https://github.com/apache/incubator-netbeans/pull/269 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[GitHub] jlahoda commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs?

2017-11-11 Thread GitBox
jlahoda commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs? URL: https://github.com/apache/incubator-netbeans/pull/269#issuecomment-343679415 Will reopen a new pull request.

[GitHub] matthiasblaesing commented on issue #161: [NETBEANS-96] New PAC Script evaluation environment

2017-11-11 Thread GitBox
matthiasblaesing commented on issue #161: [NETBEANS-96] New PAC Script evaluation environment URL: https://github.com/apache/incubator-netbeans/pull/161#issuecomment-343670673 I gave it another look I have one further comment on the code itself - the spec version of lib.jna.platform

[GitHub] jlahoda opened a new pull request #270: Let the Travis build really fail on Rat or verify-libs-and-licenses f?

2017-11-11 Thread GitBox
jlahoda opened a new pull request #270: Let the Travis build really fail on Rat or verify-libs-and-licenses f? URL: https://github.com/apache/incubator-netbeans/pull/270 ?ailures. Trying to make sure that Rat/verify-libs-and-licenses will actually break the build. For Rat,

[GitHub] lbruun commented on issue #251: [NETBEANS-126] Re-instate browser icons

2017-11-11 Thread GitBox
lbruun commented on issue #251: [NETBEANS-126] Re-instate browser icons URL: https://github.com/apache/incubator-netbeans/pull/251#issuecomment-343660739 **How they are used:** * For `css.editor` I don't think the icons add much value. See

[GitHub] emilianbold commented on issue #262: Fix NullPointerException at com.sun.source.util.TreePath.

2017-11-11 Thread GitBox
emilianbold commented on issue #262: Fix NullPointerException at com.sun.source.util.TreePath. URL: https://github.com/apache/incubator-netbeans/pull/262#issuecomment-343677854 I haven't tested this but the patch looks good to me.

[GitHub] jtulach commented on a change in pull request #2: Add Automatic-Module-Name attribute to manifest files

2017-11-10 Thread GitBox
jtulach commented on a change in pull request #2: Add Automatic-Module-Name attribute to manifest files URL: https://github.com/apache/incubator-netbeans-html4j/pull/2#discussion_r150342117 ## File path: pom.xml ## @@ -327,6 +327,7 @@

[GitHub] jlahoda commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs?

2017-11-10 Thread GitBox
jlahoda commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs? URL: https://github.com/apache/incubator-netbeans/pull/269#issuecomment-343593703 @geertjanw - please don't merge yet, the original failure was intentional, the new

[GitHub] jlahoda opened a new pull request #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs?

2017-11-10 Thread GitBox
jlahoda opened a new pull request #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs? URL: https://github.com/apache/incubator-netbeans/pull/269 ?-and-licenses failures. This is an

[GitHub] geertjanw commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs?

2017-11-10 Thread GitBox
geertjanw commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs? URL: https://github.com/apache/incubator-netbeans/pull/269#issuecomment-343584533 Ironically, the Travis build failed, can I merge this one anyway?

[GitHub] geertjanw commented on issue #264: Check whether line endings are LF with Travis CI

2017-11-10 Thread GitBox
geertjanw commented on issue #264: Check whether line endings are LF with Travis CI URL: https://github.com/apache/incubator-netbeans/pull/264#issuecomment-343586187 +1 looks good to me. Would be good if someone else reviewed this too.

[GitHub] matthiasblaesing commented on issue #218: [NETBEANS-54] Module Review xml.jaxb

2017-11-12 Thread GitBox
matthiasblaesing commented on issue #218: [NETBEANS-54] Module Review xml.jaxb URL: https://github.com/apache/incubator-netbeans/pull/218#issuecomment-343739147 @geertjanw you latest change reverts all changes you did to the xml.jaxb module. As this looked abandond I had a look at it

[GitHub] Chris2011 commented on issue #251: [NETBEANS-126] Re-instate browser icons

2017-11-12 Thread GitBox
Chris2011 commented on issue #251: [NETBEANS-126] Re-instate browser icons URL: https://github.com/apache/incubator-netbeans/pull/251#issuecomment-343740351 > For css.editor I don't think the icons add much value. See NETBEANS-126 for how they are actually used. What do you mean

[GitHub] dschoorl commented on a change in pull request #2: Add Automatic-Module-Name attribute to manifest files

2017-11-10 Thread GitBox
dschoorl commented on a change in pull request #2: Add Automatic-Module-Name attribute to manifest files URL: https://github.com/apache/incubator-netbeans-html4j/pull/2#discussion_r150360512 ## File path: pom.xml ## @@ -327,6 +327,7 @@

[GitHub] geertjanw opened a new pull request #271: [NETBEANS-54] excluding specific files, e.g., licenses via Rat

2017-11-12 Thread GitBox
geertjanw opened a new pull request #271: [NETBEANS-54] excluding specific files, e.g., licenses via Rat URL: https://github.com/apache/incubator-netbeans/pull/271 This is an automated message from the Apache Git Service.

[GitHub] lbruun commented on issue #161: [NETBEANS-96] New PAC Script evaluation environment

2017-11-12 Thread GitBox
lbruun commented on issue #161: [NETBEANS-96] New PAC Script evaluation environment URL: https://github.com/apache/incubator-netbeans/pull/161#issuecomment-343727045 I've done the requested changes. (license headers, bumped libs.jna.platform version) **Wrt frind-packages.** It

[GitHub] geertjanw commented on issue #218: [NETBEANS-54] Module Review xml.jaxb

2017-11-12 Thread GitBox
geertjanw commented on issue #218: [NETBEANS-54] Module Review xml.jaxb URL: https://github.com/apache/incubator-netbeans/pull/218#issuecomment-343731008 Reverted the license header changes on the test data files. This is an

[GitHub] matthiasblaesing commented on issue #161: [NETBEANS-96] New PAC Script evaluation environment

2017-11-12 Thread GitBox
matthiasblaesing commented on issue #161: [NETBEANS-96] New PAC Script evaluation environment URL: https://github.com/apache/incubator-netbeans/pull/161#issuecomment-343733913 Thank you very much for the work you put in here and the time you took to answer my questions/comments. I

[GitHub] matthiasblaesing opened a new pull request #272: [NETBEANS-54] Further license cleanup

2017-11-12 Thread GitBox
matthiasblaesing opened a new pull request #272: [NETBEANS-54] Further license cleanup URL: https://github.com/apache/incubator-netbeans/pull/272 There are two changes: - cleanup the xml.jaxb module by moving test-data into `xml.jaxb/test/unit/data` and fix the remaining files in the

[GitHub] matthiasblaesing commented on a change in pull request #271: [NETBEANS-54] excluding specific files, e.g., licenses via Rat

2017-11-12 Thread GitBox
matthiasblaesing commented on a change in pull request #271: [NETBEANS-54] excluding specific files, e.g., licenses via Rat URL: https://github.com/apache/incubator-netbeans/pull/271#discussion_r150411500 ## File path: nbbuild/build.xml ## @@ -2024,8 +2027,11 @@ It is

[GitHub] lbruun commented on issue #251: [NETBEANS-126] Re-instate browser icons

2017-11-12 Thread GitBox
lbruun commented on issue #251: [NETBEANS-126] Re-instate browser icons URL: https://github.com/apache/incubator-netbeans/pull/251#issuecomment-343745306 >> For css.editor I don't think the icons add much value. See NETBEANS-126 for how they are actually used. > > What do you

[GitHub] thurka opened a new pull request #273: Backport of thurka's fixes made after Apr 22, 2017

2017-11-14 Thread GitBox
thurka opened a new pull request #273: Backport of thurka's fixes made after Apr 22, 2017 URL: https://github.com/apache/incubator-netbeans/pull/273 This is a batch commit of changes for NetBeans 9 done during legal review of sources already being reviewed and donated. These changes were

[GitHub] jlahoda closed pull request #270: Let the Travis build really fail on Rat or verify-libs-and-licenses f?

2017-11-13 Thread GitBox
jlahoda closed pull request #270: Let the Travis build really fail on Rat or verify-libs-and-licenses f? URL: https://github.com/apache/incubator-netbeans/pull/270 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] geertjanw commented on issue #270: Let the Travis build really fail on Rat or verify-libs-and-licenses f?

2017-11-13 Thread GitBox
geertjanw commented on issue #270: Let the Travis build really fail on Rat or verify-libs-and-licenses f? URL: https://github.com/apache/incubator-netbeans/pull/270#issuecomment-343906908 Looks good to me too. This is an

[GitHub] matthiasblaesing commented on issue #271: [NETBEANS-54] excluding specific files, e.g., licenses via Rat

2017-11-13 Thread GitBox
matthiasblaesing commented on issue #271: [NETBEANS-54] excluding specific files, e.g., licenses via Rat URL: https://github.com/apache/incubator-netbeans/pull/271#issuecomment-343998973 No, #272 makes the exclude you introduced in 2033 obsolete, so that should be removed, The

[GitHub] dbalek opened a new pull request #274: Backport of dbalek's fixes made after Apr 22, 2017

2017-11-14 Thread GitBox
dbalek opened a new pull request #274: Backport of dbalek's fixes made after Apr 22, 2017 URL: https://github.com/apache/incubator-netbeans/pull/274 This is a batch commit of changes for NetBeans 9 done during legal review of sources already being reviewed and donated. These changes were

[GitHub] bdelacretaz commented on issue #274: Backport of dbalek's fixes made after Apr 22, 2017

2017-11-14 Thread GitBox
bdelacretaz commented on issue #274: Backport of dbalek's fixes made after Apr 22, 2017 URL: https://github.com/apache/incubator-netbeans/pull/274#issuecomment-344268500 Are you the author of all these changes? The "Backport of dbalek's changes" title seems to imply that you are, but if

[GitHub] geertjanw closed pull request #273: Backport of thurka's fixes made after Apr 22, 2017

2017-11-14 Thread GitBox
geertjanw closed pull request #273: Backport of thurka's fixes made after Apr 22, 2017 URL: https://github.com/apache/incubator-netbeans/pull/273 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] geertjanw commented on issue #273: Backport of thurka's fixes made after Apr 22, 2017

2017-11-14 Thread GitBox
geertjanw commented on issue #273: Backport of thurka's fixes made after Apr 22, 2017 URL: https://github.com/apache/incubator-netbeans/pull/273#issuecomment-344271058 Is there any reason not to merge? Otherwise, happy to merge, have looked through all the code.

[GitHub] dbalek commented on issue #274: Backport of dbalek's fixes made after Apr 22, 2017

2017-11-14 Thread GitBox
dbalek commented on issue #274: Backport of dbalek's fixes made after Apr 22, 2017 URL: https://github.com/apache/incubator-netbeans/pull/274#issuecomment-344270930 Why do you think the changes are not mine? This is an

[GitHub] geertjanw commented on issue #274: Backport of dbalek's fixes made after Apr 22, 2017

2017-11-14 Thread GitBox
geertjanw commented on issue #274: Backport of dbalek's fixes made after Apr 22, 2017 URL: https://github.com/apache/incubator-netbeans/pull/274#issuecomment-344270576 Yes, he's the author. This is an automated message from

[GitHub] bdelacretaz commented on issue #274: Backport of dbalek's fixes made after Apr 22, 2017

2017-11-14 Thread GitBox
bdelacretaz commented on issue #274: Backport of dbalek's fixes made after Apr 22, 2017 URL: https://github.com/apache/incubator-netbeans/pull/274#issuecomment-344272483 Cool! I did not imply the changes are not yours, just verifying that they are as it's important in an Apache context.

[GitHub] geertjanw commented on issue #274: Backport of dbalek's fixes made after Apr 22, 2017

2017-11-14 Thread GitBox
geertjanw commented on issue #274: Backport of dbalek's fixes made after Apr 22, 2017 URL: https://github.com/apache/incubator-netbeans/pull/274#issuecomment-344271733 Because there's so many. It's a compliment. :-) This is

[GitHub] geertjanw closed pull request #274: Backport of dbalek's fixes made after Apr 22, 2017

2017-11-14 Thread GitBox
geertjanw closed pull request #274: Backport of dbalek's fixes made after Apr 22, 2017 URL: https://github.com/apache/incubator-netbeans/pull/274 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] geertjanw commented on issue #274: Backport of dbalek's fixes made after Apr 22, 2017

2017-11-14 Thread GitBox
geertjanw commented on issue #274: Backport of dbalek's fixes made after Apr 22, 2017 URL: https://github.com/apache/incubator-netbeans/pull/274#issuecomment-344278528 OK, looked through them, makes sense to me, merging.

[GitHub] dbalek commented on issue #274: Backport of dbalek's fixes made after Apr 22, 2017

2017-11-14 Thread GitBox
dbalek commented on issue #274: Backport of dbalek's fixes made after Apr 22, 2017 URL: https://github.com/apache/incubator-netbeans/pull/274#issuecomment-344272148 That is cumulative work since April till now :-) This is

[GitHub] geertjanw commented on issue #283: Integrating NetBeans after donation changes.

2017-11-20 Thread GitBox
geertjanw commented on issue #283: Integrating NetBeans after donation changes. URL: https://github.com/apache/incubator-netbeans/pull/283#issuecomment-345643943 All checks have passed, this is important code, and great to have it here, and it should fix this, I think:

[GitHub] geertjanw commented on issue #276: [NETBEANS-149] Max heap size removed

2017-11-20 Thread GitBox
geertjanw commented on issue #276: [NETBEANS-149] Max heap size removed URL: https://github.com/apache/incubator-netbeans/pull/276#issuecomment-345673822 +1 makes sense to me. This is an automated message from the Apache Git

[GitHub] JaroslavTulach opened a new pull request #284: Updating HTML/Java libraries to just released version 1.5.1

2017-11-20 Thread GitBox
JaroslavTulach opened a new pull request #284: Updating HTML/Java libraries to just released version 1.5.1 URL: https://github.com/apache/incubator-netbeans/pull/284 Release of HTML/Java 1.5.1 has been approved and it is time to update the NetBeans platform to use it as well.

[GitHub] matthiasblaesing commented on issue #276: [NETBEANS-149] Max heap size removed

2017-11-20 Thread GitBox
matthiasblaesing commented on issue #276: [NETBEANS-149] Max heap size removed URL: https://github.com/apache/incubator-netbeans/pull/276#issuecomment-345846616 I agree too. Last time I saw such a small heap I tried to get a java 8 JVM to be loaded into a legacy 32 bit win32 application.

[GitHub] matthiasblaesing closed pull request #276: [NETBEANS-149] Max heap size removed

2017-11-20 Thread GitBox
matthiasblaesing closed pull request #276: [NETBEANS-149] Max heap size removed URL: https://github.com/apache/incubator-netbeans/pull/276 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] matthiasblaesing commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star

2017-11-20 Thread GitBox
matthiasblaesing commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star URL: https://github.com/apache/incubator-netbeans/pull/282#issuecomment-345844777 Thank you for explaining. My question came from the the fact, that at least one file in the

[GitHub] lbruun commented on issue #107: Removed failing tests dependent on nbm

2017-11-19 Thread GitBox
lbruun commented on issue #107: Removed failing tests dependent on nbm URL: https://github.com/apache/incubator-netbeans/pull/107#issuecomment-345520464 @rtaneja1 @geertjanw This commit changed **all of the files**, due to change from Unix line endings to Windows line endings.

[GitHub] lbruun commented on issue #107: Removed failing tests dependent on nbm

2017-11-19 Thread GitBox
lbruun commented on issue #107: Removed failing tests dependent on nbm URL: https://github.com/apache/incubator-netbeans/pull/107#issuecomment-345520464 @rtaneja1 @geertjanw This commit changed **all of the files**, due to change from Unix line endings to Windows line endings.

[GitHub] lbruun commented on issue #281: [NETBEANS-159] Readd maven.grammar Maven XSDs

2017-11-18 Thread GitBox
lbruun commented on issue #281: [NETBEANS-159] Readd maven.grammar Maven XSDs URL: https://github.com/apache/incubator-netbeans/pull/281#issuecomment-345475520 Great stuff. We are keeping track of all such changes (i.e. what needs to be done to reverse/review donation changes) on [this

[GitHub] dtrebbien commented on issue #280: [NETBEANS-47] readded not donated maven-4.0.0.xsd

2017-11-18 Thread GitBox
dtrebbien commented on issue #280: [NETBEANS-47] readded not donated maven-4.0.0.xsd URL: https://github.com/apache/incubator-netbeans/pull/280#issuecomment-345477165 This should fix https://netbeans.org/bugzilla/show_bug.cgi?id=271097 NullPointerException at java.net.URL.init

[GitHub] lhochet opened a new pull request #280: [NETBEANS-47] readded not donated maven-4.0.0.xsd

2017-11-18 Thread GitBox
lhochet opened a new pull request #280: [NETBEANS-47] readded not donated maven-4.0.0.xsd URL: https://github.com/apache/incubator-netbeans/pull/280 During the NetBeans code review maven.grammar\src\org\netbeans\modules\maven\grammar\maven-4.0.0.xsd was removed, this re-adds it as it is

[GitHub] lhochet opened a new pull request #281: [NETBEANS-159] Readd maven.grammar Maven XSDs

2017-11-18 Thread GitBox
lhochet opened a new pull request #281: [NETBEANS-159] Readd maven.grammar Maven XSDs URL: https://github.com/apache/incubator-netbeans/pull/281 Following on NETBEANS-47 re-add the other Maven XSDs hosted at https://maven.apache.org/xsd/ and that were not (to be) donated.

[GitHub] matthiasblaesing commented on issue #271: [NETBEANS-54] excluding specific files, e.g., licenses via Rat

2017-11-19 Thread GitBox
matthiasblaesing commented on issue #271: [NETBEANS-54] excluding specific files, e.g., licenses via Rat URL: https://github.com/apache/incubator-netbeans/pull/271#issuecomment-345548468 @geertjanw I extended your work by adding the ALv2 header to all VERSION.txt files. You established

[GitHub] lhochet commented on issue #280: [NETBEANS-47] readded not donated maven-4.0.0.xsd

2017-11-19 Thread GitBox
lhochet commented on issue #280: [NETBEANS-47] readded not donated maven-4.0.0.xsd URL: https://github.com/apache/incubator-netbeans/pull/280#issuecomment-345554806 Thanks. Once I'll have edit rights for the wiki I'll add a mention about nbm-1.0.0.xsd which isn't at Apache, and which

[GitHub] matthiasblaesing commented on issue #281: [NETBEANS-159] Readd maven.grammar Maven XSDs

2017-11-19 Thread GitBox
matthiasblaesing commented on issue #281: [NETBEANS-159] Readd maven.grammar Maven XSDs URL: https://github.com/apache/incubator-netbeans/pull/281#issuecomment-345540422 For the missing license: The XSDs are generated (see the file header) and maybe even generated at build time, so this

[GitHub] asfgit closed pull request #280: [NETBEANS-47] readded not donated maven-4.0.0.xsd

2017-11-19 Thread GitBox
asfgit closed pull request #280: [NETBEANS-47] readded not donated maven-4.0.0.xsd URL: https://github.com/apache/incubator-netbeans/pull/280 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] matthiasblaesing commented on issue #280: [NETBEANS-47] readded not donated maven-4.0.0.xsd

2017-11-19 Thread GitBox
matthiasblaesing commented on issue #280: [NETBEANS-47] readded not donated maven-4.0.0.xsd URL: https://github.com/apache/incubator-netbeans/pull/280#issuecomment-345552929 Thank you for looking into this. I squashed the commits of both changesets together and merged these in

[GitHub] lbruun opened a new pull request #282: [NETBEANS-161] Changed license header introducer to simple slash-star

2017-11-19 Thread GitBox
lbruun opened a new pull request #282: [NETBEANS-161] Changed license header introducer to simple slash-star URL: https://github.com/apache/incubator-netbeans/pull/282 The new Apache license header on all .java, .cpp, .c files (etc) started with slash-star-star (the Javadoc introducer).

[GitHub] lhochet commented on issue #281: [NETBEANS-159] Readd maven.grammar Maven XSDs

2017-11-19 Thread GitBox
lhochet commented on issue #281: [NETBEANS-159] Readd maven.grammar Maven XSDs URL: https://github.com/apache/incubator-netbeans/pull/281#issuecomment-345549674 I've added the licence header. This is an automated message

[GitHub] lbruun commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star

2017-11-19 Thread GitBox
lbruun commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star URL: https://github.com/apache/incubator-netbeans/pull/282#issuecomment-345551323 I don't think it is any safer to use include list. After all the snippet only change those files which

[GitHub] lbruun commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star

2017-11-19 Thread GitBox
lbruun commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star URL: https://github.com/apache/incubator-netbeans/pull/282#issuecomment-345551323 I don't think it is any safer to use include list. After all the snippet only change those files which

[GitHub] lbruun commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star

2017-11-19 Thread GitBox
lbruun commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star URL: https://github.com/apache/incubator-netbeans/pull/282#issuecomment-345551323 I don't think it is any safer to use include list. After all the snippet only change those files which

[GitHub] lbruun commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star

2017-11-19 Thread GitBox
lbruun commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star URL: https://github.com/apache/incubator-netbeans/pull/282#issuecomment-345551323 I don't think it is any safer to use include list. After all the snippet only change those files which

[GitHub] lbruun commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star

2017-11-19 Thread GitBox
lbruun commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star URL: https://github.com/apache/incubator-netbeans/pull/282#issuecomment-345550759 Why all files? Not sure I understand. Either we decide that this is incorrect behaviour and then we

[GitHub] matthiasblaesing commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star

2017-11-19 Thread GitBox
matthiasblaesing commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star URL: https://github.com/apache/incubator-netbeans/pull/282#issuecomment-345549737 I have two comments: - is there a real reason to change about any file in the repository?

[GitHub] lbruun commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star

2017-11-19 Thread GitBox
lbruun commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star URL: https://github.com/apache/incubator-netbeans/pull/282#issuecomment-345550759 Why all files? Not sure I understand. Either we decide that this is incorrect behaviour and then we

[GitHub] lbruun commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star

2017-11-19 Thread GitBox
lbruun commented on issue #282: [NETBEANS-161] Changed license header introducer to simple slash-star URL: https://github.com/apache/incubator-netbeans/pull/282#issuecomment-345551323 I don't think it is any safer to use include list. After all the snippet only change those files which

[GitHub] tzezula opened a new pull request #283: Integrating NetBeans after donation changes.

2017-11-19 Thread GitBox
tzezula opened a new pull request #283: Integrating NetBeans after donation changes. URL: https://github.com/apache/incubator-netbeans/pull/283 Integrating NetBeans after donation changes done be Tomas Zezula. These changes mostly target JDK9, Java development and NetBeans generic

[GitHub] jtulach commented on issue #283: Integrating NetBeans after donation changes.

2017-11-19 Thread GitBox
jtulach commented on issue #283: Integrating NetBeans after donation changes. URL: https://github.com/apache/incubator-netbeans/pull/283#issuecomment-345617211 Great to see this backport: +1 This is an automated message from

[GitHub] jlahoda opened a new pull request #285: Fixing some problems reported by verify-libs-and-licenses

2017-11-21 Thread GitBox
jlahoda opened a new pull request #285: Fixing some problems reported by verify-libs-and-licenses URL: https://github.com/apache/incubator-netbeans/pull/285 Most of the changes are intended to be editorial changes (renaming files to adhere to conventions, normalizing texts, normalizing

[GitHub] geertjanw closed pull request #284: Updating HTML/Java libraries to just released version 1.5.1

2017-11-21 Thread GitBox
geertjanw closed pull request #284: Updating HTML/Java libraries to just released version 1.5.1 URL: https://github.com/apache/incubator-netbeans/pull/284 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] geertjanw commented on issue #284: Updating HTML/Java libraries to just released version 1.5.1

2017-11-21 Thread GitBox
geertjanw commented on issue #284: Updating HTML/Java libraries to just released version 1.5.1 URL: https://github.com/apache/incubator-netbeans/pull/284#issuecomment-346171770 Makes sense and merging. This is an automated

[GitHub] lbruun opened a new pull request #276: [NETBEANS-149] Max heap size removed

2017-11-16 Thread GitBox
lbruun opened a new pull request #276: [NETBEANS-149] Max heap size removed URL: https://github.com/apache/incubator-netbeans/pull/276 Explicit max and min heap size settings removed. This file (changed in this PR) is the default `.conf` file your application will get when you

[GitHub] lbruun commented on issue #277: Permit CLI --open-group to accept a substring of a group name as a convenience

2017-11-16 Thread GitBox
lbruun commented on issue #277: Permit CLI --open-group to accept a substring of a group name as a convenience URL: https://github.com/apache/incubator-netbeans/pull/277#issuecomment-345160402 If I have groups named abc1 abc2 abc3 and I do `--open-group

[GitHub] jglick commented on issue #277: Permit CLI --open-group to accept a substring of a group name as a convenience

2017-11-16 Thread GitBox
jglick commented on issue #277: Permit CLI --open-group to accept a substring of a group name as a convenience URL: https://github.com/apache/incubator-netbeans/pull/277#issuecomment-345147892 BTW it seems that committing in, well, NetBeans fails to run gpg, despite `commit.gpgsign =

[GitHub] jglick opened a new pull request #277: Permit CLI --open-group to accept a substring of a group name as a convenience

2017-11-16 Thread GitBox
jglick opened a new pull request #277: Permit CLI --open-group to accept a substring of a group name as a convenience URL: https://github.com/apache/incubator-netbeans/pull/277 Should be self-explanatory. Tested manually on a simple case with a couple of groups ```sh ant tryme

[GitHub] geertjanw commented on issue #277: Permit CLI --open-group to accept a substring of a group name as a convenience

2017-11-16 Thread GitBox
geertjanw commented on issue #277: Permit CLI --open-group to accept a substring of a group name as a convenience URL: https://github.com/apache/incubator-netbeans/pull/277#issuecomment-345156844 Thanks, makes sense to me, looks good.

[GitHub] junichi11 commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs?

2017-11-10 Thread GitBox
junichi11 commented on issue #269: [work-in-progress] The Travis build should fail when there are either rat or verify-libs? URL: https://github.com/apache/incubator-netbeans/pull/269#issuecomment-343635104 > Unfortunately, I don't know how to test the Travis build without having a pull

[GitHub] junichi11 commented on issue #264: Check whether line endings are LF with Travis CI

2017-11-10 Thread GitBox
junichi11 commented on issue #264: Check whether line endings are LF with Travis CI URL: https://github.com/apache/incubator-netbeans/pull/264#issuecomment-343635498 @geertjanw Thanks a lot for your review! Jan is working on #269. So I'll fix `.travis.yml` again after Jan's changes

[GitHub] matthiasblaesing closed pull request #218: [NETBEANS-54] Module Review xml.jaxb

2017-11-12 Thread GitBox
matthiasblaesing closed pull request #218: [NETBEANS-54] Module Review xml.jaxb URL: https://github.com/apache/incubator-netbeans/pull/218 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] matthiasblaesing closed pull request #272: [NETBEANS-54] Further license cleanup

2017-11-12 Thread GitBox
matthiasblaesing closed pull request #272: [NETBEANS-54] Further license cleanup URL: https://github.com/apache/incubator-netbeans/pull/272 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] jtulach commented on issue #2: Add Automatic-Module-Name attribute to manifest files

2017-11-10 Thread GitBox
jtulach commented on issue #2: Add Automatic-Module-Name attribute to manifest files URL: https://github.com/apache/incubator-netbeans-html4j/pull/2#issuecomment-343644018 Hello David. You mention JUnit: from there it is just a step to TDD. I believe TDD is a great way to balance ability

[GitHub] steffendietz opened a new pull request #279: Restore autoupdate.services tests

2017-11-17 Thread GitBox
steffendietz opened a new pull request #279: Restore autoupdate.services tests URL: https://github.com/apache/incubator-netbeans/pull/279 I restored the tests which were deleted during the first couple of turbulent days after the initial donation. After that I tried to recreate the

[GitHub] geertjanw commented on issue #218: [NETBEANS-54] Module Review xml.jaxb

2017-11-03 Thread GitBox
geertjanw commented on issue #218: [NETBEANS-54] Module Review xml.jaxb URL: https://github.com/apache/incubator-netbeans/pull/218#issuecomment-341673939 Thanks a lot for the review, makes sense, will do. This is an

<    1   2   3   4   5   6   7   8   9   10   >