Re: quick reminder on new nars

2016-03-19 Thread Joe Witt
Bryan, I believe the archetype is already updated if this what you're referring to. https://github.com/apache/nifi/blob/master/nifi-maven-archetypes/nifi-processor-bundle-archetype/src/main/resources/archetype-resources/nifi-__artifactBaseName__-nar/pom.xml Thanks Joe On Wed, Mar 16, 2016 at

[GitHub] nifi pull request: NIFI-1488 Refactoring HBase Kerberos support

2016-03-19 Thread markap14
Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/281#issuecomment-197888150 @bbende code looks good. Just a few minor comments in-line (stylistic for the most part). There were a lot of files that were changed due to just white space and Java

[GitHub] nifi pull request: NIFI-1488 Refactoring HBase Kerberos support

2016-03-19 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/281#discussion_r56506078 --- Diff:

[GitHub] nifi pull request: NIFI-1488 Refactoring HBase Kerberos support

2016-03-19 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/281#discussion_r56410644 --- Diff: nifi-commons/nifi-hadoop-utils/src/main/java/org/apache/nifi/hadoop/KerberosProperties.java --- @@ -0,0 +1,146 @@ +/* + * Licensed to the

Processor additional documentation

2016-03-19 Thread Uwe Geercken
Hello, I am writing my first processor. As described in the documentation, I have added an HTML file to be used when the user selects "Usage": docs/com.datamelt.nifi.test.TemplateProcessor/additionalDetails.html This is located in the root or the Processors nar file. The processor class is

[GitHub] nifi pull request: Nifi 1274

2016-03-19 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/284#issuecomment-197950387 +1 from me as well. Verified functionality for both standalone and clustered instances. Looking good. --- If your project is set up for it, you can reply to this email

Re: patch and pull request reviewing question

2016-03-19 Thread Oleg Zhurakousky
Going back to T's original point, I'd go as far as asking the following: Once the PR is issued, do NOT squash until asked to do so. The reason for it is that I just had a great experience with Percival on new JMS support. There were 6+ follow ups. Joe only needed to review what we agreed/argued,

Re: Rollbacks

2016-03-19 Thread Devin Fisher
Cool, thanks. I'll take a look at that Processor. I've learned a lot from looking at the processor in the main project. Devin On Thu, Mar 17, 2016 at 10:46 AM, Joe Witt wrote: > Devin, > > Good stuff. Unless the api call to change the content completes > normally the

[GitHub] nifi pull request: NIFI-1647 fixed validators and config resolutio...

2016-03-19 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/288 NIFI-1647 fixed validators and config resolution You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1647 Alternatively you can review

[GitHub] nifi pull request: NIFI-1464 removed e.printStackTrace() from onTr...

2016-03-19 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/287 NIFI-1464 removed e.printStackTrace() from onTrigger in StandarProces… …sScheduler You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi

Re: Re: Processor additional documentation

2016-03-19 Thread dan bress
Uwe, No its not a problem to have both index.html and additionalDetails.html The NiFi framework generates nearly all of the documentation for your processor for you. It will generate information about the properties and relationships your processor exposes to its users. If you need to

[GitHub] nifi pull request: nifi-1562 ExecuteStreamCommand and ExecuteProce...

2016-03-19 Thread mattyb149
Github user mattyb149 commented on the pull request: https://github.com/apache/nifi/pull/247#issuecomment-198162336 reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: quick reminder on new nars

2016-03-19 Thread Bryan Bende
Ah perfect, didn't know that was already done. On Wed, Mar 16, 2016 at 9:24 AM, Joe Witt wrote: > Bryan, > > I believe the archetype is already updated if this what you're referring > to. > > >

[GitHub] nifi pull request: Nifi 1274

2016-03-19 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/284#issuecomment-197978496 All of @mcgilman 's changes are great. The test resources are files I added that make it easier to set up a Kerberized instance of NiFi for testing, but were not

Re: Rollbacks

2016-03-19 Thread Devin Fisher
Thanks for the detailed response. The details about the batching were very helpful. I've changed my processors to take advantage of the batching that framework provides since my use case fits what you described to a tee. But I have a question about the failure relationship. Maybe a concrete

[GitHub] nifi pull request: nifi-1562 ExecuteStreamCommand and ExecuteProce...

2016-03-19 Thread mattyb149
Github user mattyb149 commented on the pull request: https://github.com/apache/nifi/pull/247#issuecomment-198182467 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56446243 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java --- @@ -0,0 +1,392 @@

[GitHub] nifi pull request: NIFI-1636: Print Stacktrace When Unepected OnTr...

2016-03-19 Thread rickysaltzer
Github user rickysaltzer commented on a diff in the pull request: https://github.com/apache/nifi/pull/285#discussion_r56422806 --- Diff: nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java --- @@ -27,7 +30,12 @@ public final void onTrigger(final ProcessContext

[GitHub] nifi pull request: Nifi 1274

2016-03-19 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/284#discussion_r56507643 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/jwt/JwtService.java ---

Re: Closing in on the Apache NiFi 0.6.0 release

2016-03-19 Thread Tony Kurc
Recommend https://issues.apache.org/jira/browse/NIFI-1651 be included in 0.6.0 On Wed, Mar 16, 2016 at 4:08 PM, Joe Witt wrote: > Team, > > Ok sooo close. We have 5 tickets remaining. > > - Additional functionality/cleanup for SplitText [1] > [status] Still in discussions.

Re: Processor additional documentation

2016-03-19 Thread Russell Bateman
Uwe, When I asked this question a few days ago. What you're doing is rolling your whole processor into a NAR instead of JARing it first, then rolling the JAR into a NAR. This doesn't work and still won't work when they fix it (not just for the reason of /additional//Details.html/ because

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread trkurc
Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/271#issuecomment-197617908 @olegz : checkstyle fails when I build with your latest commit `` [INFO] --- maven-checkstyle-plugin:2.15:check (check-style) @ nifi-spring-processors ---

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56446675 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java --- @@ -0,0 +1,392 @@

Re: patch and pull request reviewing question

2016-03-19 Thread Aldrin Piri
Sounds good to here as well. Given the increasing number of contributions, which predominantly seem to arrive via GitHub PR, I also created NIFI-1615 [1] a little while ago to make a GitHub PR template [1]. Would like to distill the contributor guide down into a few easy steps for folks to check

[GitHub] nifi pull request: Nifi 1495 - AWS Kinesis Firehose

2016-03-19 Thread apiri
Github user apiri commented on the pull request: https://github.com/apache/nifi/pull/213#issuecomment-197294536 @mans2singh Looks great, thanks for getting those changes together and the contribution. I'll be merging this into master shortly. --- If your project is set up for it,

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread olegz
Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/271#issuecomment-198126926 Also, the Camel example was added for testing here https://github.com/olegz/si-demo .@PuspenduBanerjee if/when you get a chance please check it out. --- If your project

[GitHub] nifi pull request: NIFI-1488 Refactoring HBase Kerberos support

2016-03-19 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/281#discussion_r56411887 --- Diff: nifi-commons/nifi-hadoop-utils/src/main/java/org/apache/nifi/hadoop/SecurityUtil.java --- @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache

[GitHub] nifi pull request: NIFI-1617 Add source filename metadata to Ident...

2016-03-19 Thread jfrazee
Github user jfrazee closed the pull request at: https://github.com/apache/nifi/pull/273 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: Nifi 1274

2016-03-19 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/284#discussion_r56496561 --- Diff:

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread trkurc
Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/271#issuecomment-198171253 @olegz, I think @joewitt is still looking, but I think the code looks good, I put it through the paces using several applications. I'm +1 --- If your project is set up

[GitHub] nifi pull request: NIFI-1651 unit tests work on windows. removed c...

2016-03-19 Thread trkurc
GitHub user trkurc opened a pull request: https://github.com/apache/nifi/pull/291 NIFI-1651 unit tests work on windows. removed contributor name/package from data and schema You can merge this pull request into a Git repository by running: $ git pull

[GitHub] nifi pull request: NIFI-1636: Print Stacktrace When Unepected OnTr...

2016-03-19 Thread rickysaltzer
GitHub user rickysaltzer opened a pull request: https://github.com/apache/nifi/pull/285 NIFI-1636: Print Stacktrace When Unepected OnTrigger Exception Caught You can merge this pull request into a Git repository by running: $ git pull https://github.com/rickysaltzer/nifi

Re: EndpointConnectionPool is not reusable.

2016-03-19 Thread Paresh Shah
Joe, For our use case we want to be able to do the following. 1. In certain paths we want to be able to send the same FlowFiles to all nodes of a remote cluster ( broadcast use case ) 2. In another use case send it to one of the nodes of the remote cluster ( regular RPG use case ). What we are

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56445529 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java --- @@ -0,0 +1,392 @@

[GitHub] nifi pull request: NIFI-1617 Add source filename metadata to Ident...

2016-03-19 Thread mattyb149
Github user mattyb149 commented on the pull request: https://github.com/apache/nifi/pull/273#issuecomment-198185301 reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: [ANNOUNCE] New Apache NiFi Committer Oleg Zhurakousky

2016-03-19 Thread Joe Skora
Oleg, Congratulations, and thanks for all your help, past and future! Joe On Wed, Mar 16, 2016 at 10:11 AM, Pierre Villard < pierre.villard...@gmail.com> wrote: > Well deserved! Congrats! > On Mar 16, 2016 13:27, "Joe Percivall" > wrote: > > > Congrats Oleg! >

[GitHub] nifi pull request: NIFI-856 Implements experimental ListenLumberja...

2016-03-19 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/290 NIFI-856 Implements experimental ListenLumberjack Processor ListenLumberjack processor should allow NiFi to act as a drop in replacement on pipelines using logstash-forwarder and Logstash's

Aw: Re: Re: Processor: User friendly vs system friendly design

2016-03-19 Thread Uwe Geercken
Adam, ok. I got it. This way one can use any flowfile attributes and merge them with the template. I have worked all day on the two processors and it does work - very cool. Will have to do more error testing though. So the SplitToAttribute processor does the splitting of the flowfile content.

[GitHub] nifi pull request: NIFI-1575: Add QueryDatabaseTable processor

2016-03-19 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/261#discussion_r56380052 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java --- @@

[GitHub] nifi pull request: Nifi 1495 - AWS Kinesis Firehose

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread trkurc
Github user trkurc commented on the pull request: https://github.com/apache/nifi/pull/271#issuecomment-198134497 @olegz - there are a bunch of trailing whitespace and whitespace on blank lines in the xml and properties files. checkstyle doesn't complain as it checks the java code

[GitHub] nifi pull request: NIFI-1617 Add source filename metadata to Ident...

2016-03-19 Thread mattyb149
Github user mattyb149 commented on the pull request: https://github.com/apache/nifi/pull/273#issuecomment-198202258 I merged this but forgot to close the PR, @jfrazee can you do the honors? Thanks for the contrib! --- If your project is set up for it, you can reply to this

[GitHub] nifi pull request: NIFI-1629 downgraded Kafka back to 0.8

2016-03-19 Thread rickysaltzer
Github user rickysaltzer commented on the pull request: https://github.com/apache/nifi/pull/282#issuecomment-197505410 +1 - tested and verified to work with 0.8.0 and 0.9.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] nifi pull request: NIFI-1118 Update SplitText Processor - add supp...

2016-03-19 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/280#discussion_r56327650 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitText.java --- @@ -143,72

Re: User friendly versus system friendly Question

2016-03-19 Thread Russell Bateman
Uwe, While my usage is surely unrelated to yours, I do exactly this thing which is to process a CSV producing as many new output flowfiles as there are lines and the names of these flowfiles are, in my case, conveniently chosen based on the significant content of each line (so no problem

[GitHub] nifi pull request: NIFI-1337: Add Riemann Reporting Task

2016-03-19 Thread joewitt
Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/188#issuecomment-198151066 @rickysaltzer hey there. I just realized that this does have a commit against it post review commentary. My apologies for not engaging. Do you happen to be using this

Re: Re: Re: Processor additional documentation

2016-03-19 Thread dan bress
Uwe, No, the index.html is generated for you. additionalDetails.html is your responsibility only if you feel like the generated index.html doesn't fully describe your processor. I would guess 80% of the included processors do not have additionalDetails.html. If you haven't browsed here

Re: Processor: User friendly vs system friendly design

2016-03-19 Thread Uwe Geercken
Adam, interesting and I agree. that sounds very good. can you give me short tip of how to access attributes from code? once I have something usable or for testing where would I publish it? just on my github site? or is there a place for sharing? greetings Uwe     Gesendet: Freitag, 18. März

[GitHub] nifi pull request: NIFI-1118 Update SplitText Processor - add supp...

2016-03-19 Thread markobean
Github user markobean commented on a diff in the pull request: https://github.com/apache/nifi/pull/280#discussion_r56328470 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitText.java --- @@ -143,72

patch and pull request reviewing question

2016-03-19 Thread Tony Kurc
As I was reviewing a pull request, i realized that it actually was a bit more mental effort in this instance to review a squashed and rebased set of commits than if it was if I could just review the changes in a commit. Does anyone object to me adding in the contributors guide something to the

[GitHub] nifi pull request: NIFI-901: Fixed unit test to verify IP address ...

2016-03-19 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/286 NIFI-901: Fixed unit test to verify IP address of Cassandra contact point The test was checking the IP against getHostName(), but if there were a DNS/hosts entry for that IP, the test would fail.

[GitHub] nifi pull request: Nifi 1274

2016-03-19 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/284#discussion_r56410434 --- Diff: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-ui/src/main/java/org/apache/nifi/update/attributes/api/RuleResource.java ---

[GitHub] nifi pull request: NIFI-1488 Added hbase kerb auth with ugi

2016-03-19 Thread joewitt
Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/253#issuecomment-198146996 Hello @lordjc This ended up being merged and incorporated but the 'This closes #253' was not added to the commit log so the close hook didn't fire. Can you please close

[GitHub] nifi pull request: NIFI-1636: Print Stacktrace When Unepected OnTr...

2016-03-19 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/285#discussion_r56420919 --- Diff: nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java --- @@ -27,7 +30,12 @@ public final void onTrigger(final ProcessContext

[GitHub] nifi pull request: NIFI-1605 Adjust documentation and resources to...

2016-03-19 Thread mattyb149
Github user mattyb149 commented on the pull request: https://github.com/apache/nifi/pull/263#issuecomment-198165221 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1575: Add QueryDatabaseTable processor

2016-03-19 Thread joewitt
Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/261#issuecomment-198147766 @mattyb149 believe this PR is closed but apparently the commit message didn't reflect it. Can you please close it. --- If your project is set up for it, you can reply

[GitHub] nifi pull request: NIFI-1118 Update SplitText Processor - add supp...

2016-03-19 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/280#issuecomment-197388774 I think the issues are all covered now and tests have been expanded to get all critical logic and edge cases. --- If your project is set up for it, you can reply to this

[GitHub] nifi pull request: NIFI-615 - Create a processor to extract WAV fi...

2016-03-19 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/252#issuecomment-198427593 I don't love all the attribute names, I might have come up with a cleaner taxonomy myself. But, letting Tika handle it leverages the work done on another active Apache

[GitHub] nifi pull request: Nifi 1274

2016-03-19 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/284#discussion_r56496662 --- Diff:

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread PuspenduBanerjee
Github user PuspenduBanerjee commented on the pull request: https://github.com/apache/nifi/pull/271#issuecomment-198245248 @olegz Sorry for the delay in response, I shall look into that during next week. --- If your project is set up for it, you can reply to this email and have your

Re: patch and pull request reviewing question

2016-03-19 Thread Oleg Zhurakousky
+1 here as well My apologies Tony Sent from my iPhone > On Mar 17, 2016, at 21:42, Joe Witt wrote: > > +1 > >> On Thu, Mar 17, 2016 at 9:37 PM, Tony Kurc wrote: >> As I was reviewing a pull request, i realized that it actually was a bit >> more mental

Re: Re: Processor: User friendly vs system friendly design

2016-03-19 Thread Adam Taft
Uwe, I'll take a look at your code sometime soon. However, just to point you in the direction, I'd suggest extracting your single line CSV data into flowfile attributes named as you've demonstrated. i.e. create a processor which reads each CSV column as a flowfile attribute, using a configured

Processor: User friendly vs system friendly design

2016-03-19 Thread Uwe Geercken
Hello, my first mailing here. I am a Java developer, using Apache Velocity, Drill, Tomcat, Ant, Pentaho ETL, MongoDb, Mysql and more and I am very much a data guy. I have used Nifi for a while now and started yesterday of coding my first processor. I basically do it to widen my knowledge and

Re: patch and pull request reviewing question

2016-03-19 Thread Tony Kurc
Aldrin, Very cool On Mar 17, 2016 10:21 PM, "Aldrin Piri" wrote: > Sounds good to here as well. > > Given the increasing number of contributions, which predominantly seem to > arrive via GitHub PR, I also created NIFI-1615 [1] a little while ago to > make a GitHub PR

Re: Re: Processor: User friendly vs system friendly design

2016-03-19 Thread Joe Witt
This sounds pretty cool and definitely think you're both on a good track design-wise. On Fri, Mar 18, 2016 at 2:04 PM, Uwe Geercken wrote: > Adam, > > thanks again. > > I didn't know about the contributors guide - I was always looking in the docs > inside Nifi and there is

[GitHub] nifi pull request: NIFI-856 - Implements experimental ListenLumber...

2016-03-19 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/289 NIFI-856 - Implements experimental ListenLumberjack Processor ListenLumberjack processor should potentially allow NiFi to act as a drop in replacement on pipelines using logstash-forwarder and

Re: Rollbacks

2016-03-19 Thread Joe Witt
Devin, Good stuff. Unless the api call to change the content completes normally the transformation effectively did not happen. Take a look at CompressContent [1] for an example. It reads in the original content and streams out new content. If that process of transformation fails it routes the

[GitHub] nifi pull request: Nifi 1274

2016-03-19 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/284#discussion_r56425560 --- Diff: nifi-nar-bundles/nifi-kerberos-iaa-providers-bundle/nifi-kerberos-iaa-providers/src/main/java/org/apache/nifi/kerberos/KerberosProvider.java ---

Aw: Re: Processor: User friendly vs system friendly design

2016-03-19 Thread Uwe Geercken
Adam, thanks again. I didn't know about the contributors guide - I was always looking in the docs inside Nifi and there is a reference to the developer guide only. I will try to make a good processor for velocity first. The next step would then be to include also freemarker. I will try to

[GitHub] nifi pull request: NIFI-1636: Print Stacktrace When Unepected OnTr...

2016-03-19 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/285#discussion_r56420228 --- Diff: nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java --- @@ -27,7 +30,12 @@ public final void onTrigger(final ProcessContext

[GitHub] nifi pull request: Nifi 1274

2016-03-19 Thread alopresto
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/284 Nifi 1274 Adds support for Kerberos single sign-on via SPNEGO negotiation with fallback to Kerberos LoginIdentityProvider (similar to LDAP credential login). Initial PR for review. I am

[GitHub] nifi pull request: Nifi 1274

2016-03-19 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/284#discussion_r56511388 --- Diff: nifi-nar-bundles/nifi-kerberos-iaa-providers-bundle/nifi-kerberos-iaa-providers/src/test/resources/nifi.properties --- @@ -0,0 +1,185 @@ +#

[GitHub] nifi pull request: Nifi 1274

2016-03-19 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/284#discussion_r56411928 --- Diff: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-ui/src/main/java/org/apache/nifi/update/attributes/api/RuleResource.java ---

[GitHub] nifi pull request: NIFI-1629 downgraded Kafka back to 0.8

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/282 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-615 - Create a processor to extract WAV fi...

2016-03-19 Thread joewitt
Github user joewitt commented on the pull request: https://github.com/apache/nifi/pull/252#issuecomment-198149231 @jskora do the attribute names that come from the media bundles have anything special to them in terms of how tika handles them or are they purely as found in the

[GitHub] nifi pull request: Nifi 1274

2016-03-19 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/284#issuecomment-197860863 Looks really good overall. Found a couple things lingering that I believe can be removed prior to merging. Additionally, there are a number of src/test/resources in the

Re: Processor: User friendly vs system friendly design

2016-03-19 Thread Adam Taft
I'm probably on the far end of favoring composibility and processor reuse. In this case, I would even go one step further and suggest that you're talking about three separate operations: 1. Split a multi-line CSV input file into individual single line flowfiles. 2. Read columns from a single

[GitHub] nifi pull request: NIFI-1636: Print Stacktrace When Unepected OnTr...

2016-03-19 Thread rickysaltzer
Github user rickysaltzer commented on the pull request: https://github.com/apache/nifi/pull/285#issuecomment-197998896 @joewitt posted a new version of the patch. I tested it out on my local machine and it seems to work as expected. That is, the stacktrace is logged to the

[GitHub] nifi pull request: NIFI-1332 Fixed HTTP-204 handling + unit test

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/259 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-615 - Create a processor to extract WAV fi...

2016-03-19 Thread jskora
Github user jskora commented on the pull request: https://github.com/apache/nifi/pull/252#issuecomment-198408663 @joewitt, the attribute names are created by Tika and seem to be based on the source file types. The core Tika module was already in the project and the Tika parsers

[GitHub] nifi pull request: NIFI-1575: Add QueryDatabaseTable processor

2016-03-19 Thread mattyb149
Github user mattyb149 closed the pull request at: https://github.com/apache/nifi/pull/261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1631 increased timeouts on test

2016-03-19 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/283 NIFI-1631 increased timeouts on test You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-1631 Alternatively you can review and apply

[GitHub] nifi pull request: NIFI-1631 increased timeouts on test

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/283 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1636: Print Stacktrace When Unepected OnTr...

2016-03-19 Thread rickysaltzer
Github user rickysaltzer commented on a diff in the pull request: https://github.com/apache/nifi/pull/285#discussion_r56418891 --- Diff: nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java --- @@ -27,7 +30,12 @@ public final void onTrigger(final ProcessContext

[GitHub] nifi pull request: NIFI-901: Add QueryCassandra and PutCassandraQL...

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/237 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-901: Fixed unit test to verify IP address ...

2016-03-19 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/286#issuecomment-197997930 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Aw: Re: Processor additional documentation

2016-03-19 Thread Uwe Geercken
Bryan, all looks ok. I looked into the nifi-home/work/docs folder. There is nothing but a components folder. Inside there is a folder for my processor: com.datamelt.nifi.test.TemplateProcessor and inside the folder there is a file index.html and it contains the code of my

[GitHub] nifi pull request: NIFI-1488 Refactoring HBase Kerberos support

2016-03-19 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/281#discussion_r56410960 --- Diff: nifi-commons/nifi-hadoop-utils/src/main/java/org/apache/nifi/hadoop/KerberosTicketRenewer.java --- @@ -0,0 +1,69 @@ +/* + * Licensed to the

[GitHub] nifi pull request: NIFI-1337: Add Riemann Reporting Task

2016-03-19 Thread rickysaltzer
Github user rickysaltzer commented on the pull request: https://github.com/apache/nifi/pull/188#issuecomment-198464162 hey @joewitt - not an issue. I haven't actually put this patch into production yet, but I have a good use case to try it out today / over the weekend. Let me give

[GitHub] nifi pull request: NIFI-1636: Print Stacktrace When Unepected OnTr...

2016-03-19 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/285#discussion_r56419500 --- Diff: nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java --- @@ -27,7 +30,12 @@ public final void onTrigger(final ProcessContext

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/271 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: patch and pull request reviewing question

2016-03-19 Thread Mark Payne
+1 Yes please! Sent from my iPhone > On Mar 17, 2016, at 9:38 PM, Tony Kurc wrote: > > As I was reviewing a pull request, i realized that it actually was a bit > more mental effort in this instance to review a squashed and rebased set of > commits than if it was if I could

Re: patch and pull request reviewing question

2016-03-19 Thread Joe Witt
+1 On Thu, Mar 17, 2016 at 9:37 PM, Tony Kurc wrote: > As I was reviewing a pull request, i realized that it actually was a bit > more mental effort in this instance to review a squashed and rebased set of > commits than if it was if I could just review the changes in a commit.

[GitHub] nifi pull request: NIFI-901: Fixed unit test to verify IP address ...

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/286 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1636: Print Stacktrace When Unepected OnTr...

2016-03-19 Thread rickysaltzer
Github user rickysaltzer commented on a diff in the pull request: https://github.com/apache/nifi/pull/285#discussion_r56420502 --- Diff: nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java --- @@ -27,7 +30,12 @@ public final void onTrigger(final ProcessContext

[GitHub] nifi pull request: Nifi 1274

2016-03-19 Thread alopresto
Github user alopresto commented on the pull request: https://github.com/apache/nifi/pull/284#issuecomment-197610965 I removed all added TODO statements. I created NIFI-1637 to refactor the duplicated `KerberosUserDetailsService` and `AlternateKerberosUserDetailsService` to a shared

[GitHub] nifi pull request: NIFI-1571 initial commit of SpringContext suppo...

2016-03-19 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/271#discussion_r56446521 --- Diff: nifi-nar-bundles/nifi-spring-bundle/nifi-spring-processors/src/main/java/org/apache/nifi/spring/SpringContextProcessor.java --- @@ -0,0 +1,392 @@

Re: Closing in on the Apache NiFi 0.6.0 release

2016-03-19 Thread Joe Witt
Team, Ok sooo close. We have 6 tickets remaining. - Additional functionality/cleanup for SplitText [1] [status] Still in discussions. Recommend we move this change to 0.7.0. Solid effort on both code contributor and reviewer side but this is a tricky one. - Support Kerberos based

[GitHub] nifi pull request: Nifi 1274

2016-03-19 Thread JPercivall
Github user JPercivall commented on the pull request: https://github.com/apache/nifi/pull/284#issuecomment-197944422 +1 (with Gilman's last modifications) Used Gilman's branch to do a contrib check build, reviewed that comments were addressed and ran through setting up a

[GitHub] nifi pull request: Nifi 1274

2016-03-19 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/284#discussion_r56507392 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/jwt/JwtService.java ---

  1   2   >