Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/461#discussion_r64257999
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/461#discussion_r64256472
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java
---
@@ -321,6
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/461#discussion_r64256311
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java
---
@@ -321,6
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/461#discussion_r64249465
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/461#discussion_r64248276
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/461#discussion_r64248023
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/groups/ProcessGroup.java
---
@@ -46,6
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/461#discussion_r64247888
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/groups/ProcessGroup.java
---
@@ -46,6
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/303#discussion_r64235176
--- Diff:
nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestQuery.java
---
@@ -233,6 +233,24 @@ public
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/303#discussion_r64234770
--- Diff:
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/JsonPathEvaluator.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/459#discussion_r64097658
--- Diff:
nifi-nar-bundles/nifi-avro-bundle/nifi-avro-processors/src/main/java/org/apache/nifi/processors/avro/ConvertAvroToJSON.java
---
@@ -128,49 +141,77
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/459#discussion_r64097258
--- Diff:
nifi-nar-bundles/nifi-avro-bundle/nifi-avro-processors/src/main/java/org/apache/nifi/processors/avro/ConvertAvroToJSON.java
---
@@ -92,6 +103,7
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/454#issuecomment-220610191
@mcgilman I agree, I do think it makes more sense to handle that in the
Revision. Have updated the PR to back that out so that we can instead do it in
the Resource in
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/454#discussion_r64043396
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-optimistic-locking/src/main/java/org/apache/nifi/web/revision
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/454
NIFI-1745: Refactor how revisions are handled at NCM/Distributed to Node
This is part 2 of NIFI-1745, which provides user info to revision
claims/locks and removes the cluster context, as it is no
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/439#discussion_r63425823
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/repository
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/439#discussion_r63425553
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/439#discussion_r63425128
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/439#discussion_r63344780
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/446#discussion_r63344217
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/Template.java
---
@@ -0,0
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/446
NIFI-1801: Scope Templates to Process Groups
Also includes a few bug fixes that were not necessarily explicitly related
to templates being scoped to Process Groups but that are required in order to
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/441
NIFI-1872: Allow for adequate time for embedded zookeeper server to startup
for unit tests
PR for 0.x baseline
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/440
NIFI-1872: Allow sufficient time for embedded server to startup for uâ¦
â¦nit tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/437
NIFI-1872: Ignore failing unit test for now until we can properly address
Since it is on master it's best to ignore, since the problem appears to be
the lifecycle of the unit test
You can
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/419#issuecomment-218585975
@bbende I merged this to 0.x branch. However, it cannot be merged to the
'master' branch as-is. Can you create a PR That will merge to master?
---
If your
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/419#discussion_r62914873
--- Diff:
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/420#issuecomment-218563978
Excellent. Yes, I'm thinking potentially Avro, JSON, Parquet... perhaps
others. For 0.7.0 we may only have CSV and perhaps JSON but will have things in
place to add
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/419#discussion_r62906770
--- Diff:
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/419#discussion_r62907252
--- Diff:
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/419#discussion_r62906556
--- Diff:
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/419#discussion_r62906404
--- Diff:
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/420#issuecomment-218543143
@ToivoAdams as I think even more about this, it's opening up a lot of
awesome possibilities. I think we could expand this Processor even more into
really a "SQ
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/420#issuecomment-218531630
@ToivoAdams After looking at this a bit more, I've got a few very
high-level thoughts. First is that what you have built here is incredibly
awesome and powerful! I
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/420#issuecomment-218520423
I don't think we can use the provided test data as-is. Looking at
http://www.briandunning.com/sample-data/ I don't see any sort of LICENSE info.
Probably be
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/431#issuecomment-218459759
@mcgilman sorry - it appears that I messed up with I pushed the changes to
the branch, before I created the PR. What you looked at was an incomplete
version from a few
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/431
NIFI-1800: Tie Controller Services to Process Groups
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-1800
Alternatively you
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/420#discussion_r62701492
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterCSVColumns.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/420#discussion_r62701269
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterCSVColumns.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/420#discussion_r62700516
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/resources/TestFilterCSVColumns/US500.csv
---
@@ -0,0 +1
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/420#discussion_r62701139
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterCSVColumns.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/420#discussion_r62700846
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterCSVColumns.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/420#discussion_r62700756
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestFilterCSVColumns.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/420#discussion_r62700767
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestFilterCSVColumns.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/420#discussion_r62700624
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestFilterCSVColumns.java
Github user markap14 closed the pull request at:
https://github.com/apache/nifi/pull/338
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/413
NIFI-1745: Refactor how requests are replicated across cluster
This still has some work to be done, but I believe it's worth merging into
master now, only because we need to merge these changes
Github user markap14 closed the pull request at:
https://github.com/apache/nifi/pull/391
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/394
NIFI-1830: Fixed problems in the merging logic for Drop FlowFile Requests
NIFI-1830: Fixed problems in the merging logic for Drop FlowFile Requests
You can merge this pull request into a Git
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/389#discussion_r61509041
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpResponse.java
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/377#issuecomment-215533199
We have talked before about having some sort of icon on a connection that
indicates that back pressure is configured and then some sort of indicator that
back pressure
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/389#discussion_r61485635
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpResponse.java
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/391
NIFI-1824: If attempting to archive content, and there are no claimant
counts for it, ensure that the stream is closed.
NIFI-1824: If attempting to archive content, and there are no claimant
counts
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/323#discussion_r60782947
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/manager/impl
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/323#discussion_r60782754
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/323#discussion_r60782492
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/323#discussion_r60782403
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/323#discussion_r60782213
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/323#discussion_r60782150
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/323#discussion_r60781637
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/323#discussion_r60781488
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/323#discussion_r60781310
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol/src/main/java/org/apache/nifi/cluster/protocol/jaxb/message
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/372#discussion_r60474410
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java
---
@@ -0,0 +1,184
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/372#discussion_r60474156
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java
---
@@ -0,0 +1,184
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/369
NIFI-1790: Updated the URI patterns used in NCM for determining whether or
not responses should be merged
NIFI-1790: Updated the URI patterns used in NCM for determining whether or
not responses
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/365#issuecomment-212085785
+1 this looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/365#discussion_r60290762
--- Diff:
nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/StandardValidators.java
---
@@ -127,12 +127,26 @@ public
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/359#issuecomment-210618998
Looks like the latest commit addresses both issues outlined above. Will
merge into master.
Thanks for knocking this out!
---
If your project is set up for it, you
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/359#issuecomment-210612644
Looks good. I verified that I was able to start NiFi using both secure and
non-secure ports. I was then able to verify that I was able to add each
component, update it
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/321#discussion_r59908921
--- Diff: nifi-mock/src/main/java/org/apache/nifi/util/TestRunner.java ---
@@ -865,4 +866,21 @@
* @return the State Manager that is used to store and
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/352
NIFI-1762: Use Lambda Expressions in StandardNiFIServiceFacade to simplify
codebase
Changed Java dependency to 1.8 instead of 1.7 and refactored
StandardNiFiServiceFacade to make use of Lambda
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/338
NIFI-1727: Refactored logic for merging HTTP Requests
Refactored logic for merging HTTP Requests that are federated across cluster
You can merge this pull request into a Git repository by running
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/337#discussion_r59014799
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/337#discussion_r59014716
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/337#discussion_r59014646
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/337#discussion_r59014373
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/330#issuecomment-207066913
Latest commit looks good. Performed code review and then verified
contrib-check and unit tests. +1
---
If your project is set up for it, you can reply to this email and
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/330#discussion_r58933064
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-file-authorizer/src/test/java/org/apache/nifi/authorization/FileAuthorizerTest.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/330#discussion_r58930317
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-file-authorizer/src/main/java/org/apache/nifi/authorization/FileAuthorizer.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/330#discussion_r58929464
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-administration/src/main/java/org/apache/nifi/authorization
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/323#issuecomment-206513343
I updated the PR with a new commit to address an issue that I ran into.
When we create 'container' nodes in ZooKeeper whose paths are not sensitive, we
wil
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/323#issuecomment-206513196
I updated the PR with a new commit to address an issue that I ran into.
When we create 'container' nodes in ZooKeeper whose paths are not sensitive, we
wil
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/317#issuecomment-206489781
I updated the PR with a new commit to address an issue that I ran into.
When we create 'container' nodes in ZooKeeper whose paths are not sensitive, we
wil
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/323
NIFI-1678
Push heartbeats to ZooKeeper instead of NCM
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-1678
Alternatively you
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/318#discussion_r58253202
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-administration/src/main/java/org/apache/nifi/authorization
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/318#discussion_r58252888
--- Diff:
nifi-api/src/main/java/org/apache/nifi/authorization/AuthorizationRequest.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/318#discussion_r58252574
--- Diff:
nifi-api/src/main/java/org/apache/nifi/authorization/AuthorizationRequest.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/318#discussion_r58251303
--- Diff:
nifi-api/src/main/java/org/apache/nifi/authorization/AuthorizationRequest.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/317#issuecomment-204498317
@mcgilman I agree - we certainly need to address the duplication of
configuration. However, I do believe that is a job for another ticket. I went
ahead and added
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/317
NIFI-1678
Refactored NCM & Nodes so that nodes send heartbeats to ZooKeeper and NCM
reads heartbeats from ZooKeeper.
You can merge this pull request into a Git repository by running:
$
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/306#issuecomment-202419168
@ToivoAdams very cool that you're tackling this! Thanks for jumping in! The
only concern that I have with this patch is that if we end up with a buggy
processor
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/301
NIFI-483: Use ZooKeeper Leader Election to Auto-Elect Primary Node
NIFI-483: Use ZooKeeper Leader Election to Auto-Elect Primary Node
You can merge this pull request into a Git repository by running
Github user markap14 closed the pull request at:
https://github.com/apache/nifi/pull/294
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/300
NIFI-1676: Do not allow Processor to be started if state is STOPPING
Need to ensure that processor state is STOPPED, not STOPPING
You can merge this pull request into a Git repository by running
Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/294#issuecomment-200355764
@mcgilman I looked at the commit that you proposed. Looks good! +1. Thanks
for jumping in there and fixing that!
---
If your project is set up for it, you can reply to
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/295#discussion_r57096148
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/KafkaPublisher.java
---
@@ -104,21 +128,52
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/295#discussion_r57087522
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/PutKafka.java
---
@@ -371,11 +371,12
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/295#discussion_r57044106
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/Partitioners.java
---
@@ -0,0 +1,87
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/295#discussion_r57026907
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/PutKafka.java
---
@@ -446,444 +336,136
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/295#discussion_r57019067
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/Partitioners.java
---
@@ -0,0 +1,87
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/295#discussion_r57018795
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/Partitioners.java
---
@@ -0,0 +1,87
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/295#discussion_r57017510
--- Diff:
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/processors/kafka/KafkaPublisher.java
---
@@ -0,0 +1,159
101 - 200 of 421 matches
Mail list logo
