Re: [GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Thanks for the prompt reply.   || This email has been sent from a virus-free computer protected by Avast. www.avast.com | My processor set isn't QPID specific, as you say it is the protocol not the client provider that dictates how the connection is made to AMQP. I used the Apache Qpid

Re: [GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

David Thank you so much for reaching out. The reason why I am using RabbitMQ client library is because I am familiar with it, but as you aware AMQP is a protocol-based specification therefore it doesn’t mater which client library is used as long as they are compliant with the protocol version

Re: [GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

I hate spell checker. The last sentence in previous response should read compliant instead of compliment. Sent from my iPhone > On Feb 6, 2016, at 17:46, Oleg Zhurakousky > wrote: > > David > > Thank you so much for reaching out. > The reason why I am using

Re: [GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Hi Guys || This email has been sent from a virus-free computer protected by Avast. www.avast.com | As you may remember I have developed some processors that publish/subscribe to AMQP brokers, but I was having problems writing Junit tests for these processors. I was interested to see that

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/200#issuecomment-178925056 @bbende doing it now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/200#issuecomment-178928684 @bbende done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51593685 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/ConsumeAMQP.java --- @@ -0,0 +1,138 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51594383 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AbstractAMQPProcessor.java --- @@ -0,0 +1,204

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51596690 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPUtils.java --- @@ -0,0 +1,115 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51598556 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -0,0 +1,219 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51598495 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -0,0 +1,219 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51599382 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -0,0 +1,219 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51600893 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -0,0 +1,219 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51600649 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPWorker.java --- @@ -0,0 +1,104 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51601774 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPPublisher.java --- @@ -0,0 +1,134 @@

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51599615 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -0,0 +1,219 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51600206 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java --- @@ -0,0 +1,219 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51600426 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPWorker.java --- @@ -0,0 +1,104 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51602109 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPWorker.java --- @@ -0,0 +1,104 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51602176 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPUtils.java --- @@ -0,0 +1,115 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51602345 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPUtils.java --- @@ -0,0 +1,115 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51602747 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPUtils.java --- @@ -0,0 +1,115 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user olegz commented on the pull request: https://github.com/apache/nifi/pull/200#issuecomment-178641022 Sorry, the S2 naming habit. Will change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51593209 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AbstractAMQPProcessor.java --- @@ -0,0 +1,204

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51593879 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AbstractAMQPProcessor.java --- @@ -0,0 +1,204 @@

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51595280 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPUtils.java --- @@ -0,0 +1,115 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51603654 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPUtils.java --- @@ -0,0 +1,115 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/200#issuecomment-178705663 Oleg - I have not tested this with any real AMQP data, though I know others have. I have just done a review of the code itself. Several inline comments but aside from

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51604497 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPWorker.java --- @@ -0,0 +1,104 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51604778 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPUtils.java --- @@ -0,0 +1,115 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/200#discussion_r51605138 --- Diff: nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/AMQPWorker.java --- @@ -0,0 +1,104 @@ +/*

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user bbende commented on the pull request: https://github.com/apache/nifi/pull/200#issuecomment-178920339 @olegz I think this is good to go from a review perspective. There appears to be some conflicts in pom files now because another bundle just got added. Can you rebase to

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/200 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-865 added initial support for AMQP publish...

Github user apiri commented on the pull request: https://github.com/apache/nifi/pull/200#issuecomment-178325971 Had checkstyle violations for unused imports: > [INFO] --- maven-checkstyle-plugin:2.15:check (check-style) @ nifi-amqp-processors --- [WARNING]