Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/339
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Hey folks,
Just a note to let you know that AppVeyor has been incorporated for our 0.x
and master branches. Not much will change in terms of the normal
contribution process but we will receive indications for those PRs/branches
that have the appveyor.yml (you may wish to rebase off your source
Github user mattyb149 commented on the pull request:
https://github.com/apache/nifi/pull/408#issuecomment-216634155
Built and ran all tests including the added unit tests, everything LGTM,
thanks! +1
---
If your project is set up for it, you can reply to this email and have your
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/411
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/347#issuecomment-216612204
@pvillard31 Are you planning to add tests for this? If not I can take a
crack at it. LMK.
---
If your project is set up for it, you can reply to this email and have your
Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/343#issuecomment-216616469
Agreed and thanks! Will have to adjust slightly to apply to 1.0, but will
take care of that now.
---
If your project is set up for it, you can reply to this email and
Hi all,
As a result of some conversations and some varying feedback on PRs, I’d like to
discuss with the community an issue I see with PropertyDescriptor name and
displayName attributes. I’ll describe the scenarios that cause issues and my
proposed solution, and then solicit responses and
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/1#discussion_r61941921
--- Diff: Makefile ---
@@ -0,0 +1,40 @@
+CC=g++
--- End diff --
Will need the ASL header on our Makefile as well.
---
If your project
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/390#issuecomment-216611109
Given @joewitt latest comment in JIRA we may need to close this a "No Fix"
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mattyb149 commented on the pull request:
https://github.com/apache/nifi/pull/408#issuecomment-216632581
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/339#issuecomment-216612703
+1. I am going to merge this unless there are objections. Documentation is
an ongoing task, so I am sure there will be updates to it in the future, and
will be addressed
Github user mattyb149 closed the pull request at:
https://github.com/apache/nifi/pull/384
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user pvillard31 closed the pull request at:
https://github.com/apache/nifi/pull/390
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61937600
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,288 @@
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/392#issuecomment-216610646
Also, can you update the PR message with some description? Currently it
only shows 'NIFI-1808'
---
If your project is set up for it, you can reply to this email and have
Github user mattyb149 commented on the pull request:
https://github.com/apache/nifi/pull/354#issuecomment-216614373
Reviewed, LGTM and works well, thanks very much! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/411#issuecomment-216637498
Looks good now. Validated no more trailing white spaces. +1 for merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user YolandaMDavis closed the pull request at:
https://github.com/apache/nifi/pull/405
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/343#issuecomment-216616249
+1. We need to get it out there and if some minor issues pop up will
address them as we go along. Otherwise all builds are in failed state at the
moment.
---
If your
I am definitely +1 on this.
The only question I have is related to "Add code to warn (without blocking) on
processors missing displayName attributes”. Did you mean in he code itself
where some validator in the abstract class would flag it with a WARN or some
build plugin?
Cheers
Oleg
On May
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/335#issuecomment-216625510
@owieboy First of all thank you for a contribution
Unfortunately this PR is now a duplicate and we would have noticed it a
while back if it had an associated JIRA. IN
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/408
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi/pull/224#discussion_r61939505
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/dynamodb/PutDynamoDB.java
---
@@ -0,0 +1,182 @@
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/395#issuecomment-216619770
Looks great. The update to the global menu addresses my concerns that I was
hoping we could address in the next PR. I've merged this into master.
Thanks!
---
I'm a +0 here. However, the third bullet point that you listed, and the one
Oleg is asking for clarification on here:
* Add code to warn (without blocking) on processors missing displayName
attributes
I would recommend that we address this within the scope of NIFI-34 [1]. I.e, we
don't want
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/354
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Awesome! Thanks for digging into all of this, Aldrin!
-Mark
> On May 3, 2016, at 2:56 PM, Aldrin Piri wrote:
>
> Hey folks,
>
> Just a note to let you know that AppVeyor has been incorporated for our 0.x
> and master branches. Not much will change in terms of the normal
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/347#issuecomment-216635676
Sure, I'll give it a shot
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Hi Joe,
This is what I am getting while running both master and node
IllegalStateException: Application may be configured as a cluster manager or a
node, but not both
Regards,
Sourav Gulati
-Original Message-
From: Joe Witt [mailto:joe.w...@gmail.com]
Sent: Monday, May 02, 2016 6:45
Hi All,
Nifi-0.6.1 is compatible with which kafka version?
Regards,
Sourav Gulati
NOTE: This message may contain information that is confidential, proprietary,
privileged or otherwise protected by law. The message is intended solely for
the named
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/406
NIFI-1773 NIFI-1774 fixed typo/annotation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-1774-NIFI-1773
Alternatively
Mark,
I am fine including it in the best practices validator linked in your message,
but it doesn’t look like there has been any work on that ticket since January
2016.
As a quick solution (and to answer Oleg’s question), I think we could add a
simple Checkstyle regex rule [1] to detect the
Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/370#issuecomment-216654320
Merged as a result of #343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user apiri closed the pull request at:
https://github.com/apache/nifi/pull/370
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61948441
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,288 @@
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61949840
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/SubscribeMQTT.java
---
@@ -0,0 +1,301 @@
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61949787
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/SubscribeMQTT.java
---
@@ -0,0 +1,301 @@
Github user alopresto commented on the pull request:
https://github.com/apache/nifi/pull/267#issuecomment-216661583
I'm away from my keyboard right now but I have always used the
`maven:shade` plugin.
Andy LoPresto
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61956949
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,288 @@
+/*
Hi,
I am using 0.8.1.1 , I am not seeing any exception in logs . however, still it
is not writing to kafka. Any suggestions?
Regards,
Sourav Gulati
-Original Message-
From: Oleg Zhurakousky [mailto:ozhurakou...@hortonworks.com]
Sent: Tuesday, May 03, 2016 4:14 PM
To:
It will be vey hard to suggest anything without any details. Have you looked at
Kafka logs?
Oleg
> On May 3, 2016, at 7:30 AM, Sourav Gulati wrote:
>
> Hi,
>
>
> I am using 0.8.1.1 , I am not seeing any exception in logs . however, still
> it is not writing to
I upgraded kafka to 0.9.0 and now its working
Regards,
Sourav Gulati
-Original Message-
From: Oleg Zhurakousky [mailto:ozhurakou...@hortonworks.com]
Sent: Tuesday, May 03, 2016 5:25 PM
To: dev@nifi.apache.org
Subject: Re: Quick Question- Nifi Kafka
It will be vey hard to suggest
Hi
It was tested with 0.8.2 and 0.9, but it does not use new consumer API. We are
working on a new version of Kafka support slated for 0.7 release
Cheers
Oleg
> On May 3, 2016, at 02:20, Sourav Gulati wrote:
>
> Hi All,
>
> Nifi-0.6.1 is compatible with
Sourav,
A single instance of NiFi cannot be both a NCM and a Node at the same
time. In order to have both a NCM and a Node on a single server, you will
need to install two copies of NiFi. One will be configured to be the NCM
while the other is configured to be the Node. As Joe pointed out,
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/402
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/402#issuecomment-216508899
Thanks @devin-fisher ! I've merged this into both the master and 0.x
baseline. Just a heads, I noticed that the text of the message was also
incorrect so I amended your
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/339#discussion_r61892737
--- Diff: nifi-docs/src/main/asciidoc/nifi-in-depth.adoc ---
@@ -0,0 +1,209 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one or
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/339#discussion_r61892921
--- Diff: nifi-docs/src/main/asciidoc/nifi-in-depth.adoc ---
@@ -0,0 +1,209 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one or more
Oleg,
I would love to help -- couple of quick questions:
The GH PR's are ~60 as you indicated, but the How To Contribute guide (Code
review process --
https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-CodeReviewProcess
) shows a JIRA list with patches available.
Github user PuspenduBanerjee commented on the pull request:
https://github.com/apache/nifi/pull/400#issuecomment-216557197
@markap14 If it looks good, will you be able to check in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/339#issuecomment-216561922
@olegz addressed the comments in a new commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Andrew
Thank you so much for following up on this.
I am assuming you have GitHub account. If not please create one as most of our
contributions deal with pull requests (PR).
Then you can go to https://github.com/apache/nifi , click on “Pull Requests”
and review them by commenting in line (you
Thank you Oleg!
Yeah, that page with the Code Review, has a little refresh link, but it
really just points to this JIRA query:
https://issues.apache.org/jira/browse/NIFI-1837?filter=12331874
As a community is there a preference given to JIRA's with Patch or GH PR's
or are they all treated with
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/409
NIFI-1840 Added compression type property in Kite processors
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-1840
Hello,
I created a template [1] that shows an example of how to do the date
conversion you described. It is linked to from the main templates page on
the wiki [2] and is named "DateConversion.xml"
It first uses ExtractText to find the date string and extract it into an
attribute called "date".
Andrew
Regarding PR vs. Patch.
This has been an ongoing discussion and i’ll let other’s to contribute to this.
Basically we support both. That said, personally (and it appears to be embraced
by the rest of the community) PR is the preference specifically due to the
inline review/comment
Github user scottyaslan commented on the pull request:
https://github.com/apache/nifi/pull/395#issuecomment-216535306
Thanks @mcgilman! I have made some updates:
- The issue with the birdseye view has been resolve.
- The flowfont and font-awesome files have been separated.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-site/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
...this is what I see in the nifi-app.log
> java.lang.IllegalArgumentException: Comparison method violates its general
> contract!
> at java.util.ComparableTimSort.mergeHi(ComparableTimSort.java:866)
> ~[na:1.8.0_91]
> at
Mike,
We've seen this before in some environments and believe the issue has been
addressed in Jetty [1]. We need to identify which versions of Jetty the issue
was resolved in and get that included in the next NiFi release. Sorry for the
inconvenience.
Matt
[1]
Hi Mike,
What version of Java are you using?
The master branch of NiFi is working towards the 1.0 release which will
only support Java 8.
The 0.x branch is where the next 0.x release will happen, likely 0.7 if the
community chooses to do so, and this branch still supports Java 7.
-Bryan
On
I tried adding the following to the bootstrap command which addresses the
exception but now the connection just times out.
>
> -Djava.util.Arrays.useLegacyMergeSort=true
On 4 May 2016 at 03:48, Mike Harding wrote:
> ...this is what I see in the nifi-app.log
>
>
>>
Hi Mike,
I just did a git checkout of master, built the code, and started it, and it ran
fine. Can you let us know what OS, version of Java, version of Maven, and
version of Git you are using? Did you check out the source code from the Apache
NiFi repository on GitHub [1]? Thanks.
[1]
Hi,
I just complied the latest master from the repo and I'm seeing the
following error each time I try and run the nifi server. The particular
error is:
*Failed to start web server: Comparison method violates its general
contract!*
I'm lost for ideas on how to address this issue ?
Any help
Github user adamonduty commented on a diff in the pull request:
https://github.com/apache/nifi/pull/256#discussion_r61990183
--- Diff:
nifi-nar-bundles/nifi-slack-bundle/nifi-slack-processors/src/test/java/org/apache/nifi/processors/slack/PutSlackTest.java
---
@@ -0,0 +1,103 @@
Github user adamonduty commented on a diff in the pull request:
https://github.com/apache/nifi/pull/238#discussion_r61991253
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java
---
@@ -0,0 +1,232 @@
+/*
Github user adamonduty commented on a diff in the pull request:
https://github.com/apache/nifi/pull/238#discussion_r61991205
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java
---
@@ -0,0 +1,232 @@
+/*
They are treated with same priority, but as Oleg mentioned, the PRs do make
it easier for collaborative review and has the built in integration with
Travis, although currently some issues to get it consistently working.
On Tue, May 3, 2016 at 11:26 AM, Suneel Marthi wrote:
>
PR is the standard now across most Apache projects.
On Tue, May 3, 2016 at 11:25 AM, Oleg Zhurakousky <
ozhurakou...@hortonworks.com> wrote:
> Andrew
>
> Regarding PR vs. Patch.
>
> This has been an ongoing discussion and i’ll let other’s to contribute to
> this. Basically we support both. That
The "Patch Available" state in JIRA can mean a patch is attached to the
JIRA, or a PR is submitted.
It is really just a manual state transition on the ticket after
In-Progress... the next state is patch available which tells people there
is something to review.
On Tue, May 3, 2016 at 11:29 AM,
Totally makes sense. My only comment was just in regards to the fact that
on that Wiki page there is no mention of looking at GH PR's. I agree that
in this day and age looking to GH, may be first inclination for many.
However, perhaps calling that out in the contribution guide would eliminate
Totally agree on all fronts. Would seem like it makes sense for a
documentation PR to be opened soon with updates to the
https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-CodeReviewProcess
page to remove the ambiguity.
On Tue, May 3, 2016 at 11:27 AM, Bryan
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/407
NIFI-1759 Upgrade of commons-compress
Checked:
- no regression
- no use of deprecated methods
You can merge this pull request into a Git repository by running:
$ git pull
Guys
I’d like to use this opportunity to address all members of the NiFi community
hence this email is sent to both mailing lists (dev/users)
While somewhat skeptical when I started 6 month ago, I have to admit that now I
am very excited to observe the growth and adaption of the Apache NiFi
Hello,
Regarding the CsvToJson template, here is what is happening...
1) GenerateFlowFile produces a FlowFile to simulate some data
2) ReplaceText sets the content of that flow file to "a,b,c,d" to represent
and example CSV line
Steps 1 and 2 are just simulating data that would really come
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/408
NIFI-1721 updated mock framework to return correct number of threads from
mock context
You can merge this pull request into a Git repository by running:
$ git pull
Hi,
I am trying to make use of ReplaceText in order to match each each line of
delimited values (.dsv files) whose format is: DD-MM- HH.MM.SS and
replace it with -MM-DD HH:MM:SS+. I am not sure I have really
understood how to use this out-of-the-box processor and I looked at various
I think I figured it out now. I was getting syslog data from various boxes
(GetSysLog) and using the attributes from a ParseSysLog processor to
publish to a destination using PutSysLog. However, because the socket
connection comes from our NiFi's IP, the IP address associated with the
PutSysLog
Github user adamonduty commented on a diff in the pull request:
https://github.com/apache/nifi/pull/238#discussion_r61991245
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java
---
@@ -0,0 +1,232 @@
+/*
Github user adamonduty commented on the pull request:
https://github.com/apache/nifi/pull/238#issuecomment-216751696
@apiri Thanks for the review! All your comments should be addressed except
the state management pieces.
State management should work more or less like
Github user adamonduty commented on a diff in the pull request:
https://github.com/apache/nifi/pull/238#discussion_r61991321
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java
---
@@ -0,0 +1,232 @@
+/*
Github user adamonduty commented on a diff in the pull request:
https://github.com/apache/nifi/pull/238#discussion_r61991342
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java
---
@@ -46,7 +46,7 @@
Github user adamonduty commented on a diff in the pull request:
https://github.com/apache/nifi/pull/238#discussion_r61991389
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/FetchS3Object.java
---
@@ -46,7 +46,7 @@
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61912184
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,288 @@
+/*
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61913088
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,288 @@
+/*
1) Replacing with GetFile sounds good
2) You are correct, there is nothing to set since you are getting it from
GetFile
3) You could probably replace all those characters with one ReplaceText
processor where the Search Value is something like (\n|\r|\t) and the
Replacement Value is empty.
I
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61916053
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/SubscribeMQTT.java
---
@@ -0,0 +1,301 @@
+/*
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61917098
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/SubscribeMQTT.java
---
@@ -0,0 +1,301 @@
+/*
Hi Bryan, as always you are a star!
Thank you so much for your help. It does start making much more sense now, I
cannot thank you enough, this flow is really something challenging
considering my current knowledge of NiFi. So, in my case:
1 ) I have replaced GenerateFlowFile with GetFile (which
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61913245
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,288 @@
+/*
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61916950
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/SubscribeMQTT.java
---
@@ -0,0 +1,301 @@
+/*
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/410
NIFI-981: Added SelectHiveQL and PutHiveQL processors
Forward-port of #384 to the master branch
You can merge this pull request into a Git repository by running:
$ git pull
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61913545
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,288 @@
+/*
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61915046
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/PublishMQTT.java
---
@@ -0,0 +1,288 @@
+/*
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61917246
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/SubscribeMQTT.java
---
@@ -0,0 +1,301 @@
+/*
Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/392#discussion_r61917362
--- Diff:
nifi-nar-bundles/nifi-mqtt-bundle/nifi-mqtt-processors/src/main/java/org/apache/nifi/processors/mqtt/common/AbstractMQTTProcessor.java
---
@@ -0,0
Github user bbende commented on the pull request:
https://github.com/apache/nifi/pull/384#issuecomment-216595481
Latest changes look good, I am a +1 again :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
98 matches
Mail list logo