[GitHub] nifi-fds issue #1: [NIFIREG-168] upgrade to angular v5.2.0, angular-material...

2018-04-23 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi-fds/pull/1 Will review... ---

[GitHub] nifi-registry issue #1: NIFIREG-1 Initial project structure for NiFi Registr...

2017-07-11 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi-registry/pull/1 Awesome thanks @bbende! Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #611: NIFI-2119 Fixed 0.7.0 release blocker for cluster secure co...

2016-07-06 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/611 Thanks @alopresto! The changes look good. I have verified the changes locally in a secured cluster. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi issue #610: NIFI-2170: Refactor RevisionManager into a RevisionManager ...

2016-07-06 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/610 Looks good @markap14! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #611: NIFI-2119 Fixed 0.7.0 release blocker for cluster secure co...

2016-07-06 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/611 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #610: NIFI-2170: Refactor RevisionManager into a RevisionManager ...

2016-07-06 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/610 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #594: [NIFI-2081] Responsive dialog content, tab content, and scr...

2016-07-06 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/594 Thanks @scottyaslan! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #603: NIFI-1781: Updating UI to respect access controls ou...

2016-07-02 Thread mcgilman
Github user mcgilman closed the pull request at: https://github.com/apache/nifi/pull/603 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request #603: NIFI-1781: Updating UI to respect access controls ou...

2016-07-01 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/603 NIFI-1781: Updating UI to respect access controls outside of canvas - Updating UI according to permissions through out the application. - Shuffling provenance events, template, and cluster search

[GitHub] nifi issue #593: NIFI-2150: Cleanse more values from templates that are not ...

2016-07-01 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/593 @markap14 Looks great! I made one additional change to populate snippet results off of the actual components instead of just the snippet contents (since the contents are now pruned). https

[GitHub] nifi pull request #592: NIFI-2123: Add authorization of provenance events

2016-06-29 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/592#discussion_r69003620 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java

[GitHub] nifi issue #589: NIFI-1952 Update to revision-locking for users and groups

2016-06-28 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/589 @jtstorck looks good. However, I noticed that the revision version was being necessarily checked. Those are already verified in the Tenant and AccessPolicy resource. Also, I updated the error message

[GitHub] nifi issue #590: NIFI-2138 Making AccessPolicy have a single RequestAction

2016-06-28 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/590 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #588: NIFI-2127 Adding support for managing the user-group relati...

2016-06-28 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/588 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #577: [NIFI-2027] Responsive Tables

2016-06-28 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/577 Thanks @scottyaslan! This has been merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #582: NIFI-1952 Updates to REST resources for user/group manageme...

2016-06-26 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/582 I've merged this to master. Looks good @jtstorck! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #581: NIFI-1916 Improvements to FileAuthorizer to not parse flow ...

2016-06-24 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/581 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #579: NIFI-1554: Changing process for cluster detection

2016-06-24 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/579 NIFI-1554: Changing process for cluster detection - Updating cluster detection to support access through the flow resource. - Using the correct resource when authorizing a root group port during

[GitHub] nifi issue #577: [NIFI-2027] Responsive Tables

2016-06-24 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/577 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #572: NIFI-2059: Ensure that we properly pass along proxie...

2016-06-23 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/572#discussion_r68293664 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/replication

[GitHub] nifi issue #566: NIFI-2061 Ensure nodes in a cluster use consistent authoriz...

2016-06-23 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/566 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #567: NIFI-1554: Continuing to incorporate component based...

2016-06-23 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/567 NIFI-1554: Continuing to incorporate component based authorization - Addressing access controls for the Controller resource. - Addressing access controls for RAW site to site clients

[GitHub] nifi issue #559: NIFI-2075: Addressing issues with Provenance Page

2016-06-22 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/559 Thanks @scottyaslan! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #523: [NIFI-1879] Responsive dialogs and dialog UX refresh

2016-06-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/523 @scottyaslan Looks great! The additions made since the initial PR have really improved the performance of various parts. I've merged this to master. --- If your project is set up

[GitHub] nifi issue #517: NIFI-1994: Fixed issues with controller services and templa...

2016-06-20 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/517 Looks good @markap14 Had one minor issue ensuring controller services are copied as part of a process group dto. I tweak your commit to include the additionally functionality. --- If your

[GitHub] nifi issue #511: NIFI-1850 - JSON-to-JSON Schema Converter Editor

2016-06-20 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/511 Looks great @YolandaMDavis I'm merged this into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request #541: NIFI-2032 fixed 'enableControllerServices' logic

2016-06-20 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/541#discussion_r67739760 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service

[GitHub] nifi pull request #541: NIFI-2032 fixed 'enableControllerServices' logic

2016-06-20 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/541#discussion_r67739510 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service

[GitHub] nifi issue #507: NIFI-1804 Adding ability for FileAuthorizer to automaticall...

2016-06-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/507 Looks great @bbende Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request #526: NIFI-1952 Create REST endpoints for user/group/polic...

2016-06-17 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/526#discussion_r67553151 --- Diff: nifi-api/src/main/java/org/apache/nifi/authorization/Group.java --- @@ -24,7 +24,7 @@ /** * A group that users can belong

[GitHub] nifi issue #540: NIFI-2033: Allow Controller Services to be scoped at Contro...

2016-06-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/540 Looks good! Thanks for knocking this out! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #540: NIFI-2033: Allow Controller Services to be scoped at Contro...

2016-06-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/540 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #511: NIFI-1850 - JSON-to-JSON Schema Converter Editor

2016-06-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/511 @YolandaMDavis While reading over your PR I noticed that the ControllerService and ReportingTask URI's in the StandandNiFiWebConfigurationContext are incorrect. They shouldn't contain the path

[GitHub] nifi pull request #511: NIFI-1850 - JSON-to-JSON Schema Converter Editor

2016-06-16 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/511#discussion_r67456561 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java

[GitHub] nifi pull request #511: NIFI-1850 - JSON-to-JSON Schema Converter Editor

2016-06-16 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/511#discussion_r67456463 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/pom.xml --- @@ -355,10 +355,5 @@ spock-core

[GitHub] nifi issue #532: NIFI-1941: Child group contents in exported templates

2016-06-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/532 @jvwing Just addressed the issue and rebased to current master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #532: NIFI-1941: Child group contents in exported templates

2016-06-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/532 @jvwing Actually, I think I see what the issue is. Going to verify my change and if all looks good, I'll update the PR. --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi issue #532: NIFI-1941: Child group contents in exported templates

2016-06-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/532 @jvwing Thanks for jumping in to review! I am not aware of this specific issue though I know we have a number of outside JIRAs surrounding templates and the 1.0.0 release. It doesn't surprise me

[GitHub] nifi issue #517: NIFI-1994: Fixed issues with controller services and templa...

2016-06-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/517 @markap14 When exporting a template with controller services at multiple levels, it appears the services all end up at the top level group. These should probably retain the same scoping as the source

[GitHub] nifi pull request #535: NIFI-2041: Unable to refresh Controller Services whe...

2016-06-16 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/535 NIFI-2041: Unable to refresh Controller Services when scoped by Process Group - Fixing issue when attempting to refresh Controller Services when scoped by Process Group. You can merge this pull

[GitHub] nifi pull request #532: NIFI-1941: Child group contents in exported template...

2016-06-15 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/532 NIFI-1941: Child group contents in exported templates - Ensuring child group contents are included in exported templates. You can merge this pull request into a Git repository by running: $ git

[GitHub] nifi pull request #531: NIFI-2007: Restoring bulletin functionality

2016-06-15 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/531 NIFI-2007: Restoring bulletin functionality - Restoring bulletin functionality. - Ensuring appropriate merging of bulletins in clustered responses. You can merge this pull request into a Git

[GitHub] nifi pull request #526: NIFI-1952 Create REST endpoints for user/group/polic...

2016-06-14 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/526#discussion_r66968920 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/resources/nifi-web-api-context.xml --- @@ -114,7 +123,23

[GitHub] nifi issue #526: NIFI-1952 Create REST endpoints for user/group/policy manag...

2016-06-14 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/526 @jtstorck Lets knock out these couple trivial items. Looks good so far. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi pull request #526: NIFI-1952 Create REST endpoints for user/group/polic...

2016-06-14 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/526#discussion_r66962729 --- Diff: nifi-api/src/main/java/org/apache/nifi/authorization/Group.java --- @@ -24,7 +24,7 @@ /** * A group that users can belong

[GitHub] nifi pull request #526: NIFI-1952 Create REST endpoints for user/group/polic...

2016-06-14 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/526#discussion_r66960292 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/resources/nifi-web-api-context.xml --- @@ -114,7 +123,23

[GitHub] nifi pull request #526: NIFI-1952 Create REST endpoints for user/group/polic...

2016-06-14 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/526#discussion_r66959842 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/UsersResource.java --- @@ -0,0

[GitHub] nifi pull request #526: NIFI-1952 Create REST endpoints for user/group/polic...

2016-06-14 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/526#discussion_r66959717 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/UserGroupsResource.java

[GitHub] nifi pull request #526: NIFI-1952 Create REST endpoints for user/group/polic...

2016-06-14 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/526#discussion_r66959598 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessPolicyResource.java

[GitHub] nifi issue #515: NIFI-826 [REVIEW ONLY] Initial commit for deterministic tem...

2016-06-14 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/515 @olegz I believe that we're going to need to introduce the templateId or inceptionId into the flow.xml not just the template DTO. The reasoning is that we need to support the following case

[GitHub] nifi issue #518: NIFI-1901: Component based access control tests

2016-06-14 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/518 It appears that the unit tests I have added take a long time to complete and causes Travis to timeout and fail. Specifically, the slow running tests stand up an embedded Jetty server and deploys NiFi

[GitHub] nifi issue #526: NIFI-1952 Create REST endpoints for user/group/policy manag...

2016-06-13 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/526 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #507: NIFI-1804 Adding ability for FileAuthorizer to autom...

2016-06-13 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/507#discussion_r66836344 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-file-authorizer/src/main/java/org/apache/nifi/authorization/Resources.java --- @@ -0,0

[GitHub] nifi pull request #524: NIFI-1781: UI updates

2016-06-13 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/524 NIFI-1781: UI updates - Listening for window resize events more selectively. - Fixing malformed request when configuring remote process group ports. - Fixing malformed request when starting

[GitHub] nifi issue #523: [NIFI-1879] Responsive dialogs and dialog UX refresh

2016-06-13 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/523 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #518: NIFI-1901: Component based access control tests

2016-06-10 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/518 NIFI-1901: Component based access control tests - Building component based access control tests for Connections, Funnels, Labels, Input Ports, Output Ports, Processors, and Process Groups

[GitHub] nifi issue #473: NIFI-1916 Updating FileAuthorizer to extend AbstractPolicyB...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/473 @bbende The updates for ensuring thread-safe access looks good as do the converting of existing authorized-users.xml. +1 Merging to master. --- If your project is set up for it, you can

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 This has been merged into master. Discovered a few new items and identified a few old items that we'll still need to knock out. Another item that we still need to tackle is ensuring that all node

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 Also just created another PR to consider building something to automated the conversion of the nifi.properties [1]. [1] https://issues.apache.org/jira/browse/NIFI-1967 --- If your project

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 @markap14 Ran into another issue around cluster coordinator selection. When the selected coordinator has a unheritable flow it is treated as the 'golden' copy as they are the coordinator

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 @markap14 Just ran into an issue with the fields that are used in the flow fingerprint. I think we need to reconsider which fields are included. Specifically I had modified the penalty

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 @markap14 Ran into a small issue with node (re)connection regarding Templates. It appears that Templates local to that node are replaced with the cluster set of Templates

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 @markap14 I've been reviewing this PR and have some initial findings. As I'm reviewing I'm updating various comments and naming that still reflect the previous clustering model. I've gone

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #482: NIFI-1928: Remove registration

2016-06-02 Thread mcgilman
Github user mcgilman closed the pull request at: https://github.com/apache/nifi/pull/482 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #482: NIFI-1928: Remove registration

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/482 This has been merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #472: NIFI-1265: Upgrading to Jetty 9.3

2016-06-02 Thread mcgilman
Github user mcgilman closed the pull request at: https://github.com/apache/nifi/pull/472 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #472: NIFI-1265: Upgrading to Jetty 9.3

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/472 Will do. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #485: NIFI-1948 Fixed encoding-version attribute not getting crea...

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/485 +1 Looks good. Verified functionality exporting/importing templates across 0.x and 1.x versions. Merged to master. --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi issue #485: NIFI-1948 Fixed encoding-version attribute not getting crea...

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/485 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #489: NIFI-1951: Custom UIs

2016-06-02 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/489 NIFI-1951: Custom UIs - Removing deprecated NiFiWebContext and related classes. - Adding authorization to Custom UIs. - Fixing issue when creating ControllerService inline. - Addressing

[GitHub] nifi pull request: NIFI-1928: Remove registration

2016-06-01 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/482 NIFI-1928: Remove registration - Fixing UI action for bulk delete. - Removing registration form. - Fixing default visibility of the anonymous user warning. You can merge this pull request

[GitHub] nifi pull request: NIFI-1916 Updating FileAuthorizer to extend AbstractPolic...

2016-05-31 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/473 @bbende Just realized that we'll need to introduce some thread safety here. The RevisionManager in the web tier will handle locking during the User/Group/Policy CRUD operations. However

[GitHub] nifi pull request: NIFI-1908 Added encoding-version attribute to T...

2016-05-30 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/471#issuecomment-222539446 Other changes look good! Will merge to master. During my testing of a 1.x template in an 0.x instance I discovered a separate issue that the templates from an 1

[GitHub] nifi pull request: NIFI-1908 Added encoding-version attribute to T...

2016-05-30 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/471#discussion_r65097776 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java

[GitHub] nifi pull request: NIFI-1908 Added encoding-version attribute to T...

2016-05-30 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/471#discussion_r65096361 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java

[GitHub] nifi pull request: NIFI-1908 Added encoding-version attribute to T...

2016-05-30 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/471#discussion_r65095238 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java

[GitHub] nifi pull request: NIFI-1850 - Initial Commit for JSON-to-JSON Sch...

2016-05-30 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/424#issuecomment-222531466 @YolandaMDavis I'm having some issues saving the JSON specification in the Custom UI while running in a clustered instance. When I click save, the value

[GitHub] nifi pull request: NIFI-1265: Upgrading to Jetty 9.3

2016-05-27 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/472 NIFI-1265: Upgrading to Jetty 9.3 This PR should only be applied to master as Jetty 9.3 requires Java 8. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi pull request: NIFI-1908 Added encoding-version attribute to T...

2016-05-27 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/471#issuecomment-12578 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1554: Updating Cluster endpoints

2016-05-26 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/470 NIFI-1554: Updating Cluster endpoints - Refactoring Cluster endpoints. - Updating frontend to accommodate clustering endpoints. - Remove the 'Make Primary' action. This is phase one

[GitHub] nifi pull request: NIFI-1800: Providing access to Controller Servi...

2016-05-26 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/469 NIFI-1800: Providing access to Controller Services based on a given context - UI style updates to make the components stand out better. - Reusing controller service table in different contexts

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-23 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/452#issuecomment-221086451 @bbende The updated PR looks good to me. A number of great iterations here. Definitely think this is a solid foundation to continue the policy based authorizers managed

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/461#issuecomment-221051044 Thanks @markap14 All changes have been applied. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/461#discussion_r64262070 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/461#discussion_r64259949 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java --- @@ -321,6

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/461#discussion_r64251051 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/groups/ProcessGroup.java --- @@ -46,6

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/461#discussion_r64250889 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/461#discussion_r64250267 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/461#discussion_r64250769 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/groups/ProcessGroup.java --- @@ -46,6

[GitHub] nifi pull request: NIFI-1781: UI authorization updates

2016-05-23 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/461 NIFI-1781: UI authorization updates NIFI-1781: - Including access policies in the breadcrumb's trail. - Updating toolbox according to group access policies. - Updating actions in palette

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-19 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/452#issuecomment-220469545 @alopresto Great comment about the UserService. The reason we cannot do that directly is the extension point that is getting discovered is an Authorizer. However

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-19 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/452#issuecomment-220457062 With the builders included, looks good to me. @jtstorck @alopresto Thoughts? --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-19 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/452#discussion_r63956868 --- Diff: nifi-api/src/main/java/org/apache/nifi/authorization/AccessPolicy.java --- @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software

[GitHub] nifi pull request: NIFI-1745: Refactor how revisions are handled a...

2016-05-19 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/454#issuecomment-220330762 @markap14 When canceling revision claims for Connectable components in the verifyXxx() methods, DAO access will not return null so you do not need to check

[GitHub] nifi pull request: NIFI-1745: Refactor how revisions are handled a...

2016-05-19 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/454#discussion_r63874050 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-optimistic-locking/src/main/java/org/apache/nifi/web/revision

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-19 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/452#issuecomment-220307255 @alopresto Thanks for the very thorough review! This API is designed strictly for handling the persistence of access policies which would also include Users and Groups

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-18 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/452#issuecomment-220025580 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1884 Defining API for Users, Groups, and P...

2016-05-18 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/452#issuecomment-220023481 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1850 - Initial Commit for JSON-to-JSON Sch...

2016-05-17 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/424#issuecomment-219881237 @YolandaMDavis Yep. We're definitely on the same page here. However, we currently have not formally established any APIs/components/widgets for UI extensions to consume

  1   2   3   >