Ifropc commented on pull request #1:
URL: https://github.com/apache/incubator-nlpcraft/pull/1#issuecomment-629735553
Hi @skhdl , thanks you for your feedback.
1. Done
2. I think in general it's not very good approach, as it is not following
XDG base directory specification. I
[
https://issues.apache.org/jira/browse/NLPCRAFT-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109177#comment-17109177
]
Sergey Makov commented on NLPCRAFT-48:
--
Implemented in
[
https://issues.apache.org/jira/browse/NLPCRAFT-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated NLPCRAFT-48:
---
Labels: pull-request-available (was: )
> Add java client project to Jenkins and update
syermakov opened a new pull request #1:
URL: https://github.com/apache/incubator-nlpcraft-java-client/pull/1
Summary:
- Start NLPCraft server before integration tests (maven only, testing from
IDE still needs a manually started server)
- Fix build failures (JDK 11)
- Enable
skhdl commented on pull request #1:
URL: https://github.com/apache/incubator-nlpcraft/pull/1#issuecomment-629625313
9. Could you add some base request validation and throw readable errors for
such invalid requests?
Just for main cases (empty request, invalid indexes range) - now
skhdl commented on pull request #1:
URL: https://github.com/apache/incubator-nlpcraft/pull/1#issuecomment-629613105
Hi @Ifropc ! Thank your for your work, I have tried it and results are very
impressive!
Below some remarks for discussion:
1. start_server.sh - I think that better
