Re: svn commit: r1813679 - in /ofbiz/ofbiz-framework/trunk: ./ framework/common/groovyScripts/ framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/

2017-10-29 Thread Deepak Dixit
Hi Jacques, > +if (delegator != null && > "Y".equals(EntityUtilProperties.getPropertyValue("embisphere", > "use-external-server", "Y", delegator))) { > I think ti should be security instead of embisphere :)

Re: Using OFBiz as an Online Store for ASF Swag ?

2017-10-29 Thread Michael Brohl
Hi Sharan, I missed to answer to the first call, so thank you for bringing this up again. I think it would be great to have a (multi-project) merchandising shop build on base of Apache OFBiz. From the OFBiz community/product view it might help us to gain more attention and for the ASF it

Re: Using OFBiz as an Online Store for ASF Swag ?

2017-10-29 Thread Sharan Foga
Hi All I've had some initial positive feedback on this so I'd like to bring this discussion back up again on our lists to see if we have enough support to take it further. The general idea is the same – so allowing people to buy Apache branded swag, but then also at some point extending it

Re: svn commit: r1813637 - in /ofbiz/ofbiz-framework/trunk/framework/datafile/src/main/java/org/apache/of biz/datafile: DataFile.java DataFile2EntityXml.java ModelDataFileReader.java Record.java Recor

2017-10-29 Thread Michael Brohl
Ah, I thought I have used the OFBiz formatter provided by the link you mentioned, I have it embedded in Eclipse. But was wrong, it was the Eclipse default formatter. I changed it back now. I agree that we should all use the same formatting conventions to prevent having "changes" which are

Re: svn commit: r1813637 - in /ofbiz/ofbiz-framework/trunk/framework/datafile/src/main/java/org/apache/of biz/datafile: DataFile.java DataFile2EntityXml.java ModelDataFileReader.java Record.java Recor

2017-10-29 Thread Jacques Le Roux
Using a checkstyle Gradle task could help in this way, notably by running it in Buildbot. But we need 1st to agree on rules... Jacques Le 29/10/2017 à 11:57, Taher Alkhateeb a écrit : Unless we find a way of automating, I don't think we should spend much time on things like how to write an

Re: svn commit: r1813637 - in /ofbiz/ofbiz-framework/trunk/framework/datafile/src/main/java/org/apache/of biz/datafile: DataFile.java DataFile2EntityXml.java ModelDataFileReader.java Record.java Recor

2017-10-29 Thread Taher Alkhateeb
Unless we find a way of automating, I don't think we should spend much time on things like how to write an empty constructor. We have bigger problems to solve. On Oct 29, 2017 1:36 PM, "Jacques Le Roux" wrote: > We (committers at least, with contributors would even

Re: svn commit: r1813637 - in /ofbiz/ofbiz-framework/trunk/framework/datafile/src/main/java/org/apache/of biz/datafile: DataFile.java DataFile2EntityXml.java ModelDataFileReader.java Record.java Recor

2017-10-29 Thread Jacques Le Roux
We (committers at least, with contributors would even be better) could decide to use the same formatter. This would helps when merging from custom projects or backporting to them... I tried this once by sharing my Eclipse formatter at

Re: svn commit: r1813637 - in /ofbiz/ofbiz-framework/trunk/framework/datafile/src/main/java/org/apache/of biz/datafile: DataFile.java DataFile2EntityXml.java ModelDataFileReader.java Record.java Recor

2017-10-29 Thread Michael Brohl
Same thing as before. This is just produced by the formatter. Am 29.10.17 um 09:15 schrieb Jacques Le Roux: Le 28/10/2017 à 16:45, mbr...@apache.org a écrit : -    protected DataFile() {} +    protected DataFile() { +    } Hi Michael, Do we really prefer "this to that" ? Jacques

Re: svn commit: r1813637 - in /ofbiz/ofbiz-framework/trunk/framework/datafile/src/main/java/org/apache/of biz/datafile: DataFile.java DataFile2EntityXml.java ModelDataFileReader.java Record.java Recor

2017-10-29 Thread Michael Brohl
Same thing as before... Am 29.10.17 um 09:56 schrieb Jacques Le Roux: Le 28/10/2017 à 16:45, mbr...@apache.org a écrit :   /**    * little endian reader for 4 byte int.    */ -    public final int readLEInt(byte []byteArray) { -    return -    (byteArray[3])  << 24 | -   

Re: svn commit: r1813637 - in /ofbiz/ofbiz-framework/trunk/framework/datafile/src/main/java/org/apache/of biz/datafile: DataFile.java DataFile2EntityXml.java ModelDataFileReader.java Record.java Recor

2017-10-29 Thread Michael Brohl
I think this is just a formatting change becaused I used our formatter for Eclipse. Not really something worth a discussion, is it? Am 29.10.17 um 10:07 schrieb Jacques Le Roux: Le 28/10/2017 à 16:45, mbr...@apache.org a écrit : -    for (int i = 0; i < modelField.length; i++) - 

Re: svn commit: r1813637 - in /ofbiz/ofbiz-framework/trunk/framework/datafile/src/main/java/org/apache/of biz/datafile: DataFile.java DataFile2EntityXml.java ModelDataFileReader.java Record.java Recor

2017-10-29 Thread Jacques Le Roux
Le 28/10/2017 à 16:45, mbr...@apache.org a écrit : -for (int i = 0; i < modelField.length; i++) -sb.append(PAD_CHAR); -data = sb.toString(); -} +for (int i = 0; i < modelField.length; i++) +sb.append(PAD_CHAR); +

Re: svn commit: r1813637 - in /ofbiz/ofbiz-framework/trunk/framework/datafile/src/main/java/org/apache/of biz/datafile: DataFile.java DataFile2EntityXml.java ModelDataFileReader.java Record.java Recor

2017-10-29 Thread Jacques Le Roux
Le 28/10/2017 à 16:45, mbr...@apache.org a écrit : /** * little endian reader for 4 byte int. */ -public final int readLEInt(byte []byteArray) { -return -(byteArray[3]) << 24 | -(byteArray[2]&0xff) << 16 | -(byteArray[1]&0xff) << 8 | -

Re: svn commit: r1813637 - in /ofbiz/ofbiz-framework/trunk/framework/datafile/src/main/java/org/apache/of biz/datafile: DataFile.java DataFile2EntityXml.java ModelDataFileReader.java Record.java Recor

2017-10-29 Thread Jacques Le Roux
Le 28/10/2017 à 16:45, mbr...@apache.org a écrit : -protected DataFile() {} +protected DataFile() { +} Hi Michael, Do we really prefer "this to that" ? Jacques