Re: Possible issue in reserveStoreInventory service

2021-07-09 Thread Suraj Khurana
Thanks Giulio, Much appreciated. I will proceed soon with a minor enhancement on use of use-cache with filter-by-date. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, Jul 4, 2021 at 9:05 PM Giulio Speri - MpStyle Srl < giulio.sp...@mpstyle.it> wrote: > Hi Sur

Re: Possible issue in reserveStoreInventory service

2021-06-22 Thread Suraj Khurana
Hello Giulio, Thanks for pointing that out. A Jira perfectly fits here. -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Jun 23, 2021 at 5:32 AM Giulio Speri - MpStyle Srl < giulio.sp...@mpstyle.it> wrote: > Hello everyone, > > I hope you are all doing

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-03-19 Thread Suraj Khurana
+1 -- Best Regards, Suraj Khurana Senior Technical Consultant On Fri, Mar 19, 2021 at 1:43 PM Jacopo Cappellato < jacopo.cappell...@gmail.com> wrote: > +1 > > Jacopo > > On Sun, Mar 14, 2021 at 10:39 AM Jacopo Cappellato > wrote: > > > > This is the vot

Re: Welcome to Priya Sharma as new committer!

2021-03-14 Thread Suraj Khurana
Congratulations Priya !! Welcome aboard. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, Mar 14, 2021 at 10:20 PM Swapnil Shah < swapnil.s...@hotwaxsystems.com> wrote: > Many Congratulations Priya !! > > Thanks, > Swapnil > > > -Original M

Re: Welcome to Martin Becker as new committer!

2021-03-03 Thread Suraj Khurana
Many Congratulations, Martin !! Welcome aboard. -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Mar 3, 2021 at 2:00 PM Devanshu Vyas wrote: > Many Congratulations Martin! > > Thanks & Regards, > Devanshu Vyas. > > > On Wed, Mar 3, 2021 at 10

Adding flexibility to condition-service in seca/eeca rules

2021-02-04 Thread Suraj Khurana
. In this manner we give more control to developers and reduce duplicacy of code. Please share your thoughts on this. -- Best Regards, Suraj Khurana Senior Technical Consultant

Re: [OPTIONS] Java 11 and Java JDK origin

2021-02-03 Thread Suraj Khurana
Hi, +1 for jdk11. -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Feb 4, 2021 at 2:30 AM Eugen Stan wrote: > +1 for jdk11. > > We can focus on jdk17 once it's out. > The transition will probably require some work. > > jdk17 is attractive though in

Re: Welcome Girish Vasmatkar as new PMC member

2021-01-28 Thread Suraj Khurana
Many Congratulations Girish !! Welcome aboard. -- Best Regards, Suraj Khurana Senior Technical Consultant On Fri, Jan 29, 2021 at 11:28 AM Deepak Dixit wrote: > Welcome aboard Girish!! > > Thanks & Regards > -- > Deepak Dixit > ofbiz.apache.org > > > On Thu, J

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.05 - Second attempt

2021-01-04 Thread Suraj Khurana
+1. -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Jan 4, 2021 at 4:12 PM Deepak Dixit wrote: > +1 > > Thanks & Regards > -- > Deepak Dixit > ofbiz.apache.org > > > On Mon, Jan 4, 2021 at 4:05 PM Nicola Mazzoni > wrote: > > > +

Re: Welcome to Daniel Watford as new committer!

2021-01-03 Thread Suraj Khurana
Congrats Daniel. Welcome aboard !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, Jan 3, 2021 at 2:30 AM Sharan F wrote: > Congratulations and welcome Daniel! > > Thanks > Sharan > > > On Thu, 31 Dec 2020, 17:20 Jacopo Cappellato, > > wro

Re: Kickoff Meeting - Apache OFBiz Tutorial Project

2020-12-09 Thread Suraj Khurana
+1 -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Dec 9, 2020 at 1:09 PM Pranay Pandey < pranay.pan...@hotwaxsystems.com> wrote: > Hello Tutorial Project Volunteers, > > First of all thank you so much for showing interest in volunteering the > Apache OFBi

Re: Checkstyle "Utility classes should not have a public or default constructor." error message

2020-11-12 Thread Suraj Khurana
+1 -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Nov 12, 2020 at 12:03 AM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi, > > Checkstyle returns 222 occurrences of the message "Utility classes should > not have a public or default constr

Re: OFBiz as OMS Session: Pre-Orders and its Management

2020-10-27 Thread Suraj Khurana
Thanks for the update Devanshu. Looking forward to it. -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Oct 26, 2020 at 5:03 PM Devanshu Vyas wrote: > Hello, > > In continuation of our ongoing discussion on OFBiz as an open-source OMS, > we are organiz

Re: Service or job which applies recurring fee to customer

2020-10-21 Thread Suraj Khurana
will be helpful. HTH. -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Oct 21, 2020 at 11:35 AM Madhu Mohan wrote: > Is there any service or job which will run periodically and looks for uom, > applies the charge based on product(price) to billing account? > Please let me know.

UPDATE: OFBiz code linting issues

2020-09-26 Thread Suraj Khurana
. I am glad to announce that we have fixed around *99%* of these issues successfully. Kudos to everyone involved in this effort !! -- Best Regards, Suraj Khurana Senior Technical Consultant

Re: Welcome Mridul Pathak as new PMC member!!

2020-09-21 Thread Suraj Khurana
Many Congratulations Mridul !! Welcome aboard. -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Sep 21, 2020 at 11:26 AM Aditya Sharma wrote: > Felicitations Mridul! Welcome aboard. > > Thanks and Regards, > Aditya Sharma > > On Fri, Sep 18, 2020

Re: Welcome Swapnil Shah as new PMC member!!

2020-09-21 Thread Suraj Khurana
Many Congratulations Swapnil !! Welcome aboard. -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Sep 21, 2020 at 11:22 AM Aditya Sharma wrote: > Felicitations Swapnil! Welcome aboard. > > Thanks and Regards, > Aditya Sharma > > On Fri, Sep 18, 2020

Re: [ofbiz-framework] branch trunk updated: Improved: Updated tasks.checkstyleMain.maxErrors to 751. ~(-1250)

2020-09-04 Thread Suraj Khurana
Hello Jacques, You were always there on this journey and supported it. Thanks a lot. :) -- Best Regards, Suraj Khurana Senior Technical Consultant On Fri, Sep 4, 2020 at 3:22 PM Jacques Le Roux wrote: > Le 04/09/2020 à 09:01, sur...@apache.org a écrit : > > This is an automated e

Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2020-09-02 Thread Suraj Khurana
Thanks Girish. -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Sep 2, 2020 at 11:44 AM Girish Vasmatkar < girish.vasmat...@hotwaxsystems.com> wrote: > Hi Jacques/Akash - > > I have taken care of it with my latest commit > - 310a2a58eff7cb203e4f7b

Re: JsLanguageFilesMappingCreator.java

2020-08-28 Thread Suraj Khurana
Thanks Jacques for taking care of it. -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Aug 27, 2020 at 10:44 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks Suraj, > > Pushed with slight changes > > Jacques > > Le 27/08/20

Re: JsLanguageFilesMappingCreator.java

2020-08-27 Thread Suraj Khurana
Thanks Jacques. I have attached a patch at https://issues.apache.org/jira/browse/OFBIZ-11926 Could you please review it? TIA. -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Aug 27, 2020 at 3:38 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > James,

Re: Welcome to Devanshu Vyas as new committer!

2020-08-19 Thread Suraj Khurana
Many Congratulations Devanshu !! -- Best Regards, Suraj Khurana Senior Technical Consultant HotWax Commerce On Wed, Aug 19, 2020 at 2:32 PM Pawan Verma wrote: > The OFBiz PMC has invited Devanshu Vyas to become a new committer and we > are happy to announce that he has accepted thi

Re: buildbot exception in on ofbizTrunkFrameworkPlugins

2020-08-02 Thread Suraj Khurana
All good on the local machine. -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Aug 3, 2020 at 10:15 AM wrote: > The Buildbot has detected a build exception on builder > ofbizTrunkFrameworkPlugins while building ofbiz-plugins. Full details are > available at: &g

Re: ParameterNumber checkstyle rule

2020-08-02 Thread Suraj Khurana
Thanks Jacques. 10 looks good to me as well. I have created a Jira and uploaded patch for this: https://issues.apache.org/jira/browse/OFBIZ-11931 -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Jul 30, 2020 at 2:10 PM Jacques Le Roux < jacques.le.r...@les7arts.com>

Re: MethodLength checkstyle rule

2020-08-02 Thread Suraj Khurana
Thanks Jacques, I think we can go with 500, I have uploaded the patch on the ticket (OFBIZ-11915). -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Jul 30, 2020 at 2:06 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Suraj, > > Has I had

Re: MethodLength checkstyle rule

2020-07-29 Thread Suraj Khurana
Hello team, Any thoughts on this, IMO we can make it to 450 or something, it's quite readable by then. Please suggest. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, Jul 26, 2020 at 9:12 PM Suraj Khurana wrote: > Hello team, > > Currently there are around 200 i

ParameterNumber checkstyle rule

2020-07-29 Thread Suraj Khurana
/apidocs/com/puppycrawl/tools/checkstyle/checks/sizes/ParameterNumberCheck.html Please share your thoughts on this. -- Best Regards, Suraj Khurana Senior Technical Consultant

Re: Single line statements - checkstyle

2020-07-29 Thread Suraj Khurana
Thanks everyone. This was done a few days ago. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, Jul 18, 2020 at 1:56 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 14/07/2020 à 10:15, Jacques Le Roux a écrit : > > My conclusion is that cou

Re: Welcome Pawan Verma as new PMC member

2020-07-28 Thread Suraj Khurana
Many congratulations, Pawan ! -- Best Regards, Suraj Khurana Senior Technical Consultant On Tue, Jul 28, 2020 at 1:22 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invited Pawan Verma to become member of the committee > and we are glad to announce

MethodLength checkstyle rule

2020-07-26 Thread Suraj Khurana
as per conclusions drawn in this thread. Please share your thoughts on this. -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91 9669750002 email: suraj.khur...@hotwax.co *www.hotwax.co <http://www.hotwax.co/>*

Re: buildbot exception in on ofbizTrunkFrameworkPlugins

2020-07-25 Thread Suraj Khurana
Hey Jacques, I have attached a patch for this existing issue on OFBIZ-11553, it works for me. Please check and go ahead if it looks good to you as well. HTH. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, Jul 25, 2020 at 7:59 PM Suraj Khurana wrote: > On my local, I

Re: buildbot exception in on ofbizTrunkFrameworkPlugins

2020-07-25 Thread Suraj Khurana
On my local, I am facing same one test failure (testCreateOrderServiceProduct) and as you mentioned in OFBIZ-11553, it is working fine with ofbiz -test component=order --test suitename=shoppingcarttests --test case=configurableServiceOrder-test. -- Best Regards, Suraj Khurana Senior Technical

Re: buildbot exception in on ofbizTrunkFrameworkPlugins

2020-07-25 Thread Suraj Khurana
Thanks Jacques for confirming. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, Jul 25, 2020 at 5:40 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Suraj, > > It's only about (not) uploading the result file. I tested locally, we have >

Re: buildbot exception in on ofbizTrunkFrameworkPlugins

2020-07-25 Thread Suraj Khurana
Hello team, Everything looks ok on the local machine with testIntegration. I checked with "./gradlew cleanAll loadAll testIntegration". -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, Jul 25, 2020 at 2:06 PM wrote: > The Buildbot has detected a build excepti

Re: Checkstyle line wrapping Indentation

2020-07-25 Thread Suraj Khurana
Yes, no changes required. Thanks !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Jul 22, 2020 at 8:14 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > It works as expected in 4.2 when using our formatter in Eclipse. > Since the checksty

Re: Checkstyle line wrapping Indentation

2020-07-22 Thread Suraj Khurana
Hello team, I further checked oracle docs [1] and maybe this is the reason for this. See 4.2 in this pdf. [1]: https://www.oracle.com/technetwork/java/codeconventions-150003.pdf -- Best Regards, Suraj Khurana Senior Technical Consultant On Tue, Jul 21, 2020 at 10:52 PM Jacques Le Roux

Checkstyle line wrapping Indentation

2020-07-21 Thread Suraj Khurana
/indentation/IndentationCheck.html -- Best Regards, Suraj Khurana Senior Technical Consultant

Re: Ordering Decimals

2020-07-21 Thread Suraj Khurana
to product level configuration and then store level. HTH. -- Best Regards, Suraj Khurana Senior Technical Consultant On Tue, Jul 21, 2020 at 11:44 AM Pritam Kute wrote: > I think its a good idea to have orderDecimalQuantity set to N for the > products in demo data. What I have noticed in dem

Re: Welcome Suraj Khurana as new PMC member

2020-07-17 Thread Suraj Khurana
Thanks everyone for your wishes. It's always a pleasure and delightful experience to become a part of OFBiz community. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, Jul 12, 2020 at 4:18 PM Sharan Foga wrote: > Congratulations Suraj! > > Thanks > Sharan >

Re: [ofbiz-site] branch master updated: Fixed: OFBiz API Reference link does not work for Documentation/API Reference section(OFBIZ-11888)

2020-07-17 Thread Suraj Khurana
Ahh !! it is due to that php2html.sh thing. Thanks !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Fri, Jul 17, 2020 at 3:34 PM Pawan Verma wrote: > Hi Suraj, > > We can't use your suggested solution in ofbiz-site as it has its working > pattern. Please ref

Re: [ofbiz-site] branch master updated: Fixed: OFBiz API Reference link does not work for Documentation/API Reference section(OFBIZ-11888)

2020-07-17 Thread Suraj Khurana
Hi Pawan, IMO, instead of copying this to every file, we should create a new file apiReference.html or something similar so that changes are easy to manage in future. Infact if footer contents are the same, we should be creating a footer.html. WDYT? -- Best Regards, Suraj Khurana Senior

Single line statements - checkstyle

2020-07-13 Thread Suraj Khurana
thoughts on this. -- Best Regards, Suraj Khurana Senior Technical Consultant

Re: [ofbiz-framework] 01/02: Improved: Corrected remaining ', is not followed by whitespace' checkstyle errors in framework component. (OFBIZ-11805)

2020-07-07 Thread Suraj Khurana
Hello Pawan, Yes, I was trying a few IDE options that might have added this. Thanks for bringing this to my attention. Removed at rev#c5f9697e35e676cf5afa6e14dc3f420030961924 -- Best Regards, Suraj Khurana Senior Technical Consultant On Tue, Jul 7, 2020 at 4:24 PM Pawan Verma wrote: >

Re: Welcome Aditya Sharma as new PMC member

2020-07-06 Thread Suraj Khurana
Many congratulations, Aditya Sharma !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Jul 6, 2020 at 12:08 PM Devanshu Vyas wrote: > Many Congratulations Aditya! > > Thanks & Regards, > Devanshu Vyas. > > > On Sun, Jul 5, 2020 at 10:24 PM Jacques

Re: Welcome Arun Patidar as new PMC member

2020-07-06 Thread Suraj Khurana
Many congratulations, Arun Patidar !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Jul 6, 2020 at 12:30 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invited Arun Patidar to become member of the committee > and we are glad

Re: Add CHANGELOG.md file

2020-06-17 Thread Suraj Khurana
+1 -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Jun 17, 2020 at 5:08 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > +1 > > I believe it would be better done manually with a community consensus. > > Could someone probes me wrong? > >

Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2020-06-16 Thread Suraj Khurana
Hello team, As Jacques confirms in the very next commit, this was due to a checkstyle issue introduced. I would like to request all contributors to please run './gradlew check' before creating PR's. TIA. -- Best Regards, Suraj Khurana Senior Technical Consultant On Tue, Jun 16, 2020 at 4:38 PM

Re: [PROPOSAL] First Data Payment Gateway Integration

2020-06-15 Thread Suraj Khurana
+1 Nicolas. -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Jun 15, 2020 at 8:23 PM Nicolas Malin wrote: > Hi Pritam, > > My preference go to move all gateway to plugin, to keep OFBiz framework > slim and the connector quality high. > > If all thi

Re: IMPROVEMENT: Checkstyle formatting issues

2020-06-07 Thread Suraj Khurana
Thanks everyone for your inputs. Here [1] is the ticket created for the same. [1] : https://issues.apache.org/jira/browse/OFBIZ-11805 -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Jun 3, 2020 at 7:55 PM Mridul Pathak < mridul.pat...@hotwaxsystems.com> wrote:

Re: IMPROVEMENT: Checkstyle formatting issues

2020-06-01 Thread Suraj Khurana
Hello Michael, Just the very last commit on that particular line that we check while annotating. Nothing else. As Jacques mentioned most of the time the history can be rebuilt with blame using lines around. -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91 9669750002 email

Re: Removal of Price information from Pick Sheet Report

2020-06-01 Thread Suraj Khurana
to pick. Actual pick sheet (used by picker) is something available under manage picklist i.e. after picklist is created, which tells picker which item to pick from which location, no further order details. Am I missing something? -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91

Re: Github PR template

2020-05-31 Thread Suraj Khurana
Thanks Jacques. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, May 31, 2020 at 1:21 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Done also in R17 and R18, it can still be improved if necessary > > I removed a

Re: Github PR template

2020-05-30 Thread Suraj Khurana
Hello team, IMO, we should imply these changes to plugins repository as well. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, May 30, 2020 at 1:29 PM Suraj Khurana wrote: > This is awesome. > > Thanks everyone involved in this effort. > > -- > >

IMPROVEMENT: Checkstyle formatting issues

2020-05-30 Thread Suraj Khurana
thoughts on this. A known thing is that we will lose the last history of such codebase while doing this re-factoring. Any other ideas to solve the problem are most welcome. -- Best Regards, Suraj Khurana Senior Technical Consultant

Re: Github PR template

2020-05-30 Thread Suraj Khurana
This is awesome. Thanks everyone involved in this effort. -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, May 28, 2020 at 12:12 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 28/05/2020 à 07:45, Aditya Sharma a écrit : > > I t

Re: LineLength for checkstyle

2020-05-27 Thread Suraj Khurana
Thanks Jacques. Using this I think we would also be able to configure like, hey don't check for services java files, they don't have default constructors ;) -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91 9669750002 email: suraj.khur...@hotwax.co *www.hotwax.co <h

Re: LineLength for checkstyle

2020-05-26 Thread Suraj Khurana
+1 for setting rule. Also we can think of some configured values instead of 2000 (default). may be we should set it to 3000 instead. And then as Daniel mentioned, work on refactoring those offending source files where possible. -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon

Re: LineLength for checkstyle

2020-05-25 Thread Suraj Khurana
This is done in rev # d6ebef619349f809062641d1b558cacdec3da208 -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, May 25, 2020 at 2:16 PM Suraj Khurana wrote: > Thanks everyone, > > Here[1] is the ticket to track this improvement. > > [1]: https://issues.apache.

Re: LineLength for checkstyle

2020-05-25 Thread Suraj Khurana
Thanks everyone, Here[1] is the ticket to track this improvement. [1]: https://issues.apache.org/jira/browse/OFBIZ-11737 -- Best Regards, Suraj Khurana Senior Technical Consultant On Sun, May 24, 2020 at 1:58 PM Olivier Heintz < holivier.li...@ofbizextra.org> wrote: > +1 > >

LineLength for checkstyle

2020-05-23 Thread Suraj Khurana
Hello Devs, Recently we are facing some checkstyle issues and one cause of it is LineLength property. Currently we have set it to 120, I think we should make it to 150 instead. It is pretty visible in 13/14 font sizes as well. Please share your thoughts on this. -- Best Regards, Suraj Khurana

Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2020-05-23 Thread Suraj Khurana
+1 Aditya If we can do that, that would be great. -- Suraj khurana On Sat 23 May, 2020, 6:55 PM Aditya Sharma, wrote: > Hi Jacques, > > I think *check styles* plugin is important for us and we should think of > introducing a pre-commit hook that checks only for the st

Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2020-05-23 Thread Suraj Khurana
Hello team, All tests passed on my local machine. I used: ./gradlew testIntegration -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, May 23, 2020 at 5:17 PM wrote: > The Buildbot has detected a new failure on builder > ofbizTrunkFrameworkPlugins while building

Re: Modify OFBiz commit message template

2020-05-22 Thread Suraj Khurana
+1 -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, May 20, 2020 at 2:33 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi, > > With Git IMO it's convenient (more information) to have the Jira number in > the title, eg: https://ma

Re: @deprecated No replacement

2020-05-22 Thread Suraj Khurana
+1 to remove the "@deprecated No replacement" references. -- Best Regards, Suraj Khurana Senior Technical Consultant On Fri, May 22, 2020 at 1:03 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi, > > We have 5, 8 years old, , "@deprecated No replacem

Re: buildbot failure in on ofbizTrunkFramework

2020-05-16 Thread Suraj Khurana
Hello team, This is done at rev #9913e566cc5c6c6258e5870137094f138a244489 -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, May 16, 2020 at 2:28 PM Suraj Khurana wrote: > I am looking into it. > > -- > Best Regards, > Suraj Khurana > Senior Technical Consu

Re: buildbot failure in on ofbizTrunkFramework

2020-05-16 Thread Suraj Khurana
I am looking into it. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, May 16, 2020 at 2:23 PM wrote: > The Buildbot has detected a new failure on builder ofbizTrunkFramework > while building ofbiz-framework. Full details are available at: > https://ci.a

XML to Groovy conversions

2020-05-16 Thread Suraj Khurana
conversion, will improve code quality. Please share your thoughts on this. -- Best Regards, Suraj Khurana Senior Technical Consultant

Re: buildbot exception in on ofbizTrunkFrameworkPlugins

2020-05-13 Thread Suraj Khurana
Everything worked fine on the local box. -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, May 13, 2020 at 6:00 PM wrote: > The Buildbot has detected a build exception on builder > ofbizTrunkFrameworkPlugins while building ofbiz-framework. Full details are >

Re: buildbot failure in on ofbizTrunkFramework

2020-05-13 Thread Suraj Khurana
Hello team, I checked on my local box, working fine at my end. -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, May 13, 2020 at 2:36 PM wrote: > The Buildbot has detected a new failure on builder ofbizTrunkFramework > while building ofbiz-framework. Full d

Re: buildbot failure in on ofbizTrunkFramework

2020-05-06 Thread Suraj Khurana
set from entity-auto engine. I will take a deeper look into it to confirm, for now I have set default-value and it is working as expected. Thanks for reporting. -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, May 6, 2020 at 11:50 AM Suraj Khurana wrote: > Hello Jacq

Re: buildbot failure in on ofbizTrunkFramework

2020-05-06 Thread Suraj Khurana
t. Thanks !! -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91 9669750002 email: suraj.khur...@hotwax.co *www.hotwax.co <http://www.hotwax.co/>* On Wed, May 6, 2020 at 10:14 AM Suraj Khurana wrote: > Hello Jacques, > > This ser

Re: buildbot failure in on ofbizTrunkFramework

2020-05-05 Thread Suraj Khurana
Hello Jacques, This service was committed at rev # edca9f22b03ecb5f7096652cf020ca3b52043962 and it is available in the latest trunk as well. Could you please confirm it once again? -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91 9669750002 email: suraj.khur...@hotwax.co

Re: [ofbiz-framework] branch trunk updated: Improved: Converted all ShipmentReceiptRole service from crud to entity-auto (#85)

2020-04-30 Thread Suraj Khurana
Thanks Pawan. It is done in rev a92136c662b2a150274b7a9aaea2c3117488e599 -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Apr 30, 2020 at 9:54 PM Pawan Verma wrote: > Hi Suraj, > > You've missed to add default-entity-name for the entity-auto engine for the > ab

Re: Welcome Rishi Solanki as new PMC member

2020-04-28 Thread Suraj Khurana
Many Congratulations, Rishi !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Apr 29, 2020 at 8:23 AM Ankush Upadhyay < ankush.upadh...@hotwaxsystems.com> wrote: > Many Congratulations Rishi!!! > > Kind Regards, > Ankush Upadhyay > Senior Technical C

Re: service with entity engine= auto for invoke = read

2020-04-28 Thread Suraj Khurana
Hello Vinay, Welcome to OFBiz. Here [1] is the document that can be helpful for you. It includes reference of performFind service as well. [1] https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+A+Beginners+Development+Guide HTH. -- Best Regards, Suraj Khurana SENIOR TECHNICAL

Re: [ofbiz-framework] branch trunk updated: Improved: All the service level error messages for missing required field for party component. (OFBIZ-7735) Thanks Ratnesh Upadhyay for reporting and Kirti

2020-04-28 Thread Suraj Khurana
Oops ! Thanks Pawan for taking care of this. -- Best Regards, Suraj Khurana Senior Technical Consultant On Tue, Apr 28, 2020 at 1:23 PM Pawan Verma wrote: > Hi Suraj, > > In this commit, we got unintentional '+' character > in applications/party/servicedef/services.xml file which

Re: svn commit: r1867927 - in /ofbiz/ofbiz-framework/trunk/applications/order: minilang/test/OrderTests.xml src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy

2020-04-27 Thread Suraj Khurana
Thanks Jacques for taking care of it. -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Apr 27, 2020 at 9:43 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > I don't remember if it was intentional, I think I missed them and will add > them "righ

Re: svn commit: r1867927 - in /ofbiz/ofbiz-framework/trunk/applications/order: minilang/test/OrderTests.xml src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy

2020-04-27 Thread Suraj Khurana
I meant, in the XML version we were sending note (Test note) and comments (Test Comments) as well in serviceCtx, but in the converted version we are not sending these fields. Tests will pass for sure, as they are not mandatory to send. -- Best Regards, Suraj Khurana Senior Technical Consultant

Re: svn commit: r1867927 - in /ofbiz/ofbiz-framework/trunk/applications/order: minilang/test/OrderTests.xml src/main/groovy/org/apache/ofbiz/order/OrderTests.groovy

2020-04-27 Thread Suraj Khurana
Hello Jacques, I think we missed the note, comments field during conversion in this commit. Is it intentional, or am I missing something? -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Oct 3, 2019 at 5:00 PM wrote: > Author: jleroux > Date: Thu Oct 3 11:30:28 2019

Re: OFBiz-Shopify Integration

2020-04-26 Thread Suraj Khurana
+1 for creating a new plugin. -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91 9669750002 email: suraj.khur...@hotwax.co *www.hotwax.co <http://www.hotwax.co/>* On Sun, Apr 26, 2020 at 10:00 AM Ritesh Kumar < ritesh.ku...@hotwaxsystems.com> wrote: > Hello t

Re: Default constructors in JAVA classes

2020-04-26 Thread Suraj Khurana
Constants in all JAVA classes should be declared private instead of public, like MODULE. I think we can create improvement type tickets for these constant usability enhancements, if noone has any further concerns and we can improve them component wise. -- Best Regards, Suraj Khurana Senior Technical

Re: Default constructors in JAVA classes

2020-04-25 Thread Suraj Khurana
Yes, not much changes to be done after this information from Rishi. Thanks everyone. -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91 9669750002 email: suraj.khur...@hotwax.co *www.hotwax.co <http://www.hotwax.co/>* On Fri, Apr 24, 2020 at 3:22 PM Jacques L

Re: Valid Item Status for partial shipment

2020-04-25 Thread Suraj Khurana
Yes. Adding up to this, in fact, OrderReadHelper.*getItemShippedQuantity* handles *cancelQuantity* effectively. So we can efficiently get desired results using these methods. HTH. -- Best Regards, Suraj Khurana Senior Technical Consultant On Sat, Apr 25, 2020 at 12:19 PM Mridul Pathak

Re: Welcome Swapnil M Mane as new PMC member

2020-04-23 Thread Suraj Khurana
Congratulations Swapnil !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Apr 23, 2020 at 5:27 PM Pawan Verma wrote: > Congratulations Swapnil :) > -- > Thanks & Regards > Pawan Verma > ofbiz.apache.org > > > On Thu, Apr 23, 2020 at

Default constructors in JAVA classes

2020-04-22 Thread Suraj Khurana
in JAVA should be having a private constructor and must be defined as 'final' so that the JVM doesn't need to create a data object using that default constructor everytime and supplies which is time taking. Please let me know your thoughts on this. [1]: https://qaplug.com/ -- Best Regards, Suraj

Re: Welcome to Vasmatkar as new committer!

2020-04-22 Thread Suraj Khurana
Congratulations Girish !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Apr 22, 2020 at 3:11 PM Ashish Vijaywargiya < ashish.vijaywarg...@hotwaxsystems.com> wrote: > Congrats Girish! > > -- > Kind Regards, > Ashish Vijaywargiya > Vice President

Re: Welcome James Young as new PMC member

2020-04-22 Thread Suraj Khurana
Congratulations James !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Apr 22, 2020 at 3:15 PM Ashish Vijaywargiya < ashish.vijaywarg...@hotwaxsystems.com> wrote: > Congrats James! > > -- > Kind Regards, > Ashish Vijaywargiya > Vice President

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.03

2020-04-21 Thread Suraj Khurana
+1 -- Best Regards, Suraj Khurana Senior Technical Consultant On Mon, Apr 20, 2020 at 2:34 PM Jacopo Cappellato < jacopo.cappell...@gmail.com> wrote: > This is the vote thread to release a new bug fix release for the > release17.12 branch. This new release, "Apac

Re: Valid Item Status for partial shipment

2020-04-14 Thread Suraj Khurana
Adding Dev ML. -- Best Regards, Suraj Khurana Senior Technical Consultant On Tue, Apr 14, 2020 at 5:13 PM Shikha Jaiswal < shikha.jais...@hotwaxsystems.com> wrote: > Hello team, > > From the business point of view, please share what should be the exact > status of an i

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.02

2020-04-12 Thread Suraj Khurana
+1 -- Best Regards, Suraj Khurana Senior technical Consultant On Fri, Apr 10, 2020 at 3:36 PM Jacopo Cappellato < jacopo.cappell...@gmail.com> wrote: > This is the vote thread to release a new bug fix release for the > release17.12 branch. This new release, "Apac

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-27 Thread Suraj Khurana
+1 -- Best Regards, Suraj Khurana www.hotwax.co On Thu, Feb 27, 2020 at 3:20 PM Jacopo Cappellato < jacopo.cappell...@gmail.com> wrote: > This is the vote thread (3nd attempt) to release "Apache OFBiz 17.12.01": > this is the first release, containing the framework

Re: [GitHub] [ofbiz-site] PierreSmits commented on issue #1: Improved: widget-theme.xsd typos (OFBIZ-11421)

2020-02-27 Thread Suraj Khurana
+1 to move these git notifications. We can use notificati...@ofbiz.apache.org for sure, at the same time, we can have a separate list, if required. -- Best Regards, Suraj Khurana www.hotwax.co On Thu, Feb 27, 2020 at 1:48 PM Swapnil M Mane wrote: > Hi team, > Should we move the

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #2

2020-02-25 Thread Suraj Khurana
+1 for new thread. Thanks Michael for taking care of fixed version/s. -- Best Regards, Suraj Khurana On Wed, Feb 26, 2020 at 10:54 AM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks Michael, > > Jacques > > Le 25/02/2020 à 23:06, Michael Brohl a écrit :

Re: buildbot exception in on ofbizBranch17FrameworkPlugins

2020-02-23 Thread Suraj Khurana
for release17.12. Sorry for the inconvenience. -- Best Regards, Suraj Khurana On Mon, Feb 24, 2020 at 1:00 AM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Maybe this needs more explanation for the common good. > > The build Deepak used as reference was not at the orig

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.07

2020-01-31 Thread Suraj Khurana
+1. Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT On Fri, Jan 31, 2020 at 1:07 PM Swapnil M Mane wrote: > +1 > > Best regards, > Swapnil M Mane, > ofbiz.apache.org > > > > On Thu, Jan 30, 2020 at 7:43 PM Jacopo Cappellato < > j

Re: [VOTE] Do not release R17 and directly publish R18 instead.

2020-01-27 Thread Suraj Khurana
-1 Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT On Mon, Jan 27, 2020 at 1:34 PM Deepak Dixit wrote: > -1 > > Kind Regards, > Deepak Dixit > > > On Sun, Jan 26, 2020 at 10:24 PM Martin Becker > wrote: > > > -1 > > > > Martin Beck

Re: Welcome to Olivier Heintz as new committer!

2020-01-17 Thread Suraj Khurana
Many Congratulations, Olivier !! -- Best Regards, Suraj Khurana TECHNICAL CONSULTANT On Fri, Jan 17, 2020 at 6:04 PM Pawan Verma wrote: > Many congratulations Olivier!!! > -- > Thanks & Regards > Pawan Verma > Technical Consultant > *HotWax Systems* > *Enterprise op

Re: ContactNumber optional on service definition

2019-12-16 Thread Suraj Khurana
problem, I would recommend to change the serviceDef and make it work like real situations, not likely to work as per data model flexibilities. Please share you thoughts on this. -- Best Regards, Suraj Khurana TECHNICAL CONSULTANT mobile: +91 9669750002 email: suraj.khur...@hotwax.co *www.hotwax.co

Re: Welcome Gil Portenseigne and Mathieu Lirzin as new PMC members

2019-12-03 Thread Suraj Khurana
Many congratulations Gil and Mathieu !! -- Best Regards, Suraj Khurana Technical Consultant HotWax Systems On Wed, Dec 4, 2019 at 1:17 AM sharanf wrote: > Congratulations and welcome Gil and Mathieu! > > Thanks > Sharan > > On 2019-12-03 12:09, Deepak Dixit wrote: > >

ContactNumber optional on service definition

2019-12-03 Thread Suraj Khurana
ils, contactNumber should be mandatory because that's the main thing to be created/updated. Please share your thoughts, am I missing something? -- Best Regards, Suraj Khurana Technical Consultant *HotWax Systems* *Enterprise open source experts* cell: 96697-50002 http://www.hotwaxsystems.com

  1   2   3   4   >