Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-25 Thread Vaibhav Jain
Hello All, Here is a link to ticket OFBIZ-9998 raised on JIRA. Thanks & Regards Vaibhav Jain Hotwax Systems, vaibhav.j...@hotwaxsystems.com On Thu, Nov 23, 2017 at 11:39 AM, Suraj Khurana < suraj.khur...@hotwaxsystems.com> wrote: > Thanks,

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-22 Thread Suraj Khurana
Thanks, Paul and everyone for the detailed description. -- Thanks and Regards, *Suraj Khurana* | Sr. Enterprise Software Engineer *HotWax Commerce* by *HotWax Systems* Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 On Wed, Nov 22, 2017 at 1:51 PM, Vaibhav Jain

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-22 Thread Vaibhav Jain
Hello all, Thank you very much to all of you for sharing this valuable information. As we can conclude this conversation here. 1. Payment entity already has a field finAccountTransId. So there is no need of paymentId in the FinAccountTrans entity. 2. A financial account transaction may

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-21 Thread Paul Foxworthy
On 21 November 2017 at 21:48, Suraj Khurana wrote: > > I think in this case, one *FinAccountTrans* record will be created when you > receive a cheque payments from a customer with DEPOSIT purpose which marks > *paymentId* in *FinAccountTrans *entity. > Yes,

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-21 Thread Suraj Khurana
Hi Paul, Please see my comments inline. On Tue, Nov 21, 2017 at 3:30 PM, Paul Foxworthy wrote: > Hi Suraj, > > Yes, that information is valuable, and you should be able to find it. I > still don't think it all belongs in the FinAccountTrans. > > You are right that a credit

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-21 Thread Paul Foxworthy
Hi Suraj, Yes, that information is valuable, and you should be able to find it. I still don't think it all belongs in the FinAccountTrans. You are right that a credit card payment or a store account payment will almost certainly be for one order. But other FinAccountTrans instances will be more

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-21 Thread Suraj Khurana
Hello all, Just adding some thoughts, *FinAccount* is also used for various other types as well such as *STORE_CREDIT_ACCT, CREDIT_CARD_ACCOUNT *etc. and IMO, recording these transactions (orderId, returnId, shipmentId etc.) for such accounts is a valuable information to be stored to track reason

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-20 Thread Jacques Le Roux
+1 Jacques Le 21/11/2017 à 08:27, Scott Gray a écrit : I agree with Paul that FinAccountTrans shouldn't reference orderId or returnId. I have nothing to add, his reasoning is spot on. Regards Scott On 21 November 2017 at 16:56, Paul Foxworthy wrote: Hi Vaibhav, I'm

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-20 Thread Scott Gray
I agree with Paul that FinAccountTrans shouldn't reference orderId or returnId. I have nothing to add, his reasoning is spot on. Regards Scott On 21 November 2017 at 16:56, Paul Foxworthy wrote: > Hi Vaibhav, > > I'm really uncomfortable about this. > > As Pierre said,

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-20 Thread Paul Foxworthy
Hi Vaibhav, I'm really uncomfortable about this. As Pierre said, FinAccountTrans is for a transaction for a financial account (likely a bank account), rather than a transaction on an account in the accounting sense, i.e. an account in your chart of accounts. So a FinAccountTrans records a

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-20 Thread Pierre Smits
Hi Vaibhav, Thank you for providing the entity. When looking at the demo data in demo-trunk I don't see anything that relates back to an order. Maybe that is an incompleteness regarding the demo data I wonder which of the Financial Transaction related screens and services work with the

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-20 Thread Vaibhav Jain
Hello Pierre, For reference, In inventoryItemDetail entity, we are recording orderId, returnId and shipmentId to track the transaction of inventory item. Comments Inline Grin. I indeed must have overlooked something. > > So the orderId field is present in that entity. With that we can derive >

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-20 Thread Pierre Smits
Hey Vaibhav, Grin. I indeed must have overlooked something. So the orderId field is present in that entity. With that we can derive anything related, including shipments, returns, invoices, return shipments, etc. If we're going to include the fields you suggest, I surmise that before long

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-20 Thread Vaibhav Jain
Hello Pierre, I am talking about OFBiz trunk. Here is the path of the file: applications/datamodel/entitydef/accounting-entitymodel.xml:462 Just for more information, you can directly access this entity from entityengine

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-20 Thread Pierre Smits
Hi Valibhav, Which version of OFBiz are you talking about? I looked in data model.entitydef.accounting-entitymodel.xml and this entity did not show up. I may be overlooking something.. Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OEM - The

[PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-20 Thread Vaibhav Jain
Hello all, Currently, orderId field is available and returnId, shipmentId fields can be introduced in the FinAccountTrans entity. These fields are useful while recording fin account transactions. Please let me know your thoughts on it. Thanks in advance Vaibhav Jain Hotwax Systems,