[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319049#comment-15319049
]
Taher Alkhateeb commented on OFBIZ-6783:
Committed all changes in r1747288. This concludes this
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318293#comment-15318293
]
Jacques Le Roux commented on OFBIZ-6783:
* for the port, I mean to make it more obvious at 1st
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318225#comment-15318225
]
Taher Alkhateeb commented on OFBIZ-6783:
Hi Jacques,
I always feel extra assured after you pitch
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318126#comment-15318126
]
Jacques Le Roux commented on OFBIZ-6783:
Hi Taher,
I just reviewed. For the 1st time, a start
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316627#comment-15316627
]
Taher Alkhateeb commented on OFBIZ-6783:
Hi Jacopo,
Makes perfect sense. I will do that and
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316559#comment-15316559
]
Jacopo Cappellato commented on OFBIZ-6783:
--
Hi [~taher],
I am reviewing your last patch and so
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315834#comment-15315834
]
Gil Portenseigne commented on OFBIZ-6783:
-
Hi Taher,
Reading your code is very pleasant, i did
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315734#comment-15315734
]
Jacques Le Roux commented on OFBIZ-6783:
I created OFBIZ-7192 for that
> Refactor the start
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315616#comment-15315616
]
Jacques Le Roux commented on OFBIZ-6783:
I did not look (yet) at the code, but your comment makes
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307303#comment-15307303
]
Taher Alkhateeb commented on OFBIZ-6783:
Okay fixed everything and committed in r1746236
I think
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307297#comment-15307297
]
Jacopo Cappellato commented on OFBIZ-6783:
--
You are indeed right Taher! I didn't notice it
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307283#comment-15307283
]
Taher Alkhateeb commented on OFBIZ-6783:
Hi Jacopo,
The patch you provided breaks in eclipse. I
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307272#comment-15307272
]
Taher Alkhateeb commented on OFBIZ-6783:
Nice catch Jacopo, I always forget to do a second grep on
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300267#comment-15300267
]
Jacques Le Roux commented on OFBIZ-6783:
Also note that my commit r1745451 has an impact, before I
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300278#comment-15300278
]
Taher Alkhateeb commented on OFBIZ-6783:
I agree totally, things should be fixed, but one thing at
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300258#comment-15300258
]
Jacques Le Roux commented on OFBIZ-6783:
Ha I never used this syntax, only the ant target.
OK
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300171#comment-15300171
]
Taher Alkhateeb commented on OFBIZ-6783:
I'm a bit lost now.
First, the test case above "did"
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300118#comment-15300118
]
Jacques Le Roux commented on OFBIZ-6783:
OK I was wrong, at least in an up to date working copy
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300103#comment-15300103
]
Jacques Le Roux commented on OFBIZ-6783:
Mmm wait, I confused, it's not the same kind of error, I
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300090#comment-15300090
]
Jacques Le Roux commented on OFBIZ-6783:
This (kinda) pre-existed to your changes, in a WC at
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15300064#comment-15300064
]
Jacques Le Roux commented on OFBIZ-6783:
Forget this report, it's only in a WC with WIP for
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299782#comment-15299782
]
Taher Alkhateeb commented on OFBIZ-6783:
Hi jacques,
Is this behavior non existent pre patch. it
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299771#comment-15299771
]
Jacques Le Roux commented on OFBIZ-6783:
This of course in a clean up to date WC
> Refactor the
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15299683#comment-15299683
]
Jacques Le Roux commented on OFBIZ-6783:
Maybe not a big deal, but at the end of running
bq. java
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15298099#comment-15298099
]
Taher Alkhateeb commented on OFBIZ-6783:
Thank you Jacopo and Gil for your valuable feedback.
I
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297855#comment-15297855
]
Gil Portenseigne commented on OFBIZ-6783:
-
I just did the same on ubuntu with java version
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297747#comment-15297747
]
Jacopo Cappellato commented on OFBIZ-6783:
--
I have tested your last patch on a MacBook Pro
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294984#comment-15294984
]
Taher Alkhateeb commented on OFBIZ-6783:
Note:
For testing purposes and for best results, we need
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290893#comment-15290893
]
Jacques Le Roux commented on OFBIZ-6783:
Thks!
> Refactor the start component
>
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290813#comment-15290813
]
Taher Alkhateeb commented on OFBIZ-6783:
done in r1744547.
> Refactor the start component
>
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290794#comment-15290794
]
Jacques Le Roux commented on OFBIZ-6783:
This would need an extra Jira, but also some arguments...
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290791#comment-15290791
]
Jacques Le Roux commented on OFBIZ-6783:
Cool, could we not have also
{code}
--testlist
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290729#comment-15290729
]
Taher Alkhateeb commented on OFBIZ-6783:
Ok, committed in r1744537. The screen width for
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290687#comment-15290687
]
Jacques Le Roux commented on OFBIZ-6783:
A wider screen would help readability, but there could
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290672#comment-15290672
]
Jacques Le Roux commented on OFBIZ-6783:
Thanks!
> Refactor the start component
>
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290671#comment-15290671
]
Taher Alkhateeb commented on OFBIZ-6783:
Yeah I see why you got confused by that.
So there are
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290667#comment-15290667
]
Jacques Le Roux commented on OFBIZ-6783:
Indeed, this happens also with
bq. java -jar ofbiz.jar
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290663#comment-15290663
]
Jacques Le Roux commented on OFBIZ-6783:
Actually I was abused by this line in help
bq.
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290661#comment-15290661
]
Taher Alkhateeb commented on OFBIZ-6783:
Also another commit in r1744528 to clarify the usage in
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290652#comment-15290652
]
Taher Alkhateeb commented on OFBIZ-6783:
Hmmm, definitely worth investigating. It is my intention
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290647#comment-15290647
]
Jacques Le Roux commented on OFBIZ-6783:
And a Ctrl+C gave me that
{code}
2016-05-19 09:46:43,169
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290645#comment-15290645
]
Jacques Le Roux commented on OFBIZ-6783:
Ah indeed, anyway same with
bq. java -jar ofbiz.jar
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290646#comment-15290646
]
Taher Alkhateeb commented on OFBIZ-6783:
Hi Jacques,
Thank you for reverting, I have implemented
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290634#comment-15290634
]
Taher Alkhateeb commented on OFBIZ-6783:
Hi Jacques, I guess need to further finetune the
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290628#comment-15290628
]
Jacques Le Roux commented on OFBIZ-6783:
OK, I will simply revert and let you handling things,
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290599#comment-15290599
]
Taher Alkhateeb commented on OFBIZ-6783:
Hi Jacques,
This code does not look good, you shouldn't
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290486#comment-15290486
]
Jacques Le Roux commented on OFBIZ-6783:
At revision: 1744515, I Improved the visibility of the
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286382#comment-15286382
]
Jacques Le Roux commented on OFBIZ-6783:
Thanks for the review, fixed!
> Refactor the start
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286263#comment-15286263
]
Taher Alkhateeb commented on OFBIZ-6783:
Hi Jacques,
It's still not fully updated. You need to
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15286217#comment-15286217
]
Jacques Le Roux commented on OFBIZ-6783:
Done with wiki update
> Refactor the start component
>
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15285042#comment-15285042
]
Taher Alkhateeb commented on OFBIZ-6783:
Ding ding ding
Ladies and Gentlemen boys and girls, we
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284728#comment-15284728
]
Jacques Le Roux commented on OFBIZ-6783:
OK, my bad I kept the old StartupCommand.java and
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284638#comment-15284638
]
Taher Alkhateeb commented on OFBIZ-6783:
oh oh oh I think I know what you mean now. You are not
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284626#comment-15284626
]
Taher Alkhateeb commented on OFBIZ-6783:
Hi Jacques,
When I run the following command:
java -jar
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284621#comment-15284621
]
Jacques Le Roux commented on OFBIZ-6783:
Sorry Tather,
Still the same issue with _--testlist
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284404#comment-15284404
]
Jacques Le Roux commented on OFBIZ-6783:
Please remove this part from your patch
{code}
Index:
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284346#comment-15284346
]
Taher Alkhateeb commented on OFBIZ-6783:
oops, please ignore, reattaching
> Refactor the start
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284344#comment-15284344
]
Taher Alkhateeb commented on OFBIZ-6783:
I also want to note that there is more validation logic
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284343#comment-15284343
]
Taher Alkhateeb commented on OFBIZ-6783:
Fixed it in my latest patch. Please check.
> Refactor
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284335#comment-15284335
]
Jacques Le Roux commented on OFBIZ-6783:
After applying the last patch and an "ant clean-all
[
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284265#comment-15284265
]
Pierre Smits commented on OFBIZ-6783:
-
Maybe we should consider moving the cobertura integration
61 matches
Mail list logo
