RE: Applicable Promo Recommendations

2019-05-01 Thread Swapnil Shah
Actually my (and possibly Pierre's) concern was bit different. Many a times
system needs to allow exchanging the originally ordered item with a
different item. In such cases if it starts auto-inheriting the adjustments
then customer can start gaming the system by purchasing the discounted items
and exchanging it with full priced or lesser discounted items.

For example, customer originally purchases $100 item at 20% discount
(doesn't matter whether default or overridden from eligible set of active
promotion). Now returns it and get it exchanged with another $100 item which
doesn't have any active applicable promotions and is currently being sold at
fully price. If system always inherit and auto-apply the adjustments from
originally ordered item then my store would end up actually selling a
non-discounted item at 20% discount.

A possible solution could be that while exchanging the item, system can
check whether the exchanged item is eligible for same promotion as that of
returned item or not. If yes inherit and apply the same adjustments else
not. Here again authorized user with desired permissions can be allow to
manually override it later if required.

Thanks,
Swapnil

-Original Message-
From: Rishi Solanki 
Sent: Wednesday, May 01, 2019 6:49 PM
To: dev@ofbiz.apache.org
Subject: Re: Applicable Promo Recommendations

Some addition details I could think of, thanks for raising this point.
One use case to be consider as per Swapnil comment, but it is not
implemented in OFBiz. If business take returns of Non Order Items (Items
purchased but Order does not exists in the system). In this case depending
upon the business requirement system may need to identify the applicable
promotion on return. For now it is handle with manual adjustment in current
flow.
Right now non order item return not supported in current process flow. But
we should surely take care of this corner case, when we think of
implementing non order item return.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development HotWax Systems
 Plot no. 80, Scheme no. 78 Part 2, Near
Brilliant Convention Center, Indore, M.P 452010
Linkedin: *Rishi Solanki*

Direct: +91-9893287847


On Wed, May 1, 2019 at 6:13 PM Rishi Solanki 
wrote:

> Dear Swapnil/Pierre,
> Thanks for more thoughts on the subject. The return
> (refund/replacement/exchange) always use original order adjustments
> for return. No promo engine or price rule engine run in that case.
> This is because return adjustments always depends on the order
> adjustment. The only flexibility OFBiz workflow provides to add manual
> adjustments in case of conflict.
>
> IMO we are good to go with proposal. As return never use the promo
> engine to apply promo and it is only work for order as per the current
> flow.
>
> Best Regards,
> --
> *Rishi Solanki* | Sr Manager, Enterprise Software Development HotWax
> Systems  Plot no. 80, Scheme no. 78
> Part 2, Near Brilliant Convention Center, Indore, M.P 452010
> Linkedin: *Rishi Solanki*
> 
> Direct: +91-9893287847
>
>
> On Wed, May 1, 2019 at 1:42 PM Pierre Smits 
> wrote:
>
>> Thanks Swapnil, for your posting as it triggered a thought about
>> gaming the promotions by e-commerce customer.
>>
>> The though was: is this not opening up the whole for nefarious
>> e-commerce customers to game the functionalities in their favour (and
>> to the disadvantage of the adopter and its other customers) regarding
>> ordering and returning goods as such?
>>
>> I don't have that full picture yet, so it may be a non-issue. But on
>> the other hand better safe than sorry, right?
>>
>> Best regards,
>>
>> Pierre Smits
>>
>> *Apache Trafodion , Vice President*
>> *Apache Directory , PMC Member* Apache
>> Incubator , committer *Apache OFBiz
>> , contributor (without
>> privileges)
>> since 2008*
>> Apache Steve , committer
>>
>>
>> On Wed, May 1, 2019 at 9:49 AM Swapnil Shah <
>> swapnil.s...@hotwaxsystems.com>
>> wrote:
>>
>> > I am not sure if it might require an add-on handling or not but can
>> someone
>> > please test or make sure that exchange orders against the
>> > originally ordered style/assortment inherit the order adjustments
>> > from original order
>> (instead
>> > of auto applying the default promo again) or at least provide the
>> > same manual overriding options so as to make sure that exchange
>> > invoices are
>> in
>> > coherence with the original order invoice.
>> >
>> > Thanks,
>> > Swapnil
>> >
>> > -Original Message-
>> > From: Rishi Solanki 
>> > Sent: Sunday, April 28, 2019 4:09 AM
>> > To: dev@ofbiz.apache.org
>> > Subject: Applicable Promo Recommendations
>> >
>> > Devs,
>> > I would like to propose the user

Re: Next step to migrate OFBiz from Subversion (SVN) to Git

2019-05-01 Thread Swapnil M Mane
Dear Mathieu,

You are 200% correct, please accept my kind apologies for this.
I have update the document [1] with appropriate information.

Thanks so much for correcting me.


[1] https://cwiki.apache.org/confluence/x/Xg-HBg


- Best Regards,
Swapnil M Mane,
ofbiz.apache.org



On Wed, May 1, 2019 at 8:54 PM Mathieu Lirzin 
wrote:

> Hello Swapnil,
>
> Swapnil M Mane  writes:
>
> > As we have concluded to move our source repository from SVN to Git.
> > Based on our previous discussions [1], here is the document [2] which can
> > help us to strategies our migration.
> >
> > This document contain all the relevant topics which need to consider
> > before, during and after migration to Git.
>
> > I request everyone to please have a look into this document and kindly
> > share your thoughts.
> > Also, feel free to update the document.
>
> I appreciate your writing effort, however I think your writing tends to
> mix Git and Github workflows which are two separate things.
>
> As far as I understand it, we agreed to change our version control
> system to use Git not to change our contribution workflow to use Github.
> Contributions will continue to be done via JIRA, patches and the ML, as
> long as we don't discuss and vote for that.
>
> Personnally I will be against using Github social features (issues,
> pull-request, wiki, ...) in our contribution process.
>
> Thanks.
>
> --
> Mathieu Lirzin
> GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37
>


Re: Next step to migrate OFBiz from Subversion (SVN) to Git

2019-05-01 Thread Mathieu Lirzin
Hello Swapnil,

Swapnil M Mane  writes:

> As we have concluded to move our source repository from SVN to Git.
> Based on our previous discussions [1], here is the document [2] which can
> help us to strategies our migration.
>
> This document contain all the relevant topics which need to consider
> before, during and after migration to Git.

> I request everyone to please have a look into this document and kindly
> share your thoughts.
> Also, feel free to update the document.

I appreciate your writing effort, however I think your writing tends to
mix Git and Github workflows which are two separate things.

As far as I understand it, we agreed to change our version control
system to use Git not to change our contribution workflow to use Github.
Contributions will continue to be done via JIRA, patches and the ML, as
long as we don't discuss and vote for that.

Personnally I will be against using Github social features (issues,
pull-request, wiki, ...) in our contribution process.

Thanks.

-- 
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761  070D 0ADE E100 9460 4D37


RE: Applicable Promo Recommendations

2019-05-01 Thread Swapnil Shah
Yes Pierre, I would envision to have these kind of overriding features be
made permission driven eventually. In case of RMAs more often than not it's
going to be some authorized users who would be permitted to alter the
original adjustments on order.
As long as inheritance gets honored while exchanged item attracts same
default promotions as originally purchased item then we should be good to go
with it.

Thanks & Regards,
Swapnil

> -Original Message-
> From: Pierre Smits 
> Sent: Wednesday, May 01, 2019 1:43 PM
> To: dev@ofbiz.apache.org
> Subject: Re: Applicable Promo Recommendations
>
> Thanks Swapnil, for your posting as it triggered a thought about gaming
> the
> promotions by e-commerce customer.
>
> The though was: is this not opening up the whole for nefarious e-commerce
> customers to game the functionalities in their favour (and to the
> disadvantage of the adopter and its other customers) regarding ordering
> and
> returning goods as such?
>
> I don't have that full picture yet, so it may be a non-issue. But on the
> other
> hand better safe than sorry, right?
>
> Best regards,
>
> Pierre Smits
>
> *Apache Trafodion , Vice President*
> *Apache Directory , PMC Member* Apache
> Incubator , committer *Apache OFBiz
> , contributor (without privileges) since 2008*
> Apache Steve , committer
>
>
> On Wed, May 1, 2019 at 9:49 AM Swapnil Shah
> 
> wrote:
>
> > I am not sure if it might require an add-on handling or not but can
> > someone please test or make sure that exchange orders against the
> > originally ordered style/assortment inherit the order adjustments from
> > original order (instead of auto applying the default promo again) or
> > at least provide the same manual overriding options so as to make sure
> > that exchange invoices are in coherence with the original order
> > invoice.
> >
> > Thanks,
> > Swapnil
> >
> > -Original Message-
> > From: Rishi Solanki 
> > Sent: Sunday, April 28, 2019 4:09 AM
> > To: dev@ofbiz.apache.org
> > Subject: Applicable Promo Recommendations
> >
> > Devs,
> > I would like to propose the user selection ability for promotion. That
> > means user can select her own choice of promotion from the list of
> > promotion applicable to current cart. Right now promotion engine based
> > on algorithm implemented decide which promotion will be apply to cart
> > from the list of promotion. For example, if promotion engine find 3
> > promotion applicable for the current cart then based on algorithm
> > implemented it apply the maximum amount value promotion to the cart.
> >
> > Coming back to proposal with some use cases;
> >
> > Use Case 1: Promotion engine find three promotions applicable to cart
> > or item as P1, P2 and P3. And as per algorithm promo engine decide to
> > apply P1.
> > Now if user want to go with P2 or P3 then she can do that.
> >
> > Use Case 2: In #1 user can also choose to not take any promotion,
> > remove the
> > P1 and submit the order without promotion.
> >
> > Use Case 3: Item1 and item2 will have two promotions common as P1 and
> P2.
> > Now user can opt which promotion should applicable to which item. That
> > means user can apply P1 or P2 on item1 or item2 based on her
> > preference.
> >
> > Use Case 4: In #3 if user wants then she can opt to select promotion
> > for one item and can remove promo from other.
> >
> >
> > Looking forward for valuable feedback on proposal and suggestion on
> > design from community. Also please feel free to ask for more details
> > on each use case or on proposal itself.
> >
> >
> > Thanks!
> >
> > Best Regards,
> > --
> > *Rishi Solanki* | Sr Manager, Enterprise Software Development HotWax
> > Systems  Plot no. 80, Scheme no. 78
> > Part 2, Near Brilliant Convention Center, Indore, M.P 452010
> > Linkedin: *Rishi Solanki*
> > 
> > Direct: +91-9893287847
> >


Next step to migrate OFBiz from Subversion (SVN) to Git

2019-05-01 Thread Swapnil M Mane
Hi team,

Thanks so much everyone for participating in the discussion [1] to migrate
OFBiz from Subversion (SVN) to Git version control system.

As we have concluded to move our source repository from SVN to Git.
Based on our previous discussions [1], here is the document [2] which can
help us to strategies our migration.

This document contain all the relevant topics which need to consider
before, during and after migration to Git.

   1. Code Repository
   2. Workflow
  1. Small Features / Bug Fixes
  2. Large Features
   3. Buildbot configuration with Git (Build Scripts)
   4. Revert workflow
  1. Revert Pull Request
  2. Revert a commit
   5. Backport the fixes
   6. Release management
   7. Equivalent of svn:auto-props properties
   8. Update the website, wiki documents and references

The workflow in document is suggested by Taher in thread [1], and based on
my experience with Git, I have added respective the points in the above
sections.

I have added some task in document which needs to done, confluence provide
use feature to assign the task in the document itself.
Example, I have assigned two tasks to me under "Update the website, wiki
documents and references" section. We can use this feature distribute our
tasks.

I request everyone to please have a look into this document and kindly
share your thoughts.
Also, feel free to update the document.


[1]
https://lists.apache.org/thread.html/9f89b2a24ff427dffaf71294fc20306994fd1c19a6b24e64c4b06d71@1431423796@%3Cdev.ofbiz.apache.org%3E
[2] https://cwiki.apache.org/confluence/x/Xg-HBg


- Best Regards,
Swapnil M Mane,
ofbiz.apache.org


Re: Applicable Promo Recommendations

2019-05-01 Thread Rishi Solanki
Some addition details I could think of, thanks for raising this point.
One use case to be consider as per Swapnil comment, but it is not
implemented in OFBiz. If business take returns of Non Order Items (Items
purchased but Order does not exists in the system). In this case depending
upon the business requirement system may need to identify the applicable
promotion on return. For now it is handle with manual adjustment in current
flow.
Right now non order item return not supported in current process flow. But
we should surely take care of this corner case, when we think of
implementing non order item return.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems 
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*

Direct: +91-9893287847


On Wed, May 1, 2019 at 6:13 PM Rishi Solanki 
wrote:

> Dear Swapnil/Pierre,
> Thanks for more thoughts on the subject. The return
> (refund/replacement/exchange) always use original order adjustments for
> return. No promo engine or price rule engine run in that case. This is
> because return adjustments always depends on the order adjustment. The only
> flexibility OFBiz workflow provides to add manual adjustments in case of
> conflict.
>
> IMO we are good to go with proposal. As return never use the promo engine
> to apply promo and it is only work for order as per the current flow.
>
> Best Regards,
> --
> *Rishi Solanki* | Sr Manager, Enterprise Software Development
> HotWax Systems 
> Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center,
> Indore, M.P 452010
> Linkedin: *Rishi Solanki*
> 
> Direct: +91-9893287847
>
>
> On Wed, May 1, 2019 at 1:42 PM Pierre Smits 
> wrote:
>
>> Thanks Swapnil, for your posting as it triggered a thought about gaming
>> the
>> promotions by e-commerce customer.
>>
>> The though was: is this not opening up the whole for nefarious e-commerce
>> customers to game the functionalities in their favour (and to the
>> disadvantage of the adopter and its other customers) regarding ordering
>> and
>> returning goods as such?
>>
>> I don't have that full picture yet, so it may be a non-issue. But on the
>> other hand better safe than sorry, right?
>>
>> Best regards,
>>
>> Pierre Smits
>>
>> *Apache Trafodion , Vice President*
>> *Apache Directory , PMC Member*
>> Apache Incubator , committer
>> *Apache OFBiz , contributor (without
>> privileges)
>> since 2008*
>> Apache Steve , committer
>>
>>
>> On Wed, May 1, 2019 at 9:49 AM Swapnil Shah <
>> swapnil.s...@hotwaxsystems.com>
>> wrote:
>>
>> > I am not sure if it might require an add-on handling or not but can
>> someone
>> > please test or make sure that exchange orders against the originally
>> > ordered
>> > style/assortment inherit the order adjustments from original order
>> (instead
>> > of auto applying the default promo again) or at least provide the same
>> > manual overriding options so as to make sure that exchange invoices are
>> in
>> > coherence with the original order invoice.
>> >
>> > Thanks,
>> > Swapnil
>> >
>> > -Original Message-
>> > From: Rishi Solanki 
>> > Sent: Sunday, April 28, 2019 4:09 AM
>> > To: dev@ofbiz.apache.org
>> > Subject: Applicable Promo Recommendations
>> >
>> > Devs,
>> > I would like to propose the user selection ability for promotion. That
>> > means
>> > user can select her own choice of promotion from the list of promotion
>> > applicable to current cart. Right now promotion engine based on
>> algorithm
>> > implemented decide which promotion will be apply to cart from the list
>> of
>> > promotion. For example, if promotion engine find 3 promotion applicable
>> for
>> > the current cart then based on algorithm implemented it apply the
>> maximum
>> > amount value promotion to the cart.
>> >
>> > Coming back to proposal with some use cases;
>> >
>> > Use Case 1: Promotion engine find three promotions applicable to cart or
>> > item as P1, P2 and P3. And as per algorithm promo engine decide to apply
>> > P1.
>> > Now if user want to go with P2 or P3 then she can do that.
>> >
>> > Use Case 2: In #1 user can also choose to not take any promotion, remove
>> > the
>> > P1 and submit the order without promotion.
>> >
>> > Use Case 3: Item1 and item2 will have two promotions common as P1 and
>> P2.
>> > Now user can opt which promotion should applicable to which item. That
>> > means
>> > user can apply P1 or P2 on item1 or item2 based on her preference.
>> >
>> > Use Case 4: In #3 if user wants then she can opt to select promotion for
>> > one
>> > item and can remove promo from other.
>> >
>> >
>> > Looking forward for valua

Re: Applicable Promo Recommendations

2019-05-01 Thread Rishi Solanki
Dear Swapnil/Pierre,
Thanks for more thoughts on the subject. The return
(refund/replacement/exchange) always use original order adjustments for
return. No promo engine or price rule engine run in that case. This is
because return adjustments always depends on the order adjustment. The only
flexibility OFBiz workflow provides to add manual adjustments in case of
conflict.

IMO we are good to go with proposal. As return never use the promo engine
to apply promo and it is only work for order as per the current flow.

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development
HotWax Systems 
Plot no. 80, Scheme no. 78 Part 2, Near Brilliant Convention Center, Indore,
M.P 452010
Linkedin: *Rishi Solanki*

Direct: +91-9893287847


On Wed, May 1, 2019 at 1:42 PM Pierre Smits  wrote:

> Thanks Swapnil, for your posting as it triggered a thought about gaming the
> promotions by e-commerce customer.
>
> The though was: is this not opening up the whole for nefarious e-commerce
> customers to game the functionalities in their favour (and to the
> disadvantage of the adopter and its other customers) regarding ordering and
> returning goods as such?
>
> I don't have that full picture yet, so it may be a non-issue. But on the
> other hand better safe than sorry, right?
>
> Best regards,
>
> Pierre Smits
>
> *Apache Trafodion , Vice President*
> *Apache Directory , PMC Member*
> Apache Incubator , committer
> *Apache OFBiz , contributor (without privileges)
> since 2008*
> Apache Steve , committer
>
>
> On Wed, May 1, 2019 at 9:49 AM Swapnil Shah <
> swapnil.s...@hotwaxsystems.com>
> wrote:
>
> > I am not sure if it might require an add-on handling or not but can
> someone
> > please test or make sure that exchange orders against the originally
> > ordered
> > style/assortment inherit the order adjustments from original order
> (instead
> > of auto applying the default promo again) or at least provide the same
> > manual overriding options so as to make sure that exchange invoices are
> in
> > coherence with the original order invoice.
> >
> > Thanks,
> > Swapnil
> >
> > -Original Message-
> > From: Rishi Solanki 
> > Sent: Sunday, April 28, 2019 4:09 AM
> > To: dev@ofbiz.apache.org
> > Subject: Applicable Promo Recommendations
> >
> > Devs,
> > I would like to propose the user selection ability for promotion. That
> > means
> > user can select her own choice of promotion from the list of promotion
> > applicable to current cart. Right now promotion engine based on algorithm
> > implemented decide which promotion will be apply to cart from the list of
> > promotion. For example, if promotion engine find 3 promotion applicable
> for
> > the current cart then based on algorithm implemented it apply the maximum
> > amount value promotion to the cart.
> >
> > Coming back to proposal with some use cases;
> >
> > Use Case 1: Promotion engine find three promotions applicable to cart or
> > item as P1, P2 and P3. And as per algorithm promo engine decide to apply
> > P1.
> > Now if user want to go with P2 or P3 then she can do that.
> >
> > Use Case 2: In #1 user can also choose to not take any promotion, remove
> > the
> > P1 and submit the order without promotion.
> >
> > Use Case 3: Item1 and item2 will have two promotions common as P1 and P2.
> > Now user can opt which promotion should applicable to which item. That
> > means
> > user can apply P1 or P2 on item1 or item2 based on her preference.
> >
> > Use Case 4: In #3 if user wants then she can opt to select promotion for
> > one
> > item and can remove promo from other.
> >
> >
> > Looking forward for valuable feedback on proposal and suggestion on
> design
> > from community. Also please feel free to ask for more details on each use
> > case or on proposal itself.
> >
> >
> > Thanks!
> >
> > Best Regards,
> > --
> > *Rishi Solanki* | Sr Manager, Enterprise Software Development HotWax
> > Systems
> >  Plot no. 80, Scheme no. 78 Part 2, Near
> > Brilliant Convention Center, Indore, M.P 452010
> > Linkedin: *Rishi Solanki*
> > 
> > Direct: +91-9893287847
> >
>


Re: Applicable Promo Recommendations

2019-05-01 Thread Pierre Smits
Thanks Swapnil, for your posting as it triggered a thought about gaming the
promotions by e-commerce customer.

The though was: is this not opening up the whole for nefarious e-commerce
customers to game the functionalities in their favour (and to the
disadvantage of the adopter and its other customers) regarding ordering and
returning goods as such?

I don't have that full picture yet, so it may be a non-issue. But on the
other hand better safe than sorry, right?

Best regards,

Pierre Smits

*Apache Trafodion , Vice President*
*Apache Directory , PMC Member*
Apache Incubator , committer
*Apache OFBiz , contributor (without privileges)
since 2008*
Apache Steve , committer


On Wed, May 1, 2019 at 9:49 AM Swapnil Shah 
wrote:

> I am not sure if it might require an add-on handling or not but can someone
> please test or make sure that exchange orders against the originally
> ordered
> style/assortment inherit the order adjustments from original order (instead
> of auto applying the default promo again) or at least provide the same
> manual overriding options so as to make sure that exchange invoices are in
> coherence with the original order invoice.
>
> Thanks,
> Swapnil
>
> -Original Message-
> From: Rishi Solanki 
> Sent: Sunday, April 28, 2019 4:09 AM
> To: dev@ofbiz.apache.org
> Subject: Applicable Promo Recommendations
>
> Devs,
> I would like to propose the user selection ability for promotion. That
> means
> user can select her own choice of promotion from the list of promotion
> applicable to current cart. Right now promotion engine based on algorithm
> implemented decide which promotion will be apply to cart from the list of
> promotion. For example, if promotion engine find 3 promotion applicable for
> the current cart then based on algorithm implemented it apply the maximum
> amount value promotion to the cart.
>
> Coming back to proposal with some use cases;
>
> Use Case 1: Promotion engine find three promotions applicable to cart or
> item as P1, P2 and P3. And as per algorithm promo engine decide to apply
> P1.
> Now if user want to go with P2 or P3 then she can do that.
>
> Use Case 2: In #1 user can also choose to not take any promotion, remove
> the
> P1 and submit the order without promotion.
>
> Use Case 3: Item1 and item2 will have two promotions common as P1 and P2.
> Now user can opt which promotion should applicable to which item. That
> means
> user can apply P1 or P2 on item1 or item2 based on her preference.
>
> Use Case 4: In #3 if user wants then she can opt to select promotion for
> one
> item and can remove promo from other.
>
>
> Looking forward for valuable feedback on proposal and suggestion on design
> from community. Also please feel free to ask for more details on each use
> case or on proposal itself.
>
>
> Thanks!
>
> Best Regards,
> --
> *Rishi Solanki* | Sr Manager, Enterprise Software Development HotWax
> Systems
>  Plot no. 80, Scheme no. 78 Part 2, Near
> Brilliant Convention Center, Indore, M.P 452010
> Linkedin: *Rishi Solanki*
> 
> Direct: +91-9893287847
>


RE: Applicable Promo Recommendations

2019-05-01 Thread Swapnil Shah
I am not sure if it might require an add-on handling or not but can someone
please test or make sure that exchange orders against the originally ordered
style/assortment inherit the order adjustments from original order (instead
of auto applying the default promo again) or at least provide the same
manual overriding options so as to make sure that exchange invoices are in
coherence with the original order invoice.

Thanks,
Swapnil

-Original Message-
From: Rishi Solanki 
Sent: Sunday, April 28, 2019 4:09 AM
To: dev@ofbiz.apache.org
Subject: Applicable Promo Recommendations

Devs,
I would like to propose the user selection ability for promotion. That means
user can select her own choice of promotion from the list of promotion
applicable to current cart. Right now promotion engine based on algorithm
implemented decide which promotion will be apply to cart from the list of
promotion. For example, if promotion engine find 3 promotion applicable for
the current cart then based on algorithm implemented it apply the maximum
amount value promotion to the cart.

Coming back to proposal with some use cases;

Use Case 1: Promotion engine find three promotions applicable to cart or
item as P1, P2 and P3. And as per algorithm promo engine decide to apply P1.
Now if user want to go with P2 or P3 then she can do that.

Use Case 2: In #1 user can also choose to not take any promotion, remove the
P1 and submit the order without promotion.

Use Case 3: Item1 and item2 will have two promotions common as P1 and P2.
Now user can opt which promotion should applicable to which item. That means
user can apply P1 or P2 on item1 or item2 based on her preference.

Use Case 4: In #3 if user wants then she can opt to select promotion for one
item and can remove promo from other.


Looking forward for valuable feedback on proposal and suggestion on design
from community. Also please feel free to ask for more details on each use
case or on proposal itself.


Thanks!

Best Regards,
--
*Rishi Solanki* | Sr Manager, Enterprise Software Development HotWax Systems
 Plot no. 80, Scheme no. 78 Part 2, Near
Brilliant Convention Center, Indore, M.P 452010
Linkedin: *Rishi Solanki*

Direct: +91-9893287847