Re: [VOTE] [RELEASE] Apache OFBiz 16.11.07

+1 Best regards, Swapnil M Mane, ofbiz.apache.org On Thu, Jan 30, 2020 at 7:43 PM Jacopo Cappellato < jacopo.cappell...@gmail.com> wrote: > This is the vote thread to release a new bug fix release for the > release16.11 branch. This new release, "Apache OFBiz 16.11.07" will > supersede all

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.07

+1 -- Thanks & Regards Pawan Verma Technical Consultant *HotWax Systems* *Enterprise open source experts* http://www.hotwaxsystems.com On Fri, Jan 31, 2020 at 1:37 AM Gil Portenseigne < gil.portensei...@nereide.fr> wrote: > +1 > > Thanks > > On Fri, Jan 31, 2020 at 12:16:54AM +0530, Deepak

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.07

+1 Thanks On Fri, Jan 31, 2020 at 12:16:54AM +0530, Deepak Dixit wrote: > +1 > > Thanks & Regards > -- > Deepak Dixit > ofbiz.apache.org > > > On Thu, Jan 30, 2020 at 9:56 PM Nicolas Malin > wrote: > > > +1 > > > > Same result from my local > > > > Nicolas > > > > On 30/01/2020 16:06,

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.07

+1 Thanks & Regards -- Deepak Dixit ofbiz.apache.org On Thu, Jan 30, 2020 at 9:56 PM Nicolas Malin wrote: > +1 > > Same result from my local > > Nicolas > > On 30/01/2020 16:06, Michael Brohl wrote: > > +1 > > > > > > ~/Projects/apache-ofbiz/check-release-16.11.07  > >

Re: OFBiz contributions & Github Pull Requests

Dealing with pull requests in your local git environment can be done in an easy way, by adding following line to the OFBiz remotes: fetch = +refs/pull/*/head:refs/remotes/origin/pr/* preferably before the standard fetch line (fetch = +refs/heads/*:refs/remotes/origin/*). This way you can

Re: OFBiz contributions & Github Pull Requests

Michael Brohl writes: > I really don't want to see all kinds of exotic messages coming up in > our commit history. > > If the workflow allows rejecting a pull request because of bad commit > messages or maybe a hundred commits for a change, I would also be fine > with it. > > My main point is

Re: Removing “base/config/component-load.xml”

Jacques Le Roux writes: >> What question have you in mind for the vote? > > The idea is to vote about removing component-load.xml from the > framework, as Michael agreed on, but let them in applications and > plugins. Is that OK with your plan? Not really but that is better than nothing.

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.07

+1 Same result from my local Nicolas On 30/01/2020 16:06, Michael Brohl wrote: > +1 > > > ~/Projects/apache-ofbiz/check-release-16.11.07  > ../ofbiz-tools/verify-ofbiz-release.sh apache-ofbiz-16.11.07.zip > sha check of file: apache-ofbiz-16.11.07.zip > Using sha file:

Re: OFBiz contributions & Github Pull Requests

From y experience, if we want to be easy, pull/3 is good others are not. But please, let's wait investigating Github PR templates before discussing this further Jacques Le 30/01/2020 à 16:35, Pierre Smits a écrit : I inadvertently posted wrong links. See as an example the messages of the

Re: OFBiz contributions & Github Pull Requests

I mean squashing in the sense of pulling several commits together in a single commit (with a quality commit message). This could also be a diff which is applied as a patch manually. I am not just referring to the GitHub function. I really don't want to see all kinds of exotic messages coming

Re: [ofbiz-plugins] branch trunk updated: Implemented: Have a Country Dimension (OFBIZ-10954)

Hi Pawan, all, I really don't see any reason to introduce tables into the codebase which are not used anywhere in the current functionality. I would recommend to wait until there is substantial functioanality which use these table. As Piere stated in some of the *Dimension Jiras: "The

Re: OFBiz contributions & Github Pull Requests

I inadvertently posted wrong links. See as an example the messages of the commit I have in pull request #2 in ofbiz-plugins (https://github.com/apache/ofbiz-plugins/pull/2). This should be: See as an example the messages of the commit I have in pull request #2 in ofbiz-plugins

Re: OFBiz contributions & Github Pull Requests

At 1st glance, based on my experience with squashing I tend to agree Jacques Le 30/01/2020 à 16:04, Pierre Smits a écrit : Having 'quality commit message' should not pose a problem when contributors (authors) apply the template for their commit message. See as an example the messages of the

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.07

+1 ~/Projects/apache-ofbiz/check-release-16.11.07  ../ofbiz-tools/verify-ofbiz-release.sh apache-ofbiz-16.11.07.zip sha check of file: apache-ofbiz-16.11.07.zip Using sha file: apache-ofbiz-16.11.07.zip.sha512 apache-ofbiz-16.11.07.zip: EF6D32A6 7A2C2776 50FBE2B4 47E43D45 BB503EA5 2C84A604

Re: OFBiz contributions & Github Pull Requests

Having 'quality commit message' should not pose a problem when contributors (authors) apply the template for their commit message. See as an example the messages of the commit I have in pull request #2 in ofbiz-plugins (https://github.com/apache/ofbiz-plugins/pull/2). The question is whether a

Re: OFBiz contributions & Github Pull Requests

Just a quick thought because I currently cannot dig deeper: We should also have a workflow (or better: requirement) to either write quality commit messages for every commit or squash changes and have a quality commit message for the resulting commit. If people do a lot of commits during their

Re: In preparation for the 16.11.07 release

Le 30/01/2020 à 14:46, Jacopo Cappellato a écrit : On Thu, Jan 30, 2020 at 1:00 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: [...] OFBIZ-10595: I'm in the middle of something for OFBIZ-11306 (CSRF) so it's hard for me to answer you today. Hopefully tmrw, in any cases before the

Re: OFBiz contributions & Github Pull Requests

Thank you Pierre and Daniel, I have to reviewed things in detail, but the Github PR templates could be a workflow changer Jacques Le 30/01/2020 à 15:12, Pierre Smits a écrit : Thanks Daniel, This could indeed be useful. The project already has a template for the commit message (see

[VOTE] [RELEASE] Apache OFBiz 16.11.07

This is the vote thread to release a new bug fix release for the release16.11 branch. This new release, "Apache OFBiz 16.11.07" will supersede all the previous releases from the same branch. Please consider that this may be the last release in the 16.11 series and in the future releases will be

Re: OFBiz contributions & Github Pull Requests

Thanks Daniel, This could indeed be useful. The project already has a template for the commit message (see https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+commit+message+template), which is currently used by all committers. Working through/via Git (and pull requests via Github) indicates

Re: OFBiz contributions & Github Pull Requests

Hello Pierre, Its not something I've worked with before, but git commit message templates might help here. >From a quick scan of the git documentation it seems that the config.template configuration item can be used to specify a file to use as a template. (

Re: In preparation for the 16.11.07 release

On Thu, Jan 30, 2020 at 1:00 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > [...] > OFBIZ-10595: I'm in the middle of something for OFBIZ-11306 (CSRF) so it's > hard for me to answer you today. Hopefully tmrw, in any cases before the > end of week... > Ok, take your time. In the

Re: OFBiz contributions & Github Pull Requests

FWIW: I have started a related WIP page in confluence, to capture all relating aspects/issues. See https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=145724011 Best regards, Pierre Smits *Apache Trafodion , Vice President* *Apache Directory

OFBiz contributions & Github Pull Requests

Hi All, Recently we saw some postings in various threads how to deal with commits from contributors coming via pull requests in Github. If I understand it correctly, the issue we're dealing with has to do with the commit message (as defined in

contributing osafe plugin

Hi All, I managed to adapt bigfish ecommerce modules to work with Ofbiz 18.12. here is the github repo (the adaptations are explained in the README) https://github.com/tihamania-consulting/another-bigfish I was thinking about contributing these modules to the core ofbiz plugins project - osafe -

Re: In preparation for the 16.11.07 release

Hi Jacopo, OFBIZ-10639: IIRW our cookies never have a duration longer than 12 months. The French law[1] (one of the most restrictive I guess) demands that it should never be longer than 13 months. So yes all is OK with me for R16.11.07. OFBIZ-10595: I'm in the middle of something for

Re: Removing “base/config/component-load.xml”

Hi Mathieu Le 29/01/2020 à 22:26, Mathieu Lirzin a écrit : Hello Jacques, Jacques Le Roux writes: You were the most visible proponents of this. After 5 days w/o exchanges should we consider the idea is abandoned or should we start a vote? Without answers I'll consider the idea abandoned,

Re: contributing osafe plugin

Hi Amine, Your message has been moderated. Please subscribe to the dev ML for such questions and then use your email client. See here http://ofbiz.apache.org/mailing-lists.html. You will get a better support, people can answer you on the ML. The wider the audience the better the answers you

Re: In preparation for the 16.11.07 release

Ooops, I have messed up the order of the two tickets; resending here for clarity: https://issues.apache.org/jira/browse/OFBIZ-10595 @Jacques: is there anything left on this task?

In preparation for the 16.11.07 release

I am in the process of preparing the release files for the 16.11.07 release, possibly the last one in this branch and I would like to clear the Jira ticket that are still open. In particular: https://issues.apache.org/jira/browse/OFBIZ-10639 @Jacques: is there anything left on this task?

contributing osafe plugin

Hi All, I managed to adapt bigfish ecommerce modules to work with Ofbiz 18.12. here is the github repo (the adaptations are explained in the README) https://github.com/tihamania-consulting/another-bigfish I was thinking about contributing the these modules to the core ofbiz plugins project -

Re: OFBiz & Sonarcloud

@Jacques Le Roux What do you suggest? One ticket per repo to capture all enhancements (PRs or patch files)? Or going for master tickets, and per issue address a subtask? Best regards, Pierre Smits *Apache Trafodion , Vice President* *Apache Directory

Re: OFBiz & Sonarcloud

Le 30/01/2020 à 09:17, Pierre Smits a écrit : Hi All, Now that we have Sonarcloud (somewhat) in place, how do you think we should tackle the issues brought forward by that? See: 1. https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=false 2.

OFBiz & Sonarcloud

Hi All, Now that we have Sonarcloud (somewhat) in place, how do you think we should tackle the issues brought forward by that? See: 1. https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=false 2. https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=false Best