Re: [GitHub] [ofbiz-site] PierreSmits commented on issue #1: Improved: widget-theme.xsd typos (OFBIZ-11421)

2020-02-28 Thread Swapnil M Mane
Thank you team for inputs, will sync up with the Infra team to proceed with this. Best regards, Swapnil M Mane, ofbiz.apache.org On Thu, Feb 27, 2020 at 3:14 PM Pierre Smits wrote: > Good advice, Michael. But that don't always happen. > > Met vriendelijke groet, > > Pierre Smits > *Proud*

Re: [jira] [Commented] (OFBIZ-10231) Convert ProductServices.xml mini lang to groovy

2020-02-28 Thread Jacques Le Roux
Le 28/02/2020 à 17:49, ASF subversion and git services (Jira) a écrit : use kelvin syntax Hi Nicolas, Gil, Could you explain why you refer to Kelvin Syntax? TIA Jacques

[GitHub] [ofbiz-site] JacquesLeRoux merged pull request #1: Improved: widget-theme.xsd typos (OFBIZ-11421)

2020-02-28 Thread GitBox
JacquesLeRoux merged pull request #1: Improved: widget-theme.xsd typos (OFBIZ-11421) URL: https://github.com/apache/ofbiz-site/pull/1 This is an automated message from the Apache Git Service. To respond to the message,

Re: Checkstyle error: Files does not end with newline

2020-02-28 Thread Jacques Le Roux
Daniel, This: https://ci.apache.org/projects/ofbiz/logs/ Jacques Le 28/02/2020 à 14:41, Daniel Watford a écrit : Hi Jacques, If I follow the link to the ofbiz builds in Buildbot ( https://ci.apache.org/builders/ofbizTrunkFramework) I can see a list of recent builds. How do I navigate from

Re: Solr/Lucene

2020-02-28 Thread Rishi Solanki
Jacques/Pierre, Thanks for your response and information. My point is if indexing is not in use on any page, and solr does the same using Lucene. I google it Solr vs Lucene, and most of the articles in favor of Solr. So just thought to put this in front of community if ignored or postpone decision

Re: Solr/Lucene

2020-02-28 Thread Pierre Smits
IMO, indexing (lucent/solr style) should be a lower level service given the dependencies in content and product. But maybe it already is? Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz since 2008 (without privileges) *Apache Trafodion

Re: Checkstyle error: Files does not end with newline

2020-02-28 Thread Daniel Watford
Hi Jacques, If I follow the link to the ofbiz builds in Buildbot ( https://ci.apache.org/builders/ofbizTrunkFramework) I can see a list of recent builds. How do I navigate from the list of recent builds to view the test reports - e.g. view build/reports/checkstyle/test.html for

Re: Checkstyle error: Files does not end with newline

2020-02-28 Thread Jacques Le Roux
Thanks Daniel, It works in Buildbot, so it's OK with me ;) https://ci.apache.org/builders/ofbizTrunkFramework Cheers Jacques Le 28/02/2020 à 11:24, Daniel Watford a écrit : Hi Jacques, I haven't been able to come up with an explanation for what you're seeing, so through I'd post some of my

Re: Solr/Lucene

2020-02-28 Thread Pierre Smits
Rich, Jacques, Thanks for bringing this to the attention of the community. I guess the reason is that in past discussions no agreement could be established on what to do with it. Some fear it is lost forever when removed. re:If memory serves, Lucene is still used while indexing products and

Re: Solr/Lucene

2020-02-28 Thread Jacques Le Roux
Hi Rishi, If memory serves, Lucene is still used while indexing products and content. Jacques Le 28/02/2020 à 12:37, Rishi Solanki a écrit : Dear All, I was checking all plugins developed with OFBiz. I see both Solr and Lucene are there, may I know why we are keeping Lucene within plugins.

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-28 Thread Aditya Sharma
+1 Thanks and regards, Aditya Sharma On Fri, Feb 28, 2020 at 3:17 PM Michael Brohl wrote: > There is no impersonation functionality in 17.12. The findings are > either documentation or "constants" which do not affect the functionality. > > For 17.12.02 we should remove the documentation

Solr/Lucene

2020-02-28 Thread Rishi Solanki
Dear All, I was checking all plugins developed with OFBiz. I see both Solr and Lucene are there, may I know why we are keeping Lucene within plugins. As a framework we already have the Solr which resolves many functional aspects on the top of Lucene library. Do we have any good reason to keep

Re: Checkstyle error: Files does not end with newline

2020-02-28 Thread Daniel Watford
Issue https://issues.apache.org/jira/browse/OFBIZ-11428 raised and PR https://github.com/apache/ofbiz-framework/pull/36 created On Fri, 28 Feb 2020 at 10:24, Daniel Watford wrote: > Hi Jacques, > > I haven't been able to come up with an explanation for what you're seeing, > so through I'd

Re: Checkstyle error: Files does not end with newline

2020-02-28 Thread Daniel Watford
Hi Jacques, I haven't been able to come up with an explanation for what you're seeing, so through I'd post some of my configuration and results to see if we can spot anything odd. Building on a Windows 10 host. Executing builds from Git Bash running in Windows terminal: $ git log -1 commit

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-28 Thread Michael Brohl
There is no impersonation functionality in 17.12. The findings are either documentation or "constants" which do not affect the functionality. For 17.12.02 we should remove the documentation artefacts for the impersonation feature, but IMO this is no showstopper for the 17.12.01 release.

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-28 Thread Taher Alkhateeb
+1 On Fri, Feb 28, 2020, 12:37 PM Gil Portenseigne wrote: > +1 > > On Thu, Feb 27, 2020 at 06:09:34PM +0100, Michael Brohl wrote: > > +1 > > > > ~/Projects/apache-ofbiz/dist-apache-ofbiz-17.12.01  > > ../ofbiz-tools/verify-ofbiz-release.sh apache-ofbiz-17.12.01.zip > > sha check of file:

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-28 Thread Gil Portenseigne
+1 On Thu, Feb 27, 2020 at 06:09:34PM +0100, Michael Brohl wrote: > +1 > > ~/Projects/apache-ofbiz/dist-apache-ofbiz-17.12.01  > ../ofbiz-tools/verify-ofbiz-release.sh apache-ofbiz-17.12.01.zip > sha check of file: apache-ofbiz-17.12.01.zip > Using sha file: apache-ofbiz-17.12.01.zip.sha512 >

Re: Checkstyle error: Files does not end with newline

2020-02-28 Thread Jacques Le Roux
Le 28/02/2020 à 10:22, Jacques Le Roux a écrit : Le 28/02/2020 à 10:07, Daniel Watford a écrit : Hello, In my dev environment (Windows 10, IntelliJ, Git checking out with LF line endings) I see 39 checkstyle errors for our tests related to java files not ending with a newline. However on

Re: Checkstyle error: Files does not end with newline

2020-02-28 Thread Jacques Le Roux
Le 28/02/2020 à 10:07, Daniel Watford a écrit : Hello, In my dev environment (Windows 10, IntelliJ, Git checking out with LF line endings) I see 39 checkstyle errors for our tests related to java files not ending with a newline. However on inspecting one of the files, ModelFormFieldTest, I can

Checkstyle error: Files does not end with newline

2020-02-28 Thread Daniel Watford
Hello, In my dev environment (Windows 10, IntelliJ, Git checking out with LF line endings) I see 39 checkstyle errors for our tests related to java files not ending with a newline. However on inspecting one of the files, ModelFormFieldTest, I can see that it does end with a newline. A quick

Re: Backport in R18: OFBIZ-11415 & OFBIZ-11418

2020-02-28 Thread Jacques Le Roux
Le 28/02/2020 à 09:32, Pierre Smits a écrit : I advice you to not forget to put the xsd change(s) in the correct source. Hi Pierre, Thanks for your advice, actually I include that in the documentation, so no I'll not forget :p Jacques

Re: Backport in R18: OFBIZ-11415 & OFBIZ-11418

2020-02-28 Thread Pierre Smits
Hi Jacques, As you're taking the lead to work the underlying issue, I advice you to not forget to put the xsd change(s) in the correct source. Mg Pierre Op vr 28 feb. 2020 09:24 schreef Jacques Le Roux < jacques.le.r...@les7arts.com>: > Hi, > > Daniel (Watford) has asked to exceptionally

Backport in R18: OFBIZ-11415 & OFBIZ-11418

2020-02-28 Thread Jacques Le Roux
Hi, Daniel (Watford) has asked to exceptionally backport the new FlexibleStringExpander feature used in target-parameter and parameter-name of form widget to R18 branch. I'll do so (with tests and documentation) in a week if nobody is against Please share your thoughts if needed Thanks

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-28 Thread Pierre Smits
I found 3 artefacts relating to the impersonation aspects. - CommonEvents.java - security.adoc - sy-impersonation.adoc Met vriendelijke groet, Pierre Smits *Proud* *contributor** of* Apache OFBiz since 2008 (without privileges) *Apache Trafodion

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-28 Thread Nicolas Malin
+1 All work from my part Nicolas On 27/02/2020 10:49, Jacopo Cappellato wrote: > This is the vote thread (3nd attempt) to release "Apache OFBiz 17.12.01": > this is the first release, containing the framework, applications and all > the plugins from the 17.12 release branches. > > The release

Re: Impersonation feature, was: Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-28 Thread Gil Portenseigne
You understand correctly, and moreover a specific permission must be granted to allow the user to impersonate another one. And we even added another security to not allow impersonating a user with more permission than ourselves. When we contributed the feature, it was discussed, and improved

Impersonation feature, was: Re: [VOTE] [RELEASE] Apache OFBiz 17.12.01 (full version), vote #3

2020-02-28 Thread Michael Brohl
*creating a new thread to leave the vote thread untouched* In my understanding from the previous threads about the impersonation features, it is disabled by default and must be enabled explicitly. Using this feature and dealing with the consequences is up to the user then. So I see no valid