Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-03 Thread Nicolas Malin
Thanks for your return. Finally we have no big issue to release it now on the jira, I did it to didn't forget and realize it in three months :) Nicolas On 03/01/2022 11:40, Jacopo Cappellato wrote: > Thank you Nicolas! > (BTW it is fine to mark as released in Jira the version 18.12.05 since it

Re: [apache/ofbiz-framework] Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498) (PR #355)

2022-01-03 Thread Pierre Smits
Whahaha. "It is not about the PR content". "It works as intended". "Let's not implement it", because of potential future developments (sans commitment). There is no 'hurrying' here to get OFBiz improved. That might have been so, when an approach/discussion preceding the solution in the PR hadn't

Re: [apache/ofbiz-framework] Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498) (PR #355)

2022-01-03 Thread Michael Brohl
You missed the point of the cited comment on GitHub. It is not about the PR contents but about a follow-up enhancement for centralized configuration. The contributors of the PR themselves (Gil/Marco) want to improve the PR. I see no reason why you are pushing them to merge a PR they want to

Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-03 Thread Jacopo Cappellato
Thank you Nicolas! (BTW it is fine to mark as released in Jira the version 18.12.05 since it is now official... however we have to wait some time before we announce and update our download page because we need some time to make sure all mirrors around the World have received the release files).

Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-03 Thread Nicolas Malin
On 03/01/2022 10:31, Nicolas Malin wrote: > Jacopo, I can publish to 18.12.05 on jira and open the 18.12.06 if it's > ok for you I opened the 18.12.06 and I wait your official announce to release the 18.12.05 (and update the date) Cheers, Nicolas

Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-03 Thread Nicolas Malin
On 03/01/2022 09:52, Nicolas Malin wrote: > I detected with log test, that the screen xml handler is down. > On https://localhost:8443/webtools/control/WebtoolsLayoutDemoXml : > *** >freemarker.core._MiscTemplateException: Macro "renderContainerEnd" has no > parameter with name "type" >

Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-03 Thread Nicolas Malin
+1 --- Keys Ok Test Ok Under OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.292-b10, mixed mode),  Debian 11.1 I detected with log test, that the screen xml handler is down. On https://localhost:8443/webtools/control/WebtoolsLayoutDemoXml : *** freemarker.core._MiscTemplateException:

[VOTE] [RESULT] Apache OFBiz 18.12.05 (second attempt)

2022-01-03 Thread Jacopo Cappellato
Thank you, the vote is successful (3 binding votes). I am going to publish the release, wait 24 hours to let the release files propagate through the download mirror network and finally announce the release and update our site. Jacopo On Sun, Jan 2, 2022 at 12:29 PM Jacopo Cappellato <

Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-03 Thread Gil Portenseigne
+1, Verifying files... sha check of file: apache-ofbiz-18.12.05.zip Using sha file: apache-ofbiz-18.12.05.zip.sha512 apache-ofbiz-18.12.05.zip: F7952ED5 C794357F E730C7DE 404B0B8B 7A123A89 9DA7A1C1 4D0136ED 64D6FAA3 7645018E 9EDE93FB 88FC27A3 D718DA64 E8636541 334583ED 606F5516 6D653B2C

Re: [VOTE] [RELEASE] Apache OFBiz 18.12.05 (second attempt)

2022-01-03 Thread Jacopo Cappellato
+1 Jacopo On Sun, Jan 2, 2022 at 12:29 PM Jacopo Cappellato < jacopo.cappell...@gmail.com> wrote: > This is the second vote thread to release a new bug fix release for the > release18.12 branch. This new release, "Apache OFBiz 18.12.05" > supersedes all the previous releases from the same

Re: [apache/ofbiz-framework] Implemented: getEnvironmentProperty to allow environment variable configuration (OFBIZ-9498) (PR #355)

2022-01-03 Thread Pierre Smits
Hi All, To start with: I wish a healthy and prosperous 2022 to all participating in this thread. This works now! It has been brought forward as working as intended and does not disrupt OFBiz functionality. While it is good to see that this PR triggers others to think about it and suggest