Re: svn commit: r1327411 - in /ofbiz/trunk: bin/ tools/functions.sh tools/git-rebase-runner.sh

2012-04-18 Thread Adam Heath
On 04/18/2012 02:57 AM, jaco...@apache.org wrote: > Author: jacopoc > Date: Wed Apr 18 07:57:46 2012 > New Revision: 1327411 > > URL: http://svn.apache.org/viewvc?rev=1327411&view=rev > Log: > Removed bin folder and moved its content to the tools folder: this was > discussed extensively in the de

Re: svn commit: r1327411 - in /ofbiz/trunk: bin/ tools/functions.sh tools/git-rebase-runner.sh

2012-04-18 Thread Adam Heath
On 04/18/2012 10:55 AM, Erwan de FERRIERES wrote: > Le 18/04/2012 17:21, Adam Heath a écrit : >> On 04/18/2012 02:57 AM, jaco...@apache.org wrote: >>> Author: jacopoc >>> Date: Wed Apr 18 07:57:46 2012 >>> New Revision: 1327411 >>> >>> URL: htt

Re: svn commit: r1327411 - in /ofbiz/trunk: bin/ tools/functions.sh tools/git-rebase-runner.sh

2012-04-18 Thread Adam Heath
On 04/18/2012 11:56 AM, Adrian Crum wrote: > On 4/18/2012 5:43 PM, Adam Heath wrote: >> On 04/18/2012 10:55 AM, Erwan de FERRIERES wrote: >>> Le 18/04/2012 17:21, Adam Heath a écrit : >>>> On 04/18/2012 02:57 AM, jaco...@apache.org wrote: >>>>> Author:

Re: svn commit: r1327411 - in /ofbiz/trunk: bin/ tools/functions.sh tools/git-rebase-runner.sh

2012-04-18 Thread Adam Heath
On 04/18/2012 12:20 PM, Adam Heath wrote: > Things have changed in ofbiz, so that now it takes a *huge* amount of > time. Some of that is related to a larger amount of code overflowing > the cpu's L2 cache. Some of that is related to catalina startup, when > it tries to

Re: svn commit: r1327411 - in /ofbiz/trunk: bin/ tools/functions.sh tools/git-rebase-runner.sh

2012-04-18 Thread Adam Heath
On 04/18/2012 12:28 PM, Jacopo Cappellato wrote: > On Apr 18, 2012, at 7:20 PM, Adam Heath wrote: > >> ps: I am going to switch in ant *back* to javascript, *away* from >> ant-contrib. The latter is significantly slower when using a system >> installed ant. > > N

Re: svn commit: r1327411 - in /ofbiz/trunk: bin/ tools/functions.sh tools/git-rebase-runner.sh

2012-04-18 Thread Adam Heath
On 04/18/2012 12:46 PM, Jacques Le Roux wrote: > From: "Adam Heath" >> On 04/18/2012 12:28 PM, Jacopo Cappellato wrote: >>> On Apr 18, 2012, at 7:20 PM, Adam Heath wrote: >>> >>>> ps: I am going to switch in ant *back* to javascript,

jackrabbit test cases failing?

2012-04-18 Thread Adam Heath
See attached file. java.lang.ClassCastException: The content object for the path: /news/article/en is not an article content object. This Helper can only handle content obje

Re: SagePay Gateway: needs PCI with tokenization

2012-04-18 Thread Adam Heath
On 04/18/2012 03:28 PM, Brajesh Patel wrote: > Hello All, > > I am looking into Sagepay related stuff: > > Currently we have Sagepay payment gateway integration in OOTB, > > We have requirement for PCI with tokenization in sage pay. > I am thinking that we need to add 'SagepayPaymentMethod' enti

Re: svn commit: r1327735 - in /ofbiz/trunk/framework/entity/src/org/ofbiz/entity: jdbc/SqlJdbcUtil.java model/ModelViewEntity.java

2012-04-19 Thread Adam Heath
On 04/18/2012 09:14 PM, Scott Gray wrote: > Nice, I ran into a problem related to this very recently. Thanks for taking > care of it. This now works. > > Regards > Scott > > On 19/04/2012, at 11:48 AM, doo...@apache.org wrote: > >> Author: doogie >> Date: W

Re: svn commit: r1327411 - in /ofbiz/trunk: bin/ tools/functions.sh tools/git-rebase-runner.sh

2012-04-19 Thread Adam Heath
On 04/18/2012 11:33 PM, Jacopo Cappellato wrote: > > On Apr 18, 2012, at 7:37 PM, Adam Heath wrote: > >> On 04/18/2012 12:28 PM, Jacopo Cappellato wrote: >>> On Apr 18, 2012, at 7:20 PM, Adam Heath wrote: >>> >>>> ps: I am going to switch in a

Re: svn commit: r1327835 - in /ofbiz/trunk/framework: jcr/src/org/ofbiz/jcr/test/JackrabbitTests.java widget/src/org/ofbiz/widget/WidgetWorker.java

2012-04-19 Thread Adam Heath
On 04/19/2012 12:58 AM, sascharodek...@apache.org wrote: > Author: sascharodekamp > Date: Thu Apr 19 05:58:29 2012 > New Revision: 1327835 > > URL: http://svn.apache.org/viewvc?rev=1327835&view=rev > Log: > Fix jackrabbit unit testing. > > Modified: > ofbiz/trunk/framework/jcr/src/org/ofbiz/j

Re: HashCrypt is deprecated: is this an issue?

2012-04-19 Thread Adam Heath
On 04/19/2012 02:06 AM, Pierre Smits wrote: > When building the trunk I get (amonst others) following notifications: > > classes: > [javac16] Compiling 140 source files to > /ci/ofbiz/framework/entity/build/classes > [javac16] > /ci/ofbiz/framework/entity/src/org/ofbiz/entity/GenericEntity.ja

Re: svn commit: r1327411 - in /ofbiz/trunk: bin/ tools/functions.sh tools/git-rebase-runner.sh

2012-04-19 Thread Adam Heath
with the SSDs when running run-tests my CPU is always at 100% (I >> put the run-tests process priority level to idle to be able to continue >> other tasks) >> Do you have a SSD in your laptop Jacopo? >> >> Jacques >> >> From: "Jacopo Cappellato&quo

recent HashCrypt changes, and using salt-based password hashing

2012-04-19 Thread Adam Heath
As some may have noticed, I recently changed the way ofbiz creates password hashes when it stores them in the database. Each time a new password is created, a bit of randomness is used, to create a random-length, random-content salt. This is placed at the beginning of the hashed password, stored

upcoming Delegator deprecations

2012-04-19 Thread Adam Heath
commit 6493e4845f2acab9ce3e1f92cdc7f5b62bb79a2f Author: Adam Heath Date: Sun Dec 5 18:32:01 2010 -0600 Deprecate GenericValue.getRelatedDummyPK(String). Still more api simplification. Fortunately, this is a very small change. It seems that this method is hardly used by anything

openid support

2012-04-19 Thread Adam Heath
I have a series of patches that enable ofbiz to be used as an openid *provider*. I used this to allow a wordpress site to delegate authentication to ofbiz(the company in question already had an ofbiz deployment hooked into their internal ldap, with phone/name synching; didn't want to duplicate all

Re: svn commit: r1327866 - in /ofbiz/trunk: applications/accounting/data/ applications/content/data/ applications/humanres/data/ applications/marketing/data/ applications/order/data/ framework/example

2012-04-19 Thread Adam Heath
On 04/19/2012 03:43 AM, jaco...@apache.org wrote: > Author: jacopoc > Date: Thu Apr 19 08:43:54 2012 > New Revision: 1327866 > > URL: http://svn.apache.org/viewvc?rev=1327866&view=rev > Log: > Reverted rev. 1327736: with it it was impossible to log in with demo accounts. Ok, then the test cases s

Re: openid support

2012-04-19 Thread Adam Heath
On 04/19/2012 04:28 PM, Jacques Le Roux wrote: > Hi Adam, > > The recent trend is to "slim down" OFBiz. This could be one of the > Apache OFBiz Extras > > If someone needs it it pick up from there, et voilà There are multiple layers. framework/openid, which has the basic logic, but not any of t

Re: recent HashCrypt changes, and using salt-based password hashing

2012-04-19 Thread Adam Heath
of changes I currently have are rather straight forward, just moving code around. When I finally get around to adding the new features, then there is a very definate chance of breaking stuff. > > Jacques > > From: "Adam Heath" >> As some may have noticed, I recen

Re: Opinions wanted on r1307895

2012-04-19 Thread Adam Heath
On 04/19/2012 04:41 PM, Jacques Le Roux wrote: > Committed at revision: 1328122 > Jacques This change would be needed for anything dealing with PAN(credit-card number for those not into the lingo). > From: "Jacques Le Roux" >> Nope, I'd not have raised a warning else ;o) >> The user must read i

Re: recent HashCrypt changes, and using salt-based password hashing

2012-04-19 Thread Adam Heath
On 04/19/2012 04:49 PM, Adam Heath wrote: > On 04/19/2012 04:28 PM, Jacques Le Roux wrote: >> Looking forward for >> https://issues.apache.org/jira/browse/OFBIZ-1151 >> https://issues.apache.org/jira/browse/OFBIZ-2729 >> https://issues.apache.org/jira/browse/OFBIZ-3006

Re: openid support

2012-04-19 Thread Adam Heath
On 04/19/2012 04:55 PM, Brett Palmer wrote: > Adam, > > There was a previous thread on the subject of implementing other > "authentication and security" models to support OpenId, LDAP, and > other custom authentication needs. The subject of the thread was > "Alternatives to using UserLoginId as a

Re: recent HashCrypt changes, and using salt-based password hashing

2012-04-19 Thread Adam Heath
On 04/19/2012 06:13 PM, Scott Gray wrote: > > On 20/04/2012, at 9:49 AM, Adam Heath wrote: > >> On 04/19/2012 04:28 PM, Jacques Le Roux wrote: >>> Looking forward for >>> https://issues.apache.org/jira/browse/OFBIZ-1151 >>> https://issues.a

Re: openid support

2012-04-19 Thread Adam Heath
On 04/19/2012 10:39 PM, Sam Hamilton wrote: Hey Guys, We are soon going to need OAuth support to allow external users to log into OFBiz Ecommerce site, which I believe is similar in design to openid. Just wondering if you considered using Apache Shiro http://shiro.apache.org/ to help manage the

Re: recent HashCrypt changes, and using salt-based password hashing

2012-04-20 Thread Adam Heath
On 04/20/2012 12:53 AM, Pierre Smits wrote: Hi Adam, How would that be? That would be one per tenant in a multi-tenant setup? I can imagine in a multi-tenant setup with the db backend not on derby (as we all recommend) the upgrade/migration aspect can be enormous. Even more so in a HAFO-setup.

Re: openid support

2012-04-20 Thread Adam Heath
On 04/20/2012 01:32 AM, Jacques Le Roux wrote: Hi Sam, What proposes Adam is not exactly related. He proposes to introduce a way for OFBiz to be an OpenId server.. And yes we already discussed about using Shiro in OFBiz. But we also agreed recently to focus our efforts on the "slim down" action..

Re: recent HashCrypt changes, and using salt-based password hashing

2012-04-20 Thread Adam Heath
On 04/20/2012 09:56 AM, Pierre Smits wrote: > Hi Adam, > > I can follow your reasoning. And it seems reasonable. But I would like to > suggest to you to create a JIRA for this where patches are uploaded and can > be tested in a separate ofbiz instantiation. This would then help with the > creation

Re: SagePay Gateway: needs PCI with tokenization

2012-04-20 Thread Adam Heath
On 04/20/2012 11:54 AM, Brajesh Patel wrote: > Thanks Adam for your valuable comment, > > I found token related information for the sagepay from > http://www.sagepay.com/token-system site as follows: > > > Token System is a safe way of keeping card details without actually storing > them. We sto

Re: recent HashCrypt changes, and using salt-based password hashing

2012-04-20 Thread Adam Heath
On 04/20/2012 12:13 PM, Jacques Le Roux wrote: > Not sure you noticed but Builbot is no longer running > http://ci.apache.org/waterfall?show_events=false&branch=&builder=ofbiz-trunk&reload=none Yeah, noticed that buildbot wasn't emailing. Looking at that link, it appears that isis_ubuntu is offli

Re: svn commit: r1328517 - /ofbiz/branches/release10.04/framework/base/config/test-containers.xml

2012-04-20 Thread Adam Heath
On 04/20/2012 04:33 PM, er...@apache.org wrote: > Author: erwan > Date: Fri Apr 20 21:33:02 2012 > New Revision: 1328517 > > URL: http://svn.apache.org/viewvc?rev=1328517&view=rev > Log: > OFBIZ-4828 R10.04 testports in use when testing in CI (Jenkins) Um, no, don't do this. > > Modified: >

Re: svn commit: r1328517 - /ofbiz/branches/release10.04/framework/base/config/test-containers.xml

2012-04-20 Thread Adam Heath
On 04/20/2012 05:47 PM, Jacques Le Roux wrote: > From: "Adam Heath" >> On 04/20/2012 04:33 PM, er...@apache.org wrote: >>> Author: erwan >>> Date: Fri Apr 20 21:33:02 2012 >>> New Revision: 1328517 >>> >>> URL: http://svn.apach

Re: recent HashCrypt changes, and using salt-based password hashing

2012-04-26 Thread Adam Heath
On 04/22/2012 03:53 AM, Adrian Crum wrote: > On 4/20/2012 9:00 PM, Adam Heath wrote: >> On 04/20/2012 12:13 PM, Jacques Le Roux wrote: >>> Not sure you noticed but Builbot is no longer running >>> http://ci.apache.org/waterfall?show_events=false&branch=&builder=

Re: recent HashCrypt changes, and using salt-based password hashing

2012-04-26 Thread Adam Heath
On 04/23/2012 08:40 AM, Jacopo Cappellato wrote: > Adrian, > > the issue you are experiencing is interesting and I had a look at it; I was > only able to recreate the same failures by changing the timeouts in > UtilCacheTests.java at line 302 and 308; instead of: > > cache.setExpireTime(100); /

Re: framework/base tests failing

2012-04-26 Thread Adam Heath
On 04/24/2012 03:06 AM, Jacopo Cappellato wrote: > This is really weird... I am wondering if there are issues caused by > concurrent threads accessing the cache but the JUnit tests should be all > executed in the same thread... so this should not be the case. The tests run in the foreground, yes

Re: recent HashCrypt changes, and using salt-based password hashing

2012-04-26 Thread Adam Heath
On 04/24/2012 07:49 AM, Paul Foxworthy wrote: > Hi Adam, > > Maybe I'm missing something, but if the salt is a random length and might be > 0 characters, doesn't that mean that some passwords, randomly, won't get the > benefit of a salt? Why not make the salt a fixed length, or a random length > w

kek(key-encrypting-key), PCI compliance

2012-05-02 Thread Adam Heath
I came in like a storm, but then got quiet for a short while. I'm back to announce that I just had a successful first-run load-demo, with key-encrypting-key working. I've got 28(or so) changes upto today. Splitting this last little bit will add another 10(I got sidetracked on making GenericDeleg

Re: framework/base tests failing

2012-05-02 Thread Adam Heath
[trying to stop this thread a bit] If the root cause *is* a time-slice issue, the fix is to *not* increase the timeout. Dead stop. Changing the timeout will just cause it to again fail at some point in the future when computers get faster yet again. The correct fix is to make the timeout *not m

Re: kek(key-encrypting-key), PCI compliance

2012-05-02 Thread Adam Heath
On 05/02/2012 04:48 PM, Jacques Le Roux wrote: > This is really great news Adam, thanks for the effort! I still have a ton of testing to do; I need to clone some oldish-type ofbiz installs that have credit cards, apply my patch(s), then see what happens. > How did you finally handle the length of

Re: entitymodel - entity-condition inside view-link - seems to work in trunk, any plans to fix it in 11.04?

2012-05-02 Thread Adam Heath
On 04/27/2012 02:50 AM, Jacques Le Roux wrote: > Reverted, it did not compile, thanks to Amit Sharma who called me Sometimes it's not possible to backport a fix for a file bug; there can be lots of other dependant patches that are required, that are too unstable(or just not wanted) for a released

Re: framework/base tests failing

2012-05-02 Thread Adam Heath
On 05/02/2012 05:26 PM, Jacopo Cappellato wrote: > > On May 2, 2012, at 11:32 PM, Adam Heath wrote: > >> If the root cause *is* a time-slice issue, the fix is to *not* >> increase the timeout. Dead stop. Changing the timeout will just >> cause it to again fail at so

Re: entitymodel - entity-condition inside view-link - seems to work in trunk, any plans to fix it in 11.04?

2012-05-03 Thread Adam Heath
On 05/03/2012 12:56 AM, Jacques Le Roux wrote: > From: "Adam Heath" >> On 04/27/2012 02:50 AM, Jacques Le Roux wrote: >>> Reverted, it did not compile, thanks to Amit Sharma who called me >> >> Sometimes it's not possible to backport a fix for a file

Re: framework/base tests failing

2012-05-03 Thread Adam Heath
On 05/03/2012 04:44 AM, Adrian Crum wrote: > I agree that it is a workaround and not a solution. The problem is, > the tests fail 100% of the time on my development machine, and they > fail intermittently on the ASF CI machine and our (1Tech) CI machine. > So, the workaround is needed to get variou

Re: DISCUSS: deprecating a TON of Delegator/GenericDelegator calls(huge)

2012-05-03 Thread Adam Heath
On 05/03/2012 10:44 AM, Jacopo Cappellato wrote: > Hi Adam, > > On May 3, 2012, at 5:20 PM, Adam Heath wrote: > >> So, I'm asking if I can commit these to both trunk >> and 12.04. If not, we'd have to wait even longer to fully remove >> these methods(at l

(backporting kek) Re: svn commit: r1333619 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/crypto/Main.java

2012-05-04 Thread Adam Heath
On 05/04/2012 12:11 AM, Jacopo Cappellato wrote: > Hi Adam, > > are you going to backport this (and other relevant commits) to the 12.04 > branch as well? I plan to, yes, but I'm going to finish up the kek(key-encrypting-key) support first. I've got the code done, just need to do more testing.

Re: buildbot success in ASF Buildbot on ofbiz-trunk

2012-05-04 Thread Adam Heath
On 05/04/2012 11:21 AM, build...@apache.org wrote: > The Buildbot has detected a restored build on builder ofbiz-trunk while > building ASF Buildbot. > Full details are available at: > http://ci.apache.org/builders/ofbiz-trunk/builds/2732 Are all these messages still just testing the new system?

Re: buildbot failure in ASF Buildbot on ofbiz-trunk

2012-05-04 Thread Adam Heath
On 05/04/2012 01:44 PM, build...@apache.org wrote: > The Buildbot has detected a new failure on builder ofbiz-trunk while building > ASF Buildbot. > Full details are available at: > http://ci.apache.org/builders/ofbiz-trunk/builds/2737 > > Buildbot URL: http://ci.apache.org/ > > Buildslave for

Re: buildbot failure in ASF Buildbot on ofbiz-trunk

2012-05-05 Thread Adam Heath
Well, why can't the queue be purged? -- Sent from my Android phone with K-9 Mail. Please excuse my brevity. Scott Gray wrote: You'll probably find that it's just playing catch up and will get to the head soon enough. Regards Scott On 6/05/2012, at 1:22 AM, Adrian Crum wrote: > The revision

Re: tenant problem in framework can somebody (Adam) help?

2012-05-07 Thread Adam Heath
I'll fix it when I get to work. ps: there are really no test cases for tenants? -- Sent from my Android phone with K-9 Mail. Please excuse my brevity. Hans Bakker wrote: In the framework found the following problem: in GenericDelegator.java, line 226: GenericValue kekValue = baseDelegator.fin

Re: tenant problem in framework can somebody (Adam) help?

2012-05-07 Thread Adam Heath
On 05/07/2012 09:18 AM, Adam Heath wrote: > I'll fix it when I get to work. > > ps: there are really no test cases for tenants? ps: I have a plan for testing the tenant code. Do not start it by just 'cloning' the existing entitymodels for the tenant. That will take

Re: tenant problem in framework can somebody (Adam) help?

2012-05-07 Thread Adam Heath
On 05/07/2012 02:46 PM, Pierre Smits wrote: > Adam, > > Pleaase elaborate on what the unit test(s) should achieve? Creating new > tenants and loading the tenant instantiation with demo data? Or? All of the above, anything, something. There are no automated test cases *at all* for tenant anything

Re: tenant problem in framework can somebody (Adam) help?

2012-05-07 Thread Adam Heath
On 05/07/2012 03:40 PM, Pierre Smits wrote: > Given that the tenants use the same codebase and only use a different > delegator than main, you could say that performing unit tests as in a > tenant delegator should get you the same results as doing them in the main > delegator. > > But, then there

Re: svn commit: r1335268 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityCrypto.java

2012-05-07 Thread Adam Heath
On 05/07/2012 04:27 PM, doo...@apache.org wrote: > Author: doogie > Date: Mon May 7 21:27:32 2012 > New Revision: 1335268 > > URL: http://svn.apache.org/viewvc?rev=1335268&view=rev > Log: > FEATURE: Key-encrypting-key(kek) support is now enabled. To enable > support for this, run: > > java org.

old ofbiz versions

2012-05-08 Thread Adam Heath
I use git(-svn) to do my ofbiz work(as many here probably know). Currently, the svn is hosted on apache.org servers. When it was imported, the history was started fresh. This was done back in July, 2006. However, that wasn't good enough for me. I dug around and found references to the previous

Re: old ofbiz versions

2012-05-09 Thread Adam Heath
On 05/08/2012 11:18 PM, Jacopo Cappellato wrote: > Hi Adam, > > I don't know if it is useful but for some time in its history (but I don't > remember the years) the OFBiz project was hosted at dev.java.net,maybe the > url was: > > https://ofbiz.dev.java.net/ dev.java.net doesn't exist either.

Re: OFBiz's first commit

2012-05-09 Thread Adam Heath
On 01/27/2011 02:11 PM, David E Jones wrote: > > The project was created on SourceForge.net on 13 May > 2001. I don't know when the first commit was. > > The first preview release (still available on > SourceForge) was "ofbiz-2001.05.24.zip" which, as the > name implies, was released on 24 May 20

Re: OFBiz's first commit

2012-05-09 Thread Adam Heath
On 05/09/2012 06:43 PM, Adam Heath wrote: > On 01/27/2011 02:11 PM, David E Jones wrote: >> >> The project was created on SourceForge.net on 13 May >> 2001. I don't know when the first commit was. >> >> The first preview release (still available on >> S

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-10 Thread Adam Heath
On 05/10/2012 11:05 AM, doo...@apache.org wrote: > Author: doogie > Date: Thu May 10 16:05:00 2012 > New Revision: 1336768 > > URL: http://svn.apache.org/viewvc?rev=1336768&view=rev > Log: > FIX: s/run-install/load-demo/ I'm surprised I actually had to do this. It implies that the scripts are no

Re: svn commit: r1336772 - in /ofbiz/trunk/tools: mergefromtrunk.bat mergefromtrunk.sh

2012-05-10 Thread Adam Heath
On 05/10/2012 11:13 AM, doo...@apache.org wrote: > Author: doogie > Date: Thu May 10 16:13:23 2012 > New Revision: 1336772 > > URL: http://svn.apache.org/viewvc?rev=1336772&view=rev > Log: > FEATURE/OPTIMIZE: Copied these from the release12.04 branch(using svn copy). > Having to manually add the

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-10 Thread Adam Heath
On 05/10/2012 11:16 AM, Adrian Crum wrote: > The scripts are helpful if you have a Subversion client that runs from > the command line. Some of us use a graphical Subversion client - like > Tortoise, or the Eclipse plugin. Which brings up another thought I had. Maybe converting these to a series

backports(to 12.04) of my recent commits

2012-05-10 Thread Adam Heath
I've added 2 major(ish) new features recently. * salt-based password hashing(with base64 encoding) * key-encrypting-key(kek) support. The salt-based psasword feature was written when JIRA was hacked several years ago; JIRA is based on an old version of OfBiz, so this change could be considered a

Re: OFBiz multi-threading

2012-05-10 Thread Adam Heath
On 05/10/2012 06:40 PM, Adrian Crum wrote: > I wanted to discuss this again. > > Some time ago I modified my local copy of OFBiz to execute the the ant > run-install task faster by using multi-threaded entity creation and > data loading. I don't remember what i was working on at the time, but > I

Re: OFBiz multi-threading

2012-05-10 Thread Adam Heath
On 05/10/2012 06:58 PM, Adrian Crum wrote: On 5/11/2012 12:45 AM, Adam Heath wrote: On 05/10/2012 06:40 PM, Adrian Crum wrote: I wanted to discuss this again. Some time ago I modified my local copy of OFBiz to execute the the ant run-install task faster by using multi-threaded entity creation

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-10 Thread Adam Heath
On 04/20/2012 07:53 AM, jaco...@apache.org wrote: Author: jacopoc Date: Fri Apr 20 12:53:35 2012 New Revision: 1328356 URL: http://svn.apache.org/viewvc?rev=1328356&view=rev Log: The cache of parsed Groovy scripts was not thread safe; this issue, in instances with several concurrent threads run

Re: svn commit: r1337024 - in /ofbiz/trunk: applications/accounting/src/org/ofbiz/accounting/thirdparty/clearcommerce/ framework/base/src/org/ofbiz/base/util/ framework/webapp/src/org/ofbiz/webapp/eve

2012-05-10 Thread Adam Heath
On 05/10/2012 11:46 PM, ash...@apache.org wrote: Author: ashish Date: Fri May 11 04:46:26 2012 New Revision: 1337024 URL: http://svn.apache.org/viewvc?rev=1337024&view=rev Log: Applied similar fix as we did on trunk r1300463. On production systems you can't suppress Debug.log( message by the use

Re: svn commit: r1337026 - in /ofbiz/branches/release11.04: applications/accounting/src/org/ofbiz/accounting/thirdparty/clearcommerce/ framework/webapp/src/org/ofbiz/webapp/event/ specialpurpose/shark

2012-05-10 Thread Adam Heath
On 05/10/2012 11:51 PM, ash...@apache.org wrote: Author: ashish Date: Fri May 11 04:51:55 2012 New Revision: 1337026 URL: http://svn.apache.org/viewvc?rev=1337026&view=rev Log: Applied similar fix as we did on trunk r1300463. On production systems you can't suppress Debug.log( message by the use

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 12:40 AM, Jacopo Cappellato wrote: Hi Adam, please see inline: On May 11, 2012, at 4:52 AM, Adam Heath wrote: On 04/20/2012 07:53 AM, jaco...@apache.org wrote: Author: jacopoc Date: Fri Apr 20 12:53:35 2012 New Revision: 1328356 URL: http://svn.apache.org/viewvc?rev=1328356

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 08:53 AM, Adam Heath wrote: On 05/11/2012 12:40 AM, Jacopo Cappellato wrote: Hi Adam, please see inline: On May 11, 2012, at 4:52 AM, Adam Heath wrote: On 04/20/2012 07:53 AM, jaco...@apache.org wrote: Author: jacopoc Date: Fri Apr 20 12:53:35 2012 New Revision: 1328356 URL

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 09:36 AM, Jacopo Cappellato wrote: > > On May 11, 2012, at 4:26 PM, Adam Heath wrote: > >>>>>> @@ -177,10 +184,18 @@ public class GroovyUtil { >>>>>> Class scriptClass = parsedScripts.get(script); >>>>>> if (scriptClass

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 09:51 AM, Adam Heath wrote: > On 05/11/2012 09:36 AM, Jacopo Cappellato wrote: >> >> On May 11, 2012, at 4:26 PM, Adam Heath wrote: >> >>>>>>> @@ -177,10 +184,18 @@ public class GroovyUtil { >>>>>>> Class scriptCla

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 10:30 AM, Jacopo Cappellato wrote: > On May 11, 2012, at 4:51 PM, Adam Heath wrote: > >> == >> result = parsedScripts.get(key) >> if (result == null) { >> syncyronized (parsedScripts) { >>result = parsedScripts.get(key) >>if (re

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 10:49 AM, Jacopo Cappellato wrote: > > On May 11, 2012, at 5:38 PM, Adam Heath wrote: > >> On 05/11/2012 10:30 AM, Jacopo Cappellato wrote: >>> On May 11, 2012, at 4:51 PM, Adam Heath wrote: >>> >>>> == >>>>

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 12:30 PM, Jacopo Cappellato wrote: > > On May 11, 2012, at 6:34 PM, Adam Heath wrote: > >> There is no difference. The act of map.get() can be doing a *lot* of >> separate, individual steps. Without any kind of >> happens-before/happens-after on map.g

Warning! In the next few hours, I will be committing findByPrimaryKey->findOne changes

2012-05-11 Thread Adam Heath
As I have discussed, I will be committing a series of separate commits, that change findByPrimaryKey calls into findOne. I have run the test cases on these changes, and everything compiles. However, ofbiz does *not* have 100% coverage, no where close. Some of the changes are inside groovy/ftl fi

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-11 Thread Adam Heath
On 05/11/2012 02:46 PM, Jacopo Cappellato wrote: >> The UtilCache objects *are* thread-safe. You will not get any >> internal corruption inside UtilCache. That is all that can be guaranteed. >> >> What isn't thread safe, is that calling code may end up having >> multiple instances for the same ke

Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-11 Thread Adam Heath
On 05/11/2012 05:25 AM, adri...@apache.org wrote: Author: adrianc Date: Fri May 11 10:25:33 2012 New Revision: 1337103 URL: http://svn.apache.org/viewvc?rev=1337103&view=rev Log: Fixed broken Mini-language element (second try). Modified: ofbiz/trunk/framework/minilang/src/org/ofbiz/minil

Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-12 Thread Adam Heath
Could you provide the test report XML file please? -Adrian On 5/12/2012 3:59 AM, Adam Heath wrote: On 05/11/2012 05:25 AM, adri...@apache.org wrote: Author: adrianc Date: Fri May 11 10:25:33 2012 New Revision: 1337103 URL: http://svn.apache.org/viewvc?rev=1337103&view=rev Log: Fixed broken

Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-12 Thread Adam Heath
On 05/12/2012 07:17 AM, Adrian Crum wrote: Okay, rev 1337518 gets the tests to pass, but it isn't a fix - it merely masks the real problem. I made the commit so others can continue with their work, and I will continue working on the real problem. Without going into too much detail, here is a sum

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-12 Thread Adam Heath
On 05/12/2012 04:01 AM, Jacopo Cappellato wrote: On May 10, 2012, at 6:23 PM, Adam Heath wrote: On 05/10/2012 11:16 AM, Adrian Crum wrote: The scripts are helpful if you have a Subversion client that runs from the command line. Some of us use a graphical Subversion client - like Tortoise, or

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-12 Thread Adam Heath
On 05/12/2012 05:15 AM, Jacques Le Roux wrote: +1 Though I'd like to keep revert.bat, it's easier to change path (and not forget) with new release than have to search in build.xml, not a big deal though... tools/ant-revert.xml: ./ant revert ./ant -f tools/ant-revert.xml revert both commands

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-12 Thread Adam Heath
On 05/12/2012 03:36 PM, Jacques Le Roux wrote: I just meant it's easier to edit revert.bat than to seek for it in the build.xml when you have to update the path for a new release. Forget it, sometimes I'm too lazy :o) I mean the definition for the ant revert command should be in a separate fil

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-12 Thread Adam Heath
On 05/12/2012 03:39 PM, Jacques Le Roux wrote: From: "Adam Heath" On 05/12/2012 04:01 AM, Jacopo Cappellato wrote: On May 10, 2012, at 6:23 PM, Adam Heath wrote: On 05/10/2012 11:16 AM, Adrian Crum wrote: The scripts are helpful if you have a Subversion client that runs from t

Re: svn commit: r1336768 - in /ofbiz/branches/release12.04: mergefromtrunk.bat mergefromtrunk.sh

2012-05-12 Thread Adam Heath
On 05/12/2012 04:04 PM, Jacques Le Roux wrote: From: "Adam Heath" On 05/12/2012 03:36 PM, Jacques Le Roux wrote: I just meant it's easier to edit revert.bat than to seek for it in the build.xml when you have to update the path for a new release. Forget it, sometimes I'm t

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-12 Thread Adam Heath
On 05/12/2012 04:28 PM, Jacques Le Roux wrote: I'm sure you are both afraid of that, but in case you freithened people about DCL I wanted to say that since jdk 1.5 way of handling volatile it's now possible to safely use this pattern with Java http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCh

Re: svn commit: r1328356 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/GroovyUtil.java

2012-05-14 Thread Adam Heath
On 05/13/2012 02:24 AM, Jacques Le Roux wrote: > From: "Adam Heath" >> Sure, volatile makes DCL *safe*, but it is still slower, in the case >> when the initial fetch is null. For static initialization, it might >> be ok to use it. But it's probably more conf

UtilCacheTests sporadic failure

2012-05-14 Thread Adam Heath
Well, good news. I just had UtilCacheTests.testExpire fail on me. Since I'm the one who created that test, I'm the most qualified to fix it. Unfortunately, the test itself attempts to use all memory, so that UtilCache will attempt to expire all soft references. Sometimes, that doesn't work. I m

Re: UtilCacheTests sporadic failure

2012-05-14 Thread Adam Heath
On 05/14/2012 02:26 PM, Adrian Crum wrote: > It would be nice if you could specify a cache capacity - so you could > test the cache with a smaller data set. I'm already using a size of '5' and '1' in that test.

Re: svn commit: r1338361 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/collections: FlexibleMapAccessor.java test/FlexibleMapAccessorTests.java

2012-05-14 Thread Adam Heath
On 05/14/2012 02:43 PM, adri...@apache.org wrote: > Author: adrianc > Date: Mon May 14 19:43:18 2012 > New Revision: 1338361 > > URL: http://svn.apache.org/viewvc?rev=1338361&view=rev > Log: > Added a utility method to FlexibleMapAccessor.java to test for nested > expressions. > > Modified: >

Re: svn commit: r1338361 - in /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/collections: FlexibleMapAccessor.java test/FlexibleMapAccessorTests.java

2012-05-14 Thread Adam Heath
On 05/14/2012 02:49 PM, Adam Heath wrote: > On 05/14/2012 02:43 PM, adri...@apache.org wrote: >> Author: adrianc >> Date: Mon May 14 19:43:18 2012 >> New Revision: 1338361 >> >> URL: http://svn.apache.org/viewvc?rev=1338361&view=rev >> Log: >> Adde

Re: svn commit: r1338400 - in /ofbiz/trunk/framework/entity/src/org/ofbiz/entity: Delegator.java GenericDelegator.java

2012-05-14 Thread Adam Heath
That is a cut-n-paste from the method above, whoops. It should be removed. I'll do it much later tonight, or tomorrow. -- Sent from my Android phone with K-9 Mail. Please excuse my brevity. Adrian Crum wrote: On 5/14/2012 9:59 PM, doo...@apache.org wrote: > Author: doogie > Date: Mon May 14 20

Re: svn commit: r1338836 - in /ofbiz/branches/release12.04: ./ framework/base/dtd/ framework/base/src/org/ofbiz/base/util/ framework/common/config/ framework/webtools/src/org/ofbiz/webtools/labelmanag

2012-05-15 Thread Adam Heath
Except that I *am* planning on backporting the delegator changes, as it does simplify the api, and makes it easier to backport other changes. But only to 12.04, as that hasn't really been released yet. -- Sent from my Android phone with K-9 Mail. Please excuse my brevity. Scott Gray wrote: Yo

Re: svn commit: r1338836 - in /ofbiz/branches/release12.04: ./ framework/base/dtd/ framework/base/src/org/ofbiz/base/util/ framework/common/config/ framework/webtools/src/org/ofbiz/webtools/labelmanag

2012-05-15 Thread Adam Heath
This is why I spent time to make the complex shell script(and someone else did the .bat). Why not use those? -- Sent from my Android phone with K-9 Mail. Please excuse my brevity. Scott Gray wrote: I see in your subsequent commits that you encountered the problems caused by this type of chang

Re: svn commit: r1338836 - in /ofbiz/branches/release12.04: ./ framework/base/dtd/ framework/base/src/org/ofbiz/base/util/ framework/common/config/ framework/webtools/src/org/ofbiz/webtools/labelmanag

2012-05-15 Thread Adam Heath
y involved changing public method signatures in a breaking way. Regards Scott On 16/05/2012, at 1:22 PM, Adam Heath wrote: > Except that I *am* planning on backporting the delegator changes, as it does > simplify the api, and makes it easier to backport other changes. But only to > 12

Re: svn commit: r1338836 - in /ofbiz/branches/release12.04: ./ framework/base/dtd/ framework/base/src/org/ofbiz/base/util/ framework/common/config/ framework/webtools/src/org/ofbiz/webtools/labelmanag

2012-05-15 Thread Adam Heath
On 05/15/2012 10:32 PM, Scott Gray wrote: You can add a method by the same name if you need to, but you can't change an existing method's signature. 1: Add new method. Nothing broken, nothing calls new code. 2: Modify existing old method to use new method. Old method using new method, new m

use of UtilMisc.to(Map|List) in groovy and ftl

2012-05-16 Thread Adam Heath
== find -name '*.groovy' -printf '%P\n'|xargs egrep "UtilMisc\.(toList|toMap)"|wc -l 197 find -name '*.ftl' -printf '%P\n'|xargs egrep "Static\\[[\"']org.ofbiz.base.util.UtilMisc[\"']\\]\.(toList|toMap)"|wc -l 132 == There is no reason to use toMap or toList in groovy or ftl files. Both languages

Re: Errors in screen while running findByAnd

2012-05-16 Thread Adam Heath
On 05/16/2012 06:41 AM, Jacopo Cappellato wrote: > https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=Demo1002 This may be a stupid question, but why doesn't "admin/ofbiz" work as a login? (right now, the admin account is disabled for 5 minutes, that's my fault). I can't yet

Re: Errors in screen while running findByAnd

2012-05-16 Thread Adam Heath
On 05/16/2012 11:05 AM, Adam Heath wrote: > On 05/16/2012 06:41 AM, Jacopo Cappellato wrote: >> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=Demo1002 > > This may be a stupid question, but why doesn't "admin/ofbiz" work as a > login?

Re: Errors in screen while running findByAnd

2012-05-16 Thread Adam Heath
On 05/16/2012 11:18 AM, Adam Heath wrote: > On 05/16/2012 11:05 AM, Adam Heath wrote: >> On 05/16/2012 06:41 AM, Jacopo Cappellato wrote: >>> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=Demo1002 >> >> This may be a stupid question, but why d

Re: Errors in screen while running findByAnd

2012-05-16 Thread Adam Heath
On 05/16/2012 11:30 AM, Adam Heath wrote: > On 05/16/2012 11:18 AM, Adam Heath wrote: >> On 05/16/2012 11:05 AM, Adam Heath wrote: >>> On 05/16/2012 06:41 AM, Jacopo Cappellato wrote: >>>> https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=Demo100

Re: Errors in screen while running findByAnd

2012-05-17 Thread Adam Heath
On 05/17/2012 01:11 AM, Jacopo Cappellato wrote: > Adam, all, > > this is interesting, thanks for the research. > > I would suggest the following approach: > > 1) identify which one of the recent changes we did caused this error to happen I know *exactly* which commit(s) it was. The findByAnd

Re: Errors in screen while running findByAnd

2012-05-17 Thread Adam Heath
On 05/17/2012 10:22 AM, Jacopo Cappellato wrote: > Adam, > > I am sorry but a few minutes ago I filed the bug in the Freemarker issue > tracker: > > https://sourceforge.net/tracker/?func=detail&aid=3527625&group_id=794&atid=100794 > > I think I have added enough details for them to comment; if

  1   2   3   4   5   6   7   8   9   10   >