Re: svn commit: r1170521 - /ofbiz/branches/release11.04/framework/base/src/org/ofbiz/base/util/UtilValidate.java

2011-09-14 Thread Adrian Crum
This isn't a bug fix - it is an enhancement. -Adrian On 9/14/2011 11:38 AM, sascharodek...@apache.org wrote: Author: sascharodekamp Date: Wed Sep 14 10:38:50 2011 New Revision: 1170521 URL: http://svn.apache.org/viewvc?rev=1170521view=rev Log: Building a String using concatenation in a loop

Re: New link between communication event and sales opportunity

2011-09-15 Thread Adrian Crum
Just curious - how is a SalesOpportunity different from a Request (or CustRequest in OFBiz)? What does SalesOpportunity model? -Adrian On 9/15/2011 7:19 AM, Scott Gray wrote: Not necessarily every communication event, but if it requires action then a WorkEffort seems like the logic choice to

Re: Why was this done?

2011-09-17 Thread Adrian Crum
Ruth, A simple search and replace will make your modifications compatible with the newer version. The change was the result of a months-long discussion on the dev mailing list (August 2009 to October 2009). If you want more detail, you can look it up. -Adrian On 9/16/2011 10:21 PM, Ruth

Re: widgetVerbose

2011-09-18 Thread Adrian Crum
...@gmail.com: On Tue, Sep 13, 2011 at 9:54 AM, Adrian Crum adrian.c...@sandglass-software.com wrote: Thanks Scott - those are my feelings exactly. I like the way the design worked previously, and changing it because a user might accidentally leave the comments enabled in production seems silly

Re: widgetVerbose

2011-09-18 Thread Adrian Crum
I still don't know what that means. Could you be more specific please? -Adrian On 9/19/2011 1:59 AM, Hans Bakker wrote: That is fine with me as long as by default there is no active override in any web.xml Regards, Hans On Mon, 2011-09-19 at 01:52 +0100, Adrian Crum wrote: Let's see if we

Re: widgetVerbose

2011-09-18 Thread Adrian Crum
Why? As far as I know, that is not a problem - but I don't understand why it should be prohibited. -Adrian On 9/19/2011 2:14 AM, Hans Bakker wrote: that in the trunk there is no override of widget.verbose in any web.xml. Hans On Mon, 2011-09-19 at 02:01 +0100, Adrian Crum wrote: I still

Re: widgetVerbose

2011-09-19 Thread Adrian Crum
, Adrian Crum adrian.c...@sandglass-software.com wrote: Thanks Scott - those are my feelings exactly. I like the way the design worked previously, and changing it because a user might accidentally leave the comments enabled in production seems silly. That is a user's QC problem, not a widget comment

REST Servlet

2011-09-19 Thread Adrian Crum
Hi All. I apologize for all the noise from Jira - I am finished with the high level REST servlet design and I wanted to clean up the issue so it would be easier to read. I know everyone is busy, but if you could spare a few minutes to take a look at the proposed REST servlet design I would

Re: REST Servlet

2011-09-19 Thread Adrian Crum
at the moment. Did yo consider my proposition Adrian, Hans? I think it's a good compromise... Jacques From: Adrian Crum adrian.c...@sandglass-software.com Hi All. I apologize for all the noise from Jira - I am finished with the high level REST servlet design and I wanted to clean up the issue so

Re: widgetVerbose

2011-09-19 Thread Adrian Crum
how it is implemented now is fine. I hope i commented now enough? Regards, Hans On Mon, 2011-09-19 at 10:03 +0100, Adrian Crum wrote: Hans, Jacques gave some examples of where an override is currently used and why it is needed. Could you give us another reason besides i think an override

Re: widgetVerbose

2011-09-19 Thread Adrian Crum
what is generating that, then turn them all on. Like Hans said, I really don't want to have to go through code to find where it is turned off or on. Adrian Crum sent the following on 9/19/2011 8:56 AM: BJ, The original message of this thread points out why that approach does not work. If comments

Re: widgetVerbose

2011-09-19 Thread Adrian Crum
to go through code to find where it is turned off or on. Adrian Crum sent the following on 9/19/2011 8:56 AM: BJ, The original message of this thread points out why that approach does not work. If comments are defaulted to on, then there MUST be a way to turn them off for things like CSV output

Re: widgetVerbose

2011-09-19 Thread Adrian Crum
thought I'd suggest a possible solution to that problem. Maybe I'm wrong. Cheers, Anne. On 20 September 2011 10:06, Adrian Crum adrian.c...@sandglass-software.com wrote: Anne, Logging the settings is not necessary because the design is not that complicated. A setting in the widget.properties file

Re: widgetVerbose

2011-09-19 Thread Adrian Crum
. 4. If there are no further objections, then we can proceed with implementing the design. -Adrian On 9/19/2011 10:23 AM, Adrian Crum wrote: Hans, We can document the behavior in the properties file, and we have this discussion on record to describe the behavior and the reason why it was done

Re: widgetVerbose

2011-09-19 Thread Adrian Crum
wrote? as long as the properties setting in the trunk will show or hide all widget comments (so in the trunk NO override) then it is fine. Regards, Hans On Tue, 2011-09-20 at 02:10 +0100, Adrian Crum wrote: Thank you everyone for your patience and comments during this discussion. I believe we

Re: widgetVerbose

2011-09-19 Thread Adrian Crum
) what i wrote? as long as the properties setting in the trunk will show or hide all widget comments (so in the trunk NO override) then it is fine. Regards, Hans On Tue, 2011-09-20 at 02:10 +0100, Adrian Crum wrote: Thank you everyone for your patience and comments during this discussion. I

Re: discussion: database dependent display of backend screens, forms, fields and menus

2011-09-20 Thread Adrian Crum
That was one of the original reasons behind the User Preferences design - to give users the ability to control screen output. Maybe have a form widget attribute or element that specifies a preference group that should be used to control display. -Adrian On 9/20/2011 9:37 AM, Hans Bakker

Re: discussion: video rentals

2011-09-22 Thread Adrian Crum
A fixed asset is an instance of a product, much like an inventory item is an instance of a product. So, no - you do not want to connect a fixed asset to a product category. Product: Die Hard DVD Product Categories: DVD, Action, Drama, Bruce Willis Fixed Assets: 10010, 10011, 1012 -Adrian On

Re: discussion: video rentals

2011-09-22 Thread Adrian Crum
, 2011-09-23 at 06:32 +0100, Adrian Crum wrote: A fixed asset is an instance of a product, much like an inventory item is an instance of a product. So, no - you do not want to connect a fixed asset to a product category. Product: Die Hard DVD Product Categories: DVD, Action, Drama, Bruce Willis Fixed

Re: discussion: video rentals

2011-09-22 Thread Adrian Crum
showing in a different category.. Adrian, before you answer can you please think about it a bit? Regards, Hans On Fri, 2011-09-23 at 06:42 +0100, Adrian Crum wrote: Use FixedAssetProduct. -Adrian On 9/23/2011 6:37 AM, Hans Bakker wrote: but if you want a particular instance of a product? I

Re: discussion: video rentals

2011-09-22 Thread Adrian Crum
at 06:47 +0100, Adrian Crum wrote: Hans, The data model supports what you are trying to do if YOU think about it. There is no need to connect a fixed asset to a product category. -Adrian On 9/23/2011 6:44 AM, Hans Bakker wrote: sure can do that, but i want a specific instance showing in one

Re: discussion: video rentals

2011-09-23 Thread Adrian Crum
Price: $1.00 per day Product Category: DVD Price: $1.50 per day Product Category: New Releases Price: $0.50 per day -Adrian On 9/23/2011 7:16 AM, Hans Bakker wrote: On Fri, 2011-09-23 at 06:56 +0100, Adrian Crum wrote: If they are the same product, then they are in the same product categories

Re: REST Servlet

2011-09-29 Thread Adrian Crum
to contribute to this discussion. Regards Scott On 19/09/2011, at 10:24 PM, Adrian Crum wrote: Hi All. I apologize for all the noise from Jira - I am finished with the high level REST servlet design and I wanted to clean up the issue so it would be easier to read. I know everyone is busy

Re: discussion: party preference and user(loginId) preference

2011-09-29 Thread Adrian Crum
I would prefer #2. The distinction between users and parties is already blurred enough, and relating User Preferences to a party will just make that worse. -Adrian On 9/29/2011 11:11 AM, Hans Bakker wrote: Thanks BJ for the comment. In order to keep the framework (login preference) and

Re: discussion: loyalty points

2011-10-12 Thread Adrian Crum
From my perspective, loyalty points are no different than any other discount - so we could use the existing discount-related accounting. -Adrian On 10/12/2011 1:16 PM, Hans Bakker wrote: We would like to implement loyalty points. There is a box on the party profile, but no database field,

Re: discussion: loyalty points

2011-10-12 Thread Adrian Crum
in the ledger Regards, Hans On Wed, 2011-10-12 at 13:39 +0100, Adrian Crum wrote: From my perspective, loyalty points are no different than any other discount - so we could use the existing discount-related accounting. -Adrian On 10/12/2011 1:16 PM, Hans Bakker wrote: We would like to implement

Re: svn commit: r1142458 - in /ofbiz/trunk/framework/common: webcommon/WEB-INF/actions/includes/FindAutocompleteOptions.groovy widget/CommonScreens.xml

2011-10-23 Thread Adrian Crum
Could you describe what the bug is and how I can reproduce it? -Adrian On 10/23/2011 1:11 PM, Jacques Le Roux wrote: Hi Adrian, While working on https://issues.apache.org/jira/browse/OFBIZ-4498 I found a bug related to r1142458 (only shown in log). If you revert the commit it dissapears.

Re: svn commit: r1142458 - in /ofbiz/trunk/framework/common: webcommon/WEB-INF/actions/includes/FindAutocompleteOptions.groovy widget/CommonScreens.xml

2011-10-23 Thread Adrian Crum
, but this was not thrown Jacques From: Adrian Crum adrian.c...@sandglass-software.com Could you describe what the bug is and how I can reproduce it? -Adrian On 10/23/2011 1:11 PM, Jacques Le Roux wrote: Hi Adrian, While working on https://issues.apache.org/jira/browse/OFBIZ-4498 I found a bug related

Re: svn commit: r1142458 - in /ofbiz/trunk/framework/common: webcommon/WEB-INF/actions/includes/FindAutocompleteOptions.groovy widget/CommonScreens.xml

2011-10-23 Thread Adrian Crum
Yes, I get the same error with or without the changes. This commit has nothing to do with the error. -Adrian On 10/23/2011 8:47 PM, Jacques Le Roux wrote: Did you get the error? Did you try to revert to see if you still see it? Jacques From: Adrian Crum adrian.c...@sandglass-software.com I

Re: Jasper intergration with ofbiz

2011-11-01 Thread Adrian Crum
Please ask this type of question on the user mailing list. -Adrian On 11/1/2011 9:49 AM, viswanath wrote: Dear All, Can any one help me with integrating jasper with ofbiz by step by step process, so that i can run the jasper reports in order manager Regards, Viswanath --

renderDateTimeField Freemarker macro ignores framework date-time format settings

2011-11-01 Thread Adrian Crum
The renderDateTimeField macro in htmlFormMacroLibrary.ftl ignores the framework date-time format settings and formats date-time fields using jQuery instead. Two problems with that: 1. Even when shortDateInput = true, the date and time are displayed when the value is a Timestamp. 2. If the

Re: renderDateTimeField Freemarker macro ignores framework date-time format settings

2011-11-01 Thread Adrian Crum
://issues.apache.org/jira/browse/OFBIZ-3830 Maybe it's related to this comment I made a this moment, also a bet... https://issues.apache.org/jira/browse/OFBIZ-3830?focusedCommentId=12882890page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12882890JacquesFrom: Adrian Crum adrian.c

Re: renderDateTimeField Freemarker macro ignores framework date-time format settings

2011-11-03 Thread Adrian Crum
I located the problem and committed some notes in rev 1197028. I don't have time right now to fix it. The problem isn't caused by JavaScript, it's caused by the renderer. We still need to fix the JavaScript code though. -Adrian On 11/1/2011 10:19 PM, Adrian Crum wrote: The way the OFBiz

Re: Incorrect use of eca for create/updateShipment

2011-11-03 Thread Adrian Crum
take the credit. Try to be in the first group because there is less competition there. Never give up on what you really want to do. The person with big dreams is more powerful than one with all the facts. From: Adrian Crum (Commented) (JIRA)j...@apache.org To: ki...@objectedge.com Date

Re: svn commit: r1198629 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml

2011-11-07 Thread Adrian Crum
If the field element is changing the type, then wouldn't it be better to fix the element? -Adrian On 11/7/2011 6:12 AM, hans...@apache.org wrote: Author: hansbak Date: Mon Nov 7 06:12:38 2011 New Revision: 1198629 URL: http://svn.apache.org/viewvc?rev=1198629view=rev Log: repeat type of

Re: svn commit: r1198629 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/payment/PaymentServices.xml

2011-11-07 Thread Adrian Crum
that the framework specialists, like you would pick this up? We merely focus on the applications as you may know? Regards, Hans On 11/07/2011 03:58 PM, Adrian Crum wrote: If the field element is changing the type, then wouldn't it be better to fix the element? -Adrian On 11/7/2011 6:12 AM, hans

Re: group ordering

2011-11-12 Thread Adrian Crum
If the same rules apply to all orders, then it seems to me you would want a separate entity to hold the group order properties: groupOrderId* productId productPriceTypeId fromDate thruDate orderQty -Adrian On 11/12/2011 3:16 AM, Hans Bakker wrote: Some extra requirements: 1. It seems a start

Re: Trunk demo error

2011-11-17 Thread Adrian Crum
Actually, there are more errors/warnings in the trunk too - most having to do with bad entity definitions. I'm cross posting this to the dev list so we can look into it. -Adrian On 11/17/2011 11:53 AM, Jacques Le Roux wrote: Also we have an issue with this, reminder: no time to create a Jira

Re: [jira] [Commented] (OFBIZ-4583) Specify use of static java method from screen widget and form widget

2011-11-22 Thread Adrian Crum
http://ci.apache.org/projects/ofbiz/site/javadocs/ Please put your comments in the Jira issue instead of replying through nabble. -Adrian On 11/22/2011 5:41 PM, Wai wrote: I'm not familiar with UEL. I'm going to learn about this feature. Meanwhile, the purpose of the implementingjava...

Re: [jira] [Commented] (OFBIZ-4583) Specify use of static java method from screen widget and form widget

2011-11-22 Thread Adrian Crum
Sorry, wrong URL. http://ci.apache.org/projects/ofbiz/site/javadocs/org/ofbiz/base/util/string/UelFunctions.html -Adrian On 11/22/2011 6:04 PM, Adrian Crum wrote: http://ci.apache.org/projects/ofbiz/site/javadocs/ Please put your comments in the Jira issue instead of replying through nabble

Discussion: Handling Security In Nested Services

2011-11-23 Thread Adrian Crum
I am running into that familiar problem of handling authorization in nested services. Example: Application A Invoke Service A Authorized with permissions A Invokes Service C in Application C Authorized with permissions C In order for a user to run Service A, I have to give them

Re: Discussion: Handling Security In Nested Services

2011-11-23 Thread Adrian Crum
and permissions at run-time, as opposed to doing it somehow based on inheritance based on location, or even worse explicit permission checking in services and screens. BTW, this is already implemented in Moqui. -David Adrian Crum wrote: I am running into that familiar problem of handling

Re: Discussion: Handling Security In Nested Services

2011-11-23 Thread Adrian Crum
. On many case, your solution works fine, but for some service, I will keep the possibility to force permission analyze. Exclude this last point, I agree with you. Nicolas Le 23/11/2011 09:14, Adrian Crum a écrit : I am running into that familiar problem of handling authorization in nested

Re: Discussion: Handling Security In Nested Services

2011-11-23 Thread Adrian Crum
As I mentioned in my original post, this scenario already exists by passing the system or admin userLogin to the called service. So, that potential already exists and is being exploited. -Adrian On 11/23/2011 9:46 PM, Nicolas Malin wrote: Le 23/11/2011 22:19, Adrian Crum a écrit : Why would

Re: svn commit: r1202164 - /ofbiz/branches/20111115ScreenWidgetRedesign/

2011-11-23 Thread Adrian Crum
I agree that there are many improvements that can be made to the screen widgets. If you would like to submit patches against the branch, then you are welcome to do so. -Adrian On 11/23/2011 9:39 PM, Nicolas Malin wrote: Oops scuse me bad english review :/ Hi Adrian, Thanks for your screen

Re: Discussion: Handling Security In Nested Services

2011-11-23 Thread Adrian Crum
: Le 23/11/2011 22:50, Adrian Crum a écrit : As I mentioned in my original post, this scenario already exists by passing the system or admin userLogin to the called service. So, that potential already exists and is being exploited. completely agree, and it's not always a good thing. I especially

Re: svn commit: r1205710 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilDateTime.java

2011-11-24 Thread Adrian Crum
Hans, The NPE is by design. Calling code should validate parameters before calling the utility method. Providing undocumented default values will also cause strange behavior. -Adrian On 11/24/2011 2:54 AM, hans...@apache.org wrote: Author: hansbak Date: Thu Nov 24 02:54:14 2011 New

Re: new field in opportunities

2011-11-27 Thread Adrian Crum
Hans, I know this suggestion is a little late, but I will make it anyway. The way I handle this type of scenario is to create Work Efforts. Next Stepshould be a TASK WorkEffort with a child EVENT WorkEffort (the date of the next step). That way the task and event can be assigned to users so

Re: Discussion: Handling Security In Nested Services

2011-11-27 Thread Adrian Crum
performance improvement. + 1 Bilgin On Wed, Nov 23, 2011 at 8:14 AM, Adrian Crum adrian.c...@sandglass-software.com wrote: I am running into that familiar problem of handling authorization in nested services. Example: Application A Invoke Service A Authorized with permissions A Invokes Service C

Re: Jira issues will be possible to apply on ScreenWidgetRedesign

2011-11-29 Thread Adrian Crum
Some of those are bug fixes that should be applied to the trunk. I would prefer to limit the branch's scope initially, so we can be reasonably sure that progress will be made. -Adrian On 11/29/2011 8:20 PM, Nicolas Malin wrote: Hi adrian, are listed below, jira issue that will be apply on

Example Application Is Badly Broken

2011-12-03 Thread Adrian Crum
In the good old days, the Example application was used to demonstrate OFBiz development best practices. Today, it is an example of all of the wrong ways to do things. Go to https://localhost:8443/example/control/main Click the New Example button. In the popup window, click Create. You are

Re: svn commit: r1211073 - in /ofbiz/trunk: applications/accounting/src/org/ofbiz/accounting/thirdparty/worldpay/WorldPayEvents.java framework/common/src/org/ofbiz/common/CommonServices.java framework

2011-12-06 Thread Adrian Crum
Please revert this. It does not compile on Sun/Oracle JDK. -Adrian On 12/6/2011 7:51 PM, j...@apache.org wrote: Author: jaz Date: Tue Dec 6 19:51:28 2011 New Revision: 1211073 URL: http://svn.apache.org/viewvc?rev=1211073view=rev Log: few minor changes to fix compiling with openjdk icetea6

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-13 Thread Adrian Crum
I agree with Jacopo. If this test did not work for a long time then buildbot would let us know. -Adrian On 12/13/2011 3:52 PM, Jacopo Cappellato wrote: Hans, could you please be more specific on the errors/failures you are getting? It seems I was able to run successfully all the tests.

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-15 Thread Adrian Crum
I agree with Scott. A number of us have tried running the tests with no problem, so it must be a local issue. Let's get them enabled again. -Adrian On 12/15/2011 10:56 PM, Scott Gray wrote: My vote would be to re-enable them regardless, the whole point of the tests is to ensure stability and

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-16 Thread Adrian Crum
Jacopo, Setting the language on the command line should not have any effect because OFBiz sets the language when it starts up. See the ofbiz.locale.default setting in start.properties. I can duplicate the test failures by changing that setting to some other locale. That is why I thought it

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-16 Thread Adrian Crum
Huh? Start.java is not executed when run-tests is called??!! -Adrian On 12/16/2011 11:15 AM, Jacopo Cappellato wrote: Adrian, I doubt that that code is executed when run-tests is called. Jacopo On Dec 16, 2011, at 11:14 AM, Adrian Crum wrote: Jacopo, Setting the language on the command

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-16 Thread Adrian Crum
stuff I reported HTH Jacques From: Adrian Crum adrian.c...@sandglass-software.com Huh? Start.java is not executed when run-tests is called??!! -Adrian On 12/16/2011 11:15 AM, Jacopo Cappellato wrote: Adrian, I doubt that that code is executed when run-tests is called. Jacopo On Dec 16, 2011

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-16 Thread Adrian Crum
Cappellato wrote: No, I meant to say that I am pretty sure that the code that sets the locale is not executed when the tests are run... I am investigating into this now Jacopo On Dec 16, 2011, at 12:39 PM, Adrian Crum wrote: Huh? Start.java is not executed when run-tests is called??!! -Adrian On 12

Re: svn commit: r1213650 - /ofbiz/trunk/applications/accounting/testdef/accountingtests.xml

2011-12-16 Thread Adrian Crum
you suggested. I doubt it will fix the issue Jacques reported... but that may be unrelated to locale Jacques, is there any chance that you have some local modifications? Jacopo On Dec 16, 2011, at 3:17 PM, Adrian Crum wrote: There is no need to investigate - I wrote that code and I can assure

Re: svn commit: r1220622 - in /ofbiz/trunk: applications/manufacturing/data/ applications/order/src/org/ofbiz/order/order/ applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webap

2011-12-19 Thread Adrian Crum
This commit is throwing a lot of exceptions during data loading. See the buildbot report. -Adrian On 12/19/2011 6:40 AM, hans...@apache.org wrote: Author: hansbak Date: Mon Dec 19 06:40:18 2011 New Revision: 1220622 URL: http://svn.apache.org/viewvc?rev=1220622view=rev Log: new producttype:

Re: svn commit: r1220622 - in /ofbiz/trunk: applications/manufacturing/data/ applications/order/src/org/ofbiz/order/order/ applications/order/src/org/ofbiz/order/shoppingcart/ applications/order/webap

2011-12-19 Thread Adrian Crum
description=Image/ I have fixed it. Even without reviewing this big commit, this kind of errors (that imply that very few tests were done) makes me feel nervous about the quality of the code committed. Jacopo On Dec 19, 2011, at 9:24 AM, Adrian Crum wrote: This commit is throwing a lot of exceptions

Re: svn commit: r1222241 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericEntity.java

2011-12-22 Thread Adrian Crum
I don't like this commit - it looks like an ugly hack to me. What is the end result supposed to be? Or what is this supposed to do? -Adrian On 12/22/2011 2:14 PM, jler...@apache.org wrote: Author: jleroux Date: Thu Dec 22 14:14:57 2011 New Revision: 141 URL:

Re: svn commit: r1222241 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericEntity.java

2011-12-22 Thread Adrian Crum
address the problem of null values, then ? Jacques From: Adrian Crum adrian.c...@sandglass-software.com I don't like this commit - it looks like an ugly hack to me. What is the end result supposed to be? Or what is this supposed to do? -Adrian On 12/22/2011 2:14 PM, jler...@apache.org wrote

Re: svn commit: r1222241 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericEntity.java

2011-12-22 Thread Adrian Crum
surprises with this work? How would you address the problem of null values, then ? Jacques From: Adrian Crum adrian.c...@sandglass-software.com I don't like this commit - it looks like an ugly hack to me. What is the end result supposed to be? Or what is this supposed to do? -Adrian On 12

Re: svn commit: r1225641 - in /ofbiz/branches/release11.04/applications/order/src/org/ofbiz/order: order/OrderServices.java shoppingcart/ShoppingCart.java

2011-12-29 Thread Adrian Crum
Is this a bug fix? -Adrian On 12/29/2011 8:30 PM, m...@apache.org wrote: Author: mor Date: Thu Dec 29 20:30:56 2011 New Revision: 1225641 URL: http://svn.apache.org/viewvc?rev=1225641view=rev Log: Merged from trunk r1225639 r1225640. Log: Added support to associate ship groups of sales and

Re: buildbot failure in ASF Buildbot on ofbiz-trunk

2012-01-01 Thread Adrian Crum
The ability to use expressions in seed/demo data would be a nice feature. -Adrian On 1/1/2012 7:59 PM, Jacopo Cappellato wrote: Hi Jacques, the failure could be related to the year switch... this happens every year and it needs some updates to demo fiscal periods to fix; or you could try

Re: svn commit: r1226309 - /ofbiz/trunk/applications/accounting/data/DemoGlSetupData.xml

2012-01-01 Thread Adrian Crum
Jacques, Look at the commit log from a year ago. Jacopo fixed this problem last year, so the commit log should tell you what needs to be changed. -Adrian On 1/1/2012 10:30 PM, jler...@apache.org wrote: Author: jleroux Date: Sun Jan 1 22:30:18 2012 New Revision: 1226309 URL:

Re: Discussion: Potential Data Model Improvements

2012-01-02 Thread Adrian Crum
On 3/20/2011 3:33 AM, David E Jones wrote: I'm writing this to start a thread to discuss: If you could change ANYTHING in the OFBiz data model, what would it be? To kick this off here are some ideas I've compiled that have come up over the years (many based on feedback from people on this

Re: Ofbiz

2012-01-04 Thread Adrian Crum
This question should be asked on the user mailing list. The best approach is to do a find on the primary key, and if a value is found, return a user-friendly error message. -Adrian On 1/4/2012 11:04 AM, Ritesh K Kaushik wrote: If we enter a duplicate Primary key in Ofbiz then it gives a

Re: releases

2012-01-06 Thread Adrian Crum
As has been mentioned many times on this list, the EOL concept does not fit well in an open source community. As long as users are using 4.0 and are willing to provide patches, etc, then there is no need to remove it. In other words, older releases are perfectly capable of dying a natural

Re: releases

2012-01-06 Thread Adrian Crum
On 1/6/2012 1:04 PM, Erwan de FERRIERES wrote: 2012/1/6 Adrian Crumadrian.c...@sandglass-software.com: As has been mentioned many times on this list, the EOL concept does not fit well in an open source community. As long as users are using 4.0 and are willing to provide patches, etc, then there

Re: releases

2012-01-06 Thread Adrian Crum
, but are offering help to commit *well done* contributions? My basic idea (not sure for Erwan) is to prevent users to expect us to work on their issues if they don't help us... Jacques From: Adrian Crum adrian.c...@sandglass-software.com On 1/6/2012 1:04 PM, Erwan de FERRIERES wrote: 2012/1/6 Adrian

Re: svn commit: r1230793 - in /ofbiz/trunk/specialpurpose/scrum: ./ config/ data/ data/hookscripts/ entitydef/ servicedef/ src/org/ofbiz/scrum/ templates/ testdef/ webapp/demotest/ webapp/demotest/WEB

2012-01-12 Thread Adrian Crum
I'm familiar with RAT - I use it for the Commons Convert project. -Adrian On 1/12/2012 9:48 PM, Erwan de FERRIERES wrote: Le 12/01/2012 22:41, Adrian Crum a écrit : Erwan, Thank you for taking care of that. -Adrian You're welcome ! But I'm not alone, RAT (http://incubator.apache.org/rat

Stop The Madness: Indexing keyword EECAs

2012-01-13 Thread Adrian Crum
I tried to find out why a data import for a bespoke (made-to-order) manufacturer was taking WAY too long. Turns out it was keyword indexing EECAs. Each product has dozens of product features, and it also has a manufacturer ID. The indexProductKeywords is called for the product, each product

Re: Stop The Madness: Indexing keyword EECAs

2012-01-14 Thread Adrian Crum
this is something we should fix). Kind regards, Jacopo On Jan 14, 2012, at 1:59 AM, Adrian Crum wrote: I tried to find out why a data import for a bespoke (made-to-order) manufacturer was taking WAY too long. Turns out it was keyword indexing EECAs. Each product has dozens of product features, and it also

Re: buildbot failure in ASF Buildbot on ofbiz-trunk

2012-01-17 Thread Adrian Crum
On 1/17/2012 1:12 PM, build...@apache.org wrote: The Buildbot has detected a new failure on builder ofbiz-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk/builds/2536 Buildbot URL: http://ci.apache.org/ Buildslave for this Build:

Discussion: Column Screen Widgets

2012-01-19 Thread Adrian Crum
I would like to implement two new screen widgets: column-container and column. The goal is to simplify multi-column layout. The column-container widget can have only column child elements and the column widget can have any screen widget child widgets. A width attribute can specify the width of

Re: svn commit: r1213562 - in /ofbiz/trunk/applications/commonext: script/org/ofbiz/SystemInfoServices.xml servicedef/services.xml widget/CommonScreens.xml

2012-01-22 Thread Adrian Crum
Hans, Why would you do this? This commit makes the commonext component dependent on two special purpose components. Please keep application-specific code inside the application. -Adrian On 12/13/2011 4:23 AM, hans...@apache.org wrote: Author: hansbak Date: Tue Dec 13 04:23:50 2011 New

Re: svn commit: r1213562 - in /ofbiz/trunk/applications/commonext: script/org/ofbiz/SystemInfoServices.xml servicedef/services.xml widget/CommonScreens.xml

2012-01-22 Thread Adrian Crum
are generated by the related components. So if the scrum coponent is not used, it will not generate any scrum specifc messages so the link back into the scrum component will not happen. The same with the other components Regards, Hans On 01/23/2012 01:50 AM, Adrian Crum wrote: Hans, Why would

Re: Discussion: Column Screen Widgets

2012-01-24 Thread Adrian Crum
On 1/24/2012 2:11 PM, Erwan de FERRIERES wrote: 2012/1/19 Adrian Crumadrian.c...@sandglass-software.com: I would like to implement two new screen widgets:column-container and column. The goal is to simplify multi-column layout. The column-container widget can have onlycolumn child elements

Re: proposal: overriding property setting per tenant.

2012-01-27 Thread Adrian Crum
I have been thinking about Properties handling too, not from a multi-tenant perspective, but from a convenience perspective. It seems to me the way we handle properties right now could be simplified. Instead of calling a static utility method to get a property or using a special mini-language

Re: proposal: overriding property setting per tenant.

2012-01-27 Thread Adrian Crum
The use cases I can think of: 1. Implement a sandbox instance for users to learn on (with demo data), and also have a live instance (with live data). OFBiz users can learn in the sandbox without affecting live data, and then switch to the live instance. 2. Offer a customized version of OFBiz

Re: proposal: overriding property setting per tenant.

2012-01-29 Thread Adrian Crum
reason for this would be to have a single file you could use for deployment (dev.xml, staging.xml, production.xml, etc) - drop this in your hot-deploy component and have it override the values in framework / applications. -Joe On Jan 27, 2012, at 3:49 AM, Adrian Crum wrote: I have been

Re: svn commit: r1234563 - in /ofbiz/trunk: ./ framework/base/lib/j2eespecs/ framework/catalina/lib/

2012-01-31 Thread Adrian Crum
This commit is throwing a lot of exceptions during startup. -Adrian On 1/22/2012 6:05 PM, er...@apache.org wrote: Author: erwan Date: Sun Jan 22 18:05:28 2012 New Revision: 1234563 URL: http://svn.apache.org/viewvc?rev=1234563view=rev Log: Upgrading tomcat to version 7.0.25 - changelog @

Re: svn commit: r1238998 - in /ofbiz/trunk/framework: common/data/ entity/script/ entity/script/org/ entity/script/org/ofbiz/ entity/script/org/ofbiz/entity/ entity/script/org/ofbiz/entity/test/ entit

2012-02-01 Thread Adrian Crum
Hans, This looks pretty good, but I have a few questions. Do we really need EntityUtilProperties.java? It seems to me you could just add the three new methods to EntityUtil.java. In the getSystemPropertyValue method, why are you using findByAnd when the SystemProperty entity has a primary

Re: svn commit: r1238998 - in /ofbiz/trunk/framework: common/data/ entity/script/ entity/script/org/ entity/script/org/ofbiz/ entity/script/org/ofbiz/entity/ entity/script/org/ofbiz/entity/test/ entit

2012-02-01 Thread Adrian Crum
Including a systemResource field makes sense. -Adrian On 2/1/2012 10:14 AM, Chatree Srichart wrote: On Wed, Feb 1, 2012 at 4:23 PM, Adrian Crum adrian.c...@sandglass-software.com wrote: Hans, This looks pretty good, but I have a few questions. Do we really need EntityUtilProperties.java

Re: svn commit: r1234563 - in /ofbiz/trunk: ./ framework/base/lib/j2eespecs/ framework/catalina/lib/

2012-02-01 Thread Adrian Crum
. -Adrian On 2/1/2012 12:33 PM, Erwan de FERRIERES wrote: Le 31/01/2012 15:47, Adrian Crum a écrit : This commit is throwing a lot of exceptions during startup. -Adrian Adrian, could you point the exceptions ? I tried to find them, but, at my level, I have no more exceptions than with tomcat 7.0.23

Re: Definitively remove beanshell from OFBiz

2012-02-12 Thread Adrian Crum
It would be nice if we could come up with a way to use JSR 223 in screen widgets and mini-language. -Adrian On 2/9/2012 6:31 AM, Jacques Le Roux wrote: After almost 4 years, I can see no problems with that Jacques From: Erwan de FERRIERES erwan.deferrie...@gmail.com Hi all, in may 2008, we

Re: svn commit: r1234563 - in /ofbiz/trunk: ./ framework/base/lib/j2eespecs/ framework/catalina/lib/

2012-02-12 Thread Adrian Crum
[0.0.0.0]].addChild(StandardEngine[default-server].StandardHost[0.0.0.0].StandardContext[/images]) 2012-02-12 22:00:45,330 (catalina-startup-1) [ GenericDispatcher.java:69 :INFO ] Creating new dispatcher [example] (catalina-startup-1) -Adrian On 2/1/2012 12:47 PM, Adrian Crum wrote: That is odd. I

Re: svn commit: r1234563 - in /ofbiz/trunk: ./ framework/base/lib/j2eespecs/ framework/catalina/lib/

2012-02-12 Thread Adrian Crum
Based on that bug report, we can fix the errors ourselves by specifying the correct DTD in the web.xml file. -Adrian On 2/13/2012 6:49 AM, Erwan de FERRIERES wrote: Le 12/02/2012 23:08, Adrian Crum a écrit : javax.naming.NameNotFoundException: Resource /WEB-INF/classes not found Hi Adrian

Re: Server Side Javascript and OFBiz

2012-02-14 Thread Adrian Crum
Why not use the one in Java 6 - Rhino? -Adrian On 2/14/2012 5:47 PM, Al Byers wrote: Anyone working on using OFBiz with SSJS? I would like to compare notes. I am interested in pursuing the Dojo/Persevere/RingoJS path. -Al Byers

Re: ContactMechServices .xml v/s .java

2012-02-16 Thread Adrian Crum
I am sure most, if not all, contact mech services can be migrated to entity-auto services or mini-language. -Adrian On 2/16/2012 3:36 AM, ki...@objectedge.com wrote: Hello Friends, Seems like ContactMechServices.xml and ContactMechServices.java have many common methods: create/update

Re: Alternatives to using UserLoginId as a primary key

2012-02-19 Thread Adrian Crum
Brett, This opens up the possibility to solve another problem - supporting alternate authentication systems (like LDAP, etc). Right now the userLogin entity includes OFBiz credentials (login name, password), LDAP credentials (DN), and some other credentials that Andrew added. From my

Re: Alternatives to using UserLoginId as a primary key

2012-02-19 Thread Adrian Crum
and feedback early so we can avoid large changes after the POC is complete. Let me know the best way to proceed with this effort. Thanks, Brett On Sun, Feb 19, 2012 at 2:30 AM, Adrian Crum adrian.c...@sandglass-software.com wrote: Brett, This opens up the possibility to solve another

Re: Alternatives to using UserLoginId as a primary key

2012-02-20 Thread Adrian Crum
on. Kind regards, Jacopo On Feb 20, 2012, at 8:38 AM, Adrian Crum wrote: As far as I know, there are two LDAP authentication implementations - one that I worked on a while back that can be found in the framework, and a CAS-LDAP one that can be found in specialpurpose. There is also a SSO

Re: Proposal about a time based release plan

2012-02-21 Thread Adrian Crum
Sounds great! I like the idea of separating release date roadmap from release feature roadmap. -Adrian On 2/21/2012 9:18 AM, Jacopo Cappellato wrote: Hi all, I would like to share some ideas I have to make our release plan more clearer, public and well defined. This plan doesn't require

Re: svn commit: r1213562 - in /ofbiz/trunk/applications/commonext: script/org/ofbiz/SystemInfoServices.xml servicedef/services.xml widget/CommonScreens.xml

2012-02-22 Thread Adrian Crum
Thank you Hans. -Adrian On 2/22/2012 8:37 AM, Hans Bakker wrote: It took some time agrian, we we just implemented your comment in revision 1292180. On 01/23/2012 01:50 AM, Adrian Crum wrote: Hans, Why would you do this? This commit makes the commonext component dependent on two special

Re: Extend form with actions

2012-02-22 Thread Adrian Crum
We discussed this a while ago and came to an agreement on how to implement it, but it was never implemented. -Adrian On 2/22/2012 10:19 AM, Nicolas Malin wrote: Hello on widget form at this time the actions on parents form has been not execute if child form contains also an actions Example

Re: Migration of site and dist/ to svnpubsub

2012-02-24 Thread Adrian Crum
Jacopo, Thank you very much for taking care of this. -Adrian On 2/24/2012 3:56 PM, Jacopo Cappellato wrote: Today I have created the ticket for Infra to migrate the publishing mechanism for the OFBiz site and dist/ folder (releases) to svnpubsub:

Re: Summary of some recent discussions around the OFBiz release roadmap and some proposals

2012-02-26 Thread Adrian Crum
This is a good summary of the discussions. I'm not clear on what officialize means. I would prefer to have this release roadmap considered as a general outline, and not something cast in stone. My concern is that it will be taken too literally and future efforts to vary the release schedule

  1   2   3   4   5   6   7   8   9   10   >