- All tests pass on my computer
- Smoke tests on the system show normal operation across the accounting
screens and webtools.
- I got an error on
https://localhost:8443/accounting/control/PaymentAcctgTransEntriesPdf?paymentId=8003
HTTP 500, but I believe it also existed on the first release.
Given
split the tools folder from 16.11? This kind of change belongs in Trunk no?
On Thu, May 11, 2017 at 12:45 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:
> I'd like to split the tools folder, I planned it for months but delayed :/
>
> It's of course not blocking and I have nothing impo
t not the case? Do we really want to remove them definitely?
>
> Jacques
>
>
> Le 10/05/2017 à 12:18, Taher Alkhateeb a écrit :
>
>> Hi Jacques, why do you want to reintroduce the tests?
>>
>> On Wed, May 10, 2017 at 12:52 PM, Jacques Le Roux <
>> jacque
Hello everyone,
I propose the following actions to update and cleanup build.gradle
- remove copyDtds (almost never used, and not related to building OFBiz)
- remove the "committerGroup" label
- change the group label for "svnInfoFooter" and "gitInfoFooter" to
"sysadminGroup"
WDYT
arts.com> wrote:
> Hi Taher,
>
> I regularly use copyDtds to update our XSDs on our site which are used as
> references by our XML files.
>
> We could also move it to copyDtds if you prefer.
>
> Jacques
>
>
>
> Le 14/05/2017 à 07:41, Taher Alkhateeb a é
gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY) <
jaco...@apache.org>"
+1
On Tue, May 16, 2017 at 11:11 AM, Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:
> This is the vote thread to release a new bug fix release for the
> release16.11 branch. This new release,
Hello Everyone,
We had a discussion thread [1] in which we agreed that some Java files
should be removed from the framework. Some individuals suggested to move
them to plugins and started a JIRA [2] for that.
It has been a long time since this thread started and the hack we have in
build.gradle t
The master build.gradle file should not point to any plugins
On Fri, May 19, 2017 at 1:10 PM, Shi Jinghai wrote:
> Hi Jacques,
>
> In ${ofbiz.home}/build.gradle, adding solr.log.dir and solr.log.level can
> remove this error message, i.e.:
> def jvmArguments = ['-Xms128M', '-Xmx1024M',
>
My recommendation if you want to achieve something significant for this
task is the following:
- Focus first on services and tests, the bulk of messy minilang is living
there
- Maybe we shouldn't reinvent the wheel. We already have the minilang
parsing logic, why not just use it to convert everyth
minilang (beside the
technical interest :) ) could lead to have a lot of bad java with a lot of
cleaning required.
Gil
Le 19/05/2017 à 15:15, Taher Alkhateeb a écrit :
> My recommendation if you want to achieve something significant for this
> task is the following:
>
> - Focus first on
Hello Everyone,
I noticed lately that some users got confused on the progress bar in Gradle
(percent complete) when starting OFBiz from Gradle.
I thought of a quick solution that would simply suppress the progress bar
and colored output if the gradlew command contained the word "ofbiz"
anywhere (
of
that upfront.
Cheers,
Taher Alkhateeb
On Sun, May 28, 2017 at 1:34 PM, Michael Brohl
wrote:
> Thanks all for your opinions!
>
> It seems that most of us are in favor of using Groovy instead of Java for
> services, events and tests.
>
> Discussing this internally here at ecomif
I see this mind-map and think to myself there is good effort done in
thinking about it.
+1 to proceed with changes based on what's there. In my opinion, we
shouldn't worry too much about agreeing on structure. Our current wiki is
in a bad shape and any work done on it is better than keeping it as
+1
Fantastic initiative.
On Tue, May 30, 2017 at 12:10 PM, Sharan Foga wrote:
> Excellent and thanks for the link Michael!
>
> Thanks
> Sharan
>
>
> On 30/05/17 11:07, Michael Brohl wrote:
>
>> Hi Sharan, Craig,
>>
>> this is great and will fit well into the Wiki restructure efforts.
>>
>> For
Reading through the threads provided by Paul reminded me of the reason why
we suffered in making a decision. Documentation is very important, and very
boring!
I think we all agree now (more-or-less) that documentation inside the code
base is probably better. The question to raise (again!) is which
efore committing?
Cheers,
Taher Alkhateeb
] https://issues.apache.org/jira/browse/OFBIZ-9392
Cheers,
Taher Alkhateeb
I think this log message looks bad in addition to being platform dependent
with EOL character. Perhaps it should be properly formatted as it looks off
and 220 characters wide for no good reason.
On Thu, Jun 8, 2017 at 9:39 PM, wrote:
> Author: jleroux
> Date: Thu Jun 8 18:39:23 2017
> New Revis
I don't want to sound like a broken record, but at a minimum I would
suggest to apply "svn up" followed by "./gradlew cleanAll loadDefault
testIntegration" before committing. Depending on buildbot to catch errors
is not an ideal solution because it slows down other committers who are
trying to comm
Hi Jacques, the build is still crashing, and I suspect this is from your
commit r1798335. Again, this means you're committing without testing and
doing "gradlew cleanAll loadDefault testIntegration".
I also think this mass searching for try blocks in the code base and
changing them to try-with-res
code.
WDYT
[1] https://issues.apache.org/jira/browse/OFBIZ-9392
On Thu, Jun 8, 2017 at 3:38 PM, Taher Alkhateeb
wrote:
> Hey folks,
>
> It was very painful and slow, but I finally got a working almost
> full-rewrite of the CatalinaContainer. I need help with testing, reviews
gt; other. If I could have at least a volunteer developer to help me then I'd
>> be willing to try to fix the docbook implementation.
>>
>> We've just done a 16.11 release so probably won't be doing another until
>> around November (I'm only guessing here
because of a missing
context and a manager and a few other things.
Cheers,
Taher Alkhateeb
On 13/06/17 01:03, Michael Brohl wrote:
Hi Taher,
clustering support is an important feature for enterprise
installations and it worked in the past. It should be fixed if it is
broken.
What makes you t
n of
> CatalinaContainer and it's currently crashing because of a missing context
> and a manager and a few other things.
>
> Cheers,
>
> Taher Alkhateeb
>
>
> On 13/06/17 01:03, Michael Brohl wrote:
>
>> Hi Taher,
>>
>> clustering support is
ith my MacOS, I'll
try this tomorrow.
It would be great if others could check if OFBiz runs on their machine with
configured cluster support.
Regards,
Michael
Am 13.06.17 um 01:01 schrieb Taher Alkhateeb:
A compile dependency is also a runtime dependency in gradle (as opposed to
> com
cy to crash ofbiz during startup if you don't
> have it configured correctly.
>
> Definitely a -1 for removal.
>
> Regards
> Scott
>
> On 13 June 2017 at 08:57, Taher Alkhateeb
> wrote:
>
> > Hi Everyone,
> >
> > In reference to [1] and the refactorin
conflicting with my local LAN setup.
After doing the above and testing the cluster, everything worked. Bug
again, given that I'm treading in new territory, appreciate all the help.
The new patch is available at
https://issues.apache.org/jira/browse/OFBIZ-9392
Cheers,
Taher Alkhateeb
On Tue
://tomcat.apache.org/tomcat-8.0-doc/cluster-howto.html
Cheers,
--
Taher Alkhateeb
On Wed, Jun 14, 2017 at 11:07 PM, Michael Brohl
wrote:
> Hi Taher,
>
> Am 14.06.17 um 19:56 schrieb Taher Alkhateeb:
>
>> Okay, after a little bit of investigation I think I got what caused the
>> crash
Why would you add 30 sec sleep!
The right way to do this is to change the command as follows:
./gradlew "ofbiz --shutdown"
In other words, don't send the shutdown command to the background.
On Jun 16, 2017 2:34 PM, wrote:
Author: jleroux
Date: Fri Jun 16 11:34:38 2017
New Revision: 1798912
U
Hey Folks. I know everyone's probably preoccupied. It would be great to get
some feedback on OFBIZ-9392 though given how critical this piece of code
is. I'd feel much better about committing after a few reviews.
On Thu, Jun 15, 2017 at 9:22 PM, Taher Alkhateeb wrote:
> Hi Michael
Hello Everyone,
I am starting this thread because of the latest unexpected release thread
[1] due to a major bug introduced by Jacques Le Roux in [2].
We had multiple discussion with Jacques, one such discussion [3] was due to
a bad commit in which I made a recommendation to stop doing bulk commi
Tests running, Basic smoke tests reveal nothing from my side.
+1
On Wed, Jun 21, 2017 at 9:45 PM, Deepak Dixit <
deepak.di...@hotwaxsystems.com> wrote:
> +1
>
> Thanks & Regards
> --
> Deepak Dixit
>
> On Wednesday, June 21, 2017, Michael Brohl
> wrote:
>
> > +1
> >
> > ===
> >
> > mbrohl$ ~/Pr
This commit is wrong and bad on multiple levels. Please revert
On Sat, Jun 24, 2017 at 10:56 AM, wrote:
> Author: jleroux
> Date: Sat Jun 24 07:56:45 2017
> New Revision: 1799736
>
> URL: http://svn.apache.org/viewvc?rev=1799736&view=rev
> Log:
> No functional change
>
> Improves terminateOfbiz
I suspect we did something wrong in the buildbot scripts lately and that is
why we're having these weird consistent crashes. We need to review these
files.
On Sat, Jun 24, 2017 at 11:30 PM, wrote:
> The Buildbot has detected a new failure on builder
> ofbiz-trunk-framework-plugins while building
led for task ':ofbiz'.
> Process 'command '/usr/lib/jvm/java-8-oracle/bin/java'' finished with
non-zero exit value 137
Which I believe is OK because Java does not expect to be killed!
Jacques
Le 24/06/2017 à 20:04, Taher Alkhateeb a écrit :
> This commit is wrong and
quot; process is not terminated then it's killed by the 2nd
>> "if", like it was done before.
>>
>> As I said it cleanly worked with 2 OFBiz instances running in the
>> background.
>>
>> Now tell me what's wrong?
>>
>> Thanks
>&g
line contains "a start" the 1st "if" try to terminate it.
>>>
>>> If it worked the 2nd "if" does not execute. This is better than before
>>> because it allows the "'start" process "a chance to clean up after itself
without
>> endless ping-pong here on the mailing lists:
>>
>> 1. revert the change as requested
>>
>> 2. provide a Jira with patch and review/discuss it there (what's the
>> problem, how should it be solved etc.)
>>
>> 3. come to a conclusion
sleep(5000)
}
Again, this shows you how poor the quality of this code is. It introduces a
subtle bug, it repeats an if condition unnecessarily, and the comments are
wrong "Only kill if needed"
On Sun, Jun 25, 2017 at 4:22 PM, Taher Alkhateeb wrote:
> I'm completing my answer for
+1 for switching the website to the new one and completing it as we go.
We should try to automate publishing the website. One solution is to
publish the website as is. Another solution is to restructure the
website so that only the "generated" stuff gets published to the
server. So the directory s
x27;d really like to send SIGTERM before killing the
process and only kill it if it's necessary (ie if SIGTERM did not terminate
the process)
So we need to catch the SIGTERM exec and send SIGKILL if it fails, right?
Jacques
Le 25/06/2017 à 16:05, Taher Alkhateeb a écrit :
> Oh and to prov
I think the buildbot scripts might be faulty. I'll work on refactoring
it to at least start using the embedded gradle wrapper with
--no-daemon flag. We need to slowly isolate all causes
On Mon, Jun 26, 2017 at 11:29 AM, Michael Brohl
wrote:
> Done in https://issues.apache.org/jira/browse/OFBIZ-94
review
>
> Jacques
>
>
> Le 26/06/2017 à 09:37, Jacques Le Roux a écrit :
>>
>> OK, the shutdown command is somehow our SIGTERM, makes sense
>>
>> Jacques
>>
>>
>> Le 26/06/2017 à 08:45, Taher Alkhateeb a écrit :
>>>
>>> I do not
Hi, I believe this email is better asked on the user mailing list.
On Tue, Jun 27, 2017 at 8:13 PM, Heidi Dehaes - Olagos
wrote:
> Hello,
>
> Can anyone give me a hint on how the price which is visualised at a product
> in the ecommerce site comes into the cart object for visualisation on the
> c
Hi Sharan, All
I think at some point we should consider maybe ignoring the generated
HTML files from the repository given that these are just generated
replaceable documents. The real important documents are the templates.
On Wed, Jun 28, 2017 at 12:39 PM, wrote:
> Author: sharan
> Date: Wed Ju
working with all of you.
Cheers,
[1] https://cwiki.apache.org/confluence/display/OFBIZ/Re-Factor+To-Do+List
[2] https://s.apache.org/jB5f
Taher Alkhateeb
On Thu, Jun 29, 2017 at 1:13 AM, Scott Gray
wrote:
> Hi Taher,
>
> I can understand your frustration, but this:
>
>>
the code clean while some code changes are under scrutiny or
>> discussion; it also helps to but time to discuss (community discussions
>> take time); the commit history will be also improved because, after the
>> community review, the commit will represent a fully reviewed feat
Yeah I saw that too. Awesome work Deepak
On Jun 30, 2017 10:34 AM, "Sharan Foga" wrote:
> Hi Everyone
>
> I'm not sure if you saw the announcement for the ASF Annual Report that
> was published. I took a quick look through it and saw that on page 25 our
> OFBiz dev list has been listed as one of
Very cool, thanks for sharing. Maybe we should link this to the OFBiz
youtube channel.
It was kind of emotional to see Adrian Crum's name in there.
On Jul 2, 2017 4:37 AM, "Michael Brohl" wrote:
> I played with Gource and made a video of 11 years of OFBiz, from 2006
> until now.
>
> Have fun: h
This is a classic "hidden dependency" because of some sort of "global
state". I'm glad we're facing this problem because it shows the value
of separating the project into two repos.
I checked the logs and I think it would take a while to see exactly
where that null reference is coming from. So I t
I agree with Michael, baby steps for the win. I propose we perhaps
just postpone "big ideas" for now and focus on things that can get
results quickly to put life back into this initiative. Maybe next
actions could be the following:
- Create a base theme
- Move all artifacts from framework/images t
it to
> implement a new UI. It will be a lot of work and a big effort for us but I
> think it's worth it. We'll see how this will work out and how we can
> contribute this back to the project.
>
> Best regards,
>
> Michael Brohl
> ecomify GmbH
> www.ecomify.de
&
s,
Michael
Am 04.07.17 um 23:50 schrieb Taher Alkhateeb:
Hi Michael,
>
> I think we agree, just a difference in semantics. What I mean by web
> is anything CSS, JavaScript, or HTML, not FreeMarker (for now). The
> smaller the effort the bigger the chances to move this initiative
>
I faced something similar in the past (Not related to OFBiz). Many
systems require different paths of configuration depending on
different deployment scenarios.
There are multiple types of configurations I can think of including:
- platform dependent configurations (it depends on your server and t
Fantastic initiative Michael, +1
I think a simple attachment in jira or a wiki page will suffice. A
one-time scan would provide more than enough information for everyone
who needs to work on stuff. We can run it again in the future when
enough bugs have been tackled.
On Fri, Jul 7, 2017 at 1:43 P
Hello Pallavi,
All good questions, but I think it's better to start this thread in
the user ML as it is more appropriate to ask that question over there.
Cheers,
On Sat, Jul 8, 2017 at 12:08 PM, Pallavi Goyal wrote:
> Hello Devs,
>
> I was exploring the Communication Events in "Party" component
Big +1, thank you for the initiative.
I wish everyone reading this to take an active role too, there is so
much refactoring needed in the project and we need your help. It's not
hard to find an area you're comfortable with and start cleaning it up
a bit.
On Sat, Jul 8, 2017 at 12:16 PM, Michael B
Hi Jacques,
Can you elaborate on this a little bit? Maybe there is a bug we can
fix. What happens exactly? it never shuts down? takes a while? error
logs?
On Sun, Jul 9, 2017 at 1:40 PM, wrote:
> Author: jleroux
> Date: Sun Jul 9 10:40:36 2017
> New Revision: 1801365
>
> URL: http://svn.apache
By fail you mean that it does not stop? or that it stops with an error
exit code?
On Sun, Jul 9, 2017 at 2:19 PM, Jacques Le Roux
wrote:
> Hi Taher,
>
> It randomly fails, I did not reproduce locally but I did less tries locally.
>
> Jacques
>
>
>
> Le 09/07/2017 à 12:
Hello Everyone,
For a long time I was annoyed by something in OFBiz: the build system
does not fail if data loading fails for some files. I spend hours
hunting bugs only to discover that the data simply did not load.
Given that I'm working on refactoring the data loading container, I
believe this
Correction: on item (2) in my post: fail immediately, not after
loading all files, otherwise there's no point.
On Sun, Jul 9, 2017 at 10:18 PM, Taher Alkhateeb
wrote:
> Hello Everyone,
>
> For a long time I was annoyed by something in OFBiz: the build system
> does not fail if d
on 3. I recall in my own work I once needed to add a throw
where there was none to track down a problem.
However ignore-failure leads to a double negative. How about
"stop-on-failure", default value true?
Cheers
Paul Foxworthy
On 10 July 2017 at 05:27, Taher Alkhateeb
wrote:
> C
t; I agree with option 3. I recall in my own work I once needed to add a
>> throw
>> > where there was none to track down a problem.
>> >
>> > However ignore-failure leads to a double negative. How about
>> > "stop-on-failure", default
, 2017 at 1:45 PM, Devanshu Vyas
wrote:
> I agree with option #3 and the 'continue-on-failure' flag with default
> value=false. :)
>
> Thanks & Regards,
> Devanshu Vyas.
>
> On Mon, Jul 10, 2017 at 3:07 PM, Taher Alkhateeb > wrote:
>
>> Hi Rishi,
>
ontinue-on-failure"
On Mon, Jul 10, 2017 at 2:14 PM, Taher Alkhateeb
wrote:
> Thank you everyone for your feedback, I will let this discussion
> continue for a few days before committing anything (testing is going
> to take some time anyway).
>
> Now, I need help, I have a big
17 at 8:14 PM, Taher Alkhateeb
wrote:
> Quick update, to my surprise an exception is swallowed
> dp in the call stack. So getting this
> feature might require some intrusive changes. I'm still working on it
> and will keep you posted, but as of right now,
o speak about swallowed exceptions ;)
>
> I still want to continue on OFBIZ-8341 but accepted to get sidetracked in
> multi ways :)
>
> Jacques
>
>
>
> Le 10/07/2017 à 21:36, Taher Alkhateeb a écrit :
>>
>> Fixed it in the JIRA, the EntitySaxReader (should be th
If there is a JIRA with exact repeat steps then I would be interested
in working on this issue as it sounds like a good place to do some
proper refactoring on many moving parts.
On Wed, Jul 12, 2017 at 12:08 PM, Arun Patidar
wrote:
> Hello All,
>
> I was trying to load test OFBiz with huge number
is proposal? Does it sound reasonable? Also
given the size of what I'm proposing I think we need multiple people
to work on this. So is anyone interested in taking part in this
initiative?
Cheers,
Taher Alkhateeb
[1] https://issues.apache.org/jira/browse/OFBIZ-9322
[2]
https://lists.apache
se to me.
>
> Would any plugin defining custom entities also have a similar /data tree?
>
> Cheers
>
> Paul
>
>
> On 14 July 2017 at 19:59, Taher Alkhateeb
> wrote:
>
>> Hello Everyone,
>>
>> Data loading in OFBiz is quite fragile. A small chang
Hi Nicolas,
Great stuff, I'm not sure what everyone thinks but I prefer if we can
try to get your work incorporated back into the code base as early as
possible and to start completing the work from there.
On Tue, Jul 18, 2017 at 5:38 PM, Nicolas Malin wrote:
> Michael,
>
> I finished to restore
cussed.
> It would be good for instance for a type of exception and a type of file
> (service, event, helper/handler/test/etc.) to use and adopt a same type of
> exception handling."
>
> Having patterns would help everybody, when creating, reviewing, refactoring,
> etc.
>
any volunteers to commit or provide patches are more than welcomed.
[1] https://issues.apache.org/jira/browse/OFBIZ-9501
On Tue, Jul 18, 2017 at 6:57 PM, Nicolas Malin wrote:
> +1
>
>
>
> Le 14/07/2017 à 11:59, Taher Alkhateeb a écrit :
>>
>> Hello Everyone,
>>
Hello Gil,
Thank you for working on this. I have reviewed the patch and I have a few notes:
First for gradle, I don't think you need to fetch environment
variables. You can do whatever you want by passing flags, which might
be a simpler solution. So you create your own script and modify gradle
fo
s.com
> www.hotwax.co
>
> On Thu, Jul 20, 2017 at 12:15 PM, Taher Alkhateeb <
> slidingfilame...@gmail.com> wrote:
>
>> Thank you all for your feedback and votes. I just counted 12 positive
>> votes to go ahead.
>>
>> I have created a JIRA [1] for this task
Wonderful :) looking forward to getting this thing done
On Thu, Jul 20, 2017 at 11:31 AM, Devanshu Vyas
wrote:
> Hello Taher,
>
> I would like to work on to provide patches for this effort.
>
> Thanks & Regards,
> Devanshu Vyas.
>
> On Thu, Jul 20, 2017
+1
DRY is my favorite principle. Sometimes I wish if the keyboard would zap
developer fingers when performing a copy-paste :)
On Jul 22, 2017 10:33 AM, "Vaibhav Jain"
wrote:
> Hello Pallavi,
>
> Yes, we can create error message UI labels in CommonErrorUiLabels.xml for
> the common errors (like
Interesting I didn't know that! Makes the code less verbose. If this is
safe to use then maybe it's better to adopt it in all the code base
On Jul 22, 2017 12:27 PM, "Deepak Dixit"
wrote:
> Hi Arun,
>
> I think its not typo, java8 provide type interface for generic class
> instantiation, you mus
Hi Ujjawal,
Sorry maybe I lost track, but what are you recommending?
On Sat, Jul 22, 2017 at 3:26 PM, Ujjawal Solanki
wrote:
> Hello all,
> I was going through ServiceUtil.java and found that there is a method
> called setServiceFields ( whose purpose is to take in in parameter of a
> service an
Hi Gil, good feedback, inline ...
On Mon, Jul 24, 2017 at 10:17 AM, gil portenseigne
wrote:
> Hello Taher,
>
> My thoughts inline :)
>
>
> On 20/07/2017 09:05, Taher Alkhateeb wrote:
>>
>> Hello Gil,
>>
>> Thank you for working on this. I have re
Hi Nicolas,
Have you considered reusing / enhancing the ofbiz-component.xml model
or do you find it insufficient?
On Sun, Jul 23, 2017 at 2:40 AM, Nicolas Malin wrote:
> Hello,
>
> With the common-theme and my idea to implement a specific model to explain a
> theme, I would be sharing my recent
t; design so far, to ask for a little more help doing that. So once that is
> done, pending any other feedback, I think we could be ready to publish.
>
> Thanks
> Sharan
>
>
> On 2017-06-25 18:54 (+0200), Taher Alkhateeb
> wrote:
>> +1 for switching the website
heme.xml on the component root but I think It can move
> on component/widget directory.
>
> Nicolas
>
>
> Le 26/07/2017 à 08:03, Taher Alkhateeb a écrit :
>>
>> Hi Nicolas,
>>
>> Have you considered reusing / enhancing the ofbiz-component.xml model
>> or do you find it insufficient?
>
>
I agree with the suggested naming convention and proposed work.
Naturally it should be done carefully and slowly.
With that being said, since this discussion is getting traction, I
would suggest that If you are willing to make the effort towards
naming all these services then you might as well con
ully write in a
more comprehensive thread, but I'm just not sure if people are
interested in going that route
On Wed, Aug 2, 2017 at 10:24 AM, Paul Foxworthy wrote:
> On 2 August 2017 at 16:37, Taher Alkhateeb
> wrote:
>
>> If you are willing to make the effort towards
>>
Taher,
> >>
> >> I think we can keep both work independent, as it will be very messy if
> we
> >> do renaming/cleaning and movement in single shot.
> >>
> >> Thanks & Regards
> >> --
> >> Deepak Dixit
> >> www.hotw
Hi Paul,
I will start a new thread later on to keep this one focused like others
suggested. I should take my time and really develop the idea and then share
it on the ML.
Cheers,
On Aug 4, 2017 5:17 AM, "Paul Foxworthy" wrote:
> On 2 August 2017 at 18:14, Taher Alkhateeb
> w
gs seem to
be going smooth. If anyone wants to review before I commit please go
ahead and raise your hand!
Cheers,
Taher Alkhateeb
On Thu, Jul 20, 2017 at 9:34 AM, Taher Alkhateeb
wrote:
> Hi folks, I know it's a big patch, but it would be really great if
> someone can take a look at
t be (something else is used I guess) but I did not check
>
> Jacques
>
>
>
> Le 04/08/2017 à 08:52, Taher Alkhateeb a écrit :
>>
>> Hello everyone,
>>
>> So I didn't get feedback for quite a while, probably because the patch
>> is large. However, I th
Hmmm I am not sure if comments are the most appropriate form for
deprecation. Usually deprecation is useful when it is programmatic because
it goes beyond raw text to logging warnings and highlighting by tools. You
want the system to constantly remind you (both the developer and author) to
get rid
Congratulations Akash.
On Wed, Aug 9, 2017 at 1:17 PM, Ankit Joshi
wrote:
> Many Congratulations Akash :)
>
> Thanks,
> Ankit Joshi
>
> On Wed, Aug 9, 2017 at 3:29 PM, Divesh Dutta > wrote:
>
>> Congratulations Akash.
>>
>> Thanks
>> --
>> Divesh Dutta
>>
>> On Wed, Aug 9, 2017 at 2:28 PM, Sharan
Congratulations Rishi :) Now we have someone to push the data
migration thingy :)
On Wed, Aug 9, 2017 at 1:25 PM, Ankit Joshi
wrote:
> Many Congratulations Rishi!! :-)
>
> Regards,
> Ankit Joshi
>
> On Wed, Aug 9, 2017 at 3:51 PM, Humera Khan
> wrote:
>
>> Many Congratulations Rishi :)
>>
>> *Hu
This is managed by gradle so the .project file is irrelevant. We would
need to adjust the value of "rootProject.name" in "settings.gradle"
With that being said, I'm not sure why we would need to change the
name? Yes the repo is ofbiz-framework but the project could contain
other plugins. I'm not s
+1, thank you for the initiative
On Sat, Aug 19, 2017 at 12:10 PM, Jacques Le Roux
wrote:
> I just can say: +1
>
> Jacques
>
>
>
> Le 19/08/2017 à 10:50, Michael Brohl a écrit :
>>
>> Hi Pranay,
>>
>> this is a great initiative and I'm looking forward to it!
>>
>> Big +1
>>
>> Regards,
>>
>> Mich
Like Michael, I also prefer to include the work into the code base and
test it over there. It seems like you put a lot of effort into this
code so thank you! I like the fact that you brought all the artifacts
into the theme along with the FTL macros. This is a good first step,
and I believe continu
I'm not sure I understand the purpose of the .project file? Plugins
are not a standalone project. Perhaps I'm missing something?
On Fri, Aug 11, 2017 at 3:13 PM, wrote:
> Author: jleroux
> Date: Fri Aug 11 12:13:43 2017
> New Revision: 1804782
>
> URL: http://svn.apache.org/viewvc?rev=1804782&vi
gt;>> ---
>>> Arun Patidar
>>> Manager, Enterprise Software Development
>>>
>>>
>>> HotWax Systems Pvt Ltd.www.hotwaxsystems.com
>>>
>>>
>>> On Wed, Jul 12, 2017 at 5:45 PM, Arun Patidar <
>>> arun.pati...@hotwax
oughts about how to automatically
> create the relationship between the 2 projects in the eclipse Gradle task.
>
> Jacques
>
>
>
> Le 19/08/2017 à 14:18, Taher Alkhateeb a écrit :
>>
>> I'm not sure I understand the purpose of the .project file? Plugins
>> are
macro and screen but not
> manage correctly the VisualTheme concept.
>
> So I will take care about this, complete the documentation and commit on
> trunk.
>
> Nicolas
>
>
> Le 19/08/2017 à 14:14, Taher Alkhateeb a écrit :
>>
>> Like Michael, I also prefer to
et at least those changes in before publishing.
> >
> > I've noted your feedback and agree these are good points that can
> improve the site so will look at those. If I can incorporate some before
> publishing then I will, otherwise we can do it as an ongoing thing once the
> new si
201 - 300 of 1779 matches
Mail list logo
