Re: buildbot failure in on ofbizTrunkFrameworkPlugins

2018-01-11 Thread Taher Alkhateeb
So it seems like we have faulty buildbot scripts again. I feel inclined to rewrite them from scratch. Anyone interested in helping out? On Jan 11, 2018 3:16 PM, wrote: > The Buildbot has detected a new failure on builder > ofbizTrunkFrameworkPlugins while building . Full details are available at

renaming common theme component

2018-01-12 Thread Taher Alkhateeb
Hi everyone, I noticed something that is problematic. framework/common and themes/common are both components within OFBiz and I faced a few problems because of that. The name of the component in framework/common is common whereas the name of the other component is common-theme. I propose renamin

Re: [Discussion] documentation framework for OFBiz

2018-01-12 Thread Taher Alkhateeb
, 2017 at 11:01 AM, Taher Alkhateeb wrote: > Hello Folks, > > We've had this discussion multiple times in the past, but I think I > have a more concrete idea this time for solving this problem. In the > past few weeks we've been working internally in Pythys to figure out &g

Re: renaming common theme component

2018-01-12 Thread Taher Alkhateeb
mes/commons > would be enough? > > Jacques > > > > Le 12/01/2018 à 17:10, Taher Alkhateeb a écrit : >> >> Hi everyone, >> >> I noticed something that is problematic. framework/common and >> themes/common are both components within OFBiz and I faced a

Re: renaming common theme component

2018-01-12 Thread Taher Alkhateeb
05 PM, "Nicolas Malin" wrote: > When I created this component I have been hesitate to create > theme/common-theme or theme/common. The first is seem more redundancy than > the second. It's the only reason so if you have a better reason, feel free > :) > > Nico

Re: [Discussion] documentation framework for OFBiz

2018-01-15 Thread Taher Alkhateeb
tegration you > provide, this week-end. > > That's quite simple, i like it, i will play a bit more with it to find the > good way to links docs files between them. > > Thanks ! > > Gil > > > > On 12/01/2018 17:36, Taher Alkhateeb wrote: >> >> Hello

Re: Gradle cleanAll and eclipse tasks

2018-01-16 Thread Taher Alkhateeb
Every time you create a new package or change the structure of packages you need to run the gradle eclipse task to repopulate the classpath. And to do that you need to delete the eclipse files first On Jan 16, 2018 11:09 AM, "Jacques Le Roux" wrote: > Hi Taher, All, > > Could we not delete the .

Re: Gradle cleanAll and eclipse tasks

2018-01-16 Thread Taher Alkhateeb
iles was a real pain. On Tue, Jan 16, 2018 at 12:46 PM, Jacques Le Roux wrote: > But then it's regenerated, right? > > Because, if I'm not wrong, the only trouble I have in Eclipse, and need to > run the eclipse task again, is after I ran cleanAll, right? > > Jacques > &

Re: [Discussion] documentation framework for OFBiz

2018-01-17 Thread Taher Alkhateeb
is a brain dump so I leave it to you fine folks to refine the ideas and decide where we should go. Cheers, Taher Alkhateeb On Wed, Jan 17, 2018 at 6:08 PM, Craig Parker wrote: > I think the doc structure ought to mirror the menu in the software, or are > you talking about how a doc itself

Re: [Discussion] documentation framework for OFBiz

2018-01-17 Thread Taher Alkhateeb
, Jan 17, 2018 at 6:54 PM, Taher Alkhateeb wrote: > So I have thought of a few ways to implement our documentation > structure and I would like to share my ideas with everyone to see what > you prefer to go with. Here goes: > > - First, let's categorize documentation as: >

Re: [Discussion] documentation framework for OFBiz

2018-01-17 Thread Taher Alkhateeb
er docs are you? > > > > On 01/17/2018 10:54 AM, Taher Alkhateeb wrote: >> >> So I have thought of a few ways to implement our documentation >> structure and I would like to share my ideas with everyone to see what >> you prefer to go with. Here goes: >>

Re: Style tag for Widgets

2018-01-19 Thread Taher Alkhateeb
The widget system as I understand is a DSL for rendering user interfaces regardless of the underlying technology. So HTML is only one output. Introducing styles might create coupling between the widget system and HTML. We have been working hard to completely disentangle web from widget such as mov

Re: renaming common theme component

2018-01-21 Thread Taher Alkhateeb
, 2018 at 8:58 AM, Deepak Dixit wrote: > +1 Make sense, we can rename it to common-theme > > Thanks & Regards > -- > Deepak Dixit > www.hotwaxsystems.com > www.hotwax.co > > On Sat, Jan 13, 2018 at 1:03 AM, Taher Alkhateeb > wrote: > >> The name is perfectly f

Re: select your pdf document template from organizational party

2018-01-25 Thread Taher Alkhateeb
Hi Nicolas, The concept sounds interesting, but I'm having a bit of difficulty understanding the design from your explanation. Perhaps a JIRA with a PoC patch might help put it in perspective. But overall I like the general idea of allowing overridden PDF templates. On Tue, Jan 23, 2018 at 11:10

Re: [Discussion] documentation framework for OFBiz

2018-01-25 Thread Taher Alkhateeb
aybe recover some >>>> documentation content from various sources including our existing online >>>> help system and the wiki. >>>> >>>> The documentation structure will maybe need some thought, and we may >>>> need to sort out some common template o

Re: [Discussion] documentation framework for OFBiz

2018-01-28 Thread Taher Alkhateeb
Like Michael I think it is also a minor point. The reason I chose this structure is because it is the default one for asciidoctor and is flexible for the future, so Paul also makes a good point. Any structure is fine by me, the real important work is getting the documentation right which is very ex

Re: OFBiz and Google Summer of Code (GsoC) 2018 ?

2018-01-28 Thread Taher Alkhateeb
Hi Michael, Sharan, all I would volunteer as a mentor. Michael raised a good point regarding the complexity level of the tasks assigned to these participants. So the question is, what kind of tasks are suitable for such students? It's hard to think of logic simpler than writing some documentation

[Proposal] Reducing the clean* operations in gradle

2018-01-29 Thread Taher Alkhateeb
Hello Everyone, I'm not sure why we have so many fine-grained clean tasks, but to reduce clutter, I suggest to have only the following clean operations in build.gradle: - cleanCatalina: To reset web server state to test stuff - cleanData: To reset database state to test stuff - cleanAll: To remove

Re: Oracle Java release model changes and consequences for the project

2018-01-30 Thread Taher Alkhateeb
If I understood the documentation correctly, we have to choose between two different packages: - Stable release (long term support, less features) - Feature release (short term support, more features) Of the two, I think the stable LTS seems to be more compatible with our own release cycle. Also w

Re: [Proposal] Reducing the clean* operations in gradle

2018-01-30 Thread Taher Alkhateeb
strong opinion so your proposal seems to be good for slim the >> code. >> >> A noob question, can we move deleted tasks to the tools folder like ant >> previously ? >> >> Nicolas >> >> >> On 29/01/2018 11:31, Taher Alkhateeb wrote: >>> &

Re: Oracle Java release model changes and consequences for the project

2018-01-30 Thread Taher Alkhateeb
wise to me, maybe we can try Java 9 though, to not get too much > things to do later? > > Jacques > > > > Le 30/01/2018 à 17:49, Taher Alkhateeb a écrit : >> >> If I understood the documentation correctly, we have to choose between >> two different package

Re: Oracle Java release model changes and consequences for the project

2018-01-30 Thread Taher Alkhateeb
versions. To get security updates, > these users have to change their version every half year. > > It's difficult to say if you will have compatibility problems beetween those > public versions but it is possible. > > Regards, > > Michael > > > Am 30.01.18 um 18:

Re: [Proposal] Reducing the clean* operations in gradle

2018-01-30 Thread Taher Alkhateeb
te: > Hi Taher, > > Excellent work on gradle! I like your pluginLibsCompile very much. > > Inspired by the pluginLibsCompile, is it possible to define a new clean > plugin in build.gradle of a component to clean a log or index folder? > > Kind Regards, > > Shi Jing

Re: Oracle Java release model changes and consequences for the project

2018-01-31 Thread Taher Alkhateeb
I suspect that there is no difference between openjdk and oracle jdk as far as the release cycle because oracle steers both. However, like Jacopo I am not too concerned. The quick release cycle they want to adopt means that there will be perhaps less drastic changes between the versions. I am ope

Re: [Proposal] Reducing the clean* operations in gradle

2018-01-31 Thread Taher Alkhateeb
s, they provide some flexibility. If we want to reduce them though, I'm in favor of keeping cleanIndexes too. Regards, Michael Am 30.01.18 um 17:54 schrieb Taher Alkhateeb: Hi Jacques, > > Sure okay, we can keep cleanLogs and cleanFooterFiles. Any other > opinions folks? Does anyone ca

Re: [Proposal ]OR search criteria within performFind

2018-02-01 Thread Taher Alkhateeb
Hi, perhaps if you share the idea of how to translate it to the entity engine conditions then we'd be better informed? On Feb 1, 2018 6:30 PM, "gil portenseigne" wrote: > Hello, > > In a customer project we met a very specific need in a search screen that > offer search criteria that must unions

Re: [Proposal] OR search criteria within performFind

2018-02-02 Thread Taher Alkhateeb
dition, field2Condition), EntityOperator.OR)); I hope this will be clearer. On 01/02/2018 21:07, Taher Alkhateeb wrote: > Hi, perhaps if you share the idea of how to translate it to the entity > engine conditions then we'd be better informed? > > On Feb 1, 2018 6:30 PM, "gi

Re: [Proposal] OR search criteria within performFind

2018-02-02 Thread Taher Alkhateeb
Oh okay I understand. Well .. in that case how do you "OR" conditions in the form? Do you do it selectively or do you want all "OR" or all "AND"? On Feb 2, 2018 1:26 PM, "gil portenseigne" wrote: > Inline > > > On 02/02/2018 11:04, Taher

Re: [Proposal] OR search criteria within performFind

2018-02-02 Thread Taher Alkhateeb
ntityOperator.OR) > > EntityCondition.makeCondition( > UtilMisc.toList(field4Condition, field5Condition), EntityOperator.OR) > > These will be "AND" with the others... (6 and 7) > > Indeed that's a bit ugly... but that do the job, and like I said, it's a > pretty rar

Re: [Proposal] OR search criteria within performFind

2018-02-03 Thread Taher Alkhateeb
l, I'll wait for your work, if you need extra hands for anything just holler. On 02/02/2018 15:47, Taher Alkhateeb wrote: > May I try to share a design that might be a bit more generic? Here is one > idea: > > > > > > > Then we change the find services so that

Re: OFBiz and Google Summer of Code (GsoC) 2018 ?

2018-02-05 Thread Taher Alkhateeb
Thank you Sharan. Given Michael's feedback, I'm listing here (very briefly) a few quick ideas for GSoC: - Translations to any languages the students are fluent in. - Adding time-attendance functionality for the HR module. - Improving the workflow and functionality for the marketing module (leads,

Re: [DISCUSSION] The Simple Map Processor Mini-Language

2018-02-07 Thread Taher Alkhateeb
I propose a feature freeze on anything related to minilang. Let's just fix bugs and try to slowly move out. On Feb 7, 2018 11:36 AM, "Rishi Solanki" wrote: > Jacques, > As far as I remember when you raised this in past, and no proposal on how > to replace it. > As simple map processor is used fo

Re: [Proposal] OR search criteria within performFind

2018-02-07 Thread Taher Alkhateeb
test, when i'll find the time. Just letting you know i am on it :). Gil On 03/02/2018 10:17, Taher Alkhateeb wrote: > Not really, you just add an if condition to check if any search groups > exist, and if they do then apply the additional search logic. >

Re: Overriding eca definition

2018-02-12 Thread Taher Alkhateeb
I was actually thinking of the same thing, I like to have more sophistication in the conditions to create more robust graphs of service calls. +1 On Mon, Feb 12, 2018 at 12:08 PM, Arun Patidar wrote: > +1 for condition service attribute. > > -- > Thanks & Regards > --- > Arun Patidar > Manager,

Re: [OFBIZ-4959] Logout do not remove autoLogin

2018-02-12 Thread Taher Alkhateeb
I just checked this code and it looks really worrying to me. You have hard wired the ecommerce component with logic into the heart of the framework, I think we need to review the entire body of work and maybe revert it. On Sat, Feb 10, 2018 at 2:38 PM, Jacques Le Roux wrote: > Le 10/02/2018 à 12:

Re: Deprecate properties in favour of SystemProperties [ was Re: Sending mail from Ofbiz does not work]

2018-02-16 Thread Taher Alkhateeb
That could be probably an incredibly dangerous and complexity-inudcing idea. Imagine what you are suggesting, a massive state machine, implied and not explicit (a massive global collection of variables). In my opinion explicit is always better than implicit and we should strive to actually reduce

Re: Deprecate properties in favour of SystemProperties

2018-02-18 Thread Taher Alkhateeb
I agree, the two serve entirely different purposes. Multi tenancy simply means different databases sharing the same code base. If any differences in configuration are substantial enough, then this is when you consider two or more instances instead of multi-tenancy. I don't favor multi-tenancy gene

Re: [OFBIZ-4959] Logout do not remove autoLogin

2018-02-18 Thread Taher Alkhateeb
sure the webpos really > implements it, like ecommerce does. > So we could remove webpos from the keep-autologin-cookie list. > I'll check that. > > If it's really needed, as the autologin-cookie feature just remembers you > but does not sign you automatically (you

Re: [OFBIZ-4959] Logout do not remove autoLogin

2018-02-19 Thread Taher Alkhateeb
for webpos before using true there. > > Thanks > > Jacques > > > Le 18/02/2018 à 11:43, Taher Alkhateeb a écrit : > >> Hi Jacques, >> >> I don't think your proposed solution works either. It seems you might >> be missing the underlying problem.

Re: svn commit: r1824889 - /ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java

2018-02-20 Thread Taher Alkhateeb
It might be useful to relax and take a little break Jacques since you mentioned in another thread that you're having a bit of a rough day. It might not be a great idea to code when you are in a sour mood. I suggest to just revert this and come back to it later when you feel refreshed. On Tue, Feb

Re: [Discussion] documentation framework for OFBiz

2018-02-20 Thread Taher Alkhateeb
it put into the documentation framework (and this work will then > significantly clear up the wiki!). > > My availability is pretty bad this week so hope to pick this up again or > start the recruitment campaign next week :-) > > Thanks > Sharan > > On 2018/01/28 1

Re: [OFBIZ-4959] Logout do not remove autoLogin

2018-02-21 Thread Taher Alkhateeb
t; Le 19/02/2018 à 20:57, Michael Brohl a écrit : > >> +1 >> >> We are discussing this over and over again. I wonder what's so difficult >> to stick to some basic rules of collaboration. >> >> >> Am 19.02.18 um 20:48 schrieb Taher Alkhateeb: >>

Re: updatePostalAddress, updateTelecomNumber (contactMechs) missnamed ?

2018-02-23 Thread Taher Alkhateeb
perhaps updatePostalAddressWithHistory On Fri, Feb 23, 2018 at 5:41 PM, gil portenseigne wrote: > Hello, > > While working on a new contactMech type (no spoiler yet, that will come in > some days ;)), I wanted to develop the CRUD services , and stumbled upon > something that bother me. > > Actual

Re: [Discussion] documentation framework for OFBiz

2018-02-24 Thread Taher Alkhateeb
n the current directory and in the _include one. >>> The generateOfbizDocumentation task doesn't use the same rule, we should >>> say explicitly it's in the _include directory. >>> >>> The main "malfunction" of the generateOfbizDocumentation ta

Re: [Discussion] documentation framework for OFBiz

2018-02-24 Thread Taher Alkhateeb
enough to only define a convention, like an include directory > below each documentation folder? > > src / docs / asciidoc / includes > > ord maybe > > src / docs / includes > > if they should be reusable also with other documentation frameworks? > > > Am 24.02.18

Lookup fields not working

2018-02-25 Thread Taher Alkhateeb
Hi Folks, I could be wrong, but it seems the lookup fields are not working due to recent commits. The button to initiate the lookup popup window does not even appear. Anyone else experiencing this?

Re: Lookup fields not working

2018-02-25 Thread Taher Alkhateeb
> buttons are affected, the calendar lookup buttons are displayed. > > Do you have a suggestion which commit caused this? > > Regards, > > Michael > > > Am 25.02.18 um 20:58 schrieb Taher Alkhateeb: > >> Hi Folks, >> >> I could be wrong, but it seem

Re: Lookup fields not working

2018-02-25 Thread Taher Alkhateeb
> We experienced this last week so the changes from this weekend cannot be >> the cause (if it is the same effect). >> >> >> Am 25.02.18 um 21:48 schrieb Taher Alkhateeb: >> >>> Yeah I am not sure, but it might be related to some work by Deepak in >&g

Re: Lookup fields not working

2018-02-25 Thread Taher Alkhateeb
if its not working will debug it. Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com www.hotwax.co On Mon, Feb 26, 2018 at 3:11 AM, Taher Alkhateeb wrote: > Yeah .. just tested using the un-minified version and that seems to resolve > part of the issue. I still get some weird alert popups

Re: Lookup fields not working

2018-02-25 Thread Taher Alkhateeb
:53 AM, Deepak Dixit wrote: > Yes, with minified, > > > > Thanks & Regards > -- > Deepak Dixit > www.hotwaxsystems.com > www.hotwax.co > > On Mon, Feb 26, 2018 at 12:01 PM, Taher Alkhateeb < > slidingfilame...@gmail.com> wrote: > >> Hi

Re: orderSkipInvoice, complete an order without generating an invoice

2018-02-26 Thread Taher Alkhateeb
Hi Antoine, Thank you for your work and I hope we get to work with you more often. I have a few comments / questions: - First of all, you added a postgres dependency to the build file (probably by mistake?). - perhaps others can pitch in but I'm not sure if it is useful to introduce? Is this a co

Re: svn commit: r1825350 - in /ofbiz/ofbiz-framework/trunk: framework/common/src/main/java/org/apache/ofbiz/common/ framework/widget/dtd/ framework/widget/src/main/java/org/apache/ofbiz/widget/model/

2018-02-26 Thread Taher Alkhateeb
Hi Gil, Great work so far. However, I seem to be facing a bug. I list the error below that shows in almost every form: When calling macro "renderHiddenField", required parameter "conditionGroup" (parameter #2) was not specified. Tip: If the omission was deliberate, you may consider making th

Re: svn commit: r1825350 - in /ofbiz/ofbiz-framework/trunk: framework/common/src/main/java/org/apache/ofbiz/common/ framework/widget/dtd/ framework/widget/src/main/java/org/apache/ofbiz/widget/model/

2018-02-26 Thread Taher Alkhateeb
> Gil > > > > On 26/02/2018 15:00, gil portenseigne wrote: >> >> Hello Taher, >> >> Oww, i might have missed something :( , i'll look at it very soon ! >> >> Gil >> >> >> On 26/02/2018 14:52, Taher Alkhateeb wrote: >>&

Re: buildbot exception in on ofbizTrunkFramework

2018-02-27 Thread Taher Alkhateeb
Huh! very weird, all tests pass on my system. I will revert and investigate the logs. On Tue, Feb 27, 2018 at 1:44 PM, wrote: > The Buildbot has detected a build exception on builder ofbizTrunkFramework > while building . Full details are available at: > https://ci.apache.org/builders/ofbiz

Re: svn commit: r1825436 - /ofbiz/ofbiz-framework/trunk/framework/security/ofbiz-component.xml

2018-02-28 Thread Taher Alkhateeb
Hi Scott, yeah I reverted this commit. I realized that the reason for the crash is actually the order of writing the readers in the command line. There are still some issues in other areas of loading, so I need to study it a bit further. On Thu, Mar 1, 2018 at 12:46 AM, Scott Gray wrote: > Hi Ta

Re: Upgrade to latest Gradle version 4.6?

2018-02-28 Thread Taher Alkhateeb
Hi Michael, I see no problem in upgrading, we would however face a warning everytime we run a server task which I described in [1]. I have been thinking a lot of a solution and I think I am close to getting something done. So I would suggest yeah go for it and I will try to accelerate a solution

Re: [DISCUSSION] Moving the Documentation PoC into the Trunk

2018-03-02 Thread Taher Alkhateeb
I think the code will change very rapidly in the beginning until we settle and iron out all the kinks in the design. So I would recommend committing the code and then evolve as we go. So +1 On Mar 2, 2018 9:30 PM, "Sharan Foga" wrote: > Hi All > > I'd like to start the discussion about whether

[Discussion] Creating a unified service-library component

2018-03-04 Thread Taher Alkhateeb
o, etc ...) - Keep any services that are component-specific and do not operate on the generic data model in the component What do you think? Do you agree with the general idea? Can we do this in a better way? Anyone interested in helping out? Cheers, Taher Alkhateeb

Re: [Discussion] Creating a unified service-library component

2018-03-04 Thread Taher Alkhateeb
Hi Paul, Good points and questions. Inline ... On Mar 5, 2018 2:36 AM, "Paul Foxworthy" wrote: On 5 March 2018 at 00:45, Taher Alkhateeb wrote: > I think If you look at both the "data model" and "services" in OFBiz > you will notice the following: > >

Re: [Discussion] Creating a unified service-library component

2018-03-06 Thread Taher Alkhateeb
Hi Paul, Yeah I am proposing one big component to house all services. The reason is that it makes no sense in separating them because they are tightly coupled and depend on each other heavily (because they share the full data model) As I mentioned in my first email, we can perhaps create a new co

Re: [Discussion] Creating a unified service-library component

2018-03-07 Thread Taher Alkhateeb
-services.xml ├── party-services.xml ├── product-services.xml ├── shipment-services.xml └── workeffort-services.xml On Wed, Mar 7, 2018 at 3:27 PM, Paul Foxworthy wrote: > On 7 March 2018 at 16:57, Taher Alkhateeb > wrote: > > >> Yeah I am proposing one big comp

Re: [DISCUSSION] Moving the Documentation PoC into the Trunk

2018-03-08 Thread Taher Alkhateeb
Thank you all for your feedback and support. The PoC is committed to trunk in r1826199. Looking forward to the next steps On Sun, Mar 4, 2018 at 8:52 PM, Olivier Heintz wrote: > +1 > > Thanks > > Le 03/03/2018 à 10:00, Sharan Foga a écrit : >> +1 >> >> Actually I'm in favour of putting what we h

Re: svn commit: r1826200 [1/3] - in /ofbiz: ofbiz-plugins/trunk/birt/documents/ tools/wiki-files/ tools/wiki-files/BuildBot/ tools/wiki-files/birt/ tools/wiki-files/data-model/ tools/wiki-files/demos/

2018-03-09 Thread Taher Alkhateeb
I don't understand the purpose of this documentation file? And why are we adding more markdown files when we are preparing for the new documentation system? On Thu, Mar 8, 2018 at 10:30 PM, Michael Brohl wrote: > Thank you, Jacques. > > Regards, > > Michael > > > Am 08.03.18 um 20:15 schrieb Jacq

Re: svn commit: r1826200 [1/3] - in /ofbiz: ofbiz-plugins/trunk/birt/documents/ tools/wiki-files/ tools/wiki-files/BuildBot/ tools/wiki-files/birt/ tools/wiki-files/data-model/ tools/wiki-files/demos/

2018-03-10 Thread Taher Alkhateeb
be ok. Regards, Michael Am 09.03.18 um 11:55 schrieb Taher Alkhateeb: I don't understand the purpose of this documentation file? And why are > we adding more markdown files when we are preparing for the new > documentation system? > > On Thu, Mar 8, 2018 at 10:30 PM, Michael Brohl

Re: [Discussion] documentation framework for OFBiz

2018-03-12 Thread Taher Alkhateeb
_include directory. >>> >>> The main "malfunction" of the generateOfbizDocumentation task is that it >>> not re-generate the html file if it already exist >>> even if the main adoc file was modified. So it's needed to remove it >>> manually

Re: [Discussion] Creating a unified service-library component

2018-03-13 Thread Taher Alkhateeb
additional voices and opinions would also be great. If you have any concerns or questions I'd love to hear them. On Wed, Mar 7, 2018 at 4:15 PM, Taher Alkhateeb wrote: > Yes possibly folders, and more likely just file names. For example: > > service-library/ > ├── ofbiz-component.x

Re: [Discussion] documentation framework for OFBiz

2018-03-13 Thread Taher Alkhateeb
rate html file, but I'm not sure) >> >>> it's not necessary to say include file is in _include directory, it read >> >>> both in the current directory and in the _include one. >> >>> The generateOfbizDocumentation task doesn't use the same r

Re: [DOC] Welcome - Documentation Team

2018-03-13 Thread Taher Alkhateeb
Great work sharan. Maybe in the future we should be putting the HR umbrella task itself as a sub-task of the entire documentation umbrella task. This way when we branch out to other docs we know where to reference and group them. On Mon, Mar 12, 2018 at 7:33 PM, Sharan Foga wrote: > Hi All > > I’

Re: [DOC] Welcome - Documentation Team

2018-03-14 Thread Taher Alkhateeb
a documentation tickets into the one main umbrella task too. Like you say it will then be a single point of reference. It could also help us clean up some old issues that have been hanging around as they are absorbed into the documentation effort. Thanks Sharan On 2018/03/13 16:56:08, Taher Alkhateeb

Re: Demo Trunk Break

2018-03-15 Thread Taher Alkhateeb
Hi Rishi, I'm not getting any errors in the demo on my side? Could it be a web browser cache thing? I always fall in that trap myself. On Thu, Mar 15, 2018 at 10:59 AM, Rishi Solanki wrote: > It seems something specific with deployment/data at demo instance, locally > It is working. No issue with

Re: Demo Trunk Break

2018-03-15 Thread Taher Alkhateeb
> >>> Michael >>> >>> >>> Am 15.03.18 um 13:36 schrieb Jacques Le Roux: >>>> >>>> Ho, it would be convoluted, please wait, WIP... >>>> >>>> Jacques >>>> >>>> >>>> Le 15/03/2018

Re: Demo Trunk Break

2018-03-15 Thread Taher Alkhateeb
is morning it hanged at 91% I did not check more. > > This happens sometimes, not often, I'd say 15% of the time, I don't see > any reason > > Jacques > > > Le 15/03/2018 à 14:52, Taher Alkhateeb a écrit : > >> Can you be specific about "does not always be

Documentation tip - spaces between includes

2018-03-16 Thread Taher Alkhateeb
Hi Documentation team and everyone, Just a quick tip. I think It might be safer to keep spaces between "include" directives. If you stack include directives on top of each other, asciidoctor might get confused especially if the headers in these documents are of different levels. So for consistenc

Re: Demo Trunk Break

2018-03-18 Thread Taher Alkhateeb
parts in tools\demo-backup > > > > At least having a trunk and stable instance running on the same machine > > > > As it's random it will need several tries... > > > > Will you handle it? > > > > Jacques > > > > > > Le 15/03/2018 à 15:

Re: Documentation commits (.adoc file type)

2018-03-18 Thread Taher Alkhateeb
That was quick! Great work Michael On Sun, Mar 18, 2018, 4:06 PM Michael Brohl wrote: > Done. > > Michael > > Am 18.03.18 um 13:27 schrieb Michael Brohl: > > Thanks for the hint, Pierre. > > > > I will take care of it and complete the existing .adoc files, also > > leave a notice in the wiki. >

Re: svn commit: r1827146 - in /ofbiz/ofbiz-framework/trunk/docs/asciidoc: developer-manual.adoc images/OFBiz-Logo.svg user-manual.adoc

2018-03-18 Thread Taher Alkhateeb
Beautiful :) I love it Release 17.12 though? Shouldn't we call it trunk / snapshot for now and then rename it for each release? On Sun, Mar 18, 2018 at 7:24 PM, wrote: > Author: mbrohl > Date: Sun Mar 18 16:24:31 2018 > New Revision: 1827146 > > URL: http://svn.apache.org/viewvc?rev=1827146&vie

Re: svn commit: r1827146 - in /ofbiz/ofbiz-framework/trunk/docs/asciidoc: developer-manual.adoc images/OFBiz-Logo.svg user-manual.adoc

2018-03-18 Thread Taher Alkhateeb
Now that I think about it, maybe we can actually even go as far as publishing the subversion revision number on each call to generateOfbizDocumentation if you folks think this is useful? On Sun, Mar 18, 2018 at 7:29 PM, Taher Alkhateeb wrote: > Beautiful :) I love it > > Release 17.

Re: [DOC] Example asciidoc file as guideline

2018-03-18 Thread Taher Alkhateeb
Hmmm, Sounds like a good idea, but perhaps maybe a bit early? We might be still evolving and learning how to structure our documents. Also, maybe if we keep our documents clean and consistent, then they themselves offer an example for how to write stuff? Examples usually run out of date quickly un

Re: svn commit: r1827146 - in /ofbiz/ofbiz-framework/trunk/docs/asciidoc: developer-manual.adoc images/OFBiz-Logo.svg user-manual.adoc

2018-03-18 Thread Taher Alkhateeb
Brohl > ecomify GmbH > www.ecomify.de > > [1] https://issues.apache.org/jira/browse/OFBIZ-10141 > > > Am 18.03.18 um 17:31 schrieb Taher Alkhateeb: > >> Now that I think about it, maybe we can actually even go as far as >> publishing the subversion revision numbe

Re: [DOC] Example asciidoc file as guideline

2018-03-18 Thread Taher Alkhateeb
t; Thanks, > > Michael Brohl > ecomify GmbH > www.ecomify.de > > > Am 18.03.18 um 17:46 schrieb Taher Alkhateeb: > >> Hmmm, Sounds like a good idea, but perhaps maybe a bit early? We might >> be still evolving and learning how to structure our documents.

Re: Documentation commits (.adoc file type)

2018-03-19 Thread Taher Alkhateeb
I'm not sure why we're using RAT anymore? I thought this is mostly for incubating projects to help them transition and license their files. Perhaps it might be simpler to remove it from the build script to reduce complexity? On Mon, Mar 19, 2018 at 11:23 AM, Jacques Le Roux wrote: > Hi Michael, >

Re: perceived lack of exportable services

2018-03-20 Thread Taher Alkhateeb
Hi Rajesh. Your question is a bit too broad / general, but to take the example of products related to a party, then a combination between a view entity and a "performFind" service would be probably sufficient for your needs. You can also find other search services that are generic in that sense. O

Re: [DOC] Viewing the OFBiz Manuals in Progress

2018-03-20 Thread Taher Alkhateeb
Hi Sharan, Since our documentation system generates HTML, we can publish it to our wiki in a similar fashion to how we usually publish README.md. I'm not sure if we can automate the wiki or we should just copy-paste every once in a while. Others might provide some good feedback here. On Mon, Mar

Re: [DOC] Viewing the OFBiz Manuals in Progress

2018-03-20 Thread Taher Alkhateeb
> > Once the page is saved it updates automatically > > HTH > > Jacques > > > > Le 20/03/2018 à 10:57, Taher Alkhateeb a écrit : >> >> Hi Sharan, >> >> Since our documentation system generates HTML, we can publish it to >> our wiki in a s

Re: [DOC] Viewing the OFBiz Manuals in Progress

2018-03-20 Thread Taher Alkhateeb
Hi Sharan, Jacques, All Okay so if you want to move forward with this, I suggest to create a page somewhere in wiki to receive the publication, then we update buildbot to generate the docs. On Tue, Mar 20, 2018, 6:07 PM Jacques Le Roux wrote: > Le 20/03/2018 à 13:52, Taher Alkhateeb a éc

Re: perceived lack of exportable services

2018-03-20 Thread Taher Alkhateeb
want to generate the new unique productCategoryId without risk of > collision. > > does createSequenceValueItem help ? not sure if its fit for current problem. > > regds > mallah > > > > > regds > mallah. > > > > > > > > > > > On Tu

Re: Welcome Paul Foxworthy as a new PMC member

2018-03-21 Thread Taher Alkhateeb
Congrats Paul! Welcome aboard :) On Wed, Mar 21, 2018, 11:48 AM Sharan Foga wrote: > Welcome Paul and congratulations! > > Thanks > Sharan > > On 2018/03/21 08:42:26, Jacopo Cappellato > wrote: > > The OFBiz PMC has invited Paul Foxworthy to become a new member of the > > committee and we are g

Re: svn commit: r1827470 - /ofbiz/ofbiz-framework/trunk/framework/base/groovyScript/test/FileUtilTests.groovy

2018-03-22 Thread Taher Alkhateeb
Just a note to all the documentation team, I think we should probably delete most README files anyway. The manual should be comprehensive and incorporate whatever is documented in these README files On Thu, Mar 22, 2018 at 11:54 AM, wrote: > Author: pgil > Date: Thu Mar 22 08:54:00 2018 > New Re

Re: svn commit: r1827439 - /ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml

2018-03-22 Thread Taher Alkhateeb
Not only is this commit unnecessary, but also breaks one of the best features in Object Oriented Programming -- polymorphism -- for no value that I can see anywhere at all. Also by saying we depend fully on Tomcat and we should write code that further enforces that idea instead of making our archi

Re: How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC ?

2018-03-23 Thread Taher Alkhateeb
Hi Rajesh, Actually If I were you I would avoid SOAP. Maybe that is too complex and an overkill for your problem. I never liked soap for anything other than washing hands anyway :) I also think there might be multiple issues with the whole design of this service, why pass a generic value in the f

Re: svn commit: r1827439 - /ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml

2018-03-23 Thread Taher Alkhateeb
I have issues with multiple decisions all around that same topic that never got community consensus. Changes to cookies, http redirects, authentication, and other commits that did not get a proper review from the community. Such major design decisions need proper review IMO On Fri, Mar 23, 2018 at

Re: How to pass org.apache.ofbiz.entity.GenericValue using XMLRPC ?

2018-03-23 Thread Taher Alkhateeb
es suggest that there is use of GenericValue all over the > places. > > > I don't mind using SOAP it gets me out of this soup ;-) > I know XMLRPC is lightweight and faster. > > > regds > mallah. > > > > > > > > > > > > > > &

Re: svn commit: r1827439 - /ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml

2018-03-27 Thread Taher Alkhateeb
ething which is complex and intrusive. There were questionable issues in the design here. > > I hope this helps, of course reviews are welcome. It seems unfortunately that our reviews are not welcome. You are not reverting and not cooperating. > > Jacques > > [1] https://s.apac

Re: [SUMMARY] Tomcat 8.5 and, servlet4preview and how I came there

2018-03-27 Thread Taher Alkhateeb
case in point to everything I mentioned in [1] Community collaboration helps, design discussion helps. https://lists.apache.org/thread.html/9a0ce342e108cb2327c7aa277f25f095030df3e01feb682d76af2f5b@%3Cdev.ofbiz.apache.org%3E On Tue, Mar 27, 2018 at 10:19 AM, Jacques Le Roux wrote: > Hi All, > > I

Re: why some fields are set to enable-audit-log true by default?

2018-04-04 Thread Taher Alkhateeb
+1 to their removal. A quick grep lists the fields which have that flag. I'm not sure about the field in the entity component though! it might be needed in some unit tests? framework/entity/entitydef/entitymodel_test.xml: applications/datamodel/entitydef/order-entitymodel.xml: applic

Re: Deprecate properties in favour of SystemProperties

2018-04-04 Thread Taher Alkhateeb
I am a little lost in this JIRA and cannot follow the discussion. Can you please point to what you want to review with others exactly? On Wed, Apr 4, 2018 at 9:46 AM, Jacques Le Roux wrote: > Le 03/04/2018 à 09:16, Jacques Le Roux a écrit : >> >> I suggest to continue the discussion at >> https:/

Re: Deprecate properties in favour of SystemProperties

2018-04-05 Thread Taher Alkhateeb
à 07:42, Scott Gray a écrit : > > If there's an ongoing discussion on the dev list then I don't think it's > a > > good idea to try to move it to jira until there's some consensus on the > > path forward. > > > > Regards > > Scott > > &

Re: Deprecate properties in favour of SystemProperties

2018-04-05 Thread Taher Alkhateeb
o to the db >> >> If properties are only expected to exist in one of the two places, then >> the >> fallback behavior discussion becomes obsolete. >> >> Hope that helps. Jacques, sorry if I've misunderstood anything, please >> feel free to clarify. >&

Re: why some fields are set to enable-audit-log true by default?

2018-04-05 Thread Taher Alkhateeb
t; www.hotwax.co >> >> On Thu, Apr 5, 2018 at 5:38 AM, Scott Gray >> wrote: >> >>> It would be good to leave it on somewhere in the system like the example >>> entities maybe >>> >>> On Wed, 4 Apr 2018, 22:13 Jacques Le Roux,

Re: svn commit: r1815412 - in /ofbiz: ofbiz-framework/trunk/NOTICE ofbiz-framework/trunk/themes/rainbowstone/README.md tools/rat-excludes.txt

2018-04-06 Thread Taher Alkhateeb
Yup, agreed, plenty of compatible fonts out there On Fri, Apr 6, 2018, 11:02 AM Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > On Fri, Apr 6, 2018 at 8:18 AM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > Another option could be to replace this font by another

<    1   2   3   4   5   6   7   8   9   10   >