Re: [DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-25 Thread Julien NICOLAS
Hello, Sorry for the sunrise modifications, I wasn't aware about the basic theme... Then I broke it a little... I think that it could be a good thing to push the bootstrap effort in the trunk. As far as the old themes are working, it's not a problem to have it in the trunk :) Moving sunrise

Re: [DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-24 Thread Jacques Le Roux
Le 24/06/2015 11:47, Gavin Mabie a écrit : Four issues: 1. The Bootstrap Basic and Bootstrap Sunrise is in fact just one theme with Basic as theme and Sunrise as a skin (implementation of Basic). Hence the location of the css for Sunrise under bootstrap/css/skins. Other than

Re: [DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-24 Thread Gavin Mabie
Four issues: 1. The Bootstrap Basic and Bootstrap Sunrise is in fact just one theme with Basic as theme and Sunrise as a skin (implementation of Basic). Hence the location of the css for Sunrise under bootstrap/css/skins. Other than that, Sunrise uses the same template libraries as

Re: [DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-24 Thread Gavin Mabie
I did not review anything but from your explanation having separated/specific header.ftl appbar.ftl files in Sunrise makes sense to me (since it's a skin) BTW I understand that Sunrise is a skin because it's mostly a copy of basic, right? That's right. If Julien is okay with it, I can

Re: [DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-24 Thread Pierre Smits
Bootstrap Sunrise is, in effect, a beautification effort on top of Bootstrap Basic. Where the Bootstrap dev branch started out as a kind of Proof of Concept branch (proving that OFBiz could be leveraged to use the Bootstrap web framework, and investigating/implementing what was required to have).

Re: [DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-24 Thread Pierre Smits
If we, as a community, are opting for multiple themes in one component, that would sure fit the bill. But is that what we want? Add complexities and bulk to a somewhat global theme management component? Or should we just have a strategy of one theme - one component? I am in favour of the latter

Re: [DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-24 Thread Gavin Mabie
If we, as a community, are opting for multiple themes in one component, that would sure fit the bill. But is that what we want? Add complexities and bulk to a somewhat global theme management component? Or should we just have a strategy of one theme - one component? I am in favour of the

Re: [DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-24 Thread Gavin Mabie
Hi Pierre Bootstrap Sunrise is, in effect, a beautification effort on top of Bootstrap Basic. Where the Bootstrap dev branch started out as a kind of Proof of Concept branch (proving that OFBiz could be leveraged to use the Bootstrap web framework, and investigating/implementing what was

Re: [DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-24 Thread Pierre Smits
Gavin, Please don't see my posting as an attack on anyone participating in the branch. It is just a reflection of my observation infused with a viewpoint. I appreciate what has been done. And, how to do skin variants has popped up before in relation to ecommerce. See various mail threads in

Re: [DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-24 Thread Gavin Mabie
Hi Pierre No offense taken. I would like to hear from Julien on this issue so we can move it forward. Gavin On Wed, Jun 24, 2015 at 4:05 PM, Pierre Smits pierre.sm...@gmail.com wrote: Gavin, Please don't see my posting as an attack on anyone participating in the branch. It is just a

Re: [DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-23 Thread Adrian Crum
I don't think the new themes are ready. I updated my local copy yesterday and tried them out - many of the layout issues I reported still exist, plus I found another one. I don't mind if there are just a few minor quirks - those can be fixed after the themes are in the trunk, but right now

Re: [DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-23 Thread Julien NICOLAS
Hello, I was underwater since 1 month and can't work seriously on bootstrap theme. But I agree with Adrian, bootstrap basic can be removed and we can keep focused on Bootstrap Sunrise. I think that it's still not ready for trunk. For the old themes, when Sunrise work, I'm quite sure that

Re: [DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-23 Thread Jacques Le Roux
Le 23/06/2015 17:42, Julien NICOLAS a écrit : Hello, I was underwater since 1 month and can't work seriously on bootstrap theme. But I agree with Adrian, bootstrap basic can be removed and we can keep focused on Bootstrap Sunrise. I think that it's still not ready for trunk. For the old

Re: [DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-23 Thread Pierre Smits
Hi Adrian, Thanks for the feedback. That the existing patch files available in JIRA issues don't work in trunk has to do with the fact that the bootstrap dev branch is not in sync with trunk. We have to take in consideration that the framework stack of the bootstrap branch is based (for the

Re: [DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-23 Thread Adrian Crum
I evaluated the bootstrap branch as it currently exists. If there are patches waiting to be applied to the branch, then I am not aware of them. Adrian Crum Sandglass Software www.sandglass-software.com On 6/23/2015 12:43 PM, Pierre Smits wrote: Hi Adrian, Thanks for the feedback. That the

[DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-23 Thread Pierre Smits
Hi all, Recently we have seen that great strides have been made with respect to widget refactoring, theme functions disentanglement from framework ( OFBIZ-6362 https://issues.apache.org/jira/browse/OFBIZ-6362) and in the Bootstrap dev branch (OFBIZ-5840

Re: [DISCUSSION] Bootstrap Themes - is it trunk ready?

2015-06-23 Thread Pierre Smits
I am running the Bootstrap Basic (somewhat modified) against trunk. Best regards, Pierre Smits *ORRTIZ.COM http://www.orrtiz.com* Services Solutions for Cloud- Based Manufacturing, Professional Services and Retail Trade http://www.orrtiz.com On Tue, Jun 23, 2015 at 9:56 PM, Adrian Crum