Re: Pursuing the “120 chars max” guideline (was: svn commit: r1844729 - in /ofbiz/ofbiz-framework/trunk/framework/webapp: dtd/site-conf.xsd src/main/java/org/apache/ofbiz/webapp/control/RequestHandler

2018-10-27 Thread Taher Alkhateeb
As I said countless times so far, mostly to Jacques, let's please try to avoid the "I have an idea, now let's do it everywhere in the code base" kind of approach. Slow gradual refactoring is the way to go to ensure sustainable quality and stability. Therefore, I'm in favor of Mathieu's approach.

Re: Pursuing the “120 chars max” guideline (was: svn commit: r1844729 - in /ofbiz/ofbiz-framework/trunk/framework/webapp: dtd/site-conf.xsd src/main/java/org/apache/ofbiz/webapp/control/RequestHandler

2018-10-26 Thread Gil Portenseigne
Hello, +1 to follow the 120char guideline for any commit that the purpose it not to refactor line length :). Gil Le vendredi 26 oct. 2018 à 11:13:48 (+0200), Mathieu Lirzin a écrit : > Hello Jacques, > > Jacques Le Roux writes: > > > Yes you are right, the whole file should be reformatted.