---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4451/
---
(Updated 2012-03-22 23:47:07.464893)
Review request for oodt, Chris Mattmann,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4458/
---
Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4451/
---
(Updated 2012-03-22 22:55:46.864916)
Review request for oodt, Chris Mattmann,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4451/#review6278
---
Overall great fix!... Just a few comments
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r//#review6280
---
On 2012-03-22 07:15:57, Chris Mattmann wrote:
trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/typedetection/MimeExtractorConfigReader.java,
line 90
https://reviews.apache.org/r//diff/1/?file=94495#file94495line90
does this make it so that Exception is never thrown and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4458/#review6282
---
Great patch! Couple comments
See https://builds.apache.org/job/oodt-trunk/374/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4451/
---
(Updated 2012-03-23 21:02:03.638390)
Review request for oodt, Chris Mattmann,
Hey Ricky,
+1, sounds fine and thanks for fixing them!
Cheers,
Chris
On Mar 23, 2012, at 3:07 PM, Nguyen, Ricky wrote:
filed subtask OODT-431 under OODT-410.
simple fix, didn't think i needed review board since all discussion happened
for OODT-410 already.
committed and seems like jenkins
Thanks Luca!
Cheers,
Chris
On Mar 23, 2012, at 3:29 AM, Cinquini, Luca (3880) wrote:
Hi Chris,
On Mar 21, 2012, at 4:31 PM, Mattmann, Chris A (388J) wrote:
Hi Luca,
On Mar 21, 2012, at 12:34 AM, Cinquini, Luca (3880) wrote:
Hey Chris,
thanks for checking this out!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4458/
---
(Updated 2012-03-23 21:19:16.059506)
Review request for oodt, Chris Mattmann,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4451/#review6325
---
Ship it!
LGTM
- brian
On 2012-03-23 21:02:03, Ricky Nguyen wrote:
Great work guys!
Cheers,
Chris
On Mar 23, 2012, at 11:59 AM, Thomas Bennett wrote:
Hey Brian,
Thanks for the help sorting this out.
I'm happy to take over writing the unit tests ;-) no problem.
I'll check out some of your other unit tests and let you know if I get stuck.
Cheers,
Hi Tom,
Yep that was my question but it looks like you two had this one under control,
so no need for my help! Great work!
Cheers,
Chris
On Mar 26, 2012, at 12:32 AM, Thomas Bennett wrote:
Hi Chris,
I'm wondering if the beans are named DeleteDataFile and DeleteMetadataFile:
have you
No worries, bud you are pw0oning it!
Keep rockin' on...
Cheers,
Chris
On Mar 26, 2012, at 11:40 AM, Thomas Bennett wrote:
Hey Chris,
Ooops. Thanks for the pointers.
Hopefully I'll iron out all the noob mistakes soon enough! I sensed I was
missing something hence my email reply with
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4454/#review6380
---
Ship it!
Sounds good LGTM.
- Chris
On 2012-03-26 20:55:22, brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4454/
---
(Updated 2012-03-26 20:55:22.461160)
Review request for oodt, Chris Mattmann,
On 2012-03-26 14:22:31, Chris Mattmann wrote:
trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java,
line 60
https://reviews.apache.org/r/4454/diff/1/?file=94689#file94689line60
Agree with Tom here, do we need a check on if
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4458/#review6368
---
On 2012-03-26 15:50:17, Chris Mattmann wrote:
trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/ProductCrawler.java,
line 326
https://reviews.apache.org/r//diff/2/?file=95394#file95394line326
Are all of these @VisibleForTesting coupling our test system too much
with
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r//
---
(Updated 2012-03-27 00:47:30.189828)
Review request for oodt, Chris Mattmann,
22 matches
Mail list logo
