[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473931#comment-16473931 ] Hadoop QA commented on OOZIE-3217: -- Testing JIRA OOZIE-3217 Cleaning local git workspace {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:green}+1 RAW_PATCH_ANALYSIS{color} .{color:green}+1{color} the patch does not introduce any @author tags .{color:green}+1{color} the patch does not introduce any tabs .{color:green}+1{color} the patch does not introduce any trailing spaces .{color:green}+1{color} the patch does not introduce any line longer than 132 .{color:green}+1{color} the patch adds/modifies 2 testcase(s) {color:green}+1 RAT{color} .{color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} .{color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:green}+1 COMPILE{color} .{color:green}+1{color} HEAD compiles .{color:green}+1{color} patch compiles .{color:green}+1{color} the patch does not seem to introduce new javac warnings {color:red}-1{color} There are [1] new bugs found below threshold in total that must be fixed. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [webapp]. . {color:red}-1{color} There are [1] new bugs found below threshold in [core] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html . The most important FindBugs errors are: . At AuthorizationService.java:[line 193]: java/io/File.init(Ljava/lang/String;Ljava/lang/String;)V reads a file whose location might be specified by user input . At AuthorizationService.java:[line 192] . {color:green}+1{color} There are no new bugs found in [tools]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [client]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} .{color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations .{color:green}+1{color} the patch does not modify JPA files {color:red}-1 TESTS{color} .Tests run: 2131 .Tests failed: 1 .Tests errors: 1 .The patch failed the following testcases: testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService) .Tests failing with errors: testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService) .{color:orange}Tests failed at first run:{color} TestJavaActionExecutor#testCredentialsSkip TestOozieDBCLI#testOozieDBCLI .For the complete list of flaky tests, see TEST-SUMMARY-FULL files. {color:green}+1 DISTRO{color} .{color:green}+1{color} distro tarball builds with the patch {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/528/ > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > Attachments: OOZIE-3217.001.patch, OOZIE-3217.002.patch, > OOZIE-3217.003.patch, OOZIE-3217.004.patch, OOZIE-3217.005.patch, > OOZIE-3217.006.patch, OOZIE-3217.007.patch > > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following configuration, which receives the comma separated values of the > users that are admins. > {{oozie.service.AuthorizationService.admin.users}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473857#comment-16473857 ] Peter Orova commented on OOZIE-3217: [~andras.piros] the previous patch got corrupted, please find attached the corrected one > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > Attachments: OOZIE-3217.001.patch, OOZIE-3217.002.patch, > OOZIE-3217.003.patch, OOZIE-3217.004.patch, OOZIE-3217.005.patch, > OOZIE-3217.006.patch, OOZIE-3217.007.patch > > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following configuration, which receives the comma separated values of the > users that are admins. > {{oozie.service.AuthorizationService.admin.users}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473854#comment-16473854 ] Hadoop QA commented on OOZIE-3217: -- PreCommit-OOZIE-Build started > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > Attachments: OOZIE-3217.001.patch, OOZIE-3217.002.patch, > OOZIE-3217.003.patch, OOZIE-3217.004.patch, OOZIE-3217.005.patch, > OOZIE-3217.006.patch, OOZIE-3217.007.patch > > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following configuration, which receives the comma separated values of the > users that are admins. > {{oozie.service.AuthorizationService.admin.users}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472045#comment-16472045 ] Hadoop QA commented on OOZIE-3217: -- Testing JIRA OOZIE-3217 Cleaning local git workspace {color:red}-1{color} Patch failed to apply to head of branch > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > Attachments: OOZIE-3217.001.patch, OOZIE-3217.002.patch, > OOZIE-3217.003.patch, OOZIE-3217.004.patch, OOZIE-3217.005.patch, > OOZIE-3217.006.patch > > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following configuration, which receives the comma separated values of the > users that are admins. > {{oozie.service.AuthorizationService.admin.users}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472028#comment-16472028 ] Hadoop QA commented on OOZIE-3217: -- PreCommit-OOZIE-Build started > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > Attachments: OOZIE-3217.001.patch, OOZIE-3217.002.patch, > OOZIE-3217.003.patch, OOZIE-3217.004.patch, OOZIE-3217.005.patch, > OOZIE-3217.006.patch > > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following configuration, which receives the comma separated values of the > users that are admins. > {{oozie.service.AuthorizationService.admin.users}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471983#comment-16471983 ] Peter Orova commented on OOZIE-3217: [~andras.piros] thank you for your additional observations, please find patch.006 attached addressing those. > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > Attachments: OOZIE-3217.001.patch, OOZIE-3217.002.patch, > OOZIE-3217.003.patch, OOZIE-3217.004.patch, OOZIE-3217.005.patch, > OOZIE-3217.006.patch > > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following configuration, which receives the comma separated values of the > users that are admins. > {{oozie.service.AuthorizationService.admin.users}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471823#comment-16471823 ] Andras Piros commented on OOZIE-3217: - Thanks for the contribution [~orova]! Failing tests are unrelated, FindBugs warning is fixed. +1 > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > Attachments: OOZIE-3217.001.patch, OOZIE-3217.002.patch, > OOZIE-3217.003.patch, OOZIE-3217.004.patch, OOZIE-3217.005.patch > > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following configuration, which receives the comma separated values of the > users that are admins. > {{oozie.service.AuthorizationService.admin.users}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471745#comment-16471745 ] Hadoop QA commented on OOZIE-3217: -- Testing JIRA OOZIE-3217 Cleaning local git workspace {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:green}+1 RAW_PATCH_ANALYSIS{color} .{color:green}+1{color} the patch does not introduce any @author tags .{color:green}+1{color} the patch does not introduce any tabs .{color:green}+1{color} the patch does not introduce any trailing spaces .{color:green}+1{color} the patch does not introduce any line longer than 132 .{color:green}+1{color} the patch adds/modifies 2 testcase(s) {color:green}+1 RAT{color} .{color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} .{color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:green}+1 COMPILE{color} .{color:green}+1{color} HEAD compiles .{color:green}+1{color} patch compiles .{color:green}+1{color} the patch does not seem to introduce new javac warnings {color:red}-1{color} There are [1] new bugs found below threshold in total that must be fixed. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [webapp]. . {color:red}-1{color} There are [1] new bugs found below threshold in [core] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html . The most important FindBugs errors are: . At AuthorizationService.java:[line 193]: java/io/File.init(Ljava/lang/String;Ljava/lang/String;)V reads a file whose location might be specified by user input . At AuthorizationService.java:[line 192] . {color:green}+1{color} There are no new bugs found in [tools]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [client]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} .{color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations .{color:green}+1{color} the patch does not modify JPA files {color:red}-1 TESTS{color} .Tests run: 2131 .Tests failed: 3 .Tests errors: 1 .The patch failed the following testcases: testActionCheck(org.apache.oozie.command.wf.TestActionCheckXCommand) testRerun(org.apache.oozie.action.hadoop.TestRerun) testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService) .Tests failing with errors: testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService) .{color:orange}Tests failed at first run:{color} TestJavaActionExecutor#testCredentialsSkip TestCoordMaterializeTriggerService#testCoordMaterializeTriggerService3 TestOozieDBCLI#testOozieDBCLI .For the complete list of flaky tests, see TEST-SUMMARY-FULL files. {color:green}+1 DISTRO{color} .{color:green}+1{color} distro tarball builds with the patch {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/525/ > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > Attachments: OOZIE-3217.001.patch, OOZIE-3217.002.patch, > OOZIE-3217.003.patch, OOZIE-3217.004.patch, OOZIE-3217.005.patch > > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following configuration, which receives the comma separated values of the > users that are admins. >
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471683#comment-16471683 ] Hadoop QA commented on OOZIE-3217: -- PreCommit-OOZIE-Build started > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > Attachments: OOZIE-3217.001.patch, OOZIE-3217.002.patch, > OOZIE-3217.003.patch, OOZIE-3217.004.patch, OOZIE-3217.005.patch > > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following configuration, which receives the comma separated values of the > users that are admins. > {{oozie.service.AuthorizationService.admin.users}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468735#comment-16468735 ] Hadoop QA commented on OOZIE-3217: -- Testing JIRA OOZIE-3217 Cleaning local git workspace {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:green}+1 RAW_PATCH_ANALYSIS{color} .{color:green}+1{color} the patch does not introduce any @author tags .{color:green}+1{color} the patch does not introduce any tabs .{color:green}+1{color} the patch does not introduce any trailing spaces .{color:green}+1{color} the patch does not introduce any line longer than 132 .{color:green}+1{color} the patch adds/modifies 2 testcase(s) {color:green}+1 RAT{color} .{color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} .{color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:green}+1 COMPILE{color} .{color:green}+1{color} HEAD compiles .{color:green}+1{color} patch compiles .{color:green}+1{color} the patch does not seem to introduce new javac warnings {color:red}-1{color} There are [2] new bugs found below threshold in total that must be fixed. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [tools]. . {color:red}-1{color} There are [2] new bugs found below threshold in [core] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html . The most important FindBugs errors are: . At AuthorizationService.java:[line 195]: org.apache.oozie.service.AuthorizationService.loadAdminUsersFromFile() may fail to close stream . At AuthorizationService.java:[line 192]: java/io/File.init(Ljava/lang/String;Ljava/lang/String;)V reads a file whose location might be specified by user input . At AuthorizationService.java:[line 192] . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [client]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [webapp]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} .{color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations .{color:green}+1{color} the patch does not modify JPA files {color:red}-1 TESTS{color} .Tests run: 2131 .Tests failed: 18 .Tests errors: 14 .The patch failed the following testcases: testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerEhcache) testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService) testCoordinatorActionSelectors(org.apache.oozie.jms.TestJMSJobEventListener) testCoordinatorActionSelectorsNegative(org.apache.oozie.jms.TestJMSJobEventListener) testWorkflowJobSelectors(org.apache.oozie.jms.TestJMSJobEventListener) testOnCoordinatorJobSuccessEvent(org.apache.oozie.jms.TestJMSJobEventListener) testOnWorkflowJobSuspendEvent(org.apache.oozie.jms.TestJMSJobEventListener) testWorkflowJobSelectorsAnd(org.apache.oozie.jms.TestJMSJobEventListener) testOnCoordinatorJobFailureEvent(org.apache.oozie.jms.TestJMSJobEventListener) testConnectionDrop(org.apache.oozie.jms.TestJMSJobEventListener) testWorkflowJobSelectorsNegative(org.apache.oozie.jms.TestJMSJobEventListener) testWorkflowJobSelectorsOr(org.apache.oozie.jms.TestJMSJobEventListener) testOnWorkflowJobSuccessEvent(org.apache.oozie.jms.TestJMSJobEventListener) testOnCoordinatorActionWaitingEvent(org.apache.oozie.jms.TestJMSJobEventListener) testOnWorkflowJobFailureEvent(org.apache.oozie.jms.TestJMSJobEventListener) testOnCoordinatorActionStartEvent(org.apache.oozie.jms.TestJMSJobEventListener) testOnWorkflowJobStartedEvent(org.apache.oozie.jms.TestJMSJobEventListener) testSqoopActionWithRedundantArgsAndFreeFormQuery(org.apache.oozie.action.hadoop.TestSqoopActionExecutor) .Tests failing with errors: testAdminUsersWithAdminFile(org.apache.oozie.service.TestAuthorizationService) testWhenDefinedInAdminFileAndConfigurationThenAllowBothAdmins(org.apache.oozie.service.TestAuthorizationService)
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468576#comment-16468576 ] Hadoop QA commented on OOZIE-3217: -- PreCommit-OOZIE-Build started > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > Attachments: OOZIE-3217.001.patch, OOZIE-3217.002.patch, > OOZIE-3217.003.patch, OOZIE-3217.004.patch > > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following configuration, which receives the comma separated values of the > users that are admins. > {{oozie.service.AuthorizationService.admin.users}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465735#comment-16465735 ] Andras Piros commented on OOZIE-3217: - [~orova] failing tests seem unrelated. Can you please fix following pre-commit build errors: {quote} -1 RAW_PATCH_ANALYSIS . -1 the patch contains 3 line(s) longer than 132 characters . -1 There are [3] new bugs found below threshold in [core] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html . The most important FindBugs errors are: . At AuthorizationService.java:[line 192]: Found reliance on default encoding in org.apache.oozie.service.AuthorizationService.loadAdminUsersFromFile(): new java.io.InputStreamReader(InputStream) . At AuthorizationService.java:[line 192]: org.apache.oozie.service.AuthorizationService.loadAdminUsersFromFile() may fail to close stream . At AuthorizationService.java:[line 189]: java/io/File.(Ljava/lang/String;Ljava/lang/String;)V reads a file whose location might be specified by user input . At AuthorizationService.java:[line 187] {quote} > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > Attachments: OOZIE-3217.001.patch, OOZIE-3217.002.patch, > OOZIE-3217.003.patch > > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following configuration, which receives the comma separated values of the > users that are admins. > {{oozie.service.AuthorizationService.admin.users}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464115#comment-16464115 ] Hadoop QA commented on OOZIE-3217: -- Testing JIRA OOZIE-3217 Cleaning local git workspace {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} .{color:green}+1{color} the patch does not introduce any @author tags .{color:green}+1{color} the patch does not introduce any tabs .{color:green}+1{color} the patch does not introduce any trailing spaces .{color:red}-1{color} the patch contains 3 line(s) longer than 132 characters .{color:green}+1{color} the patch adds/modifies 2 testcase(s) {color:green}+1 RAT{color} .{color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} .{color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:green}+1 COMPILE{color} .{color:green}+1{color} HEAD compiles .{color:green}+1{color} patch compiles .{color:green}+1{color} the patch does not seem to introduce new javac warnings {color:red}-1{color} There are [3] new bugs found below threshold in total that must be fixed. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [webapp]. . {color:red}-1{color} There are [3] new bugs found below threshold in [core] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html . The most important FindBugs errors are: . At AuthorizationService.java:[line 192]: Found reliance on default encoding in org.apache.oozie.service.AuthorizationService.loadAdminUsersFromFile(): new java.io.InputStreamReader(InputStream) . At AuthorizationService.java:[line 192]: org.apache.oozie.service.AuthorizationService.loadAdminUsersFromFile() may fail to close stream . At AuthorizationService.java:[line 189]: java/io/File.init(Ljava/lang/String;Ljava/lang/String;)V reads a file whose location might be specified by user input . At AuthorizationService.java:[line 187] . {color:green}+1{color} There are no new bugs found in [tools]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [client]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} .{color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations .{color:green}+1{color} the patch does not modify JPA files {color:red}-1 TESTS{color} .Tests run: 2131 .Tests failed: 1 .Tests errors: 2 .The patch failed the following testcases: testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService) .Tests failing with errors: testConnectionRetryExceptionListener(org.apache.oozie.service.TestJMSAccessorService) testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService) .{color:orange}Tests failed at first run:{color} TestJavaActionExecutor#testCredentialsSkip TestXCommand#testXCommandLifecycleLockingFailingToLock TestOozieDBCLI#testOozieDBCLI .For the complete list of flaky tests, see TEST-SUMMARY-FULL files. {color:green}+1 DISTRO{color} .{color:green}+1{color} distro tarball builds with the patch {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/515/ > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > Attachments: OOZIE-3217.001.patch, OOZIE-3217.002.patch, > OOZIE-3217.003.patch > > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463996#comment-16463996 ] Hadoop QA commented on OOZIE-3217: -- PreCommit-OOZIE-Build started > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > Attachments: OOZIE-3217.001.patch, OOZIE-3217.002.patch, > OOZIE-3217.003.patch > > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following configuration, which receives the comma separated values of the > users that are admins. > {{oozie.service.AuthorizationService.admin.users}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456667#comment-16456667 ] Hadoop QA commented on OOZIE-3217: -- Testing JIRA OOZIE-3217 Cleaning local git workspace {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} .{color:green}+1{color} the patch does not introduce any @author tags .{color:green}+1{color} the patch does not introduce any tabs .{color:green}+1{color} the patch does not introduce any trailing spaces .{color:red}-1{color} the patch contains 4 line(s) longer than 132 characters .{color:green}+1{color} the patch adds/modifies 2 testcase(s) {color:green}+1 RAT{color} .{color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} .{color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:green}+1 COMPILE{color} .{color:green}+1{color} HEAD compiles .{color:green}+1{color} patch compiles .{color:green}+1{color} the patch does not seem to introduce new javac warnings {color:red}-1{color} There are [3] new bugs found below threshold in total that must be fixed. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [webapp]. . {color:red}-1{color} There are [3] new bugs found below threshold in [core] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html . The most important FindBugs errors are: . At AuthorizationService.java:[line 193]: Found reliance on default encoding in org.apache.oozie.service.AuthorizationService.loadAdminUsersFromAdminUsersFile(): new java.io.InputStreamReader(InputStream) . At AuthorizationService.java:[line 193]: org.apache.oozie.service.AuthorizationService.loadAdminUsersFromAdminUsersFile() may fail to close stream . At AuthorizationService.java:[line 190]: java/io/File.init(Ljava/lang/String;Ljava/lang/String;)V reads a file whose location might be specified by user input . At AuthorizationService.java:[line 188] . {color:green}+1{color} There are no new bugs found in [tools]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [client]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} .{color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations .{color:green}+1{color} the patch does not modify JPA files {color:red}-1 TESTS{color} .Tests run: 2114 .Tests failed: 1 .Tests errors: 1 .The patch failed the following testcases: testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService) .Tests failing with errors: testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService) .{color:orange}Tests failed at first run:{color} TestJavaActionExecutor#testCredentialsSkip TestOozieDBCLI#testOozieDBCLI .For the complete list of flaky tests, see TEST-SUMMARY-FULL files. {color:green}+1 DISTRO{color} .{color:green}+1{color} distro tarball builds with the patch {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/496/ > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > Attachments: OOZIE-3217.001.patch, OOZIE-3217.002.patch > > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456524#comment-16456524 ] Hadoop QA commented on OOZIE-3217: -- PreCommit-OOZIE-Build started > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > Attachments: OOZIE-3217.001.patch, OOZIE-3217.002.patch > > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following configuration, which receives the comma separated values of the > users that are admins. > {{oozie.service.AuthorizationService.admin.users}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16445989#comment-16445989 ] Andras Piros commented on OOZIE-3217: - [~orova] thanks for the contribution! Can you please also address the {{RAW_PATCH_ANALYSIS}} issues, add a default key / value / description triplet to {{oozie-default.xml}}, and extend {{AG_Install.twiki}}? > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > Attachments: OOZIE-3217.001.patch > > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following configuration, which receives the comma separated values of the > users that are admins. > {{oozie.service.AuthorizationService.admin.users}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442796#comment-16442796 ] Hadoop QA commented on OOZIE-3217: -- Testing JIRA OOZIE-3217 Cleaning local git workspace {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} .{color:green}+1{color} the patch does not introduce any @author tags .{color:green}+1{color} the patch does not introduce any tabs .{color:green}+1{color} the patch does not introduce any trailing spaces .{color:red}-1{color} the patch contains 2 line(s) longer than 132 characters .{color:red}-1{color} the patch does not add/modify any testcase {color:green}+1 RAT{color} .{color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} .{color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:green}+1 COMPILE{color} .{color:green}+1{color} HEAD compiles .{color:green}+1{color} patch compiles .{color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1{color} There are no new bugs found in total. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [webapp]. . {color:green}+1{color} There are no new bugs found in [core]. . {color:green}+1{color} There are no new bugs found in [tools]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [client]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} .{color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations .{color:green}+1{color} the patch does not modify JPA files {color:red}-1 TESTS{color} .Tests run: 2112 .Tests failed: 1 .Tests errors: 1 .The patch failed the following testcases: testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService) .Tests failing with errors: testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService) .{color:orange}Tests failed at first run:{color} TestJavaActionExecutor#testCredentialsSkip TestOozieDBCLI#testOozieDBCLI .For the complete list of flaky tests, see TEST-SUMMARY-FULL files. {color:green}+1 DISTRO{color} .{color:green}+1{color} distro tarball builds with the patch {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/488/ > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Affects Versions: 5.0.0 >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > Attachments: OOZIE-3217.001.patch > > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following configuration, which receives the comma separated values of the > users that are admins. > {{oozie.service.AuthorizationService.admin.users}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442639#comment-16442639 ] Hadoop QA commented on OOZIE-3217: -- PreCommit-OOZIE-Build started > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Affects Versions: trunk >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > Attachments: OOZIE-3217.001.patch > > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following configuration, which receives the comma separated values of the > users that are admins. > {{oozie.service.AuthorizationService.admin.users}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435398#comment-16435398 ] Peter Orova commented on OOZIE-3217: [~andras.piros], no I thought we could merge the contents of {{adminusers.txt}} and the envisioned {{oozie-site.xml}} parameters for backwards compatibility. > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following configuration, which receives the comma separated values of the > users that are admins. > {{oozie.service.AuthorizationService.admin.users}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OOZIE-3217) Enable definition of admin users using oozie-site.xml
[ https://issues.apache.org/jira/browse/OOZIE-3217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435044#comment-16435044 ] Andras Piros commented on OOZIE-3217: - Good idea [~orova]! Looking forward to see implementation details :) will you dump {{adminusers.txt}} then? > Enable definition of admin users using oozie-site.xml > - > > Key: OOZIE-3217 > URL: https://issues.apache.org/jira/browse/OOZIE-3217 > Project: Oozie > Issue Type: Improvement >Reporter: Peter Orova >Assignee: Peter Orova >Priority: Minor > > Currently the list of admin users is defined in the {{adminusers.txt}} file > hard coded to the Oozie config dir. For a more streamlined solution, we could > define the list of admin users via {{oozie-site.xml}} by introducing the > following configuration, which receives the comma separated values of the > users that are admins. > {{oozie.service.AuthorizationService.admin.users}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)