kinow commented on code in PR #62:
URL: https://github.com/apache/opennlp-sandbox/pull/62#discussion_r1082912447
##
modelbuilder-addon/src/main/java/opennlp/addons/modelbuilder/DefaultModelBuilderUtil.java:
##
@@ -98,17 +96,17 @@ public static void generateModel(File sentences,
mawiesne commented on code in PR #62:
URL: https://github.com/apache/opennlp-sandbox/pull/62#discussion_r1082978350
##
modelbuilder-addon/src/main/java/opennlp/addons/modelbuilder/DefaultModelBuilderUtil.java:
##
@@ -98,17 +96,17 @@ public static void generateModel(File sentence
mawiesne opened a new pull request, #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71
- adjusts opennlp-tools to 2.1.0
- adjusts parent project (org.apache.apache) to version 18
- adjusts Java language level to 11
- updates several dependencies to more up-to-date versions t
mawiesne commented on PR #56:
URL: https://github.com/apache/opennlp-sandbox/pull/56#issuecomment-1399242726
This PR can be closed, provided
https://github.com/apache/opennlp-sandbox/pull/71 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message,
mawiesne commented on PR #55:
URL: https://github.com/apache/opennlp-sandbox/pull/55#issuecomment-1399242753
This PR can be closed, provided
https://github.com/apache/opennlp-sandbox/pull/71 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message,
mawiesne commented on PR #40:
URL: https://github.com/apache/opennlp-sandbox/pull/40#issuecomment-1399242761
This PR can be closed, provided
https://github.com/apache/opennlp-sandbox/pull/71 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message,
mawiesne commented on PR #39:
URL: https://github.com/apache/opennlp-sandbox/pull/39#issuecomment-1399242775
This PR can be closed, provided
https://github.com/apache/opennlp-sandbox/pull/71 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message,
mawiesne closed pull request #39: Bump lucene-core from 4.10.0 to 7.1.0 in
/opennlp-similarity
URL: https://github.com/apache/opennlp-sandbox/pull/39
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mawiesne closed pull request #40: Bump httpclient from 4.2.1 to 4.3.6 in
/opennlp-similarity
URL: https://github.com/apache/opennlp-sandbox/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
mawiesne closed pull request #55: Bump opennlp-tools from 1.6.0 to 1.8.2 in
/opennlp-similarity
URL: https://github.com/apache/opennlp-sandbox/pull/55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mawiesne closed pull request #56: Bump solr-core from 4.10.0 to 8.8.2 in
/opennlp-similarity
URL: https://github.com/apache/opennlp-sandbox/pull/56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
kinow commented on PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#issuecomment-1399270619
>removes all other binary dep jars from 'lib' folder - all managed via Maven
now
:clap: thanks a ton!
--
This is an automated message from the Apache Git Service.
To respond to
kinow commented on code in PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#discussion_r1083301371
##
opennlp-similarity/src/main/java/opennlp/tools/apps/review_builder/WebPageReviewExtractor.java:
##
@@ -85,7 +85,7 @@ public ReviewObj
extractSentencesWithPotentia
mawiesne merged PR #59:
URL: https://github.com/apache/opennlp-sandbox/pull/59
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.a
mawiesne merged PR #62:
URL: https://github.com/apache/opennlp-sandbox/pull/62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.a
mawiesne merged PR #63:
URL: https://github.com/apache/opennlp-sandbox/pull/63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.a
mawiesne commented on PR #65:
URL: https://github.com/apache/opennlp-sandbox/pull/65#issuecomment-1399412792
This PR can be closed, provided
https://github.com/apache/opennlp-sandbox/pull/64 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message,
mawiesne closed pull request #65: Bump uimaj-core from 2.4.0 to 3.3.1 in
/caseditor-opennlp-plugin
URL: https://github.com/apache/opennlp-sandbox/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mawiesne merged PR #64:
URL: https://github.com/apache/opennlp-sandbox/pull/64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.a
mawiesne opened a new pull request, #72:
URL: https://github.com/apache/opennlp-sandbox/pull/72
- adjusts parent project (org.apache.apache) to version 18
- adjusts Java language level to 11
- updates `uimaj` dependencies to version 3.3.1
- modernizes resource handling in `WikinewsCo
mawiesne commented on PR #72:
URL: https://github.com/apache/opennlp-sandbox/pull/72#issuecomment-1399416247
@kinow This time, its a quick one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mawiesne commented on PR #67:
URL: https://github.com/apache/opennlp-sandbox/pull/67#issuecomment-1399416421
This PR can be closed, provided
https://github.com/apache/opennlp-sandbox/pull/72 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message,
mawiesne closed pull request #67: Bump uimaj-core from 2.3.1 to 3.3.1 in
/wikinews-importer
URL: https://github.com/apache/opennlp-sandbox/pull/67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mawiesne opened a new pull request, #73:
URL: https://github.com/apache/opennlp-sandbox/pull/73
- adjusts opennlp-tools to 2.1.0
- adjusts parent project (org.apache.apache) to version 18
- adjusts Java language level to 11
- revives JUnit test to actually execute
- removes "assum
mawiesne commented on code in PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#discussion_r1083407501
##
opennlp-similarity/src/main/java/opennlp/tools/apps/review_builder/WebPageReviewExtractor.java:
##
@@ -85,7 +85,7 @@ public ReviewObj
extractSentencesWithPoten
mawiesne commented on code in PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#discussion_r1083407554
##
opennlp-similarity/src/test/java/opennlp/tools/similarity/apps/taxo_builder/TaxonomyBuildMatchTest.java:
##
@@ -16,36 +16,38 @@
*/
package opennlp.tools.simi
mawiesne commented on code in PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#discussion_r1083407645
##
opennlp-similarity/src/main/java/opennlp/tools/similarity/apps/solr/NLProgram2CodeRequestHandler.java:
##
@@ -93,33 +53,28 @@ public void handleRequestBody(Solr
mawiesne commented on code in PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#discussion_r1083407707
##
opennlp-similarity/src/test/java/opennlp/tools/parse_thicket/apps/MultiSentenceSearchResultsProcessorTest.java:
##
@@ -20,11 +20,18 @@
import opennlp.tools.s
mawiesne commented on code in PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#discussion_r1083408816
##
opennlp-similarity/src/test/java/opennlp/tools/parse_thicket/apps/MultiSentenceSearchResultsProcessorTest.java:
##
@@ -20,11 +20,18 @@
import opennlp.tools.s
mawiesne commented on code in PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#discussion_r1083409008
##
opennlp-similarity/src/test/java/opennlp/tools/parse_thicket/apps/MultiSentenceSearchResultsProcessorTest.java:
##
@@ -20,11 +20,18 @@
import opennlp.tools.s
kinow commented on code in PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#discussion_r1083414241
##
opennlp-similarity/src/test/java/opennlp/tools/similarity/apps/taxo_builder/TaxonomyBuildMatchTest.java:
##
@@ -16,36 +16,38 @@
*/
package opennlp.tools.similar
kinow commented on code in PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#discussion_r1083414830
##
opennlp-similarity/src/test/java/opennlp/tools/parse_thicket/apps/MultiSentenceSearchResultsProcessorTest.java:
##
@@ -20,11 +20,18 @@
import opennlp.tools.simi
kinow commented on code in PR #73:
URL: https://github.com/apache/opennlp-sandbox/pull/73#discussion_r1083418556
##
tf-ner-poc/src/test/java/org/apache/opennlp/namefinder/WordIndexerTest.java:
##
@@ -76,55 +76,53 @@ public void testToTokenIds_TwoSentences() {
TokenIds ids
mawiesne commented on code in PR #73:
URL: https://github.com/apache/opennlp-sandbox/pull/73#discussion_r1083431975
##
tf-ner-poc/src/main/java/org/apache/opennlp/namefinder/WordIndexer.java:
##
@@ -36,32 +37,39 @@ public class WordIndexer {
public static String UNK = "$UNK$"
mawiesne commented on code in PR #73:
URL: https://github.com/apache/opennlp-sandbox/pull/73#discussion_r1083432114
##
tf-ner-poc/src/test/java/org/apache/opennlp/namefinder/WordIndexerTest.java:
##
@@ -76,55 +76,53 @@ public void testToTokenIds_TwoSentences() {
TokenIds
rzo1 merged PR #493:
URL: https://github.com/apache/opennlp/pull/493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.apache.org
rzo1 commented on code in PR #73:
URL: https://github.com/apache/opennlp-sandbox/pull/73#discussion_r1083850500
##
tf-ner-poc/src/test/java/org/apache/opennlp/namefinder/PredictTest.java:
##
@@ -1,31 +1,39 @@
package org.apache.opennlp.namefinder;
-import java.io.IOException;
rzo1 commented on code in PR #72:
URL: https://github.com/apache/opennlp-sandbox/pull/72#discussion_r1083852114
##
wikinews-importer/src/main/java/org/apache/opennlp/wikinews_importer/AnnotatingMarkupParser.java:
##
@@ -91,24 +87,21 @@ public AnnotatingMarkupParser(String langua
rzo1 commented on code in PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#discussion_r1083854188
##
opennlp-similarity/pom.xml:
##
@@ -189,14 +208,20 @@
net.billylieurance.azuresearch
azure-bing-sear
rzo1 commented on PR #72:
URL: https://github.com/apache/opennlp-sandbox/pull/72#issuecomment-1400111594
It feels like I opened the gate to hell: `bytedeco`. I downloaded tons of
libraries (lol) including javascript webjars (???) and stuff.
Feels like `npm install`. There are many things,
mawiesne commented on code in PR #72:
URL: https://github.com/apache/opennlp-sandbox/pull/72#discussion_r1084291675
##
wikinews-importer/src/main/java/org/apache/opennlp/wikinews_importer/AnnotatingMarkupParser.java:
##
@@ -91,24 +87,21 @@ public AnnotatingMarkupParser(String la
jzonthemtn merged PR #73:
URL: https://github.com/apache/opennlp-sandbox/pull/73
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp
jzonthemtn commented on code in PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#discussion_r1084325451
##
opennlp-similarity/src/test/java/opennlp/tools/parse_thicket/apps/MultiSentenceSearchResultsProcessorTest.java:
##
@@ -20,11 +20,18 @@
import opennlp.tools
jzonthemtn commented on PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#issuecomment-1400694188
Thanks for updating the stuff in this repo! At some point the project should
see what in here might be viable and able to be brought over to the main
project.
--
This is an auto
mawiesne commented on PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#issuecomment-1400818187
> At some point the project should see what in here might be viable and able
to be brought over to the main project.
@jzonthemtn I absolutely agree on this. My main goal with r
mawiesne merged PR #72:
URL: https://github.com/apache/opennlp-sandbox/pull/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.a
mawiesne commented on code in PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#discussion_r1087579871
##
opennlp-similarity/src/main/java/opennlp/tools/apps/review_builder/WebPageReviewExtractor.java:
##
@@ -85,7 +85,7 @@ public ReviewObj
extractSentencesWithPoten
mawiesne commented on code in PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#discussion_r1087581599
##
opennlp-similarity/src/test/java/opennlp/tools/similarity/apps/taxo_builder/TaxonomyBuildMatchTest.java:
##
@@ -16,36 +16,38 @@
*/
package opennlp.tools.simi
mawiesne commented on code in PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#discussion_r1087592860
##
opennlp-similarity/src/test/java/opennlp/tools/parse_thicket/apps/MultiSentenceSearchResultsProcessorTest.java:
##
@@ -20,11 +20,18 @@
import opennlp.tools.s
mawiesne commented on code in PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71#discussion_r1087593818
##
opennlp-similarity/pom.xml:
##
@@ -189,14 +208,20 @@
net.billylieurance.azuresearch
azure-bing-
rzo1 commented on code in PR #492:
URL: https://github.com/apache/opennlp/pull/492#discussion_r1087617892
##
opennlp-dl/src/test/java/opennlp/dl/doccat/DocumentCategorizerDLEval.java:
##
@@ -29,13 +29,17 @@
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.
mawiesne merged PR #71:
URL: https://github.com/apache/opennlp-sandbox/pull/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.a
mawiesne opened a new pull request, #74:
URL: https://github.com/apache/opennlp-sandbox/pull/74
- adjusts parent project (org.apache.apache) to version 18
- adjusts Java language level to 11
- introduces parent pom module `corpus-server` and reorganizes children:
`-core, -impl, -connec
rzo1 commented on PR #74:
URL: https://github.com/apache/opennlp-sandbox/pull/74#issuecomment-1405076091
Thanks for the changes. It is a good way to make the sandbox be maintainable
/ buildable. I guess, that `lucas` isn't maintained anymore and most likely not
compatible with `3.x.x`, so i
mawiesne commented on PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#issuecomment-1408967188
> Windows is broken due to weird file names but I am +1 for the PR (shows
the problems)
Hints on how to rename and fix it: welcome.
--
This is an automated message from the
kinow commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1090875982
##
.github/PULL_REQUEST_TEMPLATE.md:
##
@@ -0,0 +1,27 @@
+Thank you for contributing to Apache OpenNLP.
+
+In order to streamline the review of the contribution we as
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1090886169
##
.github/CONTRIBUTING.md:
##
@@ -0,0 +1,11 @@
+# How to contribute to Apache OpenNLP
+
+Thank you for your intention to contribute to the Apache OpenNLP project.
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1090887604
##
.github/PULL_REQUEST_TEMPLATE.md:
##
@@ -0,0 +1,27 @@
+Thank you for contributing to Apache OpenNLP.
+
+In order to streamline the review of the contribution we
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r109068
##
mahout-addon/pom.xml:
##
@@ -21,15 +21,12 @@
http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation=
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1090889186
##
pom.xml:
##
@@ -0,0 +1,473 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://m
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1090890375
##
.gitattributes:
##
@@ -0,0 +1,48 @@
+# Handle line endings automatically for files detected as text
+# and leave all files detected as binary untouched.
+* text
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1090893174
##
.github/PULL_REQUEST_TEMPLATE.md:
##
@@ -0,0 +1,27 @@
+Thank you for contributing to Apache OpenNLP.
+
+In order to streamline the review of the contribution we
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1090894768
##
.github/PULL_REQUEST_TEMPLATE.md:
##
@@ -0,0 +1,27 @@
+Thank you for contributing to Apache OpenNLP.
+
+In order to streamline the review of the contribution we
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1090901403
##
pom.xml:
##
@@ -0,0 +1,473 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://m
mawiesne commented on PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#issuecomment-1408992799
> Added a few comments, but feel free to ignore them and address/discuss
later if you prefer. Great work! 👏
Thx @kinow. I addressed most of them. Hints on the file naming issue
rzo1 opened a new pull request, #80:
URL: https://github.com/apache/opennlp-sandbox/pull/80
as the title says.
Normalize line endings according to `.gitattributes`.
Merge target: **introduce-parent-pom-for-opennlp-sandbox**
--
This is an automated message from the Apache Gi
rzo1 commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1091027976
##
.gitattributes:
##
@@ -0,0 +1,48 @@
+# Handle line endings automatically for files detected as text
+# and leave all files detected as binary untouched.
+* text=aut
rzo1 commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1091031684
##
.github/workflows/maven.yml:
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the N
rzo1 commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1091031684
##
.github/workflows/maven.yml:
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the N
jzonthemtn opened a new pull request, #494:
URL: https://github.com/apache/opennlp/pull/494
See https://issues.apache.org/jira/browse/OPENNLP-1459. The need for this
was due to the fix in https://issues.apache.org/jira/browse/OPENNLP-1332.
--
This is an automated message from the Apache G
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1091495783
##
.github/workflows/maven.yml:
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See t
mawiesne merged PR #80:
URL: https://github.com/apache/opennlp-sandbox/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.a
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1091554145
##
.gitattributes:
##
@@ -0,0 +1,48 @@
+# Handle line endings automatically for files detected as text
+# and leave all files detected as binary untouched.
+* text
jzonthemtn opened a new pull request, #495:
URL: https://github.com/apache/opennlp/pull/495
Updating copyright date to 2023 in the NOTICE file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jzonthemtn merged PR #494:
URL: https://github.com/apache/opennlp/pull/494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.apach
jzonthemtn merged PR #495:
URL: https://github.com/apache/opennlp/pull/495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.apach
mawiesne commented on code in PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#discussion_r1092243391
##
.github/CONTRIBUTING.md:
##
@@ -0,0 +1,11 @@
+# How to contribute to Apache OpenNLP
+
+Thank you for your intention to contribute to the Apache OpenNLP project.
jzonthemtn opened a new pull request, #496:
URL: https://github.com/apache/opennlp/pull/496
This seems to fix the NPE in the Jira report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
jzonthemtn merged PR #496:
URL: https://github.com/apache/opennlp/pull/496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.apach
rzo1 commented on PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#issuecomment-1413300031
> > Windows is broken due to weird file names but I am +1 for the PR (shows
the problems)
>
> Hints on how to rename and fix it: welcome.
I think, that the whole `txt` direc
mawiesne commented on PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79#issuecomment-1413304998
Thanks @rzo1 for providing that context and helpful URLs. I'll dig into it
tomorrow and will check if we can achieve a fully passing CI suite.
--
This is an automated message from
rzo1 merged PR #79:
URL: https://github.com/apache/opennlp-sandbox/pull/79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@opennlp.apach
mawiesne commented on PR #78:
URL: https://github.com/apache/opennlp-sandbox/pull/78#issuecomment-1413898043
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
jzonthemtn commented on PR #78:
URL: https://github.com/apache/opennlp-sandbox/pull/78#issuecomment-1414382109
@mawiesne This is a different `opennlp-dl` than the one that's in the
`opennlp` repository. (I should have picked a unique name!) I think this one
was experiments with DL4J and the
mawiesne commented on PR #78:
URL: https://github.com/apache/opennlp-sandbox/pull/78#issuecomment-1414398392
Thanks for clarification with the naming. Should we rename this component
here to make it clearer for the community?
--
This is an automated message from the Apache Git Service.
To
mawiesne opened a new pull request, #81:
URL: https://github.com/apache/opennlp-sandbox/pull/81
- adjusts opennlp-tools to 2.1.0
- adjusts Java language level to 11
- updates several dependencies to more up-to-date versions to mitigate
several CVEs
- removes `nd4j-jblas` dep from 'o
mawiesne commented on PR #78:
URL: https://github.com/apache/opennlp-sandbox/pull/78#issuecomment-1416711687
This PR can be closed, provided
https://github.com/apache/opennlp-sandbox/pull/81 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message,
mawiesne commented on PR #81:
URL: https://github.com/apache/opennlp-sandbox/pull/81#issuecomment-1416714392
@kinow @rzo1 This PR migrates `opennlp-dl` (sandbox) to latest tools
release.
It shows tests are broken (thus ignored) with latest DL4J release... I tried
my best to moderniz
dependabot[bot] commented on PR #78:
URL: https://github.com/apache/opennlp-sandbox/pull/78#issuecomment-1416714547
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version,
mawiesne closed pull request #78: Bump junit from 4.11 to 4.13.1 in /opennlp-dl
URL: https://github.com/apache/opennlp-sandbox/pull/78
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
mawiesne commented on PR #81:
URL: https://github.com/apache/opennlp-sandbox/pull/81#issuecomment-1418050381
> It shows tests are broken (thus ignored) with latest DL4J release... I
tried my best to modernize it, however, the latest `nd4j` (1.0.0-M2.1) lacks
`org.nd4j.linalg.api.ops.impl.tr
kinow commented on PR #81:
URL: https://github.com/apache/opennlp-sandbox/pull/81#issuecomment-1418087944
Great @mawiesne ! Just working on a PR for Jena, then will come back and
finish reviewing this one. Thanks!!
--
This is an automated message from the Apache Git Service.
To respond to
kinow commented on code in PR #81:
URL: https://github.com/apache/opennlp-sandbox/pull/81#discussion_r1096732664
##
opennlp-dl/src/test/java/opennlp/tools/dl/RNNTest.java:
##
@@ -68,6 +70,11 @@ public static Collection data() {
}
@Test
+ @Ignore
+ // TODO check why thi
kinow commented on PR #81:
URL: https://github.com/apache/opennlp-sandbox/pull/81#issuecomment-1418110154
>@kinow @rzo1 I found ways to modernize the code so it compiles and tests
execute against latest DL4J / ND4J backend. However, on my MacOS machine it
fails at runtime; see comment in RN
mawiesne commented on PR #81:
URL: https://github.com/apache/opennlp-sandbox/pull/81#issuecomment-1418204486
@kinow Updated PR to manage platform-specific DL4J deps via Maven profiles.
This helps locally and to keep GH Actions Cache small(er) than now... FYI:
@rzo1
--
This is an automat
kinow commented on PR #81:
URL: https://github.com/apache/opennlp-sandbox/pull/81#issuecomment-1418204839
> @kinow Updated PR to manage platform-specific DL4J deps via Maven
profiles. This helps locally and to keep GH Actions Cache small(er) than now...
FYI: @rzo1
Do you still have t
mawiesne commented on PR #81:
URL: https://github.com/apache/opennlp-sandbox/pull/81#issuecomment-1418205941
> Do you still have the test errors on Mac? i.e. any chance the errors were
due to some issue with the previous dependencies?
Yes, errors still present. I just managed the depe
rzo1 commented on code in PR #81:
URL: https://github.com/apache/opennlp-sandbox/pull/81#discussion_r1097099607
##
opennlp-dl/src/main/java/opennlp/tools/dl/NeuralDocCatModel.java:
##
@@ -9,16 +33,10 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import java.io
rzo1 commented on PR #81:
URL: https://github.com/apache/opennlp-sandbox/pull/81#issuecomment-1418860473
Adding
```java
org.nd4j
nd4j-native
${nd4j.native.version}
```
solves the init exception for on Linux. Now I get the same excep
mawiesne commented on PR #81:
URL: https://github.com/apache/opennlp-sandbox/pull/81#issuecomment-1418864888
> solves the init exception
Fixed for all platforms with latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
1 - 100 of 2404 matches
Mail list logo
