[dev] BigPointerArray, SvPointerArray vs STL containers

2010-06-14 Thread Bartosz Kosiorek
Hi. In the http://wiki.services.openoffice.org/wiki/To-Dos#Replace_code_with_3rd_party there is section about Replace self made containers with STL containers. SvPointerArray, BigPointerArray But in higher section there is Remove duplicate code: BigPointerArray vs. SvPointerArray So should we

[dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-14 Thread Michael Stahl
On 13/06/2010 22:36, Bartosz Kosiorek wrote: Hi. hi Bartosz, In the http://wiki.services.openoffice.org/wiki/To-Dos#Replace_code_with_3rd_party there is section about Replace self made containers with STL containers. SvPointerArray, BigPointerArray But in higher section there is Remove

Re: [dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-14 Thread Caolán McNamara
On Mon, 2010-06-14 at 11:22 +0200, Michael Stahl wrote: the SvArrays should be replaced by appropriate STL types (mostly vector, i guess, but probably in some cases stacks or deques or something else). deques I think was the best option in general the last time I looked at this. Probably best

Re: [dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-14 Thread Bartosz
I thought I had a patch somewhere to do some of the conversion, but I can't find it now. I remember that I didn't go ahead with it at the time because my first cut at it left OOo larger than it was before hand, which was an annoying result. Great. If you could find this patch, it will be very

[dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-14 Thread Michael Stahl
On 14/06/2010 13:05, Bartosz wrote: I thought I had a patch somewhere to do some of the conversion, but I can't find it now. I remember that I didn't go ahead with it at the time because my first cut at it left OOo larger than it was before hand, which was an annoying result. Great. If you

[dev] SfxItemSet assumptions and assertions

2010-06-14 Thread Björn Michaelsen
Hi all, while testing the new SfxItemSets in cws new_itemsets I came across a few interesting uses of itemsets which I had considered to be illegal (but I might be wrong there). I assumed: - non-void items should only be put at the same which id in a set as the which id on the item itself. -

Re: [dev] SfxItemSet assumptions and assertions

2010-06-14 Thread Malte Timmermann
Hi Bjoern, Björn Michaelsen wrote, On 06/14/10 13:34: Hi all, while testing the new SfxItemSets in cws new_itemsets I came across a few interesting uses of itemsets which I had considered to be illegal (but I might be wrong there). I assumed: - non-void items should only be put at the same

Re: [dev] SfxItemSet assumptions and assertions

2010-06-14 Thread Björn Michaelsen
Am Mon, 14 Jun 2010 15:11:57 +0200 schrieb Malte Timmermann malte.timmerm...@sun.com: Hi Bjoern, Björn Michaelsen wrote, On 06/14/10 13:34: Hi all, while testing the new SfxItemSets in cws new_itemsets I came across a few interesting uses of itemsets which I had considered to be

Re: [dev] SfxItemSet assumptions and assertions

2010-06-14 Thread Malte Timmermann
Björn Michaelsen wrote, On 06/14/10 16:09: Am Mon, 14 Jun 2010 15:11:57 +0200 schrieb Malte Timmermann malte.timmerm...@sun.com: Hi Bjoern, Björn Michaelsen wrote, On 06/14/10 13:34: Hi all, while testing the new SfxItemSets in cws new_itemsets I came across a few interesting uses of

[dev] patch: replace SVARRAY to STL containers

2010-06-14 Thread Bartosz
Hi. I have created patch which replace svarray to stl containers. Patch is in attachment in issue: http://www.openoffice.org/issues/show_bug.cgi?id=112395 Feel free to test it. How I could test the highlight? Best Regards Bartosz

Re: [dev] CMake

2010-06-14 Thread Bill Hoffman
On 6/13/2010 1:55 PM, Mathias Bauer wrote: On 06/10/2010 08:19 PM, Bill Hoffman wrote: add_depend is used to express depends that the build system can not figure out. For most cases, it is not needed. add_library(a ...) target_link_library(a b), a now depends on library b. It is when you use

Re: [dev] Re: CMake

2010-06-14 Thread Bill Hoffman
On 6/11/2010 1:14 PM, bjoern michaelsen - Sun Microsystems - Hamburg Germany wrote: Hi all, see http://www.gnu.org/software/automake/manual/make/Remaking-Makefiles.html#Remaking-Makefiles for details: To this end, after reading in all makefiles, make will consider each as a goal target and

Re: [dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-14 Thread Andrew Douglas Pitonyak
On 06/14/2010 07:05 AM, Bartosz wrote: I thought I had a patch somewhere to do some of the conversion, but I can't find it now. I remember that I didn't go ahead with it at the time because my first cut at it left OOo larger than it was before hand, which was an annoying result. Great. If

[dev] Re: BigPointerArray, SvPointerArray vs STL containers

2010-06-14 Thread Bjoern Michaelsen
Am Mon, 14 Jun 2010 17:32:27 -0400 schrieb Andrew Douglas Pitonyak and...@pitonyak.org: Changing out SvArray, will fix this long standing bug, which will bring great joy and happiness to my life. http://www.openoffice.org/issues/show_bug.cgi?id=84159 Getting rid of SvArray might not be