[dev] GNU make build system and exported headers
Hi, just noticed (well, have been told) that in the new GNU make build system (oh, before I start any ranting: disclaimerGreat Stuff (TM), really!/disclaimer) it is expected that header files which are to be exported from a module reside in module/inc/module. And also, but my understanding might be wrong here: Files are exported *if and only if* they reside there. While it is great to clean up this which files are delivered from where mess we currently have, the above also implies that files from module/inc/module/* are not exported anymore, i.e. it is not possible to organize header files below the second module level. Instead, they all need to be thrown on a big fat header file pile. Is this understanding correct? If so, I think this is not a good idea at all: Consider modules such as toolkit, svtools and svx, where there is a more or less complex (well, let's say: well-arranged and -readable) folder structure below the module's include folder. Putting all those files into the flat module/inc/module folder will certainly not contribute to the readability of the source tree. So, are there plans to relax the above restriction? Ciao Frank -- ORACLE Frank Schönheit | Software Engineer | frank.schoenh...@oracle.com Oracle Office Productivity: http://www.oracle.com/office - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] GNU make build system and exported headers
Am Fri, 19 Nov 2010 13:31:31 +0100 schrieb Frank Schönheit frank.schoenh...@oracle.com: Hi, just noticed (well, have been told) that in the new GNU make build system (oh, before I start any ranting: disclaimerGreat Stuff (TM), really!/disclaimer) it is expected that header files which are to be exported from a module reside in module/inc/module. And also, but my understanding might be wrong here: Files are exported *if and only if* they reside there. While it is great to clean up this which files are delivered from where mess we currently have, the above also implies that files from module/inc/module/* are not exported anymore, i.e. it is not possible to organize header files below the second module level. Instead, they all need to be thrown on a big fat header file pile. Is this understanding correct? No. Currently Headers are explicitly declared to be delivered and can come from anywhere. Nonewithstanding this, it still makes a lot of sense to have a good structure for the headers. If so, I think this is not a good idea at all: Consider modules such as toolkit, svtools and svx, where there is a more or less complex (well, let's say: well-arranged and -readable) folder structure below the module's include folder. Putting all those files into the flat module/inc/module folder will certainly not contribute to the readability of the source tree. Why would you want to put them into a _flat_ structure? Also note that from the named modules toolkit and svtools are already migrated to the new builds system. Just have a look at cws gnumake2. Best, Bjoern - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] GNU make build system and exported headers
Hi Björn, If so, I think this is not a good idea at all: Consider modules such as toolkit, svtools and svx, where there is a more or less complex (well, let's say: well-arranged and -readable) folder structure below the module's include folder. Putting all those files into the flat module/inc/module folder will certainly not contribute to the readability of the source tree. Why would you want to put them into a _flat_ structure? I don't want to. My understanding was it was required to, in the GNU make build system. Also note that from the named modules toolkit and svtools are already migrated to the new builds system. Just have a look at cws gnumake2. Uhm. You see me confused. The trigger of this question was a call from releng, which told me that in svtools, the content of svtools/inc/svtools/toolpanel had to be moved to svtools/inc/svtools, 'cause of the new build system, which would not support such sub folders ... Ciao Frank - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] GNU make build system and exported headers
On 19.11.2010 14:23, Frank Schönheit wrote: Hi Björn, If so, I think this is not a good idea at all: Consider modules such as toolkit, svtools and svx, where there is a more or less complex (well, let's say: well-arranged and -readable) folder structure below the module's include folder. Putting all those files into the flat module/inc/module folder will certainly not contribute to the readability of the source tree. Why would you want to put them into a _flat_ structure? I don't want to. My understanding was it was required to, in the GNU make build system. Also note that from the named modules toolkit and svtools are already migrated to the new builds system. Just have a look at cws gnumake2. Uhm. You see me confused. The trigger of this question was a call from releng, which told me that in svtools, the content of svtools/inc/svtools/toolpanel had to be moved to svtools/inc/svtools, 'cause of the new build system, which would not support such sub folders ... For all readers that might got confused: with the new build systems, all delivered headers must reside inside $(module)/inc/$(module), but of course there may be further sub directories inside. Placing delivered headers into this directory was the recommended way in the old build system. Now it's a requirement. Regards, Mathias -- Mathias Bauer (mba) - Project Lead OpenOffice.org Writer OpenOffice.org Engineering at Oracle: http://blogs.sun.com/GullFOSS Please don't reply to nospamfor...@gmx.de. I use it for the OOo lists and only rarely read other mails sent to it. - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
Re: [dev] GNU make build system and exported headers
Hi all, Am Fri, 19 Nov 2010 17:14:54 +0100 schrieb Mathias Bauer nospamfor...@gmx.de: For all readers that might got confused: with the new build systems, all delivered headers must reside inside $(module)/inc/$(module), but of course there may be further sub directories inside. Placing delivered headers into this directory was the recommended way in the old build system. Now it's a requirement. It still is not a absolute requirement really -- however, not sticking to the convention is causing you more work than sticking with it. I consider that a Good Thing(tm). Best Regards, Bjoern - To unsubscribe, e-mail: dev-unsubscr...@openoffice.org For additional commands, e-mail: dev-h...@openoffice.org
