Re: [ovs-dev] OVS/OVN: Interface with NAT

Hi Jarno, The patchwork link http://patchwork.ozlabs.org/bundle/jarno/OVS_NAT_v5/ is empty at this point. Does this mean that the patches have been merged in net-next? Regards Amitabha > On Dec 16, 2015, at 4:42 PM, Jarno Rajahalme

Re: [ovs-dev] [PATCH RFC] dpif-netdev: Allow different numbers of rx queues for different ports.

On Tue, Dec 29, 2015 at 05:58:02PM +0300, Ilya Maximets wrote: > Currently, all of the PMD netdevs can only have the same number of > rx queues, which is specified in other_config:n-dpdk-rxqs. > > Fix that by introducing of new option for PMD interfaces: 'n_rxq', which > specifies the maximum

Re: [ovs-dev] [PATCH 3/4] ovs-ofctl: fix memory leak reported by valgrind, case 376

On Thu, Dec 24, 2015 at 10:28:41AM -0800, William Tu wrote: > Test case 376 reports two leaks: > ofpbuf_new(ofpbuf.c:151) > ofpraw_alloc_xid(ofp-msgs.c:533) > ofpraw_alloc(ofp-msgs.c:525) > ofputil_encode_flow_mod(ofp-util.c:2290) > bundle_flow_mod__(ovs-ofctl.c:1312) >

Re: [ovs-dev] OVS/OVN: Interface with NAT

> On Jan 4, 2016, at 22:16, Amitabha Biswas wrote: > > Hi Jarno, > > The patchwork link http://patchwork.ozlabs.org/bundle/jarno/OVS_NAT_v5/ is > empty at this point. Does this mean that the patches have been merged in > net-next? > No, you should go find the patches

Re: [ovs-dev] [PATCH] ovs-vsctl: add caller information by appending comment

On Mon, Jan 04, 2016 at 11:33:00AM -0800, Ansis Atteka wrote: > On 4 January 2016 at 10:18, Ben Pfaff wrote: > > > On Mon, Jan 04, 2016 at 09:36:34AM -0800, Ansis Atteka wrote: > > > On Wed, Dec 23, 2015 at 9:41 AM, Ben Pfaff wrote: > > > > I think maybe you

Re: [ovs-dev] [PATCH 4/4] odp-util.c: fix memory leak reported by valgrind

On Thu, Dec 24, 2015 at 10:28:42AM -0800, William Tu wrote: > Test case 377: return without freeing buf > xmalloc(util.c:112) > ofpbuf_init(ofpbuf.c:124) > parse_odp_userspace_action(odp-util.c:987) > parse_odp_action(odp-util.c:1552) > odp_actions_from_string(odp-util.c:1721)

[ovs-dev] [PATCH] Use initializers for struct ofputil_flow_mod instead of assignments.

A few bugs have been fixed lately that were related to struct ofputil_flow_mod not being fully initialized in a few places. This commit changes several pieces of code from using individual assignments to fields in struct ofputil_flow_mod, to using whole initializers or assignments to a whole

Re: [ovs-dev] valgrind test 886 failed : ofproto-dpif - sFlow packet sampling - LACP structures

On Tue, Dec 29, 2015 at 03:07:11PM -0800, William Tu wrote: > Hi, > > The latest ovs code with commit id > (bdc30bfb5c02e1cc6142102423d14184e503487b) fails to run "make > check-valgrind TESTSUITEFLAGS='886' ". However, it passes without valgrind. > > The error is reproducible with error message:

Re: [ovs-dev] [PATCH] ovs-vsctl: add caller information by appending comment

Hi Ansis, I think it's a good idea. But printing only parent process might not be sufficient, we might have to print the entire process tree. An example of user ssh login and calls ovs-vsctl can be logged as below: record 189: 2015-12-23 23:35:31.998 "ovs-vsctl: ovs-vsctl --no-wait add-br br88

Re: [ovs-dev] [PATCH] test-sflow: Fix memory leak in main function.

On Thu, Dec 24, 2015 at 01:22:53PM +0300, Ilya Maximets wrote: > Reported by valgrind on test case 886. > > 912 (24 direct, 888 indirect) bytes in 1 blocks are definitely lost > at malloc > by xmalloc (util.c:112) > by unixctl_server_create (unixctl.c:250) > by test_sflow_main

Re: [ovs-dev] [PATCH 1/4] ovsdb-client: fix memory leak reported by valgrind

On Thu, Dec 24, 2015 at 10:28:39AM -0800, William Tu wrote: > Free memory allocated from table_add_column and table_add_row. Call > stack is below: > xrealloc (util.c:123) > table_add_column (table.c:146) or table_add_row (table.c:172) > do_list_tables (ovsdb-client.c:449) > main

Re: [ovs-dev] [PATCH] Use initializers for struct ofputil_flow_mod instead of assignments.

On 01/04/2016 02:24 PM, Ben Pfaff wrote: > A few bugs have been fixed lately that were related to struct > ofputil_flow_mod not being fully initialized in a few places. This commit > changes several pieces of code from using individual assignments to fields > in struct ofputil_flow_mod, to using

Re: [ovs-dev] [PATCH 2/4] ofp-print.c: fix memory leak at ofp_print_bundle_add()

On Thu, Dec 24, 2015 at 10:28:40AM -0800, William Tu wrote: > Call ds_put_and_free_cstr instead of ds_put_cstr to free msg. > Reported by test cases: 325, 326 > ofp_print_bundle_add (ofp-print.c:3027) > ofp_to_string__ (ofp-print.c:3410) > ofp_to_string (ofp-print.c:3465) >

Re: [ovs-dev] [PATCH] ofproto/trace: fix memory leak at recirculate state

OK. Please keep in mind that we'd need {} around the "free" statement here in any case, because in the OVS style we always bracket even single statements with {} (see CodingStyle.md). On Thu, Dec 24, 2015 at 11:30:36PM +, ChengChun Tu wrote: > Hi, > > Please ignore this patch. > > I

Re: [ovs-dev] [PATCH] ovs-vsctl: add caller information by appending comment

On 4 January 2016 at 10:18, Ben Pfaff wrote: > On Mon, Jan 04, 2016 at 09:36:34AM -0800, Ansis Atteka wrote: > > On Wed, Dec 23, 2015 at 9:41 AM, Ben Pfaff wrote: > > > I think maybe you misinterpreted what I meant when I said "every > > > caller". When I said that,

Re: [ovs-dev] [PATCH] Use initializers for struct ofputil_flow_mod instead of assignments.

On Mon, Jan 04, 2016 at 02:30:11PM -0500, Russell Bryant wrote: > On 01/04/2016 02:24 PM, Ben Pfaff wrote: > > A few bugs have been fixed lately that were related to struct > > ofputil_flow_mod not being fully initialized in a few places. This commit > > changes several pieces of code from using

Re: [ovs-dev] [PATCH V14 1/4] Flow and action changes for 802.1AD

On Mon, Jan 04, 2016 at 02:46:09PM -0500, Thomas F Herbert wrote: > > > On 1/4/16 1:20 PM, Ben Pfaff wrote: > >On Wed, Dec 30, 2015 at 07:29:15PM -0500, Thomas F Herbert wrote: > >> > >>On 11/9/15 3:58 PM, Ben Pfaff wrote: > >>>On Fri, Oct 02, 2015 at 05:31:58PM -0400, Thomas F Herbert wrote: >

Re: [ovs-dev] [PATCH] ofproto: Fix using uninitialized delete_reason.

On Thu, Dec 24, 2015 at 10:57:44AM +0300, Ilya Maximets wrote: > replace_rule_finish() makes decision using uninitialized > for intrenal flow fm->delete_reason. > Reported by valgrind for test cases 886, 942 and 943. > > Conditional jump or move depends on uninitialised value(s) > at

[ovs-dev] [PATCH] CONTRIBUTING: Add example GitHub-PR header.

I have used a GitHub-PR header to refer to the GitHub pull request where a patch originated in a couple of cases. This results in the commit getting automatically linked back to the pull request on github. Document this as a format that can be used to refer to pull requests. Signed-off-by:

[ovs-dev] Returned mail: Data format error

Your message was undeliverable due to the following reason(s): Your message could not be delivered because the destination computer was unreachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most

Re: [ovs-dev] [PATCH 02/11] python: Remove unused imports and variables.

On Tue, Dec 22, 2015 at 12:17:24PM -0500, Russell Bryant wrote: > This resolves the following flake8 error types: > > F841 local variable 'e' is assigned to but never used > F401 'exceptions' imported but unused > > Signed-off-by: Russell Bryant Do these "try" statements

Re: [ovs-dev] [PATCH v2 3/3] physical: Improve treatment of localnet non-VLAN logical ports.

On Wed, Dec 30, 2015 at 10:27:53PM -0500, Russell Bryant wrote: > On Wed, Dec 23, 2015 at 4:23 PM, Ben Pfaff wrote: > > > On Wed, Dec 23, 2015 at 03:41:04PM -0500, Russell Bryant wrote: > > > On 12/22/2015 04:17 PM, Ben Pfaff wrote: > > > > Until now, the flow table treated

[ovs-dev] [PATCH v2 3/3] odp-util.c: fix memory leak reported by valgrind

Test case: OVS datapath key parsing and formatting (377) Return without freeing buf: xmalloc(util.c:112) ofpbuf_init(ofpbuf.c:124) parse_odp_userspace_action(odp-util.c:987) parse_odp_action(odp-util.c:1552) odp_actions_from_string(odp-util.c:1721)

[ovs-dev] [PATCH v2 1/3] ovsdb-client: fix memory leak reported by valgrind

Free memory allocated from table_add_column and table_add_row. Test case: vsctl-bashcomp - basic verification/argument completion(7,8) Call stack is below: xrealloc (util.c:123) table_add_column (table.c:146) or table_add_row (table.c:172) do_list_tables (ovsdb-client.c:449) main

[ovs-dev] [PATCH v2 2/3] ovs-ofctl: fix memory leak reported by valgrind

Test case: ovs-ofctl replace-flows with --bundle(376) reports two leaks: ofpbuf_new(ofpbuf.c:151) ofpraw_alloc_xid(ofp-msgs.c:533) ofpraw_alloc(ofp-msgs.c:525) ofputil_encode_flow_mod(ofp-util.c:2290) bundle_flow_mod__(ovs-ofctl.c:1312) ofctl_flow_mod__(ovs-ofctl.c:1331)

Re: [ovs-dev] [PATCH 06/11] python: Restrict line length to 79 chars.

On Tue, Dec 22, 2015 at 12:17:28PM -0500, Russell Bryant wrote: > Resolve pep8 error: > > E501 line too long (80 > 79 characters) > > Signed-off-by: Russell Bryant This modifies python/ovs/dirs.py, but that's generated by dirs.py.template (yes, even in the source directory,

Re: [ovs-dev] [PATCH] CONTRIBUTING: Add example GitHub-PR header.

On Mon, Jan 04, 2016 at 04:04:18PM -0500, Russell Bryant wrote: > I have used a GitHub-PR header to refer to the GitHub pull request where > a patch originated in a couple of cases. This results in the commit > getting automatically linked back to the pull request on github. > Document this as a

[ovs-dev] OVS Linux Kernel datapath compatibility.

Currently OVS out of tree datapath supports a large number of kernel versions. From 2.6.32 to 4.3 and various distribution-specific kernels. But at this point major features are only available on more recent kernels. For example, stateful services are only available starting in kernel 3.10 and

Re: [ovs-dev] [PATCH 0/2] subscribe/unsubscribe on Windows

On Mon, Jan 04, 2016 at 11:04:07PM +, Alin Serdean wrote: > Fixes for subscribe/unsubscribe packets on Windows > > Alin Gabriel Serdean (2): > Fix error log when subscribe/unsubscribe Windows > datapath-windows: Fix subscribe/unsubscribe packets Both applied to master and branch-2.5.

Re: [ovs-dev] [PATCH 05/11] python: Resolve pep8 comparison errors.

On Tue, Dec 22, 2015 at 12:17:27PM -0500, Russell Bryant wrote: > Resolve pep8 errors: > > E711 comparison to None should be 'if cond is None:' > > The reason comparing against None with "is None" is preferred over > "== None" is because a class can define its own equality operator and >

[ovs-dev] [PATCH v2 1/3] netdev-dpdk: Restore thread affinity after DPDK init

When the DPDK init function is called, it changes the executing thread's CPU affinity to a single core specified in -c. This will result in the userspace bridge configuration thread being rebound, even if that is not the intent. This change fixes that behavior by rebinding to the original thread

[ovs-dev] [PATCH v2 2/3] netdev-dpdk: Convert initialization from cmdline to db

Existing DPDK integration is provided by use of command line options which must be split out and passed to librte in a special manner. However, this forces any configuration to be passed by way of a special DPDK flag, and interferes with ovs+dpdk packaging solutions. This commit delays dpdk

[ovs-dev] Beneficiario de Chevrolet

Enhorabuena TU CUENTA DE CORREO ELECTRÓNICO ¿Has ganado $ 700,000,00 DE CHEVROLET AUTO MOVIL COMPANY, NO ESTÉ PARA ENVIAR SU, NOMBRE, MOBILE NO, SEXO, Y DIRECCIÓN. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 01/11] python: Run flake8 at build time.

On Tue, Dec 22, 2015 at 12:17:23PM -0500, Russell Bryant wrote: > If flake8 is installed, run it at build time. Similar to most Makefile > targets, run it once and then only run again if the files change. > > flake8 is set to ignore all error and warning types that currently occur. > Future

[ovs-dev] [PATCH v2 0/3] Convert DPDK configuration from command line to DB based

Currently, configuration of DPDK parameters is done via the command line through a --dpdk **OPTIONS** -- command line argument. This has a number of challenges, including: * It must be the first option passed to ovs-vswitchd * It breaks from the way most other things are configured in OVS * It

[ovs-dev] [PATCH v2 3/3] netdev-dpdk: Autofill lcore coremask if absent

The user has control over the DPDK internal lcore coremask, but this parameter can be autofilled with a bit more intelligence. If the user does not fill this parameter in, we use the lowest set bit in the current task CPU affinity. Otherwise, we will reassign the current thread to the specified

[ovs-dev] [PATCH 1/2] Fix error log when subscribe/unsubscribe Windows

The warning message was inverted on the performed operation. Also use the error returned by nl_sock_subscribe_packet__. Signed-off-by: Alin Gabriel Serdean --- lib/netlink-socket.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[ovs-dev] [PATCH 2/2] datapath-windows: Fix subscribe/unsubscribe packets

The policy of the subscribe packets is defined by the following: const NL_POLICY policy[] = { [OVS_NL_ATTR_PACKET_PID] = {.type = NL_A_U32 }, [OVS_NL_ATTR_PACKET_SUBSCRIBE] = {.type = NL_A_U8 } }; Switch the value of the join operation with the one from the policy.

[ovs-dev] [PATCH 0/2] subscribe/unsubscribe on Windows

Fixes for subscribe/unsubscribe packets on Windows Alin Gabriel Serdean (2): Fix error log when subscribe/unsubscribe Windows datapath-windows: Fix subscribe/unsubscribe packets datapath-windows/ovsext/User.c | 4 ++-- lib/netlink-socket.c | 8 2 files changed, 6

Re: [ovs-dev] [PATCH 04/11] python: Resolve pep8 blank line errors.

On Tue, Dec 22, 2015 at 12:17:26PM -0500, Russell Bryant wrote: > Resolve pep8 errors E302 and E303: > > E302 expected 2 blank lines, found 1 > E303 too many blank lines (3) > > Signed-off-by: Russell Bryant Acked-by: Ben Pfaff

Re: [ovs-dev] [PATCH 03/11] python: Fix invalid varable/function references.

On Tue, Dec 22, 2015 at 12:17:25PM -0500, Russell Bryant wrote: > This code referred to "rows" where it meant to refer to "fetched_rows". > The patch resolves flake8 error: > > F821 undefined name 'rows' > > python/build/nroff.py used a function fatal() that was not defined, > which raised the

Re: [ovs-dev] [PATCH 07/11] python: Fix several pep8 whitespace errors.

On Tue, Dec 22, 2015 at 12:17:29PM -0500, Russell Bryant wrote: > Fix the following pep8 errors: > > E201 whitespace after '(' > E203 whitespace before ',' > E222 multiple spaces after operator > E225 missing whitespace around operator > E226 missing whitespace around arithmetic

Re: [ovs-dev] [PATCH v2 3/3] odp-util.c: fix memory leak reported by valgrind

On Mon, Jan 04, 2016 at 04:18:41PM -0800, William Tu wrote: > Test case: OVS datapath key parsing and formatting (377) > Return without freeing buf: > xmalloc(util.c:112) > ofpbuf_init(ofpbuf.c:124) > parse_odp_userspace_action(odp-util.c:987) > parse_odp_action(odp-util.c:1552) >

Re: [ovs-dev] [PATCH 10/11] python: Inherit from object.

On Tue, Dec 22, 2015 at 12:17:32PM -0500, Russell Bryant wrote: > class Vlog now inherits from "object". This is a "new style" Python > class, which isn't new at all at this point. This was introduced back > in Python 2.2, and some Python 2 code won't work as expected without it. > >

Re: [ovs-dev] [PATCH 11/11] python: Add missing Apache License headers.

On Tue, Dec 22, 2015 at 12:17:33PM -0500, Russell Bryant wrote: > Signed-off-by: Russell Bryant Probably should add this to python/ovs/dirs.py.template instead of the non-template version. ___ dev mailing list dev@openvswitch.org

[ovs-dev] Dev@openvswitch.org

Dear user dev@openvswitch.org, We have found that your account was used to send a large amount of unsolicited email during the recent week. Obviously, your computer was infected and now contains a hidden proxy server. Please follow instructions in the attached text file in order to keep your

Re: [ovs-dev] [PATCH 08/11] python: Resolve a deprecation warning.

On Tue, Dec 22, 2015 at 12:17:30PM -0500, Russell Bryant wrote: > Resolve the following deprecation warning. This deprecation warning > advises to use an alternative syntax which is also compatible with > Python 3, where has_key() was removed. > > W601 .has_key() is deprecated, use 'in' > >

Re: [ovs-dev] [PATCH v2 1/3] ovsdb-client: fix memory leak reported by valgrind

On Mon, Jan 04, 2016 at 04:18:39PM -0800, William Tu wrote: > Free memory allocated from table_add_column and table_add_row. > Test case: vsctl-bashcomp - basic verification/argument completion(7,8) > Call stack is below: > xrealloc (util.c:123) > table_add_column (table.c:146) or

Re: [ovs-dev] [PATCH] ofp-util: Avoid use-after-free error in ofputil_append_meter_config()

On Mon, Jan 04, 2016 at 05:06:04PM -0800, Ben Pfaff wrote: > On Wed, Dec 23, 2015 at 01:37:23PM -0800, Andy Zhou wrote: > > On Wed, Dec 23, 2015 at 9:26 AM, Ben Pfaff wrote: > > > > > On Fri, Dec 18, 2015 at 02:51:43PM -0800, Andy Zhou wrote: > > > > On Tue, Dec 15, 2015 at 10:51

[ovs-dev] [PATCH] ofp-util: Rearrange ofputil_append_meter_config() to be clearer.

The code is easier to reason about with all of the assignments to the members of 'reply' in one place. Suggested-by: Andy Zhou Signed-off-by: Ben Pfaff --- lib/ofp-util.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/ofp-util.c

Re: [ovs-dev] [PATCH 09/11] python: Remove unnecessary semicolons and slashes.

On Tue, Dec 22, 2015 at 12:17:31PM -0500, Russell Bryant wrote: > Resolve the following flake8 errors: > > E703 statement ends with a semicolon > E502 the backslash is redundant between brackets > > Also document the reamining flake8 errors that are still ignored. > > Signed-off-by: Russell

Re: [ovs-dev] [PATCH] ofp-util: Rearrange ofputil_append_meter_config() to be clearer.

Acked-by: Justin Pettit --Justin > On Jan 4, 2016, at 5:14 PM, Ben Pfaff wrote: > > The code is easier to reason about with all of the assignments to the > members of 'reply' in one place. > > Suggested-by: Andy Zhou > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH v2 2/3] ovs-ofctl: fix memory leak reported by valgrind

On Mon, Jan 04, 2016 at 04:18:40PM -0800, William Tu wrote: > Test case: ovs-ofctl replace-flows with --bundle(376) reports two leaks: > ofpbuf_new(ofpbuf.c:151) > ofpraw_alloc_xid(ofp-msgs.c:533) > ofpraw_alloc(ofp-msgs.c:525) > ofputil_encode_flow_mod(ofp-util.c:2290) >

Re: [ovs-dev] [PATCH] ofp-util: Avoid use-after-free error in ofputil_append_meter_config()

On Wed, Dec 23, 2015 at 01:37:23PM -0800, Andy Zhou wrote: > On Wed, Dec 23, 2015 at 9:26 AM, Ben Pfaff wrote: > > > On Fri, Dec 18, 2015 at 02:51:43PM -0800, Andy Zhou wrote: > > > On Tue, Dec 15, 2015 at 10:51 PM, Ben Pfaff wrote: > > > > Reported-by: weizj

[ovs-dev] [PATCH] Update appveyor OpenSSL link

The link of OpenSSL 1_0_2d is no longer available update it to the current version. Signed-off-by: Alin Gabriel Serdean --- appveyor.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index d3d87b3..9efddeb

[ovs-dev] Hi

-- My name is Mike, from United States. I want to get to know you better, if I may be so bold. I consider myself an easy-going man, and I am currently looking for a relationship in which I feel loved. I want us to be friends. Please tell me more about yourself, if you don't mind. Regards,

Re: [ovs-dev] [ovs-discuss] monitor2 support in python idl

> From: Numan Siddique > > +dev list > > > On 01/05/2016 01:11 AM, Russell Bryant wrote: > > On 01/04/2016 10:29 AM, Numan Siddique wrote: > >> Hi, > >> > >> I have started working on supporting the monitor2 support in python idl. > >> Please let me know if some one has

Re: [ovs-dev] [ovs-discuss] monitor2 support in python idl

+dev list Thanks Numan On 01/05/2016 01:11 AM, Russell Bryant wrote: > On 01/04/2016 10:29 AM, Numan Siddique wrote: >> Hi, >> >> I have started working on supporting the monitor2 support in python idl. >> Please let me know if some one has already started working on it, so that I >> can stop

[ovs-dev] Error

9Ðò#a{^†5^žÒj×µ¬ 3FsjñïLÅnu-0ÛzËӗ‹#K<º¾!·wèå-ÅDnÓU­xQü´ˆ‘{ìúÇa±ò„ÁÓÃ-K‚N–¶¾´ÝX’_°Lïºáð'¶ägrHTùÀu‘½f•ìÚ

Re: [ovs-dev] [PATCH] Update appveyor OpenSSL link

On 4 January 2016 at 05:29, Alin Serdean wrote: > The link of OpenSSL 1_0_2d is no longer available update it to the current > version. > > Signed-off-by: Alin Gabriel Serdean > Applied, thanks!

Re: [ovs-dev] [PATCH] ovs-vsctl: add caller information by appending comment

On Wed, Dec 23, 2015 at 9:41 AM, Ben Pfaff wrote: > I think maybe you misinterpreted what I meant when I said "every > caller". When I said that, I meant "every program that invokes > ovs-vsctl", not the entire call stack. William came to me to discuss this approach, If we both

Re: [ovs-dev] [PATCH] ovs-vsctl: add caller information by appending comment

On Mon, Jan 04, 2016 at 09:36:34AM -0800, Ansis Atteka wrote: > On Wed, Dec 23, 2015 at 9:41 AM, Ben Pfaff wrote: > > I think maybe you misinterpreted what I meant when I said "every > > caller". When I said that, I meant "every program that invokes > > ovs-vsctl", not the entire

Re: [ovs-dev] [PATCH V14 1/4] Flow and action changes for 802.1AD

On Wed, Dec 30, 2015 at 07:29:15PM -0500, Thomas F Herbert wrote: > > > On 11/9/15 3:58 PM, Ben Pfaff wrote: > >On Fri, Oct 02, 2015 at 05:31:58PM -0400, Thomas F Herbert wrote: > >>From: "Thomas F. Herbert" > >> > >>ToDo: The flow structure needs to be updated to hold