[ovs-dev] [PATCH v2 net] openvswitch: Set the skbuff pkt_type for proper pmtud support.

2024-05-16 Thread Aaron Conole
dd vxlan tunneling support.") Signed-off-by: Aaron Conole --- v1->v2: Include a comment as requested by Eelco, and add some details about bridge port packets. net/openvswitch/actions.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/openvswitch/actions.c b/net/openv

Re: [ovs-dev] [PATCH v3] utilities: Correct deletion reason in flow_reval_monitor.py.

2024-05-16 Thread Aaron Conole
f to bridge in delete reasons. > - Added comment pointing back to delete reasons in .c. > v2: - Converted the list of strings to dictionary. > - Added comment to code to keep code and script in sync. > - Unified flow_delete reason comments and script output. > --- Acked-by:

Re: [ovs-dev] [PATCH net] net: openvswitch: fix overwriting ct original tuple for ICMPv6

2024-05-09 Thread Aaron Conole
n conntrack > tuple to sw_flow_key.") > Reported-by: Antonin Bas > Closes: https://github.com/openvswitch/ovs-issues/issues/327 > Signed-off-by: Ilya Maximets > --- Acked-by: Aaron Conole > Note: I'm working on a selftest for this issue, but it requires some > ground w

Re: [ovs-dev] [PATCH net-next 6/8] net:openvswitch: add psample support

2024-05-08 Thread Aaron Conole
Adrian Moreno writes: > On 5/3/24 11:43 AM, Eelco Chaudron wrote: >> On 24 Apr 2024, at 15:50, Adrian Moreno wrote: >> >>> Add support for psample sampling via two new attributes to the >>> OVS_ACTION_ATTR_SAMPLE action. >>> >>> OVS_SAMPLE_ATTR_PSAMPLE_GROUP used to pass an integer psample

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-25 Thread Aaron Conole
Jakub Kicinski writes: > On Thu, 25 Apr 2024 19:57:19 +0100 Simon Horman wrote: >> openvswitch.sh does not appear to have any dependencies on Open vSwitch >> user-space. My understanding is that, rather, it makes use of >> tools/testing/selftests/net/openvswitch/ovs-dpctl.py to talk to the

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-25 Thread Aaron Conole
Simon Horman writes: > On Wed, Apr 24, 2024 at 02:14:09PM -0400, Aaron Conole wrote: >> Simon Horman writes: >> >> > Hi Aaron, Jakub, all, >> > >> > I have recently been exercising the Open vSwitch kernel selftests, >> > using vng, somet

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-25 Thread Aaron Conole
Jakub Kicinski writes: > On Wed, 24 Apr 2024 17:44:05 +0100 Simon Horman wrote: >> I have recently been exercising the Open vSwitch kernel selftests, >> using vng, > > Speaking of ovs tests, we currently don't run them in CI (and suffer > related skips in pmtu.sh) because Amazon Linux doesn't

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-24 Thread Aaron Conole
Benjamin Poirier writes: > On 2024-04-24 18:37 +0100, Simon Horman wrote: >> On Wed, Apr 24, 2024 at 05:44:05PM +0100, Simon Horman wrote: >> > Hi Aaron, Jakub, all, >> > >> > I have recently been exercising the Open vSwitch kernel selftests, >> > using vng, something like this: >> > >> >

Re: [ovs-dev] selftests: openvswitch: Questions about possible enhancements

2024-04-24 Thread Aaron Conole
Simon Horman writes: > Hi Aaron, Jakub, all, > > I have recently been exercising the Open vSwitch kernel selftests, > using vng, something like this: > > TESTDIR="tools/testing/selftests/net/openvswitch" > > vng -v --run . --user root --cpus 2 \ > --overlay-rwdir

Re: [ovs-dev] [PATCH net-next] net: openvswitch: Release reference to netdev

2024-04-24 Thread Aaron Conole
Jun Gu writes: > dev_get_by_name will provide a reference on the netdev. So ensure that > the reference of netdev is released after completed. > > Fixes: 2540088b836f ("net: openvswitch: Check vport netdev name") > Signed-off-by: Jun Gu > --- Thanks

Re: [ovs-dev] [PATCH] net: openvswitch: Fix Use-After-Free in ovs_ct_exit

2024-04-24 Thread Aaron Conole
t; > To prevent this, it should be changed to hlist_for_each_entry_safe. > > Fixes: 11efd5cb04a1 ("openvswitch: Support conntrack zone limit") > Signed-off-by: Hyunwoo Kim > --- Reviewed-by: Aaron Conole ___ dev mailing list d...@open

Re: [ovs-dev] [PATCH] rhel/systemd: Set ovsdb-server timeout to 5 minutes

2024-04-23 Thread Aaron Conole
Chris Riches writes: > On 15/04/2024 14:39, Jon Kohler wrote: >>> On Apr 11, 2024, at 9:43 AM, Chris Riches wrote: >>> >>> On 11/04/2024 14:24, Ilya Maximets wrote: On 4/11/24 10:59, Chris Riches wrote: > From what we know so far, the DB was full of stale connection-tracking >

Re: [ovs-dev] [PATCH net-next] selftests: openvswitch: Fix escape chars in regexp.

2024-04-17 Thread Aaron Conole
; > Signed-off-by: Adrian Moreno > --- Thanks, Adrian. Reviewed-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] ovs-tcpdump: Support vlan option.

2024-04-09 Thread Aaron Conole
Daniel Ding writes: > 2024年3月30日 上午2:43,Aaron Conole 写道: > > Daniel Ding writes: > > When I try filter geneve protocol with a vlan, the warning message > occurs that tell me the kernel cann't support this combination. > > ^ can't &g

Re: [ovs-dev] [PATCH v2] Rename primary development branch as main.

2024-04-04 Thread Aaron Conole
k.rst | 2 +- > NEWS | 3 ++ > README.rst | 2 +- > 12 files changed, 50 insertions(+), 47 deletions(-) Acked-by: Aaron Conole > diff --git a/Documentation/internals/committer-respons

Re: [ovs-dev] [PATCH v7 2/2] netlink-conntrack: Optimize flushing ct zone.

2024-04-04 Thread Aaron Conole
ed-By: Luca Czesla > Signed-off-by: Luca Czesla > Co-Authored-By: Max Lamprecht > Signed-off-by: Max Lamprecht > Signed-off-by: Felix Huettner > --- Acked-by: Aaron Conole Thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v7 1/2] util: Support checking for kernel versions.

2024-04-03 Thread Aaron Conole
Felix Huettner via dev writes: > Extract checking for a given kernel version to a separate function. > It will be used also in the next patch. > > Acked-by: Mike Pattrick > Acked-by: Eelco Chaudron > Signed-off-by: Felix Huettner > --- Acked-by: Aaron Conole &g

Re: [ovs-dev] [PATCH v1 1/1] ofproto: Fix NULL deref reported by Coverity.

2024-04-02 Thread Aaron Conole
mit...@outlook.com writes: > From: miter > > Ofproto_class_find__() may return NULL, and dereference it to cause > segfault. > > Tested-by: Zhang YuHuang > Signed-off-by: Lin Huang > --- I guess that type_run and type_wait aren't flagged this way because the only users walk the ofproto types

Re: [ovs-dev] [PATCH] ovs-tcpdump: Support vlan option.

2024-03-29 Thread Aaron Conole
Daniel Ding writes: > When I try filter geneve protocol with a vlan, the warning message > occurs that tell me the kernel cann't support this combination. ^ can't > > $ ovs-tcpdump -i eth2 -nne vlan 10 and geneve > Warning: Kernel filter failed: Invalid argument

Re: [ovs-dev] [PATCH] conntrack: Do clean instead of forece expire.

2024-03-27 Thread Aaron Conole
Cheng Li writes: > Force expire a connection and then create new connection of the same > tuple(cmap hash). This makes ct->conns cmap operation expensive( > within ct->ct_lock). > > This patch cover the scenario by doing the clean immediately instead > of setting expire. Also this patch fix

Re: [ovs-dev] [PATCH net] openvswitch: Set the skbuff pkt_type for proper pmtud support.

2024-03-27 Thread Aaron Conole
Eelco Chaudron writes: > On 25 Mar 2024, at 13:37, Ilya Maximets wrote: > >> On 3/25/24 13:22, Aaron Conole wrote: >>> Eelco Chaudron writes: >>> >>>> On 22 Mar 2024, at 20:06, Aaron Conole wrote: >>>> >>>>> O

Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: Fix continuations with associated metering.

2024-03-27 Thread Aaron Conole
Aaron Conole writes: > Ilya Maximets writes: > >> On 3/22/24 14:40, Aaron Conole wrote: >>> Open vSwitch supports the ability to invoke a controller action by way >>> of a sample action with a specified meter. In the normal case, this >>> sample action

Re: [ovs-dev] [PATCH net] openvswitch: Set the skbuff pkt_type for proper pmtud support.

2024-03-25 Thread Aaron Conole
Eelco Chaudron writes: > On 22 Mar 2024, at 20:06, Aaron Conole wrote: > >> Open vSwitch is originally intended to switch at layer 2, only dealing with >> Ethernet frames. With the introduction of l3 tunnels support, it crossed >> into the realm of needing to care

Re: [ovs-dev] [PATCH v2] ofproto-dpif-xlate: Fix continuations with associated metering.

2024-03-25 Thread Aaron Conole
Ilya Maximets writes: > On 3/22/24 14:40, Aaron Conole wrote: >> Open vSwitch supports the ability to invoke a controller action by way >> of a sample action with a specified meter. In the normal case, this >> sample action is transparently generated during xlate processi

[ovs-dev] [PATCH net] openvswitch: Set the skbuff pkt_type for proper pmtud support.

2024-03-22 Thread Aaron Conole
oss, time 1061ms In this case, the first ping request receives the FRAG_NEEDED message and a local routing exception is created. Reported-at: https://issues.redhat.com/browse/FDP-164 Fixes: 58264848a5a7 ("openvswitch: Add vxlan tunneling support.") Signed-off-by: Aaron Conole --- NOTE:

[ovs-dev] [PATCH v2] ofproto-dpif-xlate: Fix continuations with associated metering.

2024-03-22 Thread Aaron Conole
to preserve metering, whether we are doing a plain old send to controller, or a continuation. Fixes: 77ab5fd2a95b ("Implement serializing the state of packet traversal in "continuations".") Reported-at: https://issues.redhat.com/browse/FDP-455 Tested-by: Alex Musil Signed-

Re: [ovs-dev] [PATCH v2] route-table: Avoid routes from non-standard routing tables.

2024-03-21 Thread Aaron Conole
stly.") > Fixes: ea83a2fcd0d3 ("lib: Show tunnel egress interface in ovsdb") > Reported-at: https://github.com/openvswitch/ovs-issues/issues/185 > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-discuss/2022-October/052091.html > Signed-off-by: Ilya Maximets > --- Thanks! Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] route-table: Avoid routes from non-standard routing tables.

2024-03-20 Thread Aaron Conole
Ilya Maximets writes: > On 3/19/24 20:56, Aaron Conole wrote: >> Ilya Maximets writes: >> >>> Currently, ovs-vswitchd is subscribed to all the routing changes in the >>> kernel. On each change, it marks the internal routing table cache as >>> invali

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Fix continuations with associated metering.

2024-03-19 Thread Aaron Conole
Ilya Maximets writes: > On 3/7/24 18:25, Aaron Conole wrote: >> Open vSwitch supports the ability to invoke a controller action by way >> of a sample action with a specified meter. In the normal case, this >> sample action is transparently generated during xlate processi

Re: [ovs-dev] [PATCH] route-table: Avoid routes from non-standard routing tables.

2024-03-19 Thread Aaron Conole
Ilya Maximets writes: > Currently, ovs-vswitchd is subscribed to all the routing changes in the > kernel. On each change, it marks the internal routing table cache as > invalid, then resets it and dumps all the routes from the kernel from > scratch. The reason for that is kernel routing

Re: [ovs-dev] [PATCH] github: Reduce ASLR entropy to be compatible with asan in llvm 14.

2024-03-12 Thread Aaron Conole
ut these are not available in Ubuntu 22.04 image. > > This should be fixed by GitHub, but until new images are available > reducing ASLR entropy manually to 28 bits to make builds work. > > Reported-at: https://github.com/actions/runner-images/issues/9491 > Signed-off-by: Ilya Maximets >

[ovs-dev] [PATCH] ofproto-dpif-xlate: Fix continuations with associated metering.

2024-03-07 Thread Aaron Conole
to preserve metering, whether we are doing a plain old send to controller, or a continuation. Fixes: 77ab5fd2a95b ("Implement serializing the state of packet traversal in "continuations".") Reported-at: https://issues.redhat.com/browse/FDP-455 Tested-by: Alex Musil Signed-

Re: [ovs-dev] [PATCH v3] conntrack: Remove nat_conn introducing key directionality.

2024-03-06 Thread Aaron Conole
Simon Horman writes: > + Xavier > > On Thu, Aug 31, 2023 at 02:52:59PM -0400, Aaron Conole wrote: >> Ilya Maximets writes: >> >> > On 8/31/23 09:15, Frode Nordahl wrote: >> >> On Wed, Aug 30, 2023 at 9:30 PM Paolo Valerio wrote: >> >>

[ovs-dev] [PATCH v10 2/2] rhel: Enable USDT scripts by default in Fedora builds.

2024-03-05 Thread Aaron Conole
All supported versions of Fedora do package libbpf, so it makes sense to enable USDT support. Acked-by: Simon Horman Acked-by: Eelco Chaudron Signed-off-by: Aaron Conole --- rhel/openvswitch-fedora.spec.in | 8 1 file changed, 8 insertions(+) diff --git a/rhel/openvswitch

[ovs-dev] [PATCH v10 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-03-05 Thread Aaron Conole
-scripts/flow_reval_monitor.py) which serves as a demonstration of how the new USDT probe might be used going forward. Acked-by: Han Zhou Signed-off-by: Kevin Sprague Co-authored-by: Aaron Conole Signed-off-by: Aaron Conole --- v8 -> v9: Reorganized the flow delete reasons enum Upda

[ovs-dev] [PATCH v10 0/2] debugging: Add a revalidator probe, and monitor script

2024-03-05 Thread Aaron Conole
Resurrecting a feature from 2022, introduce a probe that indicates why a particular flow may be selected for eviction during revalidation and includes the flow information. The second patch tells fedora builds to include the USDT probe support on Fedora systems. Aaron Conole (1): rhel: Enable

Re: [ovs-dev] [PATCH v9 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-03-04 Thread Aaron Conole
Eelco Chaudron writes: > On 20 Feb 2024, at 22:47, Aaron Conole wrote: > >> From: Kevin Sprague >> >> During normal operations, it is useful to understand when a particular flow >> gets removed from the system. This can be useful when debugging performance >>

Re: [ovs-dev] [RFC 3/7] selftests: openvswitch: use non-graceful kills when needed

2024-02-21 Thread Aaron Conole
Adrian Moreno writes: > On 2/16/24 16:28, Aaron Conole wrote: >> Normally a spawned process under OVS is given a SIGTERM when the test >> ends as part of cleanup. However, in case the process is still lingering >> for some reason, we also send a SIGKILL to force it down

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-21 Thread Aaron Conole
Adrian Moreno writes: > On 2/20/24 19:06, Aaron Conole wrote: >> Eelco Chaudron writes: >> >>> On 19 Feb 2024, at 19:57, Aaron Conole wrote: >>> >>>> Eelco Chaudron writes: >>>> >>>>> On 12 Feb 2024, at 15:15, Aar

Re: [ovs-dev] [PATCH v1] ovs-tcpdump: Cleanup mirror failed with twice fatal signals

2024-02-21 Thread Aaron Conole
un(): > > Signed-off-by: Daniel Ding > --- LGTM for the linux side - maybe Alin might check the windows side. When you post v2 you can keep my Reviewed-by: Aaron Conole > utilities/ovs-tcpdump.in | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/uti

Re: [ovs-dev] [PATCH] userspace: Allow UDP zero checksum with IPv6 tunnels.

2024-02-21 Thread Aaron Conole
Mike Pattrick writes: > On Tue, Feb 20, 2024 at 8:56 PM Mike Pattrick wrote: >> >> This patch adopts the proposed RFC 6935 by allowing null UDP checksums >> even if the tunnel protocol is IPv6. This is already supported by Linux >> through the udp6zerocsumtx tunnel option. It is disabled by

Re: [ovs-dev] [PATCH] userspace: Allow UDP zero checksum with IPv6 tunnels.

2024-02-21 Thread Aaron Conole
Mike Pattrick writes: > This patch adopts the proposed RFC 6935 by allowing null UDP checksums > even if the tunnel protocol is IPv6. This is already supported by Linux > through the udp6zerocsumtx tunnel option. It is disabled by default and > IPv6 tunnels are flagged as requiring a checksum,

[ovs-dev] [PATCH v9 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-20 Thread Aaron Conole
-scripts/flow_reval_monitor.py) which serves as a demonstration of how the new USDT probe might be used going forward. Acked-by: Han Zhou Signed-off-by: Kevin Sprague Co-authored-by: Aaron Conole Signed-off-by: Aaron Conole --- v8 -> v9: Reorganized the flow delete reasons enum Upda

[ovs-dev] [PATCH v9 2/2] rhel: Enable USDT scripts by default in Fedora builds.

2024-02-20 Thread Aaron Conole
All supported versions of Fedora do package libbpf, so it makes sense to enable USDT support. Acked-by: Simon Horman Signed-off-by: Aaron Conole --- rhel/openvswitch-fedora.spec.in | 8 1 file changed, 8 insertions(+) diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch

[ovs-dev] [PATCH v9 0/2] debugging: Add a revalidator probe, and monitor script

2024-02-20 Thread Aaron Conole
Resurrecting a feature from 2022, introduce a probe that indicates why a particular flow may be selected for eviction during revalidation and includes the flow information. The second patch tells fedora builds to include the USDT probe support on Fedora systems. Aaron Conole (1): rhel: Enable

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-20 Thread Aaron Conole
Eelco Chaudron writes: > On 19 Feb 2024, at 19:57, Aaron Conole wrote: > >> Eelco Chaudron writes: >> >>> On 12 Feb 2024, at 15:15, Aaron Conole wrote: >>> >>>> Aaron Conole writes: >>>> >>>>> Eelco

Re: [ovs-dev] [RFC 0/7] selftests: openvswitch: cleanups for running as selftests

2024-02-20 Thread Aaron Conole
Jakub Kicinski writes: > On Fri, 16 Feb 2024 10:28:39 -0500 Aaron Conole wrote: >> The series is a host of cleanups to the openvswitch selftest suite >> which should be ready to run under the netdev selftest runners using >> vng. For now, the testing has been don

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-19 Thread Aaron Conole
Eelco Chaudron writes: > On 12 Feb 2024, at 15:15, Aaron Conole wrote: > >> Aaron Conole writes: >> >>> Eelco Chaudron writes: >>> >>>> On 2 Feb 2024, at 11:31, Adrian Moreno wrote: >>>> >>>>> On 2/1/24 10:02, Eelco

Re: [ovs-dev] [PATCH v3 2/2] conntrack: Handle persistent selection for IP addresses.

2024-02-19 Thread Aaron Conole
Paolo Valerio writes: > The patch, when 'persistent' flag is specified, makes the IP selection > in a range persistent across reboots. > > Signed-off-by: Paolo Valerio > Acked-by: Simon Horman > --- Acked-by: Aaron Conole ___

Re: [ovs-dev] [PATCH v3 1/2] conntrack: Handle random selection for port ranges.

2024-02-19 Thread Aaron Conole
gt; Signed-off-by: Paolo Valerio > Acked-by: Simon Horman > --- Acked-by: Aaron Conole > Documentation/ref/ovs-actions.7.rst | 3 +-- > NEWS| 3 +++ > lib/conntrack.c | 15 --- > lib/conntrack.h

Re: [ovs-dev] [PATCH v3] netlink-conntrack: Optimize flushing ct zone.

2024-02-19 Thread Aaron Conole
Felix Huettner writes: >> > diff --git a/lib/netlink-conntrack.c b/lib/netlink-conntrack.c >> > index 492bfcffb..1b050894d 100644 >> > --- a/lib/netlink-conntrack.c >> > +++ b/lib/netlink-conntrack.c >> > @@ -25,6 +25,7 @@ >> > #include >> > #include >> > #include >> > +#include >> > >>

Re: [ovs-dev] [RFC 4/7] selftests: openvswitch: delete previously allocated netns

2024-02-16 Thread Aaron Conole
Paolo Abeni writes: > On Fri, 2024-02-16 at 10:28 -0500, Aaron Conole wrote: >> Many openvswitch test cases reused netns and interface names. This works >> fine as long as the test case cleans up gracefully. However, if there is >> some kind of ungraceful termination

[ovs-dev] [RFC 7/7] selftests: openvswitch: add config and timeout settings

2024-02-16 Thread Aaron Conole
file which includes a timeout value that should be sufficent for such environments. Signed-off-by: Aaron Conole --- .../testing/selftests/net/openvswitch/config | 50 +++ .../selftests/net/openvswitch/settings| 1 + 2 files changed, 51 insertions(+) create mode 100644

[ovs-dev] [RFC 4/7] selftests: openvswitch: delete previously allocated netns

2024-02-16 Thread Aaron Conole
timeout gets exceeded, while running under very slow debugging conditions. The solution here is to cleanup the netns on executing the next test. Signed-off-by: Aaron Conole --- tools/testing/selftests/net/openvswitch/openvswitch.sh | 4 1 file changed, 4 insertions(+) diff --git a/tools/testing

[ovs-dev] [RFC 6/7] selftests: openvswitch: insert module when running the tests

2024-02-16 Thread Aaron Conole
a different location. Signed-off-by: Aaron Conole --- .../testing/selftests/net/openvswitch/openvswitch.sh | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tools/testing/selftests/net/openvswitch/openvswitch.sh b/tools/testing/selftests/net/openvswitch/openvswitch.sh index a2c106104fb8

[ovs-dev] [RFC 3/7] selftests: openvswitch: use non-graceful kills when needed

2024-02-16 Thread Aaron Conole
Normally a spawned process under OVS is given a SIGTERM when the test ends as part of cleanup. However, in case the process is still lingering for some reason, we also send a SIGKILL to force it down faster. Signed-off-by: Aaron Conole --- tools/testing/selftests/net/openvswitch/openvswitch.sh

[ovs-dev] [RFC 1/7] selftests: openvswitch: add test case error directories to clean list

2024-02-16 Thread Aaron Conole
Normally, the openvswitch selftests don't keep error files around, but if debugging, there is an option to keep these files. The 'clean' target should be informed that they exist to ensure they are deleted properly. Signed-off-by: Aaron Conole --- tools/testing/selftests/net/openvswitch

[ovs-dev] [RFC 5/7] selftests: openvswitch: make arping test a bit 'slower'

2024-02-16 Thread Aaron Conole
, and also increase the opportunity to not miss processing the upcall queue. Signed-off-by: Aaron Conole --- tools/testing/selftests/net/openvswitch/openvswitch.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/openvswitch/openvswitch.sh b/tools

[ovs-dev] [RFC 2/7] selftests: openvswitch: be more verbose with selftest debugging

2024-02-16 Thread Aaron Conole
the amount of details logged to the debug log by trapping all 'info' logs, and all 'ovs_sbx' commands. Signed-off-by: Aaron Conole --- tools/testing/selftests/net/openvswitch/openvswitch.sh | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/net

[ovs-dev] [RFC 0/7] selftests: openvswitch: cleanups for running as selftests

2024-02-16 Thread Aaron Conole
/ \ -- \ make -C tools/testing/selftests/net/openvswitch \ TARGETS=openvswitch TEST_PROGS=openvswitch.sh run_tests Aaron Conole (7): selftests: openvswitch: add test case error directories to clean list selftests: openvswitch: be more verbose with selftest debugging selftests

Re: [ovs-dev] [PATCH v3] netlink-conntrack: Optimize flushing ct zone.

2024-02-15 Thread Aaron Conole
Felix Huettner via dev writes: > Previously the kernel did not provide a netlink interface to flush/list > only conntrack entries matching a specific zone. With [1] and [2] it is now > possible to flush and list conntrack entries filtered by zone. Older > kernels not yet supporting this feature

Re: [ovs-dev] [PATCH v2 2/2] conntrack: Handle persistent selection for IP addresses.

2024-02-15 Thread Aaron Conole
Paolo Valerio writes: > The patch, when 'persistent' flag is specified, makes the IP selection > in a range persistent across reboots. > > Signed-off-by: Paolo Valerio > --- > NEWS | 3 ++- > lib/conntrack.c | 27 +-- > lib/conntrack.h | 1 + >

Re: [ovs-dev] [PATCH] conntrack: Fix flush not flushing all elements.

2024-02-15 Thread Aaron Conole
Xavier Simonart writes: > When a ct element was cleaned, the cmap could be shrinked, potentially > causing some elements to be skipped in the flush iteration. > > Signed-off-by: Xavier Simonart > --- This only applies to netdev datapaths, so might be good to mention it in the commit message.

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-12 Thread Aaron Conole
Aaron Conole writes: > Eelco Chaudron writes: > >> On 2 Feb 2024, at 11:31, Adrian Moreno wrote: >> >>> On 2/1/24 10:02, Eelco Chaudron wrote: >>>> >>>> >>>> On 31 Jan 2024, at 18:03, Aaron Conole wrote: >>>> >&g

Re: [ovs-dev] [PATCH branch-3.1 0/2] Release patches for v3.1.4.

2024-02-08 Thread Aaron Conole
3 deletions(-) Series: Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-3.2 0/2] Release patches for v3.2.2.

2024-02-08 Thread Aaron Conole
3 deletions(-) Series: Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-2.17 0/2] Release patches for v2.17.9.

2024-02-08 Thread Aaron Conole
3 deletions(-) Series: Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH branch-3.0 0/2] Release patches for v3.0.6.

2024-02-08 Thread Aaron Conole
3 deletions(-) Series: Acked-by: Aaron Conole ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH net v2 0/2] net: openvswitch: limit the recursions from action sets

2024-02-07 Thread Aaron Conole
, this series provides a selftest in 2/2 that can be used to determine if the OVS module is allowing unbounded access. It can be safely omitted where the ovs selftest framework isn't available. Aaron Conole (2): net: openvswitch: limit the number of recursions from action sets selftests

[ovs-dev] [PATCH net v2 2/2] selftests: openvswitch: Add validation for the recursion test

2024-02-07 Thread Aaron Conole
Add a test case into the netlink checks that will show the number of nested action recursions won't exceed 16. Going to 17 on a small clone call isn't enough to exhaust the stack on (most) systems, so it should be safe to run even on systems that don't have the fix applied. Signed-off-by: Aaron

[ovs-dev] [PATCH net v2 1/2] net: openvswitch: limit the number of recursions from action sets

2024-02-07 Thread Aaron Conole
Signed-off-by: Aaron Conole --- v1->v2: Switch to tracking the stack depth by using a depth argument rather than a per-cpu counter. net/openvswitch/flow_netlink.c | 49 +++--- 1 file changed, 33 insertions(+), 16 deletions(-) diff --git a/net/openvswitch/flo

Re: [ovs-dev] [PATCH net 1/2] net: openvswitch: limit the number of recursions from action sets

2024-02-06 Thread Aaron Conole
Eric Dumazet writes: > On Tue, Feb 6, 2024 at 3:55 PM Aaron Conole wrote: >> >> >> Oops - I didn't consider it. >> >> Given that, maybe the best approach would not to rely on per-cpu >> counter. I'll respin in the next series with a depth counter

Re: [ovs-dev] [PATCH net 1/2] net: openvswitch: limit the number of recursions from action sets

2024-02-06 Thread Aaron Conole
Eric Dumazet writes: > On Tue, Feb 6, 2024 at 2:11 PM Aaron Conole wrote: >> >> The ovs module allows for some actions to recursively contain an action >> list for complex scenarios, such as sampling, checking lengths, etc. >> When these actions are copied i

[ovs-dev] [PATCH net 2/2] selftests: openvswitch: Add validation for the recursion test

2024-02-06 Thread Aaron Conole
Add a test case into the netlink checks that will show the number of nested action recursions won't exceed 16. Going to 17 on a small clone call isn't enough to exhaust the stack on (most) systems, so it should be safe to run even on systems that don't have the fix applied. Signed-off-by: Aaron

[ovs-dev] [PATCH net 1/2] net: openvswitch: limit the number of recursions from action sets

2024-02-06 Thread Aaron Conole
Signed-off-by: Aaron Conole --- net/openvswitch/flow_netlink.c | 33 - 1 file changed, 28 insertions(+), 5 deletions(-) diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c index 88965e2068ac..ba5cfa67a720 100644 --- a/net/openvswitch/flow

[ovs-dev] [PATCH net 0/2] net: openvswitch: limit the recursions from action sets

2024-02-06 Thread Aaron Conole
, this series provides a selftest in 2/2 that can be used to determine if the OVS module is allowing unbounded access. It can be safely omitted where the ovs selftest framework isn't available. Aaron Conole (2): net: openvswitch: limit the number of recursions from action sets selftests

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-02 Thread Aaron Conole
Eelco Chaudron writes: > On 2 Feb 2024, at 11:31, Adrian Moreno wrote: > >> On 2/1/24 10:02, Eelco Chaudron wrote: >>> >>> >>> On 31 Jan 2024, at 18:03, Aaron Conole wrote: >>> >>>> Eelco Chaudron writes: >>>> >>>

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-02 Thread Aaron Conole
Adrian Moreno writes: > On 2/1/24 10:02, Eelco Chaudron wrote: >> On 31 Jan 2024, at 18:03, Aaron Conole wrote: >> >>> Eelco Chaudron writes: >>> >>>> On 25 Jan 2024, at 21:55, Aaron Conole wrote: >>>> >>>>> From: Kevin S

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-02 Thread Aaron Conole
Eelco Chaudron writes: > On 1 Feb 2024, at 18:28, Aaron Conole wrote: > >> Eelco Chaudron writes: >> >>> On 31 Jan 2024, at 18:03, Aaron Conole wrote: >>> >>>> Eelco Chaudron writes: >>>> >>>>> On 25 Jan 2024, at 21:55,

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-02-01 Thread Aaron Conole
Eelco Chaudron writes: > On 31 Jan 2024, at 18:03, Aaron Conole wrote: > >> Eelco Chaudron writes: >> >>> On 25 Jan 2024, at 21:55, Aaron Conole wrote: >>> >>>> From: Kevin Sprague >>>> >>>> During normal operations,

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-01-31 Thread Aaron Conole
Eelco Chaudron writes: > On 25 Jan 2024, at 21:55, Aaron Conole wrote: > >> From: Kevin Sprague >> >> During normal operations, it is useful to understand when a particular flow >> gets removed from the system. This can be useful when debugging performance >>

Re: [ovs-dev] [PATCH net-next] selftests: openvswitch: Test ICMP related matches work with SNAT

2024-01-31 Thread Aaron Conole
@faucet.nz/ > Link: https://mail.openvswitch.org/pipermail/ovs-dev/2024-January/410476.html > Suggested-by: Aaron Conole > Signed-off-by: Brad Cowie > --- I tested this on a patched kernel and as well as an unpatched kernel and got the following: 6.5.5-200: TEST: ip4-nat-related: ICMP related matches

Re: [ovs-dev] [PATCH v8 2/2] rhel: Enable USDT scripts by default in Fedora builds.

2024-01-30 Thread Aaron Conole
Ilya Maximets writes: > On 1/25/24 21:55, Aaron Conole wrote: >> All supported versions of Fedora do package libbpf, so it >> makes sense to enable USDT support. >> >> Signed-off-by: Aaron Conole >> --- >> v8: Include the correct devel package a

Re: [ovs-dev] [PATCH v7 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-01-26 Thread Aaron Conole
Simon Horman writes: > On Thu, Jan 25, 2024 at 12:05:29PM -0500, Aaron Conole wrote: >> From: Kevin Sprague >> >> During normal operations, it is useful to understand when a particular flow >> gets removed from the system. This can be useful when debugging performanc

Re: [ovs-dev] [PATCH v7 2/2] rhel: Enable USDT scripts by default in Fedora builds

2024-01-26 Thread Aaron Conole
Simon Horman writes: > On Thu, Jan 25, 2024 at 12:05:30PM -0500, Aaron Conole wrote: >> All supported versions of Fedora do package libbpf, so it >> makes sense to enable USDT support. >> >> Signed-off-by: Aaron Conole >> --- >> rhel/openvswitch-fedora.

Re: [ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-01-26 Thread Aaron Conole
Han Zhou writes: > On Thu, Jan 25, 2024 at 12:55 PM Aaron Conole wrote: >> >> From: Kevin Sprague >> >> During normal operations, it is useful to understand when a particular flow >> gets removed from the system. This can be useful when debugging performan

[ovs-dev] [PATCH v8 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-01-25 Thread Aaron Conole
-scripts/flow_reval_monitor.py) which serves as a demonstration of how the new USDT probe might be used going forward. Signed-off-by: Kevin Sprague Co-authored-by: Aaron Conole Signed-off-by: Aaron Conole --- Documentation/topics/usdt-probes.rst | 1 + ofproto/ofproto-dpif-upcall.c

[ovs-dev] [PATCH v8 0/2] debugging: Add a revalidator probe, and monitor script

2024-01-25 Thread Aaron Conole
Resurrecting a feature from 2022, introduce a probe that indicates why a particular flow may be selected for eviction during revalidation and includes the flow information. The second patch tells fedora builds to include the USDT probe support on Fedora systems. Aaron Conole (1): rhel: Enable

[ovs-dev] [PATCH v8 2/2] rhel: Enable USDT scripts by default in Fedora builds.

2024-01-25 Thread Aaron Conole
All supported versions of Fedora do package libbpf, so it makes sense to enable USDT support. Signed-off-by: Aaron Conole --- v8: Include the correct devel package as a dependency rhel/openvswitch-fedora.spec.in | 8 1 file changed, 8 insertions(+) diff --git a/rhel/openvswitch

[ovs-dev] [PATCH v7 2/2] rhel: Enable USDT scripts by default in Fedora builds

2024-01-25 Thread Aaron Conole
All supported versions of Fedora do package libbpf, so it makes sense to enable USDT support. Signed-off-by: Aaron Conole --- rhel/openvswitch-fedora.spec.in | 5 + 1 file changed, 5 insertions(+) diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index

[ovs-dev] [PATCH v7 0/2] debugging: Add a revalidator probe, and monitor script

2024-01-25 Thread Aaron Conole
Resurrecting a feature from 2022, introduce a probe that indicates why a particular flow may be selected for eviction during revalidation and includes the flow information. The second patch tells fedora builds to include the USDT probe support on Fedora systems. Aaron Conole (1): rhel: Enable

[ovs-dev] [PATCH v7 1/2] revalidator: Add a USDT probe during flow deletion with purge reason.

2024-01-25 Thread Aaron Conole
-scripts/flow_reval_monitor.py) which serves as a demonstration of how the new USDT probe might be used going forward. Signed-off-by: Kevin Sprague Co-authored-by: Aaron Conole Signed-off-by: Aaron Conole --- Documentation/topics/usdt-probes.rst | 1 + ofproto/ofproto-dpif-upcall.c

Re: [ovs-dev] [PATCH] dp-packet: Reset offload flags when clearing a packet.

2024-01-24 Thread Aaron Conole
Dumitru Ceara writes: > On 1/23/24 00:11, Mike Pattrick wrote: >> The OVN test suite identified a bug in dp_packet_ol_send_prepare() where >> a BFD packet flagged as double encapsulated would trigger a seg fault. >> The problem surfaced because bfd_put_packet was reusing a packet >> allocated on

Re: [ovs-dev] [PATCH ovn] checkpatch.py: Port checkpatch related changes from the OVS repo.

2024-01-19 Thread Aaron Conole
Dumitru Ceara writes: > On 1/17/24 21:40, Mark Michelson wrote: >> On 1/16/24 11:23, Numan Siddique wrote: >>> On Tue, Jan 16, 2024 at 8:09 AM Dumitru Ceara wrote: This picks up the following OVS changes:    00d3d4a7d375 ("checkpatch: Avoid catastrophic backtracking.")   

Re: [ovs-dev] [PATCH v2 1/3] ofproto-dpif-upcall: Change flow dump duration message to WARN level.

2024-01-16 Thread Aaron Conole
Eelco Chaudron writes: > On 16 Jan 2024, at 0:24, Ilya Maximets wrote: > >> On 1/10/24 12:25, Eelco Chaudron wrote: >>> Currently the 'Spent an unreasonably long Xms dumping flows' message >>> is set to the INFO level. However, based on this, we are also >>> drastically limiting the number of

Re: [ovs-dev] [PATCH v2 3/3] timeval: Add coverage counter for long poll interval events.

2024-01-15 Thread Aaron Conole
storical context. > > Reported-at: > https://lists.linuxfoundation.org/pipermail/ovs-discuss/2023-June/052523.html > Suggested-by: Martin Kennelly > Co-Authored-By: Aaron Conole > Signed-off-by: Aaron Conole > Signed-off-by: Eelco Chaudro

Re: [ovs-dev] [PATCH v2 2/3] ofproto-dpif-upcall: Add flow_limit coverage counters.

2024-01-15 Thread Aaron Conole
Eelco Chaudron writes: > Add new coverage counters that might help debugging flow_limit > related issues. > > Signed-off-by: Eelco Chaudron > --- Thanks, applied. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH v2 1/3] ofproto-dpif-upcall: Change flow dump duration message to WARN level.

2024-01-15 Thread Aaron Conole
Eelco Chaudron writes: > Currently the 'Spent an unreasonably long Xms dumping flows' message > is set to the INFO level. However, based on this, we are also > drastically limiting the number of flows in the datapath, and this > would warrant a WARNING level. > > Acked-by: Simon Horman >

Re: [ovs-dev] [PATCH v5 3/3] system-traffic.at: Test conntrack + FTP server running on a non-standard port.

2024-01-10 Thread Aaron Conole
Viacheslav Galaktionov via dev writes: > All existing test iterations assume that the FTP server is running on a > standard port, which may not always be the case. These tests helped find > problems in conntrack alg processing with non-standard ports. > > Perform the necessary adjustments to

Re: [ovs-dev] [PATCH v5 2/3] conntrack: Use helpers from committed connections.

2024-01-10 Thread Aaron Conole
Viacheslav Galaktionov via dev writes: > When a packet hits a flow rule without an explicitly specified helper, > OvS has to rely on automatic application layer gateway detection to > find related connections. This works as long as services are running on > their standard ports, e.g. when FTP

  1   2   3   4   5   6   7   8   9   10   >