Re: [ovs-dev] [PATCH v2] datapath-windows: Fix GENEVE option header

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 3/6/17, 8:16 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >From: Alin Serdean <aserd...@cloudbasesolutio

Re: [ovs-dev] [PATCH v2] windows: Fix uninitialized variable in netlink-socket

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 3/6/17, 8:22 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >From: Alin Serdean <aserd...@cloudbaseso

[ovs-dev] [PATCH] datapath-windows: Trigger conntrack event after setting mark and label

New Conntrack Entry event should be triggered after setting the mark and label fields. The current RW lock implementation prevents Event Handler from reading the entry until mark/label is set. Fixing the workflow to trigger the event after setting mark/label. Signed-off-by: Sairam Venugopal

Re: [ovs-dev] [PATCH v2] msi: add ovs-vswitchd trigger info

Thanks for sending this over. I was able to verify that ovs ports were still retained after a reboot. It will however be good to add the command to the documentation for folks who don’t use the MSI. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 2/21/17, 1:50 PM, "o

Re: [ovs-dev] [PATCH 6/6] datapath-windows: GENEVE Check for flow destination port

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 1/10/17, 8:48 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >Change the UDP destination port(GENEVE heade

Re: [ovs-dev] [PATCH 5/6] datapath-windows: STT Check for flow destination port

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 1/10/17, 8:48 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >Change the TCP destination port(STT heade

Re: [ovs-dev] [PATCH 4/6] datapath-windows: VXLAN Check for flow destination port

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 1/10/17, 8:48 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >Change the UDP destination port(VXLAN heade

Re: [ovs-dev] [PATCH v4 3/5] datapath-windows: Retain MRU value in the OvsForwardingContext.

My main comment here would be to see if we can add the MRU to the NBL Buffer Context instead of OvsForwardingContext - https://github.com/openvswitch/ovs/blob/75e2077e0c43224bcca92746b28b01a4936fc101/datapath-windows/ovsext/BufferMgmt.h#L51 This will drastically reduce the amount of changes

Re: [ovs-dev] [PATCH] windows: wmi add include

Alin, Can you open a bug in ovs-issues and move the stack trace to that instead? You can tag the commit message with the ovs-issue id. Thanks, Sairam On 1/27/17, 12:41 PM, "ovs-dev-boun...@openvswitch.org on behalf of Guru Shetty"

Re: [ovs-dev] [PATCH v3 1/4] datapath-windows: OvsUpdateIPv4Header remove unnecessary addition

Re-Acking - Acked-by: Sairam Venugopal <vsai...@vmware.com> On 1/26/17, 3:38 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >From: Alin Serdean <ase

Re: [ovs-dev] [PATCH v3 2/4] datapath-windows: Add function to get continuous buffer from context

Re-acking - Acked-by: Sairam Venugopal <vsai...@vmware.com> On 1/26/17, 3:45 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >From: Alin Serdean <ase

Re: [ovs-dev] [PATCH v3 4/4] datapath-windows: Add support for OVS_KEY_ATTR_TCP set action

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 1/26/17, 3:43 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >From: Alin Serdean <aserd...@cloudbasesolut

Re: [ovs-dev] [PATCH] documentation: Windows support multiple VTEP/NICs

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 1/26/17, 6:30 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >Multiple VTEP and multiple physical NICs are

[ovs-dev] [PATCH v2] Windows: Fix wmi.c to use count of wchar_t instead of sizeof

Venugopal <vsai...@vmware.com> Reported-by: Sairam Venugopal <vsai...@vmware.com> Reported-at: openvswitch/ovs-issues#121 --- lib/wmi.c | 38 +- 1 file changed, 21 insertions(+), 17 deletions(-) diff --git a/lib/wmi.c b/lib/wmi.c index e38b482..63

Re: [ovs-dev] [PATCH] windows: WSAPoll broken on windows

Thanks for the patch. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 12/15/16, 6:50 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >Unfortunately, WSAP

Re: [ovs-dev] [PATCH] windows: wmi add include

ot; <aserd...@cloudbasesolutions.com> wrote: >Answer inline. > >Thanks, >Alin. > >> -Original Message- >> From: Sairam Venugopal [mailto:vsai...@vmware.com] >> Sent: Friday, January 27, 2017 2:36 AM >> To: Alin Serdean <aserd...@cloudbasesoluti

[ovs-dev] [PATCH] Windows: Fix wmi.c to use count of wchar_t instead of sizeof

-by: Sairam Venugopal <vsai...@vmware.com> Reported-by: Sairam Venugopal <vsai...@vmware.com> Reported-at: openvswitch/ovs-issues#121 --- lib/wmi.c | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) diff --git a/lib/wmi.c b/lib/wmi.c index e38b482..a9

Re: [ovs-dev] [PATCH] windows: wmi add include

Hi Alin, Does this fix the access violation error in wcscat_s inside create_wmi_port()? I ran into this issue when creating a bridge previously. I will apply this patch and re-test. Thanks, Sairam On 1/26/17, 2:15 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean"

Re: [ovs-dev] [PATCH v3] datapath-windows: Add a wrapper to retreive external vport

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 1/24/17, 12:37 PM, "ovs-dev-boun...@openvswitch.org on behalf of Shashank Ram" <ovs-dev-boun...@openvswitch.org on behalf of r...@vmware.com> wrote: >This wrapper is to simplify readability. > >Signed-off-by

Re: [ovs-dev] [PATCH v2] datapath-windows: Add a wrapper to retreive external vport

Hi Shashank, Please find my comments inline. Thanks, Sairam On 1/24/17, 12:25 PM, "ovs-dev-boun...@openvswitch.org on behalf of Shashank Ram" wrote: >This wrapper is to simplify readability. > >Signed-off-by: Shashank Ram

Re: [ovs-dev] [PATCH v2 5/5] datapath-windows: Fragment NBL based on MRU size

Hi Anand, Thanks for the patch. Please find my comments inline. Thanks, Sairam On 1/12/17, 1:13 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" wrote: >MRU value is updated only for the Ipv4 fragments. If

Re: [ovs-dev] [PATCH v2 2/5] datapath-windows: Added Ipv4 fragments support in Conntrack

Please find the comments inline. I have prefixed them with “sai:” Thanks, Sairam On 1/12/17, 1:13 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" wrote: >This patch adds support for Ipv4 fragments in

Re: [ovs-dev] [PATCH 4/6] datapath-windows: VXLAN Check for flow destination port

Do we need to convert the tunKey->dst_port to network byte order? On 1/10/17, 8:48 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: >Change the UDP destination port(VXLAN header) to check if

Re: [ovs-dev] [PATCH 3/6] datapath-windows: Add support for OVS_TUNNEL_KEY_ATTR_TP_DST

We should consolidate this logic into 1 function for retrieving the tunKey from attr. This can be done separately. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 1/10/17, 8:48 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvs

Re: [ovs-dev] [PATCH 2/6] datapath-windows: Allow tunnel action to modify destination port

Patch 2 and 3 could’ve been combined into the same patch since they are about dst_port. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 1/10/17, 8:48 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org

Re: [ovs-dev] [PATCH] windows: Change driver and MSI company name to LF

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 12/6/16, 3:30 PM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >Until now we used 'Open vSwitch' as the

Re: [ovs-dev] [PATCH v2 5/5] datapath-windows: Add support for OVS_KEY_ATTR_TCP set action

Please see my comment inline: On 1/6/17, 11:33 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" wrote: >This patch adds support for set action with OVS_KEY_ATTR_TCP attribute >(change TCP source or

Re: [ovs-dev] [PATCH v2 3/5] datapath-windows: Fix typo in OvsUpdateIPv4Header

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 1/6/17, 11:33 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >Found by inspection. > >Signed-off-

Re: [ovs-dev] [PATCH v2 2/5] datapath-windows: Add function to get continuous buffer from context

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 1/6/17, 11:33 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >This patch extracts the code that tries to get

Re: [ovs-dev] [PATCH v2 1/5] datapath-windows: OvsUpdateIPv4Header remove unnecessary addition

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 1/6/17, 11:33 AM, "ovs-dev-boun...@openvswitch.org on behalf of Alin Serdean" <ovs-dev-boun...@openvswitch.org on behalf of aserd...@cloudbasesolutions.com> wrote: >bufferStart can be used directly to access t

Re: [ovs-dev] [PATCH 1/3 v8] Windows: Add internal switch port per OVS bridge

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 12/20/16, 11:41 AM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >From: Alin Serdean <aserd...@cloudbasesolutions.com> > >This patch updates the following commands in the vswitch: > ovs-vsctl a

Re: [ovs-dev] [PATCH 2/3 v8] datapath-windows: Add multiple switch internal ports

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 12/20/16, 11:42 AM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: > >This patch adds multiple internal ports support to the windows datapath. >All tunnels types have been updated to accommodate this n

Re: [ovs-dev] [PATCH 1/3 v7] Windows: Add internal switch port per OVS bridge

Thanks for the patch! Acked-by: Sairam Venugopal <vsai...@vmware.com> On 12/15/16, 11:37 AM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >This patch updates the following commands in the vswitch: > ovs-vsctl add-br br-test > ovs-vsctl del-br br-t

Re: [ovs-dev] [PATCH 3/3 v7] Windows: document multiple NIC support setup

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 12/15/16, 11:37 AM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >This patch updates the documentation on how to set up OVS with multiple >NICs. > >Also update the documentation to show users h

Re: [ovs-dev] [PATCH v2] Windows: Implement Hyper-V VIF discovery agent.

Hi Yin, Looks like all of your files precede with invalid BOM character - +< Can you send out a patch after cleaning this up? Also, looks like you are targetting .Net 4.5.2 which isn¹t default in Visual Studio 2013. Can you target .Net 4.5 instead? Thanks, Sairam On 12/12/16, 2:20 PM, "Yin

[ovs-dev] [PATCH v3 0/4] datapath-windows: Enable support for tracking FTP connections

v3: Address alignment and new-line issues. Sairam Venugopal (4): datapath-windows: Conntrack - Fix OvsGetTcpPayloadLength() datapath-windows: Cleanup Conntrack definitions and introduce related entries datapath-windows: Conntrack - Introduce support for tracking related connections

[ovs-dev] [PATCH v3 4/4] datapath-windows: Conntrack - Enable FTP support

-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/Conntrack.c | 61 ++- datapath-windows/ovsext/Conntrack.h | 8 datapath-windows/ovsext/Netlink/Netlink.c | 16 datapath-windows/ovsext/Netlink/Netlink.h | 1 + da

[ovs-dev] [PATCH v3 3/4] datapath-windows: Conntrack - Introduce support for tracking related connections

table. If there is a matching FTP data connection, then the state for that connection is marked as RELATED. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/automake.mk| 2 + datapath-windows/ovsext/Conntrack-ftp.c | 237 ++ da

[ovs-dev] [PATCH v2 1/4] datapath-windows: Conntrack - Fix OvsGetTcpPayloadLength()

Move the OvsGetTcpPayloadLength() to common header. Update the code to check for null references and the correct size of the TCP header. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/Conntrack-tcp.c | 15 --- datapath-windows/ovsext/Connt

[ovs-dev] [PATCH v2 4/4] datapath-windows: Conntrack - Enable FTP support

-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/Conntrack.c | 61 ++- datapath-windows/ovsext/Conntrack.h | 8 datapath-windows/ovsext/Netlink/Netlink.c | 16 datapath-windows/ovsext/Netlink/Netlink.h | 1 + da

[ovs-dev] [PATCH v2 0/4] datapath-windows: Enable support for tracking FTP connections

and Shashank's review comments. Sairam Venugopal (4): datapath-windows: Conntrack - Fix OvsGetTcpPayloadLength() datapath-windows: Cleanup Conntrack definitions and introduce related entries datapath-windows: Conntrack - Introduce support for tracking related connections datapath-windows

Re: [ovs-dev] [PATCH] datapath-windows: Fix issues related to packet completion

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 12/8/16, 1:31 PM, "Shashank Ram" <r...@vmware.com> wrote: >- In OvsTunnelPortTx() function, for packets coming from the > VIF port, the srcVportNo, srcPortId and srcNicIndex were > getting modified for the

Re: [ovs-dev] [PATCH] datapath-windows: Remove dead code from PacketIO

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 12/8/16, 9:57 AM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >Assigning value to 'nativeNbls' has no effect outside the function and >the variable is not used inside the function. > >Signed-o

Re: [ovs-dev] [PATCH 1/4] datapath-windows: Force driver version to depend on a variable

Thanks for sending this out. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 12/5/16, 6:58 PM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >The following components use Windows driver information: >- System (inf file); used during device instal

Re: [ovs-dev] [PATCH 1/4] datapath-windows: Force driver version to depend on a variable

Thanks for sending this out. On 12/5/16, 6:58 PM, "Alin Serdean" wrote: >The following components use Windows driver information: >- System (inf file); used during device installation >- Resource file (rc file); used by applications when looking over

Re: [ovs-dev] [PATCH 4/5] datapath-windows: Fix function prototypes

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 12/5/16, 7:39 AM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >There is a mismatch between OvsInitCompletionList and >OvsAddPktCompletionList >prototypes. > >Eg: >https://

Re: [ovs-dev] [PATCH 1/5] datapath-windows: Ignore VStudio 2015 temporary files

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 12/5/16, 7:39 AM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >Ignore the temporary files created by Visual Studio 2015 when opening >a solution. > >Signed-off-by: Alin Gabriel Serdea

Re: [ovs-dev] [PATCH 3/4] datapath-windows: Conntrack - Introduce support for tracking related connections

ors. > >Other small comments inlined. > >> -Original Message- >> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- >> boun...@openvswitch.org] On Behalf Of Sairam Venugopal >> Sent: Thursday, December 1, 2016 11:19 PM >> To: d...@openvswitch.

Re: [ovs-dev] [PATCH 2/4] datapath-windows: Cleanup Conntrack definitions and introduce related entries

t I have a question regarding the includes. Do you need >"NetProto.h", ? > >Thanks, >Alin. > >> -Original Message- >> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- >> boun...@openvswitch.org] On Behalf Of Sairam Venugopal >> Sent: Thursd

[ovs-dev] [PATCH] datapath-windows: Fix the redefinition of variables

Some of the variables were getting re-defined in the function. This causes compiler warning in Windows SDK 10. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/BufferMgmt.c | 22 +++--- datapath-windows/ovsext/Offload.c| 8 2

[ovs-dev] [PATCH] datapath-windows: Fix typos in function summaries

Fixed mismatch between function names and descriptions. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/BufferMgmt.c | 2 +- datapath-windows/ovsext/Conntrack.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath-windows/

[ovs-dev] [PATCH 3/4] datapath-windows: Conntrack - Introduce support for tracking related connections

table. If there is a matching FTP data connection, then the state for that connection is marked as RELATED. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/automake.mk| 2 + datapath-windows/ovsext/Conntrack-ftp.c | 234 ++ da

[ovs-dev] [PATCH 0/4] datapath-windows: Enable support for tracking FTP connections

Add support for maintaining and tracking related connections. This patch introduces the concept of related-connections table. There is an FTP parser in place to parse FTP PASV and PORT commands. Support for traking extended FTP commands will be added in subsequently. Sairam Venugopal (4

[ovs-dev] [PATCH 4/4] datapath-windows: Conntrack - Enable FTP support

-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/Conntrack.c | 62 +++-- datapath-windows/ovsext/Conntrack.h | 8 + datapath-windows/ovsext/Switch.c| 8 + 3 files changed, 76 insertions(+), 2 deletions(-) diff --git a/da

[ovs-dev] [PATCH 2/4] datapath-windows: Cleanup Conntrack definitions and introduce related entries

Consolidate the reusable structs and includes. Introduce the new OVS_CT_REL_ENTRY to track related connections. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/Conntrack.c | 12 datapath-windows/ovsext/Conntrack.

Re: [ovs-dev] [PATCH] datapath-windows: pop buffer from packet / pop_vlan bug

Looks like my previous Acked-by was missed out. Resending this. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 10/27/16, 4:48 PM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >Switch too memmove(RtlMoveMemory) instead of copy and predefined allocated &g

[ovs-dev] [PATCH v2] datapath-windows: Enable support for tracking ICMP code and type

Add support for tracking ICMP code and Type in the Hyper-V Conntrack module. This code is similar to the userspace connection tracker. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/Conntrack-icmp.c | 84 +++ datapath-windows/

Re: [ovs-dev] [PATCH 5/5 v2] datapath-windows: fix return value in conntrack

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 10/27/16, 1:45 PM, "Sairam Venugopal" <vsai...@vmware.com> wrote: >Acked-by: Sairam Venugopal <vsai...@vmware.com> > > >On 10/27/16, 11:57 AM, "Alin Serdean" <aserd...@cloudbasesol

Re: [ovs-dev] [PATCH v4 1/3] Windows: Add internal switch port per OVS bridge

I had acked it earlier. Will re-ack that patch if needed. Thanks, Sairam On 11/4/16, 7:55 AM, "Guru Shetty" <g...@ovn.org> wrote: >On 10 October 2016 at 15:47, Sairam Venugopal <vsai...@vmware.com> wrote: > >> Sorry for the delay in the review. >

Re: [ovs-dev] [PATCH 3/3 v5] Windows: document multiple NIC support setup

Hi Alin, We had discussed this over IRC, will you be adding some more example to the documentation? Mainly around internal devices? Thanks, Sairam On 9/13/16, 11:13 AM, "Alin Serdean" wrote: >This patch updates the documentation on how to set up OVS with

Re: [ovs-dev] [PATCH 3/5 v2] datapath-windows: clean code in gre

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 10/27/16, 11:55 AM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >The purpose of this patch is to make the code more readable and >fix a static analyzer warning. > >Signed-off-by: Alin Gabriel Serdea

Re: [ovs-dev] [PATCH 1/5 v2] datapath-windows: clean code in vxlan

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 10/27/16, 11:53 AM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >The purpose of this patch is to make the code more readable and >fix a static analyzer warning. > >Signed-off-by: Alin Gabriel Serdea

Re: [ovs-dev] [PATCH 2/5 v2] datapath-windows: clean code in stt

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 10/27/16, 11:55 AM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >The purpose of this patch is to make the code more readable and >fix a static analyzer warning. > >Signed-off-by: Alin Gabriel Serdea

Re: [ovs-dev] [PATCH 4/5 v2] datapath-windows: clean code in geneve

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 10/27/16, 11:57 AM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >The purpose of this patch is to make the code more readable and >fix a static analyzer warning. > >Signed-off-by: Alin Gabriel Serdea

[ovs-dev] [PATCH] datapath-windows: Enable support for tracking ICMP code and type

Add support for tracking ICMP code and Type in the Hyper-V Conntrack module. This code is similar to the userspace connection tracker. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/Conntrack-icmp.c | 80 +++ datapath-windows/

Re: [ovs-dev] [PATCH 1/2] netdev-windows: fix ofpbuf initialization

I thought we had set warnings to be treated as error. Appveyor didn¹t catch this one either. Thanks for fixing this. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 10/27/16, 12:20 PM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >ofpbuf_const_i

Re: [ovs-dev] [PATCH 5/5 v2] datapath-windows: fix return value in conntrack

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 10/27/16, 11:57 AM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >'status' is of type 'NTSTATUS' and NlFillOvsMsgForNfGenMsg is of type >bool. > >Signed-off-by: Alin Gabriel Serdean <aserd...@cl

Re: [ovs-dev] [PATCH 2/2] netdev-windows: use bitwise comparison for flags

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 10/27/16, 12:20 PM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >Use bitwise comparison when checking flags set by the kernel for the >device. > >Signed-off-by: Alin Gabriel Serdean <aserd.

Re: [ovs-dev] [PATCH] dpif-netdev: Fix windows build.

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 10/19/16, 1:50 PM, "Daniele Di Proietto" <diproiet...@vmware.com> wrote: >OVS_ALIGNED_VAR(...) should be at the beginning of a definition, as >the example in include/openvswitch/compiler.h shows. > >Fixes:

Re: [ovs-dev] [PATCH v4 1/3] Windows: Add internal switch port per OVS bridge

Sorry for the delay in the review. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 8/12/16, 6:06 PM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >This patch updates the following commands in the vswitch: >ovs-vsctl add-br br-test >ovs-vsctl del-br

Re: [ovs-dev] [PATCH v2] datapath-windows: Set isActivated flag only on success

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 10/10/16, 3:15 PM, "Shashank Ram" <r...@vmware.com> wrote: >@Switch.c: Modifies OvsActivateSwitch() function >to mark the switch as activated only if the >the status is success. The callers itself >only cal

Re: [ovs-dev] [PATCH] datapath_windows: Set isActivated flag only on success

Thanks for the patch. Usually we append Œdatapath-windows: Brief description¹ for Windows datapath commmits. Had a comment which is inlined. Thanks, Sairam On 10/5/16, 2:33 PM, "Shashank Ram" wrote: >@Switch.c: Modifies OvsActivateSwitch() function >to mark the switch as

Re: [ovs-dev] [PATCH v3] datapath-windows: Add define for last module number

Thanks for fixing this. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 9/19/16, 4:16 PM, "Shashank Ram" <r...@vmware.com> wrote: >Adds a define for the last defined module number. > >Change-Id: I1ea9230317a849e911900cf69e96ed85a65d3a8c >Signed-off

Re: [ovs-dev] [PATCH v2] datapath-windows: Add define for last module number

Hi Shashank, Looks like the patch is missing ancestor history. Can you resend this patch after fixing this? Thanks, Sairam On 9/19/16, 3:24 PM, "Shashank Ram" wrote: >Adds a define for the last defined module number. > >Change-Id: I1ea9230317a849e911900cf69e96ed85a65d3a8c

Re: [ovs-dev] [PATCH] datapath-windows: Add define for last module number

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 9/15/16, 5:46 PM, "Shashank Ram" <r...@vmware.com> wrote: >Adds a define for the last defined module number. > >Signed-off-by: Shashank Ram <r...@vmware.com> >--- > datapath-windows/ovsext/Debug.h |

[ovs-dev] [PATCH v2] Windows: Update the Driver and MSI properties

Fix the legal notice section in OVSEXT.SYS properties. Update the MSI to include the properties mentioned in MSDN - 'Extension driver MSI packaging requirements' section - https://msdn.microsoft.com/windows/hardware/drivers/network/extension-driver-msi-packaging-requirements Signed-off-by: Sairam

[ovs-dev] [PATCH v2] datapath-windows: Fix conntrack event handler

Fix an issue with the OvsReadEventCmdHandler when handling conntrack events. Driver initiated messages should have zero seq number. Reverting the previous review comment since the inputBuffer in this case will be NULL. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> Acked-by: Nithi

Re: [ovs-dev] [PATCH] datapath-windows: update CodingStyle

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 9/11/16, 10:56 PM, "Nithin Raju" <nit...@vmware.com> wrote: >Signed-off-by: Nithin Raju <nit...@vmware.com> >--- > datapath-windows/CodingStyle | 2 ++ > 1 file changed, 2 insertions(+) > >diff -

[ovs-dev] [PATCH] datapath-windows: Fix conntrack event handler

Fix an issue with the OvsReadEventCmdHandler when handling conntrack events. Reverting the previous review comment since the inputBuffer in this case will be NULL. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/Datapath.c | 3 +-- 1 file changed, 1 ins

Re: [ovs-dev] [PATCH] Windows: Update the Driver and MSI properties

w >>i >>ndows_hardware_drivers_network_extension-2Ddriver-2Dmsi-2Dpackaging-2Dreq >>u >>irements=CwIDaQ=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs=pNHQcdr >>7 >>B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80=te_VudSnncTlArUDlqRfpCxCP-VdRxr5Gh7 >>b >>DDo9Y9U=cqJ5

[ovs-dev] [PATCH] Windows: Update the Driver and MSI properties

Fix the legal notice section in OVSEXT.SYS properties. Update the MSI to include the properties mentioned in MSDN - 'Extension driver MSI packaging requirements' section - https://msdn.microsoft.com/windows/hardware/drivers/network/extension-driver-msi-packaging-requirements Signed-off-by: Sairam

[ovs-dev] [PATCH] datapath-windows: Encapsulate packet when src port is tunnel port

=4,0x1680100}),flags(df|csum|key))),5,4 Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/Actions.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/datapath-windows/ovsext/Actions.c b/datapath-windows/ovsext/Actions.c index 722a2a8..f

Re: [ovs-dev] [PATCH] INSTALL.Windows.md : Updated the kernel datapath project solution file name

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 8/31/16, 1:33 PM, "Anand Kumar" <kumaran...@vmware.com> wrote: >Singed-off-by : Anand Kumar <kumaran...@vmware.com> >--- > INSTALL.Windows.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion

Re: [ovs-dev] [PATCH] datapath-windows: add assert in OvsHashFlow()

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 8/31/16, 11:41 PM, "Nithin Raju" <nit...@vmware.com> wrote: >Also fix a minor indentation issue in User.c > >Signed-off-by: Nithin Raju <nit...@vmware.com> >--- > datapath-windows/ovsext/Flow.c | 1 +

Re: [ovs-dev] [PATCH] datapath-windows: Fixed tcp flags byte order in conntrack

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 8/29/16, 12:11 PM, "Paul Boca" <pb...@cloudbasesolutions.com> wrote: >In user mode the flags are interpreted as little endian. >This fix makes the kernel mode compatible with user mode. > >S

Re: [ovs-dev] [PATCH] datapath-windows: remove invalid ASSERT in Flow.c

Thanks for fixing this. Acked-by: Sairam Venugopal <vsai...@vmware.com> On 8/31/16, 3:33 AM, "Nithin Raju" <nit...@vmware.com> wrote: >Since the Geneve changes, the key->l2.offset will no longer be 0 when >the tunnel key is valid within the OVS flow key. key-

Re: [ovs-dev] [PATCH] datapath-windows: Fix connection state tracking in Conntrack

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 8/29/16, 12:12 PM, "Paul Boca" <pb...@cloudbasesolutions.com> wrote: >A connection can be both a reply and related. > >Signed-off-by: Paul-Daniel Boca <pb...@cloudbasesolutions.com> >--- > datapath

Re: [ovs-dev] [PATCH] stream-windows: Disconnect faulty named pipes

Hi Alin, How do you typically run into this issue? Do you also need to call into CloseHandle(p->fd)? Thanks, Sairam On 8/12/16, 12:46 AM, "Alin Serdean" wrote: >Disconnect named pipes that failed connection. > >Found by testing. > >Signed-off-by: Alin Gabriel

Re: [ovs-dev] Windows: Report absolute file name

Acked-by: Sairam Venugopal <vsai...@vmware.com> On 8/12/16, 12:39 AM, "Alin Serdean" <aserd...@cloudbasesolutions.com> wrote: >On Windows if a file path contains ":" we can safely say it is an absolute >file name. > >This patch allows fil

Re: [ovs-dev] [PATCH v3 2/3] datapath-windows: Add multiple switch internal ports

Hi Alin, I took a preliminary look at the patch and have added some review comments. I was mainly concerned about the use of switchContext->internalPortId when we no longer have switchContext->internalVport and we can have multiple internal ports. Thanks, Sairam On 8/2/16, 12:47 PM, "Alin

Re: [ovs-dev] [PATCH v3 1/3] Windows: Add internal switch port per OVS bridge

Nice work putting this together! I went over the changes and had some comments. Haven¹t tested it yet. Thanks, Sairam On 8/2/16, 12:46 PM, "Alin Serdean" wrote: >This patch updates the following commands in the vswitch: >ovs-vsctl add-br br-test >ovs-vsctl

Re: [ovs-dev] [PATCH v3 3/3] Windows: document multiple NIC support setup

Hi Alin, Thanks for the patch! Had some inlined comments about the documentation. I will run some tests and send out the review comments for other 2 patches. Thanks, Sairam On 8/2/16, 12:51 PM, "Alin Serdean" wrote: >This patch updates the documentation on

Re: [ovs-dev] [PATCH v2 1/7] datapath-windows: Explicitly name vport related event to vportEvent

Hi Guru, Thanks for applying the patches. I will keep note of that for my future patches. I wasn’t aware of the complications it caused. Regards, Sairam From: Guru Shetty <g...@ovn.org<mailto:g...@ovn.org>> Date: Friday, July 29, 2016 at 8:46 AM To: Sairam Venugopal <vsa

[ovs-dev] [PATCH v2 5/7] datapath-windows: Add support for multiple event queue in Event.c

Update Event.c to have multiple event queues and mechanism to retrieve the associated queue. Introduce OvsPostCtEvent and OvsRemoveCtEventEntry similar to OvsPostVportEvent and OvsRemoveVportEventEntry. v2: Added Acked-By Signed-off-by: Sairam Venugopal <vsai...@vmware.com> Acked-by: Pau

[ovs-dev] [PATCH v2 3/7] datapath-windows: Define new multicast conntrack events and netlink protocol

of OVS_EVENT_SUBSCRIBE structure. v2: Squashed patches 2/9 and 5/9 into one. Addressed review comments from Yin Lin and Alin Serdean Signed-off-by: Sairam Venugopal <vsai...@vmware.com> --- datapath-windows/ovsext/Datapath.c | 21 ++--- datapath-windows/

[ovs-dev] [PATCH v2 7/7] datapath-windows: Post Conntrack delete and new events

Post Conntrack delete and create events when entries are deleted or created. v2: Added Acked-By Signed-off-by: Sairam Venugopal <vsai...@vmware.com> Acked-by: Paul Boca <pb...@cloudbasesolutions.com> Acked-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> --- datap

[ovs-dev] [PATCH v2 4/7] datapath-windows: Modify OvsCreateNlMsgFromCtEntry to make it reusable

Tweak the OvsCreateNlMsgFromCtEntry() method to reuse it for creating netlink messages from other files. Also define the function in Conntrack.h to make it accessible. v2: Added Acked-By Signed-off-by: Sairam Venugopal <vsai...@vmware.com> Acked-By: Yin Lin <li...@vmware.com> Ac

[ovs-dev] [PATCH v2 1/7] datapath-windows: Explicitly name vport related event to vportEvent

and 3/9 into one commit. Added Acked-by. Signed-off-by: Sairam Venugopal <vsai...@vmware.com> Acked-By: Yin Lin <li...@vmware.com> Acked-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> --- datapath-windows/ovsext/Datapath.c | 7 --- datapath-windows/ovsext

[ovs-dev] [PATCH v2 0/7] Windows: Add support for sending Conntrack events

and subtypes can be represent by means of masks (eg: vport up/down, ct delete/add/update etc.,) Sairam Venugopal (7): datapath-windows: Explicitly name vport related event to vportEvent datapath-windows: Fix bugs in Event.c around subscribe and lock datapath-windows: Define new multicast

[ovs-dev] [PATCH v2 6/7] datapath-windows: Update OvsReadEventCmdHandler in Datapath.c to support different events

to 0 and instead read from msgIn). Added Acked-By Signed-off-by: Sairam Venugopal <vsai...@vmware.com> Acked-by: Paul Boca <pb...@cloudbasesolutions.com> --- datapath-windows/ovsext/Datapath.c | 66 +- 1 file changed, 50 insertions(+), 16 deletions(-)

<    1   2   3   4   5   >