rip.nsk created ORC-359:
---
Summary: Use Gflags (Google Commandline Flags) instead of getopt
Key: ORC-359
URL: https://issues.apache.org/jira/browse/ORC-359
Project: ORC
Issue Type: Improvement
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/265#discussion_r186114158
--- Diff: c++/test/CreateTestFiles.cc ---
@@ -31,8 +31,8 @@
void writeCustomOrcFile(const std::string& filename,
const
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/249#discussion_r186140770
--- Diff:
java/core/src/java/org/apache/orc/impl/writer/TimestampTreeWriter.java ---
@@ -54,9 +57,20 @@ public TimestampTreeWriter(int columnId,
if
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/249#discussion_r186134142
--- Diff: java/core/src/java/org/apache/orc/OrcFile.java ---
@@ -761,6 +782,10 @@ public boolean getWriteVariableLengthBlocks() {
public HadoopShims
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/249#discussion_r186137062
--- Diff: java/core/src/java/org/apache/orc/impl/writer/WriterImplV2.java
---
@@ -373,7 +379,11 @@ private void flushStripe() throws IOException {
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/249#discussion_r186133762
--- Diff: java/core/src/java/org/apache/orc/OrcFile.java ---
@@ -320,6 +321,16 @@ public ReaderOptions fileMetadata(final FileMetadata
metadata) {
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/249#discussion_r186134015
--- Diff: java/core/src/java/org/apache/orc/OrcFile.java ---
@@ -320,6 +321,16 @@ public ReaderOptions fileMetadata(final FileMetadata
metadata) {
Hi all,
I think the major reason that we don’t support zstd compressor today is that
there’s no native java library currently. But I do see a java decompressor in
presto code base -
0.11 is released.
-dain
Sent from my iPhone
> On May 4, 2018, at 1:41 PM, Owen O'Malley wrote:
>
> I just upgraded ORC to use aircompressor 0.10. I assume we'll want to move
> to 0.11 before we use zstd?
>
> .. Owen
>
>> On Fri, May 4, 2018 at 12:49 PM, Dain Sundstrom
Github user jcamachor commented on the issue:
https://github.com/apache/orc/pull/249
@wgtmac , @omalley , thanks for the feedback. I think I have addressed all
your points with last two commits, could you take another look? Thanks
---
I just upgraded ORC to use aircompressor 0.10. I assume we'll want to move
to 0.11 before we use zstd?
.. Owen
On Fri, May 4, 2018 at 12:49 PM, Dain Sundstrom wrote:
> The maintained location (and the version we use in prod) is:
>
The maintained location (and the version we use in prod) is:
https://github.com/airlift/aircompressor/tree/master/src/main/java/io/airlift/compress/zstd
We plan on writing the compressor soon as we need it for our production systems.
BTW we are about to do a release that fixes a bug with
12 matches
Mail list logo