GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/14
ORC-36. Create a test program that writes ORC files from future versions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-36
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/33#discussion_r65626684
--- Diff: CMakeLists.txt ---
@@ -56,16 +64,17 @@ set (ZLIB_LIBRARIES zlib)
#
# Compiler specific flags
#
+set(CMAKE_CXX_FLAGS_DEBUG "-
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/37
ORC-65 Write new documentation for the ORC site.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-65
Alternatively you can review
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/34
ORC-66. Remove the extra text from the NOTICES file.
Signed-off-by: Owen O'Malley <omal...@apache.org>
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/35
ORC-67 Fix for reading GMT timezone info on MacOS.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-67
Alternatively you can review
Github user omalley commented on the pull request:
https://github.com/apache/orc/pull/29
Ok, this needed a relatively large change. To compare the schemas, I wanted
to make TypeDescription implement Comparable, but the equals and hashCode were
set up to match against the id, which
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/29
The compilation was working for me, but you had a good point that in the
current version that everything should implement WritableComparable since
obviously compareTo needs to recurse all the way down
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/27#discussion_r65282144
--- Diff: java/mapreduce/src/test/org/apache/orc/mapreduce/TestMrUnit.java
---
@@ -0,0 +1,202 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/27#discussion_r65283394
--- Diff:
java/mapreduce/src/java/org.apache.orc.mapreduce/OrcInputFormat.java ---
@@ -0,0 +1,95 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user omalley commented on the pull request:
https://github.com/apache/orc/pull/15#issuecomment-172117542
The stream listing is located in the stripe footer, which the reader isn't
exposing yet.
---
If your project is set up for it, you can reply to this email and have your
Github user omalley commented on the pull request:
https://github.com/apache/orc/pull/15#issuecomment-172677305
Ok, I just extended the Reader API to get the additional details. I also
added a "--verbose" flag to file-metadata that prints the streams and encoding
informatio
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/19#discussion_r54128437
--- Diff: tools/src/FileMemory.cc ---
@@ -95,37 +127,11 @@ int main(int argc, char* argv[]) {
return 1;
}
- orc::ReaderOptions opts
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/22
ORC-48. Generalize docker script for any branch from github.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-48
Alternatively you
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/48
ORC-83. Protect users from Reader.rows(Options) modifying the Options object
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-83
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/41#discussion_r71377966
--- Diff: c++/include/orc/Reader.hh ---
@@ -645,7 +645,72 @@ namespace orc {
};
/**
- * The interface for reading ORC files
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/49
ORC-84. Create a separate java tool module
This creates a new java/tools directory and moves the Java ORC tools into
it.
* An uber jar is much easier to use from the command line
* It reduces
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/41
The ReaderOptions needs to split in half too:
* ReaderOptions
* setTailLocation
* setErrorStream
* setSerializedFooter
* RowReaderOptions
* include
* range
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/41#discussion_r71443174
--- Diff: c++/src/Reader.cc ---
@@ -1062,37 +1062,36 @@ namespace orc {
// PASS
}
+ RowReader::~RowReader() {
+// PASS
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/43
ORC-72 Add benchmarking code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-72
Alternatively you can review and apply
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/45
ORC-77. Implement LZO and LZ4 compression codecs.
This patch uses the aircompressor codecs to implement lzo and lz4. It also
replaces the org.iq80.snappy codec with the aircompressor snappy codec
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/40
This is looking good. I rebased it to the current trunk and undid some of
the spacing changes. My version is here:
https://github.com/omalley/orc/tree/orc-54
I also left some comments
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/40#discussion_r69785648
--- Diff: java/core/src/java/org/apache/orc/impl/SchemaEvolution.java ---
@@ -85,55 +142,78 @@ void buildMapping(TypeDescription fileType,
// check
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/40#discussion_r69777633
--- Diff: java/core/src/java/org/apache/orc/impl/ReaderImpl.java ---
@@ -572,7 +572,14 @@ public RecordReader rows(Options options) throws
IOException
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/40#discussion_r69777020
--- Diff: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java ---
@@ -27,21 +27,7 @@
import java.util.List;
import java.util.Map
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/47
ORC-81 Add support for LZO and LZ4 in the C++ reader.
* Add lz4 to the c++/libs.
* Add example files for lzo and lz4 from the java writer.
* Add tests for the new example files and compression
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/51
ORC-85. Update the C++ library with the newer WriterVersion values.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-85
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/50
ORC-88. Add --raw mode for orc-metadata to see the raw protobuf structures
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-88
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/38
I buy that we may want to test the batch size for performance tests, but
orc-scan is the important tool there since you don't really want to benchmark
the conversion into JSON
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/55
ORC-54: Evolve schemas based on field name rather than index
This is an updated version of Mark's patch that fixes evolution of ACID
files and rebases it to the current trunk.
You can merge this pull
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/56
ORC-93 Remove log message about seeking into an empty stream.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-93
Alternatively you
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/87
Ok, I took a pass at this:
https://github.com/omalley/orc/tree/orc-135
Changes:
* Block all use of PPD on timestamps from before ORC-135.
* Block PPD on timestamp with numeric
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/91
ORC-142. Fix TimestampColumnStatistics when reading from old
files (pre ORC-135).
Signed-off-by: Owen O'Malley <omal...@apache.org>
You can merge this pull request into a Git repo
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/89
ORC-141. Make setting a memory manager for the writer public.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-141
Alternatively
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/90
Of course we should rebase & squash before committing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/90
ORC-135. Fixing PPD for timestamps across timezones.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-135
Alternatively you can
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/85
I did also move the plugin to the build in the root pom.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/85
I can do the merge, thanks though!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/93
ORC-144. Implement test cases and fix the documentation for RLEv2.
This patch:
* Fixes the documentation to use a 20 number sequence for patched based rle
v2.
* Adds test cases that test
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/92
ORC-147. Fix backwards compatibility with Hive 2.1.
Fix some backwards compatibility issues with Hive 2.1.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/84
ORC-132. Implement a merge file method and fix the number of rows wriâ¦
â¦tten
during merge. (omalley)
You can merge this pull request into a Git repository by running:
$ git pull https
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/84#discussion_r96791733
--- Diff: java/core/src/test/org/apache/orc/TestVectorOrcFile.java ---
@@ -2944,4 +2948,164 @@ public void testWriterVersion() throws Exception
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/84#discussion_r96791717
--- Diff: java/core/src/java/org/apache/orc/OrcFile.java ---
@@ -642,4 +671,187 @@ public static Writer createWriter(Path path,
return new WriterImpl(fs
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/84#discussion_r96791802
--- Diff: java/core/src/test/org/apache/orc/TestVectorOrcFile.java ---
@@ -2944,4 +2948,164 @@ public void testWriterVersion() throws Exception
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/82
ORC-124. Port of HIVE-15335 fast decimal to ORC.
Forward port HIVE-15335 to ORC.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-124
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/81
I've committed this and deployed it to the site. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/57
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/97
ORC-153. Treat no arguments in convert and json-schema as help request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-153
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/60
ORC-101 fix broken encoding for string and decimal bloom filters
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-101
Alternatively
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/60#discussion_r79100075
--- Diff: java/core/src/java/org/apache/orc/OrcConf.java ---
@@ -105,6 +105,12 @@
"dictionary or not will be retained there
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/60#discussion_r79101245
--- Diff: java/core/src/java/org/apache/orc/impl/RecordReaderUtils.java ---
@@ -106,49 +198,58 @@ public OrcIndex readRowIndex(StripeInformation stripe
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/60#discussion_r79101181
--- Diff: java/core/src/java/org/apache/orc/OrcFile.java ---
@@ -231,6 +232,33 @@ public static Reader createReader(Path path,
void preFooterWrite
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/60#discussion_r79093773
--- Diff: java/core/src/java/org/apache/orc/OrcConf.java ---
@@ -105,6 +105,12 @@
"dictionary or not will be retained there
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/60#discussion_r79100160
--- Diff: java/core/src/java/org/apache/orc/util/BloomFilter.java ---
@@ -130,7 +125,7 @@ public void addString(String val) {
if (val == null
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/60
Ok, the latest push has a few changes:
* bloom_filter_utf8 streams use a new encoding with bytes instead of
long[]. This is much more efficient for performance and storage size.
* all column
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/64
ORC-106. Add ORC scan to java tool module.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-106
Alternatively you can review
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/69
ORC-115. Fix BytesColumnVector.stringifyValue to use the proper byte array
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc hive-115
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/74#discussion_r92892464
--- Diff: tools/test/ToolTest.cc ---
@@ -82,8 +83,10 @@ int runProgram(const std::vector& command,
std::string ) {
// cr
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/67
Thanks, Seth!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/75
ORC-125. Fix deserialization of WriterVersion
Prevent future WriterVersions from causing runtime errors.
Signed-off-by: Owen O'Malley <omal...@apache.org>
You can merge this pull r
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/76
The original version is https://issues.apache.org/jira/browse/HIVE-14453
The goal is to build support for a write through cache, although Sergey is
the owner of the use case.
---
If your
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/103#discussion_r107234940
--- Diff: java/core/src/java/org/apache/orc/impl/SchemaEvolution.java ---
@@ -128,6 +128,11 @@ public SchemaEvolution(TypeDescription fileSchema
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/101
Oh, sorry, it is at https://github.com/omalley/orc/tree/pr/101
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/101
I haven't gone through the details yet, but I took the liberty of moving it
from core into mapreduce, which is where the other object level shim is. I also
renamed the package to pojo instead
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/105
ORC-170. TypeDescription parent links aren't always initialized.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-170
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/106
ORC-171. Fix C++ template warnings on Mac OS 10.12.4 with
Clang Apple LLVM version 8.1.0 (clang-802.0.41).
You can merge this pull request into a Git repository by running:
$ git pull https
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/104#discussion_r111253053
--- Diff: site/_docs/core-java.md ---
@@ -233,14 +233,15 @@ VectorizedRowBatch batch = schema.createRowBatch();
LongColumnVector x = (LongColumnVector
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/104
As a double check, I tried the two variants:
```java
TypeDescription schema =
TypeDescription.fromString("struct<x:int,y:int>");
Writer writer = OrcF
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/134
It looks like it is a "long" vs "long long" problem.
/Users/owen/work/code/orc/build/libhdfspp_ep-prefix/src/libhdfspp_ep/lib/common/configuration.cc:85:1
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/151#discussion_r10120
--- Diff: c++/include/orc/Reader.hh ---
@@ -288,6 +288,17 @@ namespace orc {
virtual uint64_t getCompressionSize() const = 0
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/151#discussion_r132734446
--- Diff: c++/include/orc/Reader.hh ---
@@ -288,6 +288,17 @@ namespace orc {
virtual uint64_t getCompressionSize() const = 0
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/151#discussion_r132571311
--- Diff: c++/include/orc/Reader.hh ---
@@ -288,6 +288,17 @@ namespace orc {
virtual uint64_t getCompressionSize() const = 0
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/153
ORC-229. Add an UNSTABLE-PRE-2.0 file format version.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-229
Alternatively you can
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r127855671
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r127853962
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r127855265
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r127854823
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/135
Ok, I committed this with only a slight tweak to also filter out the shared
libraries on MacOS.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124658015
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124657014
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124657688
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,294 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/128
Sorry for not getting to this sooner. I'm looking at it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124667097
--- Diff: c++/src/ColumnWriter.cc ---
@@ -0,0 +1,507 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r124665356
--- Diff: c++/src/ColumnWriter.cc ---
@@ -0,0 +1,507 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/99
I realized that we really shouldn't be using the variable, but rather the
sarg leaf as the thing we are caching the exceptional results for. (So that we
avoid excessive logging)
---
If your project
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/110
I think we should probably add new methods for timestamp statistics for
getLowerBound and getUpperBound that will be the same for the new version of
the statistics, but be a looser bound in the case
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/109
I just committed this (squashed and stripping trailing whitespace).
Thanks, Deepak!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/110#discussion_r113301215
--- Diff: c++/src/Reader.cc ---
@@ -526,16 +526,25 @@ namespace orc {
if (metadata.get() == nullptr) {
throw std::logic_error("No s
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/110#discussion_r113300916
--- Diff: c++/src/Statistics.cc ---
@@ -279,20 +277,28 @@ namespace orc {
}
TimestampColumnStatisticsImpl::TimestampColumnStatisticsImpl
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/110#discussion_r113301529
--- Diff: c++/src/Statistics.hh ---
@@ -23,10 +23,17 @@
#include "orc/OrcFile.hh"
#include "orc/Reader.hh"
+#
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/144#discussion_r131476321
--- Diff: java/core/pom.xml ---
@@ -57,6 +57,10 @@
org.slf4j
slf4j-api
+
--- End diff --
Let's keep
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/144#discussion_r131476624
--- Diff: java/bench/src/java/org/apache/orc/bench/Driver.java ---
@@ -23,7 +23,6 @@
import org.apache.commons.cli.HelpFormatter;
import
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/144#discussion_r131476844
--- Diff: java/pom.xml ---
@@ -637,7 +637,7 @@
junit
junit
-4.11
+4.12
--- End diff
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/144#discussion_r131476392
--- Diff: java/core/src/java/org/apache/orc/RecordReader.java ---
@@ -20,11 +20,15 @@
import java.io.IOException;
import
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/138#discussion_r131491100
--- Diff: java/core/src/java/org/apache/orc/impl/HadoopShims.java ---
@@ -124,6 +126,43 @@
*/
public TextReaderShim getTextReaderShim(InputStream
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131718481
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,228 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131738380
--- Diff: c++/include/orc/Common.hh ---
@@ -27,6 +27,30 @@
#include
namespace orc {
+
+ class FileVersion {
--- End diff
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131718185
--- Diff: c++/include/orc/Writer.hh ---
@@ -0,0 +1,228 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131738738
--- Diff: c++/src/ColumnWriter.cc ---
@@ -0,0 +1,507 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/142
You may find the docker scripts useful for testing in other linux platforms.
.. Owen
On Mon, Aug 7, 2017 at 10:06 AM, Martin Grund <notificati...@github.com>
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/142
For most environments, this is a bad idea. Those zone files are patched all
of the time. Embedding them into a library will create problems. However, it
does provide a way out for environments
1 - 100 of 282 matches
Mail list logo
