[GitHub] [parquet-mr] lssatvik commented on pull request #791: Parquet-1860: Add missing Builder support to ProtoParquetWriter

2020-05-07 Thread GitBox
lssatvik commented on pull request #791: URL: https://github.com/apache/parquet-mr/pull/791#issuecomment-625641517 Where do I create a test? I have tested on my system, but I haven't "created" a test in the repository. This

[GitHub] [parquet-mr] lssatvik opened a new pull request #791: Parquet-1860: Add missing Builder support

2020-05-07 Thread GitBox
lssatvik opened a new pull request #791: URL: https://github.com/apache/parquet-mr/pull/791 Added Builder support to build ProtoParquetWriter instances through Builder class ProtoParquetWriter only has basic constructors, that which call deprecated super constructors. We cannot set

[jira] [Created] (PARQUET-1860) Builder Support for ProtoParquetWriter

2020-05-07 Thread Santosh Lade (Jira)
Santosh Lade created PARQUET-1860: - Summary: Builder Support for ProtoParquetWriter Key: PARQUET-1860 URL: https://issues.apache.org/jira/browse/PARQUET-1860 Project: Parquet Issue Type: New

[jira] [Commented] (PARQUET-1728) Simplify NullPointerException Handling in AvroWriteSupport

2020-05-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101824#comment-17101824 ] ASF GitHub Bot commented on PARQUET-1728: - Fokko commented on pull request #716: URL:

[jira] [Resolved] (PARQUET-1775) Deprecate AvroParquetWriter Builder Hadoop Path

2020-05-07 Thread Fokko Driesprong (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved PARQUET-1775. --- Fix Version/s: 1.12.0 Resolution: Fixed > Deprecate AvroParquetWriter

[jira] [Resolved] (PARQUET-1728) Simplify NullPointerException Handling in AvroWriteSupport

2020-05-07 Thread Fokko Driesprong (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved PARQUET-1728. --- Fix Version/s: 1.12.0 Resolution: Fixed > Simplify NullPointerException

[GitHub] [parquet-mr] Fokko commented on pull request #716: PARQUET-1728: Simplify NullPointerException Handling in AvroWriteSupport

2020-05-07 Thread GitBox
Fokko commented on pull request #716: URL: https://github.com/apache/parquet-mr/pull/716#issuecomment-625342263 @belugabehr Yes, I always like to give other members of the community some time to respond. But this looks good to me.

[jira] [Resolved] (PARQUET-1750) Reduce Memory Usage of RowRanges Class

2020-05-07 Thread Fokko Driesprong (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fokko Driesprong resolved PARQUET-1750. --- Fix Version/s: 1.12.0 Resolution: Fixed > Reduce Memory Usage of RowRanges

[jira] [Commented] (PARQUET-1728) Simplify NullPointerException Handling in AvroWriteSupport

2020-05-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101815#comment-17101815 ] ASF GitHub Bot commented on PARQUET-1728: - belugabehr commented on pull request #716: URL:

[GitHub] [parquet-mr] belugabehr commented on pull request #716: PARQUET-1728: Simplify NullPointerException Handling in AvroWriteSupport

2020-05-07 Thread GitBox
belugabehr commented on pull request #716: URL: https://github.com/apache/parquet-mr/pull/716#issuecomment-625340815 @Fokko Possible to get this merged? Thanks! This is an automated message from the Apache Git Service. To

[jira] [Commented] (PARQUET-1750) Reduce Memory Usage of RowRanges Class

2020-05-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101729#comment-17101729 ] ASF GitHub Bot commented on PARQUET-1750: - belugabehr commented on pull request #735: URL:

[GitHub] [parquet-mr] belugabehr commented on pull request #735: PARQUET-1750: Reduce Memory Usage of RowRanges Class

2020-05-07 Thread GitBox
belugabehr commented on pull request #735: URL: https://github.com/apache/parquet-mr/pull/735#issuecomment-625297512 @Fokko I took a look at this once more and thought I could make it even a little neater. Please take a look. Thanks!! In regards to testing, there is already a

[jira] [Commented] (PARQUET-1775) Deprecate AvroParquetWriter Builder Hadoop Path

2020-05-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101677#comment-17101677 ] ASF GitHub Bot commented on PARQUET-1775: - belugabehr commented on pull request #750: URL:

[GitHub] [parquet-mr] belugabehr commented on pull request #750: PARQUET-1775: Deprecate AvroParquetWriter Builder Hadoop Path

2020-05-07 Thread GitBox
belugabehr commented on pull request #750: URL: https://github.com/apache/parquet-mr/pull/750#issuecomment-625255839 @Fokko @ryanrupp Ready to merge this PR? Thanks! :) This is an automated message from the Apache Git

[jira] [Resolved] (PARQUET-1808) SimpleGroup.toString() uses String += and so has poor performance

2020-05-07 Thread Gabor Szadovszky (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Szadovszky resolved PARQUET-1808. --- Resolution: Fixed > SimpleGroup.toString() uses String += and so has poor

[jira] [Updated] (PARQUET-1639) [C++] Remove regex dependency for parsing ApplicationVersion

2020-05-07 Thread Antoine Pitrou (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antoine Pitrou updated PARQUET-1639: Labels: (was: beginner) > [C++] Remove regex dependency for parsing ApplicationVersion

[jira] [Commented] (PARQUET-1827) UUID type currently not supported by parquet-mr

2020-05-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101496#comment-17101496 ] ASF GitHub Bot commented on PARQUET-1827: - gszadovszky commented on a change in pull request

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-07 Thread GitBox
gszadovszky commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r421389575 ## File path: parquet-avro/src/test/java/org/apache/parquet/avro/TestAvroSchemaConverter.java ## @@ -766,6 +768,33 @@ public void

[jira] [Commented] (PARQUET-1827) UUID type currently not supported by parquet-mr

2020-05-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101490#comment-17101490 ] ASF GitHub Bot commented on PARQUET-1827: - gszadovszky commented on a change in pull request

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-07 Thread GitBox
gszadovszky commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r421384119 ## File path: parquet-avro/README.md ## @@ -0,0 +1,44 @@

[jira] [Commented] (PARQUET-1827) UUID type currently not supported by parquet-mr

2020-05-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PARQUET-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101484#comment-17101484 ] ASF GitHub Bot commented on PARQUET-1827: - gszadovszky commented on a change in pull request

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-07 Thread GitBox
gszadovszky commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r421381112 ## File path: parquet-column/src/test/java/org/apache/parquet/schema/TestPrimitiveStringifier.java ## @@ -309,6 +308,35 @@ public void

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-07 Thread GitBox
gszadovszky commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r421372389 ## File path: parquet-column/src/main/java/org/apache/parquet/schema/PrimitiveStringifier.java ## @@ -421,4 +422,30 @@ private String

[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #778: PARQUET-1827: UUID type currently not supported by parquet-mr

2020-05-07 Thread GitBox
gszadovszky commented on a change in pull request #778: URL: https://github.com/apache/parquet-mr/pull/778#discussion_r421368850 ## File path: parquet-column/src/main/java/org/apache/parquet/schema/LogicalTypeAnnotation.java ## @@ -861,6 +871,36 @@ PrimitiveStringifier