[
https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597565#comment-17597565
]
ASF GitHub Bot commented on PARQUET-758:
emkornfield commented on code in PR #18
emkornfield commented on code in PR #184:
URL: https://github.com/apache/parquet-format/pull/184#discussion_r958042831
##
src/main/thrift/parquet.thrift:
##
@@ -232,6 +232,7 @@ struct MapType {} // see LogicalTypes.md
struct ListType {}// see LogicalTypes.md
struct Enu
[
https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597562#comment-17597562
]
ASF GitHub Bot commented on PARQUET-758:
emkornfield commented on PR #184:
URL:
emkornfield commented on PR #184:
URL: https://github.com/apache/parquet-format/pull/184#issuecomment-1231187345
It isn't clear to me if this should be a logical type or a physical type. We
would need understand if there is different handling for forward compatibility
purposes (what do we w
[
https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597558#comment-17597558
]
ASF GitHub Bot commented on PARQUET-758:
emkornfield commented on PR #184:
URL:
emkornfield commented on PR #184:
URL: https://github.com/apache/parquet-format/pull/184#issuecomment-1231185256
We should probably specify that using the [Byte Split
Encodings](https://github.com/apache/parquet-format/blob/master/Encodings.md#byte-stream-split-byte_stream_split--9)
can be
[
https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597412#comment-17597412
]
ASF GitHub Bot commented on PARQUET-758:
anjakefala commented on code in PR #184
anjakefala commented on code in PR #184:
URL: https://github.com/apache/parquet-format/pull/184#discussion_r957822642
##
src/main/thrift/parquet.thrift:
##
@@ -342,6 +343,7 @@ union LogicalType {
12: JsonType JSON // use ConvertedType JSON
13: BsonType BSON
[
https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antoine Pitrou updated PARQUET-758:
---
Summary: [Format] HALF precision FLOAT Logical type (was: HALF precision
FLOAT Logical type
[
https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597064#comment-17597064
]
ASF GitHub Bot commented on PARQUET-758:
pitrou commented on PR #184:
URL: https
pitrou commented on PR #184:
URL: https://github.com/apache/parquet-format/pull/184#issuecomment-1229983463
@anjakefala You need to add to the `LogicalType` union, not to the `Type`
enum (which is for physical types).
Also cc @emkornfield
--
This is an automated message from the A
[
https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597061#comment-17597061
]
ASF GitHub Bot commented on PARQUET-758:
pitrou commented on code in PR #184:
UR
[
https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597062#comment-17597062
]
ASF GitHub Bot commented on PARQUET-758:
pitrou commented on code in PR #184:
UR
[
https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597060#comment-17597060
]
ASF GitHub Bot commented on PARQUET-758:
pitrou commented on code in PR #184:
UR
pitrou commented on code in PR #184:
URL: https://github.com/apache/parquet-format/pull/184#discussion_r957065065
##
src/main/thrift/parquet.thrift:
##
@@ -889,6 +891,7 @@ union ColumnOrder {
* INT32 - signed comparison
* INT64 - signed comparison
* INT96 (only
pitrou commented on code in PR #184:
URL: https://github.com/apache/parquet-format/pull/184#discussion_r957064862
##
src/main/thrift/parquet.thrift:
##
@@ -416,6 +417,7 @@ enum Encoding {
* BOOLEAN - 1 bit per value. 0 is false; 1 is true.
* INT32 - 4 bytes per value. S
pitrou commented on code in PR #184:
URL: https://github.com/apache/parquet-format/pull/184#discussion_r957064370
##
src/main/thrift/parquet.thrift:
##
@@ -34,6 +34,7 @@ enum Type {
INT32 = 1;
INT64 = 2;
INT96 = 3; // deprecated, only used by legacy implementations.
+
[
https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597058#comment-17597058
]
ASF GitHub Bot commented on PARQUET-758:
pitrou commented on code in PR #184:
UR
pitrou commented on code in PR #184:
URL: https://github.com/apache/parquet-format/pull/184#discussion_r957063147
##
LogicalTypes.md:
##
@@ -245,6 +245,18 @@ comparison.
To support compatibility with older readers, implementations of parquet-format
should
write `DecimalType`
[
https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597057#comment-17597057
]
ASF GitHub Bot commented on PARQUET-758:
pitrou commented on code in PR #184:
UR
pitrou commented on code in PR #184:
URL: https://github.com/apache/parquet-format/pull/184#discussion_r957060962
##
LogicalTypes.md:
##
@@ -245,6 +245,18 @@ comparison.
To support compatibility with older readers, implementations of parquet-format
should
write `DecimalType`
[
https://issues.apache.org/jira/browse/PARQUET-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597055#comment-17597055
]
ASF GitHub Bot commented on PARQUET-758:
pitrou commented on code in PR #184:
UR
pitrou commented on code in PR #184:
URL: https://github.com/apache/parquet-format/pull/184#discussion_r957060962
##
LogicalTypes.md:
##
@@ -245,6 +245,18 @@ comparison.
To support compatibility with older readers, implementations of parquet-format
should
write `DecimalType`
23 matches
Mail list logo
