[GitHub] [parquet-mr] rdblue commented on a diff in pull request #950: PARQUET-2006: Column resolution by ID

rdblue commented on code in PR #950: URL: https://github.com/apache/parquet-mr/pull/950#discussion_r842099171 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -878,11 +880,97 @@ public String getFile() { return blocks; } -

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #950: PARQUET-2006: Column resolution by ID

rdblue commented on code in PR #950: URL: https://github.com/apache/parquet-mr/pull/950#discussion_r842097255 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -878,11 +880,97 @@ public String getFile() { return blocks; } -

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #950: PARQUET-2006: Column resolution by ID

rdblue commented on code in PR #950: URL: https://github.com/apache/parquet-mr/pull/950#discussion_r842096174 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -878,11 +880,97 @@ public String getFile() { return blocks; } -

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #950: PARQUET-2006: Column resolution by ID

rdblue commented on code in PR #950: URL: https://github.com/apache/parquet-mr/pull/950#discussion_r842094667 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -878,11 +880,97 @@ public String getFile() { return blocks; } -

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #950: PARQUET-2006: Column resolution by ID

rdblue commented on code in PR #950: URL: https://github.com/apache/parquet-mr/pull/950#discussion_r842094667 ## parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java: ## @@ -878,11 +880,97 @@ public String getFile() { return blocks; } -

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #950: PARQUET-2006: Column resolution by ID

rdblue commented on code in PR #950: URL: https://github.com/apache/parquet-mr/pull/950#discussion_r842091649 ## parquet-column/src/main/java/org/apache/parquet/filter2/predicate/SchemaCompatibilityValidator.java: ## @@ -170,6 +174,24 @@ public Void visit(Not not) {

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #950: PARQUET-2006: Column resolution by ID

rdblue commented on code in PR #950: URL: https://github.com/apache/parquet-mr/pull/950#discussion_r842090063 ## parquet-column/src/main/java/org/apache/parquet/filter2/predicate/SchemaCompatibilityValidator.java: ## @@ -170,6 +174,24 @@ public Void visit(Not not) {

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #950: PARQUET-2006: Column resolution by ID

rdblue commented on code in PR #950: URL: https://github.com/apache/parquet-mr/pull/950#discussion_r842090063 ## parquet-column/src/main/java/org/apache/parquet/filter2/predicate/SchemaCompatibilityValidator.java: ## @@ -170,6 +174,24 @@ public Void visit(Not not) {

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #950: PARQUET-2006: Column resolution by ID

rdblue commented on code in PR #950: URL: https://github.com/apache/parquet-mr/pull/950#discussion_r842088106 ## parquet-column/src/main/java/org/apache/parquet/filter2/predicate/Operators.java: ## @@ -48,10 +55,18 @@ protected Column(ColumnPath columnPath, Class columnType) {

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #950: PARQUET-2006: Column resolution by ID

rdblue commented on code in PR #950: URL: https://github.com/apache/parquet-mr/pull/950#discussion_r842087619 ## parquet-column/src/main/java/org/apache/parquet/filter2/predicate/FilterApi.java: ## @@ -72,26 +73,50 @@ public static IntColumn intColumn(String columnPath) {

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #950: PARQUET-2006: Column resolution by ID

rdblue commented on code in PR #950: URL: https://github.com/apache/parquet-mr/pull/950#discussion_r842086915 ## parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java: ## @@ -511,6 +519,11 @@ public Builder withPageWriteChecksumEnabled(boolean val) {

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #950: PARQUET-2006: Column resolution by ID

rdblue commented on code in PR #950: URL: https://github.com/apache/parquet-mr/pull/950#discussion_r842086583 ## parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java: ## @@ -266,6 +269,10 @@ public int getMaxBloomFilterBytes() { return

[GitHub] [parquet-mr] rdblue commented on a diff in pull request #950: PARQUET-2006: Column resolution by ID

rdblue commented on code in PR #950: URL: https://github.com/apache/parquet-mr/pull/950#discussion_r842085396 ## parquet-column/src/main/java/org/apache/parquet/column/ColumnDescriptor.java: ## @@ -70,7 +71,20 @@ public ColumnDescriptor(String[] path, PrimitiveTypeName type,